From nobody Mon Feb 9 13:39:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607714676; cv=none; d=zohomail.com; s=zohoarc; b=CXfQT8kE/qrPxWwOI6j1olM/w4vUpRLcylJCMMdgC7TeXO6brbFMzbXjHOzTj+1pK/u/qBeRWJM2vUP4cUA0bFPqyb6yv9GjdJDfhNWvxmbrpPKA9MoFibT/7unLpu4vkmtyG6cVydYQdutVcNQa1MIDs6gC5GoIKm8KWGfHrh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607714676; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hyXsrL+PuXp2DnKfHhvz8yzSbfDhBrvb7mgoaou9bVE=; b=MXRnHaNTIAlhWmP8MdqCOrSJo7J7piLhRCjbSxOS/BGQq2xwx7VLLF7H70DC3z+8bBZ7omhjqprFj6wJk0VTpFsJI+E65m/swFewyJHEXUtp1RrRs3omyCgT+rpTNeVsiLJQkx/rK2pqjYi211baSrJ1s6t9ZSqSsZo/Xh3NE9E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607714676699367.7457092169318; Fri, 11 Dec 2020 11:24:36 -0800 (PST) Received: from localhost ([::1]:32916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knmlP-0001eX-9e for importer@patchew.org; Fri, 11 Dec 2020 13:03:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knlxs-0007XD-Eg for qemu-devel@nongnu.org; Fri, 11 Dec 2020 12:12:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1knlxc-0003S2-5O for qemu-devel@nongnu.org; Fri, 11 Dec 2020 12:12:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-nnefTOeeNGiwi92EzyJpjw-1; Fri, 11 Dec 2020 12:11:58 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 879E6800FFC; Fri, 11 Dec 2020 17:11:57 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 585055F9AC; Fri, 11 Dec 2020 17:11:57 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E365E112E5DD; Fri, 11 Dec 2020 18:11:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607706722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hyXsrL+PuXp2DnKfHhvz8yzSbfDhBrvb7mgoaou9bVE=; b=PRiKCq1BmnjK17bwIXHgpdkuYHigcEop/D5jbT0zVBXgeGtr1INYgwoVKryL5qylKMNKih ynH0H+GoLULDa6dxG/oBvVRlrstkO0Xo0tSigGxfGLXAjKwFW8Bzj/SfhouHGjiqGL9Lyz vTdobavacjxRbj08PV4P8/OsmvMl7fE= X-MC-Unique: nnefTOeeNGiwi92EzyJpjw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 18/20] keyval: Use GString to accumulate value strings Date: Fri, 11 Dec 2020 18:11:50 +0100 Message-Id: <20201211171152.146877-19-armbru@redhat.com> In-Reply-To: <20201211171152.146877-1-armbru@redhat.com> References: <20201211171152.146877-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" QString supports modifying its string, but it's quite limited: you can only append. The remaining callers use it for building an initial string, never for modifying it later. Change keyval_parse_one() to do build the initial string with GString. This is another step towards making QString immutable. Signed-off-by: Markus Armbruster --- util/keyval.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/util/keyval.c b/util/keyval.c index 7f625ad33c..be34928813 100644 --- a/util/keyval.c +++ b/util/keyval.c @@ -189,7 +189,7 @@ static const char *keyval_parse_one(QDict *qdict, const= char *params, QDict *cur; int ret; QObject *next; - QString *val; + GString *val; =20 key =3D params; val_end =3D NULL; @@ -263,7 +263,7 @@ static const char *keyval_parse_one(QDict *qdict, const= char *params, =20 if (key =3D=3D implied_key) { assert(!*s); - val =3D qstring_from_substr(params, 0, val_end - params); + val =3D g_string_new_len(params, val_end - params); s =3D val_end; if (*s =3D=3D ',') { s++; @@ -276,7 +276,7 @@ static const char *keyval_parse_one(QDict *qdict, const= char *params, } s++; =20 - val =3D qstring_new(); + val =3D g_string_new(NULL); for (;;) { if (!*s) { break; @@ -286,11 +286,12 @@ static const char *keyval_parse_one(QDict *qdict, con= st char *params, break; } } - qstring_append_chr(val, *s++); + g_string_append_c(val, *s++); } } =20 - if (!keyval_parse_put(cur, key_in_cur, val, key, key_end, errp)) { + if (!keyval_parse_put(cur, key_in_cur, qstring_from_gstring(val), + key, key_end, errp)) { return NULL; } return s; --=20 2.26.2