From nobody Thu Dec 18 17:51:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607708948; cv=none; d=zohomail.com; s=zohoarc; b=FtHX6Av60tFnfQhnAdv266ONg8qZrfOtWYmJrypsSjkkKFjFWu5+CEkvIdu8dsc5dZjPf5Sy4T1n4cGyW61c4x5ZiJktF6nrYC+4z1vm3MdQC/moFRpN/N+MH2RbMi63CHCqFm9CTNBt0uo49Q2tBptufmtyE/BPB+7oCOx7mHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607708948; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Si/VfFgD2E+KfaE6Uukp5i3Wn9g7s3KAAx8h/GEYWng=; b=FbQvljo3Jypa2Owf8iXuE486Q4tqPWJcRcfoJuo8xphHbMOHAYTHWq0Of53RgGGDQiXL2WXP38O7KcRezO0NL6FQ+n31lnpViY0fa+1R5qn5eavi1j7SoFNF/OCq3GqkL3u0kQU0KSlMZnuKCoeAaq2Ty0SEjAGGQFOcnYb/xGs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607708948017686.7498136051778; Fri, 11 Dec 2020 09:49:08 -0800 (PST) Received: from localhost ([::1]:50562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knmXS-0001jx-1s for importer@patchew.org; Fri, 11 Dec 2020 12:49:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knlvP-0004Yu-F7 for qemu-devel@nongnu.org; Fri, 11 Dec 2020 12:09:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1knlue-0002Jv-Op for qemu-devel@nongnu.org; Fri, 11 Dec 2020 12:09:45 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-Bj9Fx_eTMjmrFZ9s48aQGw-1; Fri, 11 Dec 2020 12:08:57 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4057F107ACE6; Fri, 11 Dec 2020 17:08:56 +0000 (UTC) Received: from merkur.redhat.com (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 111D15D6A8; Fri, 11 Dec 2020 17:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607706540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Si/VfFgD2E+KfaE6Uukp5i3Wn9g7s3KAAx8h/GEYWng=; b=gw6PDZ/dlJD6UcmIhZ/9ehHZvJAMHfKO15oVYQMQ8ShKBFNJrziJFHNF5lHpmXX95ktstx 0kka21uf4FIxgOJ6o+KFZtvfK93Ycf4sGumGBXn8AwpW7ebiCo2ZI2NY10p143al6GzuOv CBLeAFeYcI6mHWbmL4rD+5zRjhzc6n8= X-MC-Unique: Bj9Fx_eTMjmrFZ9s48aQGw-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 28/34] block/file-posix: fix workaround in raw_do_pwrite_zeroes() Date: Fri, 11 Dec 2020 18:08:06 +0100 Message-Id: <20201211170812.228643-29-kwolf@redhat.com> In-Reply-To: <20201211170812.228643-1-kwolf@redhat.com> References: <20201211170812.228643-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy We should not set overlap_bytes: 1. Don't worry: it is calculated by bdrv_mark_request_serialising() and will be equal to or greater than bytes anyway. 2. If the request was already aligned up to some greater alignment, than we may break things: we reduce overlap_bytes, and further bdrv_mark_request_serialising() may not help, as it will not restore old bigger alignment. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20201203222713.13507-2-vsementsov@virtuozzo.com> Signed-off-by: Kevin Wolf --- block/file-posix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index 806764f7e3..9bee3d88d0 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2952,7 +2952,6 @@ raw_do_pwrite_zeroes(BlockDriverState *bs, int64_t of= fset, int bytes, =20 end =3D INT64_MAX & -(uint64_t)bs->bl.request_alignment; req->bytes =3D end - req->offset; - req->overlap_bytes =3D req->bytes; =20 bdrv_mark_request_serialising(req, bs->bl.request_alignment); } --=20 2.29.2