From nobody Fri May 17 12:14:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607623162; cv=none; d=zohomail.com; s=zohoarc; b=CmoBGtD/LeooCb2YqErfoxYzN9YxT75+ZO5VWy7yARLPmbQuquz1I3SXwEp9W5Qa9e5GKd00tbjvJszLvjOkWH0564G9kkaXetdlG6dGFG1liAWKTLi6IusUyfl6yilbB6IH/sy9JcZzQKyyu+SqVzSyVIWZ8o2MLLG2F3bWlhI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607623162; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=/Ud3KxDqUBdjOZUtEIZXpH5CF1Q02Z/msk2wmjc+8dE=; b=ZgvOprF94RiMOQtTdB2euwYywqgLOTAN+MYqyDhNRZzEF9SS/DyOAV4bNvDlidEg5nfNGacBDOsi6k6y6YoHA/2Q36X/dZET+MruD7SUMC+UZpdivm/c5QuRjrnXyE5gJBm5DPq0wYSwqj3Y40QzmibkrukvdS1UbnJO8Vt8BI0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1607623162478137.6690302992165; Thu, 10 Dec 2020 09:59:22 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-jh33fgecOmeNkDdhzpdeOg-1; Thu, 10 Dec 2020 12:59:19 -0500 Received: by mail-wr1-f70.google.com with SMTP id b8so2212195wrv.14 for ; Thu, 10 Dec 2020 09:59:19 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id o74sm13298630wme.36.2020.12.10.09.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 09:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607623161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/Ud3KxDqUBdjOZUtEIZXpH5CF1Q02Z/msk2wmjc+8dE=; b=XZp4qBLuUvnOLRvaT9KHl8k4tsxgPcUVflavjjiPZBuOR4g+V+RAy01EHyUF5XH13VS9XL DPASpibXKxZr95S9F8Cc0SATUss6hMiAEheI5CdRi20kfmZyLwGvunzjI3JzCakYWH6lcs AX6eseYnEaIPez+zonAYyFTtuU0vsOM= X-MC-Unique: jh33fgecOmeNkDdhzpdeOg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/Ud3KxDqUBdjOZUtEIZXpH5CF1Q02Z/msk2wmjc+8dE=; b=ELEGE9eonw+us5QhBJJ+IGKPVSkGyVDArb9/n/yZQjUD54M5ieJmnIE4aLqx8WzUil DE3VRWe/IwjcEemptBzQ6eZWWJINQthe/Oe7YKNj21T8K8Ltmudh+x8fZChDhjkZ9bPf NdueMePnSPU77xf1X6LP/9Y5tGSJproXpD34lb/jQS5asLGTdU4x1xBpEQcwM3cg16uu JEOAbgBf4lfLSIEA95ciTy/C0I6kiXn/gTgSGKcuCdxUxcafl3N1X/PficGJG9cZaFub RMdYGkDZeeNc0FbXYir8/ZSk124F+KYDFErD5AhGk3Rtw0A0T5LThSRUOGGJdrbwC4lU UMWA== X-Gm-Message-State: AOAM533yzCQBu7jXU8/Zl9LmtfNaxUFscR5SzgOwh1HwQzfuxi9pXR3f 4rJW+cZ47LeN5rE4h4z8sJmu+ISETAn6JNjdrjwxYehtyJ7PFgRF4NtKIrH3FID5aPf49jpkbOg O7B5F8bd4wKQyrQ== X-Received: by 2002:a7b:cb82:: with SMTP id m2mr9265006wmi.75.1607623158385; Thu, 10 Dec 2020 09:59:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEQiDzySAPyn/08D+Jwn9LrpXnRXpJUua0gftvYcLqvx4RatZX0RndEb4S2ie3TXWMMIZUgQ== X-Received: by 2002:a7b:cb82:: with SMTP id m2mr9264989wmi.75.1607623158220; Thu, 10 Dec 2020 09:59:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH] virtio: Only display errors if GUEST_ERROR is enabled Date: Thu, 10 Dec 2020 18:59:16 +0100 Message-Id: <20201210175916.187273-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Do not display virtio guest errors until the user request it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/virtio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index eff35fab7ce..bde0d31c5d9 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3622,9 +3622,11 @@ void GCC_FMT_ATTR(2, 3) virtio_error(VirtIODevice *v= dev, const char *fmt, ...) { va_list ap; =20 - va_start(ap, fmt); - error_vreport(fmt, ap); - va_end(ap); + if (qemu_loglevel_mask(LOG_GUEST_ERROR)) { + va_start(ap, fmt); + error_vreport(fmt, ap); + va_end(ap); + } =20 if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { vdev->status =3D vdev->status | VIRTIO_CONFIG_S_NEEDS_RESET; --=20 2.26.2