From nobody Mon Feb 9 12:15:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607618894; cv=none; d=zohomail.com; s=zohoarc; b=YBig6msCbpnWw1Vm4YUhFfm7KL0Uzp5X5Idf+g2JeEywyandrytnPqng4TSaJ4wNEB0tnZvZf8OU83+Dw6M233HLFas+PxC7YgDryN7AoZVbqeVQnXpLlRQXRbigFsJucCAYxC+eukyLiElaJb1wE3y8ygfjnIVLEmu1DE0U8tI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607618894; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ui5ZoOjNR7TGnKFeRY7gBJ6jmyr1OpeMdHskRzGsr0Q=; b=F5ignnVXJ6V4JNNvlyBT3r9en8APz+9/GY1RDPbxqlseI3l35gADKIOwyp9alzBgKVQw4kx4wXHDrSs4zVL+u/Wi+5PRCTrB+/8BGv+ewRNnjk88jXy52SGYiQKuwCCWYvsykwhUBGEyW1RBCQLTJqZ0BsaPC6h6o6jW8yItAE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607618894030275.7893930466885; Thu, 10 Dec 2020 08:48:14 -0800 (PST) Received: from localhost ([::1]:57354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knP6y-0002B2-6G for importer@patchew.org; Thu, 10 Dec 2020 11:48:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knOrj-0008Nt-Np for qemu-devel@nongnu.org; Thu, 10 Dec 2020 11:32:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:39868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1knOrZ-0003Th-7f for qemu-devel@nongnu.org; Thu, 10 Dec 2020 11:32:27 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-VSya15mbN3KKUniuWX8A-A-1; Thu, 10 Dec 2020 11:32:10 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B051F107ACE3; Thu, 10 Dec 2020 16:31:39 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF6766E71D; Thu, 10 Dec 2020 16:31:35 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CD2A210FA0A8; Thu, 10 Dec 2020 17:31:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607617934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ui5ZoOjNR7TGnKFeRY7gBJ6jmyr1OpeMdHskRzGsr0Q=; b=hXhpd0baRSNKPMcFOHIZ7F9eY43VMJ4IwePQV+DQOQox4gjw2WoCYZHaLQ8bgT8Vs/5GM0 wzF80MP/fH0EsSD69Btwlp2FgI2v/u9JqKUWr1hDnddjZVtvhosXasI0miat5I70vI7cBX /8zggX1M5rVfBF/ZH/imHMJToQynz6o= X-MC-Unique: VSya15mbN3KKUniuWX8A-A-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 06/13] ui: Improve a client_migrate_info error message Date: Thu, 10 Dec 2020 17:31:25 +0100 Message-Id: <20201210163132.2919935-7-armbru@redhat.com> In-Reply-To: <20201210163132.2919935-1-armbru@redhat.com> References: <20201210163132.2919935-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" client_migrate_info reports spice_server_migrate_connect() failure as "An undefined error has occurred". Improve to "Could not set up display for migration". QERR_UNDEFINED_ERROR is now unused. Drop. Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster Message-Id: <20201113082626.2725812-6-armbru@redhat.com> --- include/qapi/qmp/qerror.h | 3 --- monitor/misc.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index d8267129bc..596fce0c54 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -65,9 +65,6 @@ #define QERR_REPLAY_NOT_SUPPORTED \ "Record/replay feature is not supported for '%s'" =20 -#define QERR_UNDEFINED_ERROR \ - "An undefined error has occurred" - #define QERR_UNSUPPORTED \ "this feature or command is not currently supported" =20 diff --git a/monitor/misc.c b/monitor/misc.c index c563e901c0..bb102df823 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -441,7 +441,7 @@ void qmp_client_migrate_info(const char *protocol, cons= t char *hostname, has_port ? port : -1, has_tls_port ? tls_port : -1, cert_subject)) { - error_setg(errp, QERR_UNDEFINED_ERROR); + error_setg(errp, "Could not set up display for migration"); return; } return; --=20 2.26.2