From nobody Tue May 21 16:48:25 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607518537; cv=none; d=zohomail.com; s=zohoarc; b=iq0vWDDCPcJFwZhGtK2aX+z2aJLZ0vHWykTemncRiRxTxtzUqSP7A3kc2uhA2AjYXiJ5A+SmPxlFL163QKtdynPNc9Rlc6tUmTmWakulfWgRVAXfN2WEld4rLMZaXTnz6VEQVnfEe7UVbpw3Fy+G6w2JrezchxRSgID/sT5MHak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607518537; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=o2x0AvFb+iHHHKFZsE069+kjFFsSFvyPByq4JZGEWZg=; b=hrqPKPVxC4Y0/2IyuWdAHoqxzV1oyEKyV4fuYEC2SG1CH5ZlE+yQHL/Z/+AvYAlAu5X5JyVOpSjSi5x0/49BA6xeVY6HdfLomV0ISwFseEmvOcfOpVRny7sXNrGFgdCoOpTbaGFOak60IyP2JblZQ8Na+HGfhc5MeQ9Nlvq7b6Y= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607518537433208.733071358933; Wed, 9 Dec 2020 04:55:37 -0800 (PST) Received: from localhost ([::1]:32862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmyQo-0002EW-LC for importer@patchew.org; Wed, 09 Dec 2020 07:18:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmyPt-0001bl-E9 for qemu-devel@nongnu.org; Wed, 09 Dec 2020 07:17:57 -0500 Received: from kerio.kamp.de ([195.62.97.192]:45524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmyPq-0001gC-CZ for qemu-devel@nongnu.org; Wed, 09 Dec 2020 07:17:57 -0500 Received: from submission.kamp.de ([195.62.97.28]) by kerio.kamp.de with ESMTPS (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)) for qemu-devel@nongnu.org; Wed, 9 Dec 2020 13:17:41 +0100 Received: (qmail 25607 invoked from network); 9 Dec 2020 12:17:43 -0000 Received: from lieven-pc.kamp-intra.net (HELO lieven-pc) (relay@kamp.de@::ffff:172.21.12.60) by submission.kamp.de with ESMTPS (DHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPA; 9 Dec 2020 12:17:43 -0000 Received: by lieven-pc (Postfix, from userid 1060) id 3483613D863; Wed, 9 Dec 2020 13:17:43 +0100 (CET) X-Footer: a2FtcC5kZQ== From: Peter Lieven To: qemu-block@nongnu.org Subject: [PATCH] block/nfs: fix int overflow in nfs_client_open_qdict Date: Wed, 9 Dec 2020 13:17:35 +0100 Message-Id: <20201209121735.16437-1-pl@kamp.de> X-Mailer: git-send-email 2.17.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.62.97.192; envelope-from=pl@kamp.de; helo=kerio.kamp.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-stable@nongnu.org, Peter Lieven , qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" nfs_client_open returns the file size in sectors. This effectively makes it impossible to open files larger than 1TB. Fixes: a1a42af422d46812f1f0cebe6b230c20409a3731 Cc: qemu-stable@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Stefano Garzarella --- block/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index 77905f516d..8c1968bb41 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -592,7 +592,7 @@ static int64_t nfs_client_open_qdict(NFSClient *client,= QDict *options, int flags, int open_flags, Error **er= rp) { BlockdevOptionsNfs *opts; - int ret; + int64_t ret; =20 opts =3D nfs_options_qdict_to_qapi(options, errp); if (opts =3D=3D NULL) { --=20 2.17.1