From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507480; cv=none; d=zohomail.com; s=zohoarc; b=DWDO8g1i7wIwCJXhgQod1LYxRNDiqYWhpH2wsCa+yBk8o9MNS0Sjbn/GHj+/G3Aa2HVZnBYQSuwNUVxOJq883cZNNF1ZX8Ru5oWZJXRcWH/mqphg4qc4i6c5bpVjo2wIC2xa5Ir5R90hT7r0ZBObk2X+DVsP8QFetegIhUMyF/g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507480; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=W6tyCDJtepPW1R06jPEtPjloL9Bo4O1vdeoGq97Gtls=; b=bLI4Rxv42hT4fAAB7iqMCP7Oi2jJCW1GTOEJ0+HWgjJ8kgJ0syIdrQFQ8AsxgrxOVQpRsO/6BMulkkuHIuliE1hBPaa0RgtJFgsIjUuWMdnaObF9PdRh2FlhYzLEsTEyOv1q+XbhOMTVn/pyuiHPSXpx1n76jXNqkBmd5hM797c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507480032739.1803910818518; Wed, 9 Dec 2020 01:51:20 -0800 (PST) Received: from localhost ([::1]:59118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmw7y-0006pQ-1V for importer@patchew.org; Wed, 09 Dec 2020 04:51:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw5r-00058p-N7 for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36861) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw5q-0007KZ-27 for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-8iXEz5MiOLGJJiHSc7Om2w-1; Wed, 09 Dec 2020 04:49:02 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B34BA8018AF; Wed, 9 Dec 2020 09:49:00 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id A48655C23D; Wed, 9 Dec 2020 09:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W6tyCDJtepPW1R06jPEtPjloL9Bo4O1vdeoGq97Gtls=; b=hYxyFn+N2ofwhAjQgZP4hS/8hgcS5GwS1M4s7FSPM+GlFGj92UdsWEY4wDJUmL14RCrF9P 6JJ4OEkPbU5SOjUK1nGCk/45fo/teZSlExb+c7ikh4qOo+UTeAKEhiGhe6ODZECzKPIGub pe/ILmdsQc3e1K5vn156ammO2D30hAU= X-MC-Unique: 8iXEz5MiOLGJJiHSc7Om2w-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 01/13] gitlab-ci: Document 'build-tcg-disabled' is a KVM X86 job Date: Wed, 9 Dec 2020 10:48:44 +0100 Message-Id: <20201209094856.17788-2-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Document what this job cover (build X86 targets with KVM being the single accelerator available). Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201207131503.3858889-2-philmd@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d0173e82b1..ee31b1020f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -220,6 +220,11 @@ build-disabled: s390x-softmmu i386-linux-user MAKE_CHECK_ARGS: check-qtest SPEED=3Dslow =20 +# This jobs explicitly disable TCG (--disable-tcg), KVM is detected by +# the configure script. The container doesn't contain Xen headers so +# Xen accelerator is not detected / selected. As result it build the +# i386-softmmu and x86_64-softmmu with KVM being the single accelerator +# available. build-tcg-disabled: <<: *native_build_job_definition variables: --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507482; cv=none; d=zohomail.com; s=zohoarc; b=ANQzedkqJ3XygLwMO2WxTSl/SyQmF6co8H9BEtlrdqRtu8JFsXvYKpE11SolX6m8hSYln6z5hClmZFSvSP02rm1EdKy3KyrHS5gVkJ5GTSCMyY5zwttePBuPXnIpfnm4BgkrSxe/iD4SEsGeGOU60vpxobKiwxEXhvryWd7amdE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507482; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Na8TCRdB3qsq3O24yjvbzck+sAgs9WMLKSNTmc3xfiw=; b=hK7GYWpBXQdesw5RrVz7o9MNYTHVQ3ImcSZVjzoX75MV0SJroxq4VZbQ24SskspAk2nOdwvs51v2EtEF3VpV6EJqNyVeiVughLJQj8nVDUrzhwAR6JQJstyQ9YoTNag3YvXNEcTkg1PHwk8uvklKgYJl7Fmmoo2Bzs416JeF9EM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160750748284846.92595864445343; Wed, 9 Dec 2020 01:51:22 -0800 (PST) Received: from localhost ([::1]:59368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmw81-0006vh-I1 for importer@patchew.org; Wed, 09 Dec 2020 04:51:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw5t-00059v-Ad for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw5q-0007Ki-Mg for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:09 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-ZJcSNHf_MFact1grSHUzNw-1; Wed, 09 Dec 2020 04:49:03 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A1BC1927818; Wed, 9 Dec 2020 09:49:02 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E0EC5C23D; Wed, 9 Dec 2020 09:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Na8TCRdB3qsq3O24yjvbzck+sAgs9WMLKSNTmc3xfiw=; b=OgAUAyzCKlOJCbdW21x36nf2TfMGD/mwkPom3SXv5m5IMnvoitlJVOmgsasbcE6zfdCZxj yUo9J6acdgXHI5ZeB7WBWzmh+xrBdJo2N6+1Z4hvu7kAZxSZtHQeoSw7Kdy0UuYCePWR0a ckyWY3NyxogGY8KlxKwKZV9l74m1vF4= X-MC-Unique: ZJcSNHf_MFact1grSHUzNw-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 02/13] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job) Date: Wed, 9 Dec 2020 10:48:45 +0100 Message-Id: <20201209094856.17788-3-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends More importantly it allows exploding YAML jobs. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201207131503.3858889-3-philmd@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 40 ++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 03ebfabb3f..099949aaef 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -1,5 +1,5 @@ =20 -.cross_system_build_job_template: &cross_system_build_job_definition +.cross_system_build_job: stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest timeout: 80m @@ -13,7 +13,7 @@ xtensa-softmmu" - make -j$(expr $(nproc) + 1) all check-build =20 -.cross_user_build_job_template: &cross_user_build_job_definition +.cross_user_build_job: stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest script: @@ -24,91 +24,91 @@ - make -j$(expr $(nproc) + 1) all check-build =20 cross-armel-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-armel-cross =20 cross-armel-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-armel-cross =20 cross-armhf-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-armhf-cross =20 cross-armhf-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-armhf-cross =20 cross-arm64-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-arm64-cross =20 cross-arm64-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-arm64-cross =20 cross-mips-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-mips-cross =20 cross-mips-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-mips-cross =20 cross-mipsel-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-mipsel-cross =20 cross-mipsel-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-mipsel-cross =20 cross-mips64el-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-mips64el-cross =20 cross-mips64el-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-mips64el-cross =20 cross-ppc64el-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-ppc64el-cross =20 cross-ppc64el-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-ppc64el-cross =20 cross-s390x-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: debian-s390x-cross =20 cross-s390x-user: - <<: *cross_user_build_job_definition + extends: .cross_user_build_job variables: IMAGE: debian-s390x-cross =20 cross-win32-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: fedora-win32-cross =20 cross-win64-system: - <<: *cross_system_build_job_definition + extends: .cross_system_build_job variables: IMAGE: fedora-win64-cross --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507490; cv=none; d=zohomail.com; s=zohoarc; b=ccu47Q56BfJDOC+tE576eSELQi6eEKibCK7Whu9DHMtyAx3pIB7wm3upvaKyJhl6IIvcizlzqL+MjCQa14FUs+VM2+kyU0GtHEvXPGbkFB25GhzAvNlB8f5SIgIrVQ/OH5g+4CMw7LhfQbizpXbeD+wmAdHRA3MoKqQ5SJ0Z9bs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507490; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b6/e0wHvdJ4FDDGfDgn0d8JqOfAIuJFNTNkOA6bLPGg=; b=XU8YFVZP+8HvAmIHWxGfDPdsr5tYoC9Rcw3/99cl81wLXyLTz7debA7fyR1Wtp5VOLJ8XT9FYyV+IYeSoFNvlzMQX4cv1A3t5C8oiMTmrkP2aYRpLNprm1kyuxsBh4bkq/m6/tc24eTmMew82QWZVwuw6yqU1UGI/EDORMW+lkA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507490655848.272893317196; Wed, 9 Dec 2020 01:51:30 -0800 (PST) Received: from localhost ([::1]:59760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmw89-00075g-CH for importer@patchew.org; Wed, 09 Dec 2020 04:51:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw5w-0005Ea-3w for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw5u-0007MI-CJ for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:11 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-7t1ZCznmP-agMJ-H8HqqmQ-1; Wed, 09 Dec 2020 04:49:07 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A171A425D0; Wed, 9 Dec 2020 09:49:06 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 87CBE5C23D; Wed, 9 Dec 2020 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b6/e0wHvdJ4FDDGfDgn0d8JqOfAIuJFNTNkOA6bLPGg=; b=K77wU/7BHPLNs75els899rMTNomzZUrdqsjXdlwg0YEN77pNjPAlG8gxOFLwNMqkIItahm sO1jU1qOsilk7bEzKpHhtvkPyPL8yh4ZdQskpSbXpkO1fQNRRCIPvkeIka6KcHOc1QzvnK lH3NXQCdz0gQ5eQ+gh/C1HwZeI6wZgY= X-MC-Unique: 7t1ZCznmP-agMJ-H8HqqmQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 03/13] gitlab-ci: Introduce 'cross_accel_build_job' template Date: Wed, 9 Dec 2020 10:48:46 +0100 Message-Id: <20201209094856.17788-4-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Introduce a job template to cross-build accelerator specific jobs (enable a specific accelerator, disabling the others). The specific accelerator is selected by the $ACCEL environment variable (default to KVM). Extra options such disabling other accelerators are passed via the $ACCEL_CONFIGURE_OPTS environment variable. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201207131503.3858889-4-philmd@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 099949aaef..b59516301f 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -13,6 +13,23 @@ xtensa-softmmu" - make -j$(expr $(nproc) + 1) all check-build =20 +# Job to cross-build specific accelerators. +# +# Set the $ACCEL variable to select the specific accelerator (default to +# KVM), and set extra options (such disabling other accelerators) via the +# $ACCEL_CONFIGURE_OPTS variable. +.cross_accel_build_job: + stage: build + image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest + timeout: 30m + script: + - mkdir build + - cd build + - PKG_CONFIG_PATH=3D$PKG_CONFIG_PATH + ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-tools + --enable-${ACCEL:-kvm} $ACCEL_CONFIGURE_OPTS + - make -j$(expr $(nproc) + 1) all check-build + .cross_user_build_job: stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507664; cv=none; d=zohomail.com; s=zohoarc; b=VIJrpBfuzOzL5y+i++NRmBwc/a0Ocq55TtkorzSvQL6G3+A9Ci3hmW6Dmnua/Bs3AqDt7X6F37ASouIokm+cMvYXZmvA8/Tpqac6nLvr0NuMS3SOkM7YkPEk1mmEehnxUkfDKmIUJcsH3sO2sJv1UJuNZ+5Sbq2HI3Hns8upGyg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507664; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=t/qWs1Z6ZkEtGQwG8bSn3zDqKPVce7JiQfJ+2CXkB+g=; b=UfAQEVfltqky0RyqMWr08VdNbLsfGbZP4Sge5H+L1Io+xC8s346zTQjQ5Bel2asHPJQMz5EqSORFQKiF/Ip7oFj8/bzh+OkvZYpmilC9OaSPVhzib2fbObPrweEgs7/v7PX6MWj+MatEBFYT3pQTxQnAUIUzImLYrVPkRR6S4bg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507664107869.0412861123925; Wed, 9 Dec 2020 01:54:24 -0800 (PST) Received: from localhost ([::1]:39310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwAw-0001yh-Ef for importer@patchew.org; Wed, 09 Dec 2020 04:54:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw5x-0005Gd-57 for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw5v-0007NK-HZ for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:12 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-135-ijgo2MmwOzeEjpk-dOhm1g-1; Wed, 09 Dec 2020 04:49:08 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E533A1927804; Wed, 9 Dec 2020 09:49:07 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F7855C234; Wed, 9 Dec 2020 09:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t/qWs1Z6ZkEtGQwG8bSn3zDqKPVce7JiQfJ+2CXkB+g=; b=R4IJVNBwGEYvxs6hXPtaULsnII3JMN53V1/2j+5TMmOaI9YO/RuGbRe991i1qzhFnl2ixj YR0XV0MNSO9Ci1bAcUXSquFaexDFZd3Ze2olIEtESk+OKL89iHyQoPoc990SumWi6TWSlq 3t9xGaCjUbqY9dK/NTjErjP+u1msfeQ= X-MC-Unique: ijgo2MmwOzeEjpk-dOhm1g-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 04/13] gitlab-ci: Add KVM s390x cross-build jobs Date: Wed, 9 Dec 2020 10:48:47 +0100 Message-Id: <20201209094856.17788-5-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Cross-build s390x target with only KVM accelerator enabled. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201207131503.3858889-5-philmd@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index b59516301f..51896bbc9f 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -1,4 +1,3 @@ - .cross_system_build_job: stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest @@ -120,6 +119,12 @@ cross-s390x-user: variables: IMAGE: debian-s390x-cross =20 +cross-s390x-kvm-only: + extends: .cross_accel_build_job + variables: + IMAGE: debian-s390x-cross + ACCEL_CONFIGURE_OPTS: --disable-tcg + cross-win32-system: extends: .cross_system_build_job variables: --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507503; cv=none; d=zohomail.com; s=zohoarc; b=XZjoeRIXYXjLV4FEanaN570AAWJ/YbAfdbNtwkWnl4AIGXeyTyo+QguEv/KO/pzHDO5QMOoPJv5LmBW/8MVT9wXDC6yMtKX+CxLYej/XaZCzkS7Pa/TtnA9OF9iiTJPaDK7PAhc1dSV2x/4E3FmC5b24FyRPEA86ukvoo9eU+v4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507503; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vDDqdZAeiiL2gZpo5csTBBz4F6jgVsFNvSff4mtN/Bk=; b=jyN/FmLB0DApPjYIU1QiLP3pvHf3qR/OGm6BoMdxyKrJFsS6I2LE6bPndhX3Zx+eW+pp7v2VWAM28wcUdWwichZEFVhwX+UbMF5zJyj/zjzKhpLnaMe4CMPRQDKDvpFGJJixCp9KmWD3xEn6dZ7LtGU1whvn7S8vHo7Zh8E06tU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507503724413.9639922511458; Wed, 9 Dec 2020 01:51:43 -0800 (PST) Received: from localhost ([::1]:60018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmw8M-0007Bw-Es for importer@patchew.org; Wed, 09 Dec 2020 04:51:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw5y-0005JS-Sq for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw5x-0007Nz-B3 for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:14 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-GCCeTCxUOOmnsHTJfwHX8w-1; Wed, 09 Dec 2020 04:49:10 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74082425C8; Wed, 9 Dec 2020 09:49:09 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 694615C234; Wed, 9 Dec 2020 09:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vDDqdZAeiiL2gZpo5csTBBz4F6jgVsFNvSff4mtN/Bk=; b=cNjZmntqrW8CJYHxnyeIb71Wu8QehmnWpSxttfV4kk4qOmBNrK9JW9WyJ/iofTvjBmqvhD /PCtIdDrejt8pULvQLgWj1rwprTzzhqAmHdY/0HAF8zbIf8u12rh0zAVDhpQQjhrm2Csmz EVNZweTS9X/w3FQMcLNtbDmvtikjfAs= X-MC-Unique: GCCeTCxUOOmnsHTJfwHX8w-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 05/13] gitlab-ci: Add Xen cross-build jobs Date: Wed, 9 Dec 2020 10:48:48 +0100 Message-Id: <20201209094856.17788-6-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Cross-build ARM and X86 targets with only Xen accelerator enabled. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201207131503.3858889-6-philmd@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 51896bbc9f..bd6473a75a 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -134,3 +134,17 @@ cross-win64-system: extends: .cross_system_build_job variables: IMAGE: fedora-win64-cross + +cross-amd64-xen-only: + extends: .cross_accel_build_job + variables: + IMAGE: debian-amd64-cross + ACCEL: xen + ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-kvm + +cross-arm64-xen-only: + extends: .cross_accel_build_job + variables: + IMAGE: debian-arm64-cross + ACCEL: xen + ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-kvm --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507820; cv=none; d=zohomail.com; s=zohoarc; b=aepCHODKPAzXP862INI8EsCLTmXP81gOVq8ZmvSluxbAHNoDIcVHhDHz7JL6DXRwxuqmniSghiWAMCw2k/gdC9QnzE2gTjipHh52uLJwkWDEf2i8GyqgTaBPwTavh67JVbuaV6joIY/bQa3VsQVN9VpPQyU7oLaG0r+sp+SFQGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507820; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kjhazOPgtvZ6B/zqhf9DQqbMkE3gduMMNFqxEyilhBA=; b=crjhKrF3r47F8vVu7c2c8/gMsdULAYn6SeXCGVhssLbuZVWWYzUTHU/Vm218ipLHASJRRyhVsF/J7LMLtQ88IBTmVmsaoS2qzhlq2tlLuGeoxx8EpK5lBF1R66FuhtCvfPcLERxFxKbgF0xnCJYyqTyu2jG2cbDSxcyvwWmBYQw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507820654712.976545995271; Wed, 9 Dec 2020 01:57:00 -0800 (PST) Received: from localhost ([::1]:48322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwDT-0005nr-C3 for importer@patchew.org; Wed, 09 Dec 2020 04:56:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw63-0005ME-JE for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw60-0007P8-8o for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:19 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-gJ_wUNKZN0GK1E8-kdyKCg-1; Wed, 09 Dec 2020 04:49:12 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5DB7107ACE3; Wed, 9 Dec 2020 09:49:10 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id C28F95C23D; Wed, 9 Dec 2020 09:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kjhazOPgtvZ6B/zqhf9DQqbMkE3gduMMNFqxEyilhBA=; b=UzXN+JYTO5Qj5tCRwg5PrzDFMBBc2KEYlVQRSo30Tqz3Zmg+JaoIbPfH5hTpU34u6gSIoy l2AUm+XDLgM1maJ9If6FPyuRPfuXnWd6gpSoDKPmd9jdbBGUFC7pBgXcoigCl29KGVxykJ Mrp+W+25IDsTrsOUj5iSkWkDNplKqp8= X-MC-Unique: gJ_wUNKZN0GK1E8-kdyKCg-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 06/13] test-qga: fix a resource leak in test_qga_guest_get_osinfo() Date: Wed, 9 Dec 2020 10:48:49 +0100 Message-Id: <20201209094856.17788-7-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Alex Chen The fixture->fd is created in fixture_setup() and, likewise, needs to be cl= osed in fixture_tear_down(). Reported-by: Euler Robot Signed-off-by: Alex Chen Reviewed-by: Li Qiang Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20201125102403.57709-1-alex.chen@huawei.com> Signed-off-by: Thomas Huth --- tests/test-qga.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-qga.c b/tests/test-qga.c index c1b173b3cb..eb33264e8e 100644 --- a/tests/test-qga.c +++ b/tests/test-qga.c @@ -111,6 +111,7 @@ fixture_tear_down(TestFixture *fixture, gconstpointer d= ata) =20 g_rmdir(fixture->test_dir); g_free(fixture->test_dir); + close(fixture->fd); } =20 static void qmp_assertion_message_error(const char *domain, --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507669; cv=none; d=zohomail.com; s=zohoarc; b=hONn6L+sakdmmwmYQNWSC/7Da3n2UNOEdS6LHIvOpqWriMq7a5RjilQiXrT9zOaiDWplIgTFw3xX6Z99I1EzMnNbr+7VA8XVobVhsFWXcjc05+uUbCBSls+DldB89Eu8w91LoYXJSvcUDYsKj1BzwhtGIubyTyEXI7++7jSBNrY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507669; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LsETqTNuu0aB9+GRsnJd4uKFkyUbCTAU9f/mtAmw/nA=; b=bMxpYjixF0SmFIvvmkSyzSjmFKEdq9goK4Pid9cjgYhWCw6S7w2h+AOkgBGcMNMMo0pQgEEfcjltht61XPaMQUzcOUc1WJU755pPu2mUVUXr/vCA5N9jW1G8GrrKpDuIp7+RnYFHGW0hOWyTvj1ITU4B12RML6RygpGN5NTGaWU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507669957568.4296205144949; Wed, 9 Dec 2020 01:54:29 -0800 (PST) Received: from localhost ([::1]:39896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwB2-0002D0-MB for importer@patchew.org; Wed, 09 Dec 2020 04:54:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw61-0005Lv-HK for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw5z-0007P5-Vj for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:17 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-zGSwtG5sPVSZO7HPJ2mT3w-1; Wed, 09 Dec 2020 04:49:13 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C8521005504; Wed, 9 Dec 2020 09:49:12 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4465C5C234; Wed, 9 Dec 2020 09:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LsETqTNuu0aB9+GRsnJd4uKFkyUbCTAU9f/mtAmw/nA=; b=aAcDaXV5v/t66gXfmGDdEi8a9w0Aqf5/sblQgaOxt74ogciCRK+5eTJBcCUe+jlcCNsez+ CaBhfHUm/Hk2jAOysgPL6LcFPHIJMVpuycySuU2bD+AS14IO2CR0a+R5mauDs9v5pfgyGl TXNbR8TY9AMSTrfG1tY+IgcCMsVIEfw= X-MC-Unique: zGSwtG5sPVSZO7HPJ2mT3w-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 07/13] tests/qtest/fuzz-test: Quit test_lp1878642 once done Date: Wed, 9 Dec 2020 10:48:50 +0100 Message-Id: <20201209094856.17788-8-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Missed in fd250172842 ("qtest: add a reproducer for LP#1878642"). Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201201191026.4149955-2-philmd@redhat.com> Reviewed-by: Li Qiang Signed-off-by: Thomas Huth --- tests/qtest/fuzz-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c index 9cb4c42bde..87b72307a5 100644 --- a/tests/qtest/fuzz-test.c +++ b/tests/qtest/fuzz-test.c @@ -45,6 +45,7 @@ static void test_lp1878642_pci_bus_get_irq_level_assert(v= oid) qtest_outl(s, 0xcf8, 0x8400f841); qtest_outl(s, 0xcfc, 0xebed205d); qtest_outl(s, 0x5d02, 0xebed205d); + qtest_quit(s); } =20 int main(int argc, char **argv) --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607509261; cv=none; d=zohomail.com; s=zohoarc; b=DOaHTX57dqlH1o2gyzTc+m1TopJSViQVox7z05oEq1YLPOfG7uAiLsWETWEEynDknwLZcUjQf65Dkb2CkssQd7CqO5DdH2AXmXEb9XUuNGSGPxd0PI2QRMTReN/QP64i6naXdChDd4ZJQi5XBlHNR9lOP982qKZY1j9Eq3HPj08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607509261; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=tPYQuJfAFpwqk/56/qEDeo41MhtdTN/7twypqmUBF6w=; b=EuD7yb43Wf4rGsKsJ7MnCFhhjXeyAiBsXD2JDwRu8QvXgcYEA1G+rfsX6eiUAvomW966Bj/hHqE1/wr3b1bD/hHT4bPAZJ6agRWpaFuHqDX+fd4OGNMLUGKzjRidyxjAH9VCdyGx3avPp4yhfkfQrtZsjC5pc8iQCqU30IH6jFY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607509261072193.18976699709208; Wed, 9 Dec 2020 02:21:01 -0800 (PST) Received: from localhost ([::1]:56806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwGj-0000sC-6o for importer@patchew.org; Wed, 09 Dec 2020 05:00:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw6B-0005O1-Ng for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29384) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw61-0007Q6-Mb for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:26 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-t9Vc4PWUNi-TK4PMZer-8g-1; Wed, 09 Dec 2020 04:49:14 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C82271927803; Wed, 9 Dec 2020 09:49:13 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB4A55C234; Wed, 9 Dec 2020 09:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=tPYQuJfAFpwqk/56/qEDeo41MhtdTN/7twypqmUBF6w=; b=NNnvkpNGzwQJs5mywozHHjyVPoFCj00LF6Fidp781SYN9dwn2gnl95iOnxTjudP1dwfV2l h0falAR8wtfNSc+igr65b2gotqXcTth4LeEiy9pWfDZysbwfuEPZ5YUGfQPXDmSy8q3eqj o8nzUjmR5YcW5BUf0qthzkBNOY3jzfc= X-MC-Unique: t9Vc4PWUNi-TK4PMZer-8g-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 08/13] fuzz: avoid double-fetches by default Date: Wed, 9 Dec 2020 10:48:51 +0100 Message-Id: <20201209094856.17788-9-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Bulekov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Alexander Bulekov The generic fuzzer can find double-fetch bugs. However: * We currently have no good way of producing qemu-system reproducers for double-fetch bugs. Even if we can get developers to run the binary-blob reproducers with the qemu-fuzz builds, we currently don't have a minimize= r for these reproducers, so they are usually not easy to follow. * Often times the fuzzer will provide a reproducer containing a double-fetch for a bug that can be reproduced without double-fetching. Until we find a way to build nice double-fetch reproducers that developers are willing to look at, lets tell OSS-Fuzz to avoid double-fetches. Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny Message-Id: <20201202164214.93867-1-alxndr@bu.edu> Signed-off-by: Thomas Huth --- tests/qtest/fuzz/generic_fuzz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuz= z.c index 262a963d2e..07ad690683 100644 --- a/tests/qtest/fuzz/generic_fuzz.c +++ b/tests/qtest/fuzz/generic_fuzz.c @@ -916,6 +916,7 @@ static GString *generic_fuzz_predefined_config_cmdline(= FuzzTarget *t) g_assert(t->opaque); =20 config =3D t->opaque; + setenv("QEMU_AVOID_DOUBLE_FETCH", "1", 1); setenv("QEMU_FUZZ_ARGS", config->args, 1); setenv("QEMU_FUZZ_OBJECTS", config->objects, 1); return generic_fuzz_cmdline(t); --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607508031; cv=none; d=zohomail.com; s=zohoarc; b=mq+s43xXtvlsCJhuXxzn++PvZUOZpZwzAomn05CvZwWrlmY8EJi9un+NAS8s5WHJ4PidO5+cNrsmJ4D3GPQpSLZwmjEYZPRhfJZ6Z0HSlNIRq0E4Y5VwO1ZZow/Uz8CLgE3z/gb3DLxjNZNI/Pq50RQGjte0rdUazrxR5hcyrpw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607508031; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2lozm2TPJMF/YF3/HO6u6/cGWniLFxLwGKhXgcJoS4s=; b=K1foQnp/g//GH9w1ISlaPp+H6WofSU5+fprYl/XkAJjWctFBYjJbdElln7oKu55LWr2HzdKPOOQpC1Rs6JmLyn0aJtoBSjUVyeNQLhlltvT4mz3tcPZ0kxFciUIHaoW84Kw0JrRdwfF0zQ6me0vTtuni2dbWm5DHXTyaLDd2sR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607508031812712.5318334358993; Wed, 9 Dec 2020 02:00:31 -0800 (PST) Received: from localhost ([::1]:56772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwGl-0000rJ-CS for importer@patchew.org; Wed, 09 Dec 2020 05:00:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw6C-0005Oe-5g for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw67-0007Qb-0P for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:27 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-4AZ_rD9DMwmm2YBr6Zvi8w-1; Wed, 09 Dec 2020 04:49:16 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D926107ACE3; Wed, 9 Dec 2020 09:49:15 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 24A615C234; Wed, 9 Dec 2020 09:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2lozm2TPJMF/YF3/HO6u6/cGWniLFxLwGKhXgcJoS4s=; b=RNx7JhGS0FkUi/RGBfBn9es0XTFOUFqeOv1cibYSl4meI+K4ZmXjqJhyX6uso/rju2Amgw k+Irs3j48ysPveLdHmUfbGpjdTUi02Jnqqt0uG6Rr1FL0tT/QbQ2mm3s1QVECzreo97qlY QRYnnW9NgDODaYDpsHocgclVrGhlh8M= X-MC-Unique: 4AZ_rD9DMwmm2YBr6Zvi8w-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 09/13] gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled Date: Wed, 9 Dec 2020 10:48:52 +0100 Message-Id: <20201209094856.17788-10-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 We will keep adding/removing options to our 'configure' script, so for easier maintainability it makes sense to have CONFIGURE_ARGS declared as one option per line. This way we can review diff easily (or rebase/cherry-pick). No logical change. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201108204535.2319870-6-philmd@redhat.com> Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 80 +++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 63 insertions(+), 17 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ee31b1020f..d2cd5d9386 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -199,23 +199,69 @@ build-disabled: <<: *native_build_job_definition variables: IMAGE: fedora - CONFIGURE_ARGS: --disable-attr --disable-avx2 --disable-bochs - --disable-brlapi --disable-bzip2 --disable-cap-ng --disable-capstone - --disable-cloop --disable-coroutine-pool --disable-curl --disable-cu= rses - --disable-dmg --disable-docs --disable-glusterfs --disable-gnutls - --disable-gtk --disable-guest-agent --disable-iconv --disable-kvm - --disable-libiscsi --disable-libpmem --disable-libssh --disable-libu= sb - --disable-libxml2 --disable-linux-aio --disable-live-block-migration - --disable-lzo --disable-malloc-trim --disable-mpath --disable-nettle - --disable-numa --disable-parallels --disable-pie --disable-qcow1 - --disable-qed --disable-qom-cast-debug --disable-rbd --disable-rdma - --disable-replication --disable-sdl --disable-seccomp --disable-shee= pdog - --disable-slirp --disable-smartcard --disable-snappy --disable-spice - --disable-strip --disable-tpm --disable-usb-redir --disable-vdi - --disable-vhost-crypto --disable-vhost-net --disable-vhost-scsi - --disable-vhost-user --disable-vhost-vdpa --disable-vhost-vsock - --disable-virglrenderer --disable-vnc --disable-vte --disable-vvfat - --disable-xen --disable-zstd + CONFIGURE_ARGS: + --disable-attr + --disable-avx2 + --disable-bochs + --disable-brlapi + --disable-bzip2 + --disable-cap-ng + --disable-capstone + --disable-cloop + --disable-coroutine-pool + --disable-curl + --disable-curses + --disable-dmg + --disable-docs + --disable-glusterfs + --disable-gnutls + --disable-gtk + --disable-guest-agent + --disable-iconv + --disable-kvm + --disable-libiscsi + --disable-libpmem + --disable-libssh + --disable-libusb + --disable-libxml2 + --disable-linux-aio + --disable-live-block-migration + --disable-lzo + --disable-malloc-trim + --disable-mpath + --disable-nettle + --disable-numa + --disable-parallels + --disable-pie + --disable-qcow1 + --disable-qed + --disable-qom-cast-debug + --disable-rbd + --disable-rdma + --disable-replication + --disable-sdl + --disable-seccomp + --disable-sheepdog + --disable-slirp + --disable-smartcard + --disable-snappy + --disable-spice + --disable-strip + --disable-tpm + --disable-usb-redir + --disable-vdi + --disable-vhost-crypto + --disable-vhost-net + --disable-vhost-scsi + --disable-vhost-user + --disable-vhost-vdpa + --disable-vhost-vsock + --disable-virglrenderer + --disable-vnc + --disable-vte + --disable-vvfat + --disable-xen + --disable-zstd TARGETS: arm-softmmu i386-softmmu ppc64-softmmu mips64-softmmu s390x-softmmu i386-linux-user MAKE_CHECK_ARGS: check-qtest SPEED=3Dslow --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507817; cv=none; d=zohomail.com; s=zohoarc; b=NJxveF2QOsh2/aqlA2lRwQhbDNVbHIzRjZgbWABDzeQ6EJyjtG3Glmape2ttt6Wfd67TllQ2JG8e1G33/9BAO75hNWHq54BZOOWlO+CYmOG7w40OI67rMZD4OuR+qlkSTJVtAT7Modf1kb7dyr2a3LnONifAfceXK3vvBpsr7B4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507817; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f/LONfY0wLYM507v7mLDSvKiGE6HWwmxphGx6MMord0=; b=IV5PoSvRelYdfhXDDAnThsudiKtZi99rHDrhGZtUC69/eSVmpS92x9iW92aaPeZgLbrUtbUpal3L8tgnJJqs1sJBENjHJz3tMSuu2R9eNhvfr7zbPsGscXsh/yvtDRz5lk5PZBjK6hPjWRD1DNQGIBLXfpfOlpbACOsikE1SYd8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507817776356.41651547669437; Wed, 9 Dec 2020 01:56:57 -0800 (PST) Received: from localhost ([::1]:48340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwDQ-0005oF-7m for importer@patchew.org; Wed, 09 Dec 2020 04:56:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw6D-0005Oj-4E for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw67-0007QW-0l for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:28 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-xbrQsPmkPPyt-09faMBt-Q-1; Wed, 09 Dec 2020 04:49:17 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97ABD1005513; Wed, 9 Dec 2020 09:49:16 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FF3F5C234; Wed, 9 Dec 2020 09:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/LONfY0wLYM507v7mLDSvKiGE6HWwmxphGx6MMord0=; b=BVJan7JxvmGBPxTNfRcOuclzp6EpEf6rxilNzhGCAbaY0tYSPk3hY2qNpCvMSXzLSGgBSB sTH9drI+ugb1D8YTtpPynRfvXVLm4qz3lwB06mUftzPZ7gFtxnfcuZyA4H4weZm8IfIfwQ VPP8S6aD6KX49M+1SibxbRzlSDKBtd8= X-MC-Unique: xbrQsPmkPPyt-09faMBt-Q-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 10/13] gitlab-ci: Update 'build-disabled' to cover all configurable options Date: Wed, 9 Dec 2020 10:48:53 +0100 Message-Id: <20201209094856.17788-11-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Add these missing options to the 'build-disabled' job: --disable-auth-pam (commit 8953caf3cd38) --disable-gcrypt (commit 91bfcdb01d48) --disable-keyring (commit 54e7aac05624) --disable-libudev (commit 5c53015a480b) --disable-opengl (commit da076ffed6b9) --disable-sparse (commit 03b4fe7de226) Signed-off-by: Philippe Mathieu-Daud=C3=A9 [thuth: Dropped the unnecessary hunk with --disable-vhost-user-blk-server] Message-Id: <20201108204535.2319870-7-philmd@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d2cd5d9386..8f72a2630d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -201,6 +201,7 @@ build-disabled: IMAGE: fedora CONFIGURE_ARGS: --disable-attr + --disable-auth-pam --disable-avx2 --disable-bochs --disable-brlapi @@ -213,15 +214,18 @@ build-disabled: --disable-curses --disable-dmg --disable-docs + --disable-gcrypt --disable-glusterfs --disable-gnutls --disable-gtk --disable-guest-agent --disable-iconv + --disable-keyring --disable-kvm --disable-libiscsi --disable-libpmem --disable-libssh + --disable-libudev --disable-libusb --disable-libxml2 --disable-linux-aio @@ -231,6 +235,7 @@ build-disabled: --disable-mpath --disable-nettle --disable-numa + --disable-opengl --disable-parallels --disable-pie --disable-qcow1 @@ -245,6 +250,7 @@ build-disabled: --disable-slirp --disable-smartcard --disable-snappy + --disable-sparse --disable-spice --disable-strip --disable-tpm --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507876; cv=none; d=zohomail.com; s=zohoarc; b=A0wXwoh8bxkpdOIjwIJYUbNcmXAN+JPPz46yS+D7BdJ86k5f7aFpeJjr5IyuU93pJiZBP4omEdvM4+sTUk2Bo4pQXnxWNmn3VCOlLsZ2Wv6B87TRnBzkClxRhXFJpJT0npSc6V6xw0YcTRoeMFSv/bTUu6R10I/m0DXJ7IPhfXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507876; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nLGCmnPiwzTOGxMpIv3CrD+KsQctZ3kDi1bwndaDXFk=; b=J8jlwXivhv6CWnHxO4VtFsTlRDTrJI0FDU0AXQEV2DnybrbxaGu1HDJKgMhaZyLLNjbcgkF3MAYFKXpPmg47iQNXvZzZPw3w9tMDQ7IFjpn3n5ec4Wm2X4FXbM4wMY9PwNWRaCiFOwU5xsAUrILoKz9bEZdexApMskwxtA8TJuo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507876451211.49757067601297; Wed, 9 Dec 2020 01:57:56 -0800 (PST) Received: from localhost ([::1]:50766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwEM-0006mK-1p for importer@patchew.org; Wed, 09 Dec 2020 04:57:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw69-0005NU-Qd for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw67-0007Qg-1E for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:25 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-LErt0xMVMIGptFkwAZ61Ow-1; Wed, 09 Dec 2020 04:49:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E0EB802ED7; Wed, 9 Dec 2020 09:49:18 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 007305C234; Wed, 9 Dec 2020 09:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLGCmnPiwzTOGxMpIv3CrD+KsQctZ3kDi1bwndaDXFk=; b=TbdIQxTf489ysDqp57sYvJVuy8EL64poqRpsTwYy/t7Oet1mw4g1zNCRdPKFTnuloxFssZ wnf/1XuTAUUp8MC2GVRxb87HsVJwgmUFmFXD6CIt8AkPYH4NhUuQcl4cjh2JItos1UE7yq AmDiXOl9R/cKCWMjuWLbZtfwKsmJmRE= X-MC-Unique: LErt0xMVMIGptFkwAZ61Ow-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 11/13] gitlab-ci: Move user-static test across to gitlab Date: Wed, 9 Dec 2020 10:48:54 +0100 Message-Id: <20201209094856.17788-12-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Similarly to commit 8cdb2cef3f1, move the user-static test to GitLab. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201108204535.2319870-11-philmd@redhat.com> Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 7 +++++++ .travis.yml | 5 ----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8f72a2630d..7381c7858d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -304,6 +304,13 @@ build-user: CONFIGURE_ARGS: --disable-tools --disable-system MAKE_CHECK_ARGS: check-tcg =20 +build-user-static: + <<: *native_build_job_definition + variables: + IMAGE: debian-all-test-cross + CONFIGURE_ARGS: --disable-tools --disable-system --static + MAKE_CHECK_ARGS: check-tcg + # Only build the softmmu targets we have check-tcg tests for build-some-softmmu: <<: *native_build_job_definition diff --git a/.travis.yml b/.travis.yml index 1f80bdb624..12828f351c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -119,11 +119,6 @@ after_script: =20 jobs: include: - - name: "GCC static (user)" - env: - - CONFIG=3D"--disable-system --static" - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-default" - # Just build tools and run minimal unit and softfloat checks - name: "GCC check-unit and check-softfloat" env: --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607507676; cv=none; d=zohomail.com; s=zohoarc; b=TzwVe4FZJIvurFGuPDOAWf5POHMVzBVyFM3AqcCwoPw9stMFVVnXzt8OuqQHbJzoT/Kv7BR/X+SK8ND2u3py4NwefDKCgb3eG3hfjYhLuqdD+tiBwGXNjVXPhObJBwv60hMa+tmB7jxrQQwQFEZJuUK4Or69TglDdcZ6Oah3twA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607507676; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=w4AGHjiiyoWfPHvOu9gnxCxhCUV2+mC0SyPHzVmqzWg=; b=fQgBs5reKfCz06c6pq9uIOneABTItnQ68qq+Pb2GfY6w1VlCToH3Jj2p0MMm3rdrEUNpg3UL0RpRbVSaA4cZv6ZhrYECKh5rcvplVuLRQlNATVfrXZVdIX5vzRnfLUlWEjYRzS/fCldofs1H4puZi8MAQ/36L2qDbjNS6PSAado= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607507676917144.6245710151302; Wed, 9 Dec 2020 01:54:36 -0800 (PST) Received: from localhost ([::1]:40574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwB9-0002WO-KY for importer@patchew.org; Wed, 09 Dec 2020 04:54:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw6B-0005O5-Pv for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw67-0007Qo-LP for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:27 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-VXgldB8aObWViV5b4Au6xA-1; Wed, 09 Dec 2020 04:49:20 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74777107ACE3; Wed, 9 Dec 2020 09:49:19 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6793B5C234; Wed, 9 Dec 2020 09:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w4AGHjiiyoWfPHvOu9gnxCxhCUV2+mC0SyPHzVmqzWg=; b=KBLW9LdVK5qfgSjB28WLKTREArU2gMYISpmb8a7dQRWop9zViwD0kLI+jd+bM9Qkr6tq+Z olvzl5noblTL0ABelMxrCETxMUy5UFPtKLJvFh/V71XR36Mk4lIeXaWfYHUmpW7a8AaLq7 TEkmvXryd+wLAgeJW+hRTK30oqDqO6k= X-MC-Unique: VXgldB8aObWViV5b4Au6xA-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 12/13] gitlab-ci: Move coroutine tests across to gitlab Date: Wed, 9 Dec 2020 10:48:55 +0100 Message-Id: <20201209094856.17788-13-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Similarly to commit 8cdb2cef3f1, move the coroutine tests to GitLab. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201108204535.2319870-13-philmd@redhat.com> Reviewed-by: Wainer dos Santos Moschetta [thuth: Replaced Travis by Gitlab-CI in comment] Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 16 ++++++++++++++++ .travis.yml | 14 -------------- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7381c7858d..873ed19fcf 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -413,6 +413,22 @@ build-tci: - QTEST_QEMU_BINARY=3D"./qemu-system-x86_64" ./tests/qtest/pxe-test - QTEST_QEMU_BINARY=3D"./qemu-system-s390x" ./tests/qtest/pxe-test -m = slow =20 +# Alternate coroutines implementations are only really of interest to KVM = users +# However we can't test against KVM on Gitlab-CI so we can only run unit t= ests +build-coroutine-ucontext: + <<: *native_build_job_definition + variables: + IMAGE: ubuntu2004 + CONFIGURE_ARGS: --with-coroutine=3Ducontext --disable-tcg + MAKE_CHECK_ARGS: check-unit + +build-coroutine-sigaltstack: + <<: *native_build_job_definition + variables: + IMAGE: ubuntu2004 + CONFIGURE_ARGS: --with-coroutine=3Dsigaltstack --disable-tcg + MAKE_CHECK_ARGS: check-unit + # Most jobs test latest gcrypt or nettle builds # # These jobs test old gcrypt and nettle from RHEL7 diff --git a/.travis.yml b/.travis.yml index 12828f351c..d01714a5ae 100644 --- a/.travis.yml +++ b/.travis.yml @@ -148,20 +148,6 @@ jobs: - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-default" =20 =20 - # Alternate coroutines implementations are only really of interest to = KVM users - # However we can't test against KVM on Travis so we can only run unit = tests - - name: "check-unit coroutine=3Ducontext" - env: - - CONFIG=3D"--with-coroutine=3Ducontext --disable-tcg" - - TEST_CMD=3D"make check-unit -j${JOBS} V=3D1" - - - - name: "check-unit coroutine=3Dsigaltstack" - env: - - CONFIG=3D"--with-coroutine=3Dsigaltstack --disable-tcg" - - TEST_CMD=3D"make check-unit -j${JOBS} V=3D1" - - # Check we can build docs and tools (out of tree) - name: "tools and docs (bionic)" dist: bionic --=20 2.18.4 From nobody Wed May 22 03:00:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607508087; cv=none; d=zohomail.com; s=zohoarc; b=E7+HoC3hVEXn7N715daLzqYsqpGaCulUv6DsFqKmP36Xa9MymbGYAaq8lKmzPeT6nkS9Be2SiVusfJEL5V0cQIfyYh6ZTTfQKRXfksD0SHlWNfVxTiZgL1EeCDCwpNbPwx69jVgwJc/giZ+CcePp6fGToOGrlmAD6USr1ojOzKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607508087; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0GrfhnuhB5mq6HxiqzqPcElFKnZd9rtGczF8GGT5oac=; b=CNcTElkpplFH6KvzN5yCEL5Hbj7W97nTmKxzeIwZAI3CgXbPWpYhZUxwgyJISdSlbXiT0ikowLv4FDQyPYkPr5jJ7A0qoFm0ykxi0MlyKPyNSk5J5zHU9JrcTtYF7NfF/+TYEkv9DHhpVD5xRZkNDu7OT5UmjN7Hoi6iqKw6EaI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607508087310411.18834723968564; Wed, 9 Dec 2020 02:01:27 -0800 (PST) Received: from localhost ([::1]:58510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmwHl-0001fD-48 for importer@patchew.org; Wed, 09 Dec 2020 05:01:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmw6I-0005Q2-7V for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmw6B-0007Rr-DO for qemu-devel@nongnu.org; Wed, 09 Dec 2020 04:49:31 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-dCP8i7eGN_uOMoTbnIYWVQ-1; Wed, 09 Dec 2020 04:49:21 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ECD341927800; Wed, 9 Dec 2020 09:49:20 +0000 (UTC) Received: from thuth.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id D415E5C23D; Wed, 9 Dec 2020 09:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607507366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GrfhnuhB5mq6HxiqzqPcElFKnZd9rtGczF8GGT5oac=; b=AHljz+Id1/NTOh4KmFc1ZIklYS/t5HAW8JIMtj+7vx59QW6YZOKe6eezyx0xBGbku5W9Ba 71Vr/leTK3VlpZLoYfRrTXskxOlQSzYCd3nNHSrOGSpFNWMmGqo4RPfJqtW9qzEaFJ1Aw/ AsVWwBk6u04GOgBdplI/eWpzTpLGSMI= X-MC-Unique: dCP8i7eGN_uOMoTbnIYWVQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 13/13] hw/m68k/mcf5206: Don't leak IRQs in mcf5206_mbar_realize() Date: Wed, 9 Dec 2020 10:48:56 +0100 Message-Id: <20201209094856.17788-14-thuth@redhat.com> In-Reply-To: <20201209094856.17788-1-thuth@redhat.com> References: <20201209094856.17788-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Peter Maydell Coverity points out that the realize function for the TYPE_MCF5206_MBAR device leaks the IRQ array it allocates with qemu_allocate_irqs(). Keep a pointer to it in the device state struct to avoid the leak. (Since it needs to stay around for the life of the simulation there is no need to actually free it, and the leak was harmless.) Fixes: Coverity CID 1432412 Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201120172314.14725-1-peter.maydell@linaro.org> Signed-off-by: Thomas Huth --- hw/m68k/mcf5206.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c index 51d2e0da1c..92a194dbc4 100644 --- a/hw/m68k/mcf5206.c +++ b/hw/m68k/mcf5206.c @@ -164,6 +164,7 @@ typedef struct { =20 M68kCPU *cpu; MemoryRegion iomem; + qemu_irq *pic; m5206_timer_state *timer[2]; void *uart[2]; uint8_t scr; @@ -588,17 +589,16 @@ static const MemoryRegionOps m5206_mbar_ops =3D { static void mcf5206_mbar_realize(DeviceState *dev, Error **errp) { m5206_mbar_state *s =3D MCF5206_MBAR(dev); - qemu_irq *pic; =20 memory_region_init_io(&s->iomem, NULL, &m5206_mbar_ops, s, "mbar", 0x00001000); sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->iomem); =20 - pic =3D qemu_allocate_irqs(m5206_mbar_set_irq, s, 14); - s->timer[0] =3D m5206_timer_init(pic[9]); - s->timer[1] =3D m5206_timer_init(pic[10]); - s->uart[0] =3D mcf_uart_init(pic[12], serial_hd(0)); - s->uart[1] =3D mcf_uart_init(pic[13], serial_hd(1)); + s->pic =3D qemu_allocate_irqs(m5206_mbar_set_irq, s, 14); + s->timer[0] =3D m5206_timer_init(s->pic[9]); + s->timer[1] =3D m5206_timer_init(s->pic[10]); + s->uart[0] =3D mcf_uart_init(s->pic[12], serial_hd(0)); + s->uart[1] =3D mcf_uart_init(s->pic[13], serial_hd(1)); s->cpu =3D M68K_CPU(qemu_get_cpu(0)); } =20 --=20 2.18.4