From nobody Wed May 22 01:01:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607506780; cv=none; d=zohomail.com; s=zohoarc; b=eHoMysT3Q87ncwuyJFHZGE1dg0CK66Zch96hBRaJojRHWnM6xJZ4Efgf4AAuMfqbe6rocTTDHdlogwFz0/LQ0FxV0NXgfqE+1o/URNderm3HPcTl5+SvmaxONjhdjV33JZmHdCq8pmNCO3GwaF+jTXs81vBXfECC09PiKaxZrGQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607506780; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=2R4Sy1Y1Yk6/QbSMr3cSE+VqR34RhfQP4OrH2FHiV1E=; b=fa4M790/bQ1RJLVBgrvH/tLfKz9xalN+u9QaaOGYguQ86hlw02X0FPP1zhZvUcznRI3G9AQixFZIWgXyB5f2EVwjT+PNY2PlfULhdWLfoNUa5TUqxz4+CrbUiOFAfdWmTCXq1ih91OHycpi4XLa6LovPFA96jM8uxWS00P6MNWA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607506780801666.4924416280041; Wed, 9 Dec 2020 01:39:40 -0800 (PST) Received: from localhost ([::1]:50104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmvwg-00025Y-W1 for importer@patchew.org; Wed, 09 Dec 2020 04:39:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmvtS-0000uI-P9; Wed, 09 Dec 2020 04:36:18 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:16968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmvtQ-00031x-3R; Wed, 09 Dec 2020 04:36:18 -0500 Received: from wise (unknown [77.159.208.71]) (Authenticated sender: stephane.duverger@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 2D5705FF9E; Wed, 9 Dec 2020 10:36:03 +0100 (CET) Date: Wed, 9 Dec 2020 10:35:44 +0100 From: Stephane Duverger To: qemu-devel@nongnu.org Subject: [PATCH] ppc/translate: Fix need_access_type for non MMU_64 Message-ID: <20201209093544.GA58577@wise> MIME-Version: 1.0 Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.27.42.5; envelope-from=stephane.duverger@free.fr; helo=smtp5-g21.free.fr X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, SPOOFED_FREEMAIL=1.973 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The 64bits MMU variants have POWERPC_MMU_64 flag and POWERPC_MMU_64B is a specific one (POWERPC_MMU_32B with flag POWERPC_MMU_64). As a consequence, the original test ignored POWERPC_MMU_32B too. The commit 5f2a625452 targeted hash64 mmu version. And indeed the 'mmu-hash64.c' does not use access_type. But 'mmu-hash32.c' does. Signed-off-by: Stephane Duverger --- target/ppc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 54cac0e6a7..b4d0699ce3 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7892,7 +7892,7 @@ static void ppc_tr_init_disas_context(DisasContextBas= e *dcbase, CPUState *cs) ctx->insns_flags =3D env->insns_flags; ctx->insns_flags2 =3D env->insns_flags2; ctx->access_type =3D -1; - ctx->need_access_type =3D !(env->mmu_model & POWERPC_MMU_64B); + ctx->need_access_type =3D !(env->mmu_model & POWERPC_MMU_64); ctx->le_mode =3D !!(env->hflags & (1 << MSR_LE)); ctx->default_tcg_memop_mask =3D ctx->le_mode ? MO_LE : MO_BE; ctx->flags =3D env->flags; --=20 2.25.1