From nobody Tue May 21 12:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607483651; cv=none; d=zohomail.com; s=zohoarc; b=n6TgItnrgdUuyQb114ffcPy+HM3UuK+v9JQ/Md3oV0C7sxcswsc0uKHHs2O0xry7TfdB3W5M8q32RIG0ViGQ0UZdCPdJTQ+gt95p3erXzK9aqSKdUA0sjNWjljzKTZtnFi8xNLc5gZujd5i+MAESlBEtD8KnF7xCOwWCN0c4DH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607483651; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ApzxttbILK0zP5pmPcwJKINVHhvk+bo+9gALgKL2jOs=; b=itvdPQX5GmfIegPTj56hVurUdMAfqbajgfr2nbhI5gpPU7txUrc49JtY8ty9pnc24sT4Dj1rIl152SCRXhsWZMRouwhOn9b6gpKrF7eSu8/w0xvMafeXrPIOv846BaACZfkJjhXmKuoAkaqlj8VQ3Gc1BQvVNAwHXCbFekbqqxM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160748365154191.09631210172142; Tue, 8 Dec 2020 19:14:11 -0800 (PST) Received: from localhost ([::1]:49312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmpve-0006Eq-Di for importer@patchew.org; Tue, 08 Dec 2020 22:14:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpuC-0004ZD-UQ; Tue, 08 Dec 2020 22:12:40 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpu7-0008N3-Gx; Tue, 08 Dec 2020 22:12:40 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CrMXd3fRszhpXv; Wed, 9 Dec 2020 11:12:01 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 9 Dec 2020 11:12:16 +0800 From: zhouyang To: Subject: [PATCH v2 1/5] contrib: Don't use '#' flag of printf format Date: Wed, 9 Dec 2020 11:04:43 +0800 Message-ID: <20201209030447.2135652-2-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201209030447.2135652-1-zhouyang789@huawei.com> References: <20201209030447.2135652-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=zhouyang789@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the misuse of '#' flag of printf format Signed-off-by: zhouyang --- contrib/plugins/hotblocks.c | 2 +- contrib/plugins/hotpages.c | 2 +- contrib/plugins/howvec.c | 2 +- contrib/plugins/lockstep.c | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 37435a3fc7..4b08340143 100644 --- a/contrib/plugins/hotblocks.c +++ b/contrib/plugins/hotblocks.c @@ -63,7 +63,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) =20 for (i =3D 0; i < limit && it->next; i++, it =3D it->next) { ExecCount *rec =3D (ExecCount *) it->data; - g_string_append_printf(report, "%#016"PRIx64", %d, %ld, %"PRId= 64"\n", + g_string_append_printf(report, "0x%016"PRIx64", %d, %ld, %"PRI= d64"\n", rec->start_addr, rec->trans_count, rec->insns, rec->exec_count); } diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c index ecd6c18732..eacc678eac 100644 --- a/contrib/plugins/hotpages.c +++ b/contrib/plugins/hotpages.c @@ -88,7 +88,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) for (i =3D 0; i < limit && it->next; i++, it =3D it->next) { PageCounters *rec =3D (PageCounters *) it->data; g_string_append_printf(report, - "%#016"PRIx64", 0x%04x, %"PRId64 + "0x%016"PRIx64", 0x%04x, %"PRId64 ", 0x%04x, %"PRId64"\n", rec->page_address, rec->cpu_read, rec->reads, diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 3b9a6939f2..6e602aaccf 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -209,7 +209,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) i++, counts =3D g_list_next(counts)) { InsnExecCount *rec =3D (InsnExecCount *) counts->data; g_string_append_printf(report, - "Instr: %-24s\t(%ld hits)\t(op=3D%#08x/= %s)\n", + "Instr: %-24s\t(%ld hits)\t(op=3D0x%08x= /%s)\n", rec->insn, rec->count, rec->opcode, diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 5aad50869d..7fd35eb669 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -134,7 +134,7 @@ static void report_divergance(ExecState *us, ExecState = *them) =20 /* Output short log entry of going out of sync... */ if (verbose || divrec.distance =3D=3D 1 || diverged) { - g_string_printf(out, "@ %#016lx vs %#016lx (%d/%d since last)\n", + g_string_printf(out, "@ 0x%016lx vs 0x%016lx (%d/%d since last)\n", us->pc, them->pc, g_slist_length(divergence_log), divrec.distance); qemu_plugin_outs(out->str); @@ -144,7 +144,7 @@ static void report_divergance(ExecState *us, ExecState = *them) int i; GSList *entry; =20 - g_string_printf(out, "=CE=94 insn_count @ %#016lx (%ld) vs %#016lx= (%ld)\n", + g_string_printf(out, "=CE=94 insn_count @ 0x%016lx (%ld) vs 0x%016= lx (%ld)\n", us->pc, us->insn_count, them->pc, them->insn_count= ); =20 for (entry =3D log, i =3D 0; @@ -152,7 +152,7 @@ static void report_divergance(ExecState *us, ExecState = *them) entry =3D g_slist_next(entry), i++) { ExecInfo *prev =3D (ExecInfo *) entry->data; g_string_append_printf(out, - " previously @ %#016lx/%ld (%ld insns)= \n", + " previously @ 0x%016lx/%ld (%ld insns= )\n", prev->block->pc, prev->block->insns, prev->insn_count); } --=20 2.23.0 From nobody Tue May 21 12:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607483649; cv=none; d=zohomail.com; s=zohoarc; b=DmGibU5+e8r+ONWTi+v8FtzQA2yj4/aGIF314GCUr2DjvhPA1Y/4RSCTiBOcMJ3GtuiavpLFzHYR4zfvHXTex9YWKaTmb2XW9pR2t4QsOucOYNgTFXdaWR3UiEMMQbPOM8dd9ggYNWn45N0VfUUZuIlHapwxZU4vRAIf+qJRdo0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607483649; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S9U/WeQLgwHsKpCvpBBDu+ZJEyw6fNAxv52Q4J+SnEg=; b=NZEHL8ALSOsGeu3HoWtK1oueSSvt8PHkZamp4lnR8XEw+ydolkrjOWNg7T3byWLFpLHf4a3KKjuYdqGQ9+OceORmWMHpPD4ynaLl4md+1ej3J+y9N155b2RPafcFc/6VTwh8Cvht1edqF93S7xcLcZ6X2FlfUpnYJkxGjRnolVs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160748364962628.717370635956513; Tue, 8 Dec 2020 19:14:09 -0800 (PST) Received: from localhost ([::1]:49172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmpvc-0006Am-BQ for importer@patchew.org; Tue, 08 Dec 2020 22:14:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpuA-0004YZ-Lj; Tue, 08 Dec 2020 22:12:38 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpu7-0008N2-C8; Tue, 08 Dec 2020 22:12:38 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CrMXd3pPHzhpbL; Wed, 9 Dec 2020 11:12:01 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 9 Dec 2020 11:12:16 +0800 From: zhouyang To: Subject: [PATCH v2 2/5] contrib: Fix some code style problems, ERROR: "foo * bar" should be "foo *bar" Date: Wed, 9 Dec 2020 11:04:44 +0800 Message-ID: <20201209030447.2135652-3-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201209030447.2135652-1-zhouyang789@huawei.com> References: <20201209030447.2135652-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=zhouyang789@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: zhouyang --- contrib/plugins/howvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 6e602aaccf..2f892da17d 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -235,7 +235,7 @@ static void vcpu_insn_exec_before(unsigned int cpu_inde= x, void *udata) (*count)++; } =20 -static uint64_t * find_counter(struct qemu_plugin_insn *insn) +static uint64_t *find_counter(struct qemu_plugin_insn *insn) { int i; uint64_t *cnt =3D NULL; --=20 2.23.0 From nobody Tue May 21 12:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607483877; cv=none; d=zohomail.com; s=zohoarc; b=HKQGtgqkEyZfUZkJuFYBm9fcwqs7+/gh9mUgMZqat5eAbAAGcQHjLlsEzWBoIjUj2prcYdT7vpaIxjwJZ0QrteOtXTpKNPBLG85wy9oi6q8R6enVuC1BYr3VWL//Dcy2FnLs33/5do6W4o3V1DXkBfNK9bb2fv6kByip2sA1yUs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607483877; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yfwRodM3SVvFLcgsYmQ4W0ghVCgariZfqKCl3iTjfzE=; b=LU4JgRnfVJ/6vlRqQ6sE1cNqJpyJ3wwY86ivhAqbMuSW7gkBUnYlFql+RL1RCvl3yWYgQMEuiRMe/fMAnprzIhEnQDC5wxM3rAPxe1z2icgpjylGFgecP4kOIDvIs81A1iGOxwPrvywc2APBbtYo4OYUHs0MrBQ/Kmd9O4tREik= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607483877446795.3986908672741; Tue, 8 Dec 2020 19:17:57 -0800 (PST) Received: from localhost ([::1]:57448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmpzI-0001KC-5c for importer@patchew.org; Tue, 08 Dec 2020 22:17:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpuM-0004wH-Kj; Tue, 08 Dec 2020 22:12:50 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpu7-0008N5-I4; Tue, 08 Dec 2020 22:12:50 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CrMXd4G5Kzhpbc; Wed, 9 Dec 2020 11:12:01 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 9 Dec 2020 11:12:17 +0800 From: zhouyang To: Subject: [PATCH v2 3/5] contrib: Add spaces around operator Date: Wed, 9 Dec 2020 11:04:45 +0800 Message-ID: <20201209030447.2135652-4-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201209030447.2135652-1-zhouyang789@huawei.com> References: <20201209030447.2135652-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=zhouyang789@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: spaces required around that '*' Signed-off-by: zhouyang --- contrib/ivshmem-server/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c index ee08c4ced0..224dbeb547 100644 --- a/contrib/ivshmem-server/main.c +++ b/contrib/ivshmem-server/main.c @@ -17,7 +17,7 @@ #define IVSHMEM_SERVER_DEFAULT_PID_FILE "/var/run/ivshmem-server.pid" #define IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH "/tmp/ivshmem_socket" #define IVSHMEM_SERVER_DEFAULT_SHM_PATH "ivshmem" -#define IVSHMEM_SERVER_DEFAULT_SHM_SIZE (4*1024*1024) +#define IVSHMEM_SERVER_DEFAULT_SHM_SIZE (4 * 1024 * 1024) #define IVSHMEM_SERVER_DEFAULT_N_VECTORS 1 =20 /* used to quit on signal SIGTERM */ --=20 2.23.0 From nobody Tue May 21 12:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607483647; cv=none; d=zohomail.com; s=zohoarc; b=LE/eFrUkJYxUelw7vR6WS5p/PwGCqSwW21XacbgXjW1uV8KSqkF+AKixgxdq4fxWb1WOgJrKD6F9iEqcdIjw3M0/+pBJ3D4xChRwfbF+C+VV+6AUOxGgtR29jidO/ChWxhr04xO+ZTGbF0kd0ttSWSfHX5IxXY6yL+gDfdWAgGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607483647; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OA6F4Mx+2bDFPtutFSvgUkIoKDw48xDLjIFjLos0Byk=; b=R6fXMsuiS8CF20O8QKxNIIQHu+9YcYldqS8xGKg8xBijMbJMThDjKu+MCWERhYh/qbumem12neSj4BegkDFzbqXBtrY0V0OB8/l04oFwvY+kSSLLJ9n8GzMdKZKggkATVoI/tNFtLF7ma46gyO+oXWC24ygCUXtB4fJTQWBk5xI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16074836474263.0827474362743033; Tue, 8 Dec 2020 19:14:07 -0800 (PST) Received: from localhost ([::1]:48940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmpvZ-00064z-UT for importer@patchew.org; Tue, 08 Dec 2020 22:14:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpuC-0004Yx-6D; Tue, 08 Dec 2020 22:12:40 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpu7-0008N6-JJ; Tue, 08 Dec 2020 22:12:39 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CrMXd4QFDzhpcN; Wed, 9 Dec 2020 11:12:01 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 9 Dec 2020 11:12:18 +0800 From: zhouyang To: Subject: [PATCH v2 4/5] contrib: space required after that ',' Date: Wed, 9 Dec 2020 11:04:46 +0800 Message-ID: <20201209030447.2135652-5-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201209030447.2135652-1-zhouyang789@huawei.com> References: <20201209030447.2135652-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=zhouyang789@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: space required after that ',' Signed-off-by: zhouyang --- contrib/plugins/howvec.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 2f892da17d..9d6fa33297 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -68,7 +68,7 @@ static InsnClassExecCount aarch64_insn_classes[] =3D { { "Reserved", "res", 0x1e000000, 0x00000000, COUNT_CLASS= }, /* Data Processing Immediate */ { " PCrel addr", "pcrel", 0x1f000000, 0x10000000, COUNT_CLASS= }, - { " Add/Sub (imm,tags)","asit", 0x1f800000, 0x11800000, COUNT_CLASS= }, + { " Add/Sub (imm,tags)", "asit", 0x1f800000, 0x11800000, COUNT_CLAS= S}, { " Add/Sub (imm)", "asi", 0x1f000000, 0x11000000, COUNT_CLASS= }, { " Logical (imm)", "logi", 0x1f800000, 0x12000000, COUNT_CLASS= }, { " Move Wide (imm)", "movwi", 0x1f800000, 0x12800000, COUNT_CLASS= }, @@ -91,17 +91,17 @@ static InsnClassExecCount aarch64_insn_classes[] =3D { { "Branches", "branch", 0x1c000000, 0x14000000, COUNT_CLASS= }, /* Loads and Stores */ { " AdvSimd ldstmult", "advlsm", 0xbfbf0000, 0x0c000000, COUNT_CLASS= }, - { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS= }, + { " AdvSimd ldstmult++", "advlsmp", 0xbfb00000, 0x0c800000, COUNT_CLA= SS}, { " AdvSimd ldst", "advlss", 0xbf9f0000, 0x0d000000, COUNT_CLASS= }, - { " AdvSimd ldst++", "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS= }, + { " AdvSimd ldst++", "advlssp", 0xbf800000, 0x0d800000, COUNT_CLAS= S}, { " ldst excl", "ldstx", 0x3f000000, 0x08000000, COUNT_CLASS= }, { " Prefetch", "prfm", 0xff000000, 0xd8000000, COUNT_CLASS= }, { " Load Reg (lit)", "ldlit", 0x1b000000, 0x18000000, COUNT_CLASS= }, - { " ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS= }, + { " ldst noalloc pair", "ldstnap", 0x3b800000, 0x28000000, COUNT_CLAS= S}, { " ldst pair", "ldstp", 0x38000000, 0x28000000, COUNT_CLASS= }, { " ldst reg", "ldstr", 0x3b200000, 0x38000000, COUNT_CLASS= }, { " Atomic ldst", "atomic", 0x3b200c00, 0x38200000, COUNT_CLASS= }, - { " ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS= }, + { " ldst reg (reg off)", "ldstro", 0x3b200b00, 0x38200800, COUNT_CLAS= S}, { " ldst reg (pac)", "ldstpa", 0x3b200200, 0x38200800, COUNT_CLASS= }, { " ldst reg (imm)", "ldsti", 0x3b000000, 0x39000000, COUNT_CLASS= }, { "Loads & Stores", "ldst", 0x0a000000, 0x08000000, COUNT_CLASS= }, @@ -202,7 +202,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) =20 counts =3D g_hash_table_get_values(insns); if (counts && g_list_next(counts)) { - g_string_append_printf(report,"Individual Instructions:\n"); + g_string_append_printf(report, "Individual Instructions:\n"); counts =3D g_list_sort(counts, cmp_exec_count); =20 for (i =3D 0; i < limit && g_list_next(counts); --=20 2.23.0 From nobody Tue May 21 12:09:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607483904; cv=none; d=zohomail.com; s=zohoarc; b=ejI3Ui1qwP5xHPlJpq/H4ka8soSZMVCiIG29XfCHsV190/y+4boIDdaM3lWaKHbzGUrnn5Ds6c7ZGFyZAcNvT5sXjq7Nke2vTpcIa8XWe+gIURL0Zps7JAqf9ljH4Snsa2VQmjSiqpSLPuKKARwKdeOSR/DShbCIgEe6fpWW9oU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607483904; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6fCh12kdodBm7K03w+8DVzQhhM81r7hXJJv75piL74E=; b=SIDWtQ/WtjaVFzgX0mx8LFbrsf9fKIYe2HX4+/G63dsAHoKywswO5LDv2SHz15kpwRuRrsGnCXqAx6/Oh3A/o+fHGB7Ob6j85cJmQnFThr78zOyQNstZd3gKqIlLuT4XisJ8jC5b8rpXY86pth1SCNJqJefvlZE/nRRalMrw+z8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607483904499401.4232091908599; Tue, 8 Dec 2020 19:18:24 -0800 (PST) Received: from localhost ([::1]:59200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmpzj-000223-F9 for importer@patchew.org; Tue, 08 Dec 2020 22:18:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpuF-0004e5-1P; Tue, 08 Dec 2020 22:12:43 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmpuD-0008Qn-Ap; Tue, 08 Dec 2020 22:12:42 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CrMXd38Zmzhp6R; Wed, 9 Dec 2020 11:12:01 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 9 Dec 2020 11:12:18 +0800 From: zhouyang To: Subject: [PATCH v2 5/5] contrib: Open brace '{' following struct go on the same line Date: Wed, 9 Dec 2020 11:04:47 +0800 Message-ID: <20201209030447.2135652-6-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201209030447.2135652-1-zhouyang789@huawei.com> References: <20201209030447.2135652-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=zhouyang789@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I found some style problems whil check the code using checkpatch.pl. This commit fixs the issue below: ERROR: that open brace { should be on the previous line Signed-off-by: zhouyang --- contrib/plugins/howvec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 9d6fa33297..600f7facc1 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -145,8 +145,7 @@ typedef struct { int table_sz; } ClassSelector; =20 -static ClassSelector class_tables[] =3D -{ +static ClassSelector class_tables[] =3D { { "aarch64", aarch64_insn_classes, ARRAY_SIZE(aarch64_insn_classes) }, { "sparc", sparc32_insn_classes, ARRAY_SIZE(sparc32_insn_classes) }, { "sparc64", sparc64_insn_classes, ARRAY_SIZE(sparc64_insn_classes) }, --=20 2.23.0