From nobody Tue Feb 10 05:10:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) client-ip=209.85.208.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607459865; cv=none; d=zohomail.com; s=zohoarc; b=H1+xkQljLC/gYqbVoZPyuAMqiP3PA9zSoSgsyGjG5r555JA4Vv+CNwQWb5IFNBoDgh3c6utvRkf3Bs2JxCiBUAM70UrxS4bzeqi1gQVMnyWDMhAUKC5+j8RFxK5OxlW6zFAF/X1kJVmMAd3vHfzOsur4EWFJqcWL3TpcedjDGKs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607459865; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5s+Pc76VS0giYYBfSeBqYRPzwDyC7ikS6JhKYOaNfSk=; b=JUTjgJFkmA0s2fRkGt14UzMGtQIij1IckkfZBtsaEUEnxpF1ZJ4fAAWDA7RfsPFdvNegH1kPprFauuJWqKdk4IVWaSYw8sOHQ5oSsGoEx8nGA8ELIFkqhMHWvTnSTkRyx709vdg0lOVeLqnj2J7Sk/6itqpSgrQ+hZpl2vLSvIo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by mx.zohomail.com with SMTPS id 1607459865087493.94533756637054; Tue, 8 Dec 2020 12:37:45 -0800 (PST) Received: by mail-ed1-f68.google.com with SMTP id c7so18976876edv.6 for ; Tue, 08 Dec 2020 12:37:44 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id x15sm17889483edj.91.2020.12.08.12.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 12:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5s+Pc76VS0giYYBfSeBqYRPzwDyC7ikS6JhKYOaNfSk=; b=gMSNM8+rP/wUen1Ewblxic202ImVW+lIq3zfHbQvRxm8HEKVxIgjht4/m9sWn/5p1M J6LhMeVw+f3yaf9Z0xOqeA1AVnvplBodNNMIK5d/Voa4JlFoyrAgySWE2YO5aKGpWMve 88kPhcOcT9WwocudpjqV9d4SUcWsp75naNdK2rHY9tcEFEgQdI8R4oUq3iw51SrZmTOD uCGd6e46uuR8P6Xut0muG3rpGaOcKxi1LMNyJ4g+CWH2n0uuOHjMcGTfRYdgBnJyA60d fY8dDH9lNtwx07y+SgGOTCnNaNzhx9ud+shI3MbR4S4EnFlMVGDFZ3nU50H8nwG92FG3 7e0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5s+Pc76VS0giYYBfSeBqYRPzwDyC7ikS6JhKYOaNfSk=; b=T6HUyQMxHlleKbMMLM1IkTRbbpod9xHZGLew8uPhAqweK2DoWENu7BScnICd40/A/V jEYCnDnWZMpvVkfBYAK+9ZqYgViaJxQo/PGCf3rFTGAOdrHkb2+JU8RulvSMLO15ArsK Arj0Yjd1css10xE4qPkrcTfjY8zCklIIa3LExDGgQpLfjuFEZq7LVidND8nFeNM6lAr5 lcpdqIlFoLYJTrAMeQKzwkluipQtl9C4OTEshlGUPDY5yZ5b0rruxtxlhbXjCCi0QmKX gIiODYVoEZG0Ew3IVPbN8GFNu7J1XvPcIxv12vO/lV0Oov8D8c8/sHcpv2SuCnpVj00j f+cA== X-Gm-Message-State: AOAM5311wVZId/Wvno2xtxz1KHmBugfcSVIZB/dP9ovxnpO9qyIZ0iT8 2CTn0co4GRFKc39Wn1KtEmg= X-Google-Smtp-Source: ABdhPJzbSylaj2ZjzVohbJDsLTirXN2tuFc4bOyEsBOPB0aij9iiPNZuBr8hCOdD8rXr6JF8NGa0Bw== X-Received: by 2002:a50:9310:: with SMTP id m16mr21869080eda.94.1607459863214; Tue, 08 Dec 2020 12:37:43 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH 07/13] target/mips: Convert Rel6 COP1X opcode to decodetree Date: Tue, 8 Dec 2020 21:36:58 +0100 Message-Id: <20201208203704.243704-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201208203704.243704-1-f4bug@amsat.org> References: <20201208203704.243704-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) COP1x opcode has been removed from the Release 6. Add a single decodetree entry for it, triggering Reserved Instruction if ever used. Remove unreachable check_insn_opc_removed() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/isa-mips32r6.decode | 2 ++ target/mips/translate.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mips/isa-mips32r6.decode b/target/mips/isa-mips32r6.dec= ode index 259bac612ab..7b12a1bff25 100644 --- a/target/mips/isa-mips32r6.decode +++ b/target/mips/isa-mips32r6.decode @@ -16,4 +16,6 @@ =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa =20 +REMOVED 010011 ----- ----- ----- ----- ------ # COP1X (COP3) + REMOVED 011100 ----- ----- ----- ----- ------ # SPECIAL2 diff --git a/target/mips/translate.c b/target/mips/translate.c index 788b5112a80..81ca1d45063 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28874,7 +28874,6 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) break; =20 case OPC_CP3: - check_insn_opc_removed(ctx, ISA_MIPS32R6); if (ctx->CP0_Config1 & (1 << CP0C1_FP)) { check_cp1_enabled(ctx); op1 =3D MASK_CP3(ctx->opcode); --=20 2.26.2