From nobody Tue Feb 10 11:23:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) client-ip=209.85.208.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607459859; cv=none; d=zohomail.com; s=zohoarc; b=QGAPXE7khDa5QSzVYx9AiYzVPEcpNKJLkT1GgJSEZuHuAdvplUt09cvzTpD2w4uCNH8W3RbFfBq3RYd5xYw+bCpQer2ZGYbV6w6dgFhRo4pxGZK2vPqnOMw6/FdYtK+aK1kko8hBGc7mkqbETQi5O1KJIfMaMd47Ic/3pnc+bHg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607459859; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U37hHuN0OpgX2w1oBuujDMHXNpPVE7yqxkafsImH4gs=; b=kHC9/3KYbSsRjrMAr/sS0SwjS2lCT5yYhyt/jWXoLMY4HJIynygG/UamNmwwxASvTyUU39gkeLPq5DmXSiatJOG0yaCGdRME42M9AULgfEC6qw9AEDnVTJmW7RAbRwOYh1wS9vn9PSY2a6Fqe8440eErlXEaNzhT0dvFMtcLB+w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by mx.zohomail.com with SMTPS id 160745985997092.89425537252998; Tue, 8 Dec 2020 12:37:39 -0800 (PST) Received: by mail-ed1-f66.google.com with SMTP id b2so18992241edm.3 for ; Tue, 08 Dec 2020 12:37:39 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id e14sm16214855ejh.62.2020.12.08.12.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 12:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U37hHuN0OpgX2w1oBuujDMHXNpPVE7yqxkafsImH4gs=; b=bj8lpzDv0pcFa4lwf8fzlPbDhwJKyLj0xnGCc7jaSURxAxkxSMGoJaZsaF1DSog2kP wP7i0U2GW5wYsCkpZO5GJuxmcKWv9k+Wff94WGTdmb3lIbEkYWaIn3SN26Zw44LCYwSl Aq6mGLf5wJ+jPoFzfM88tosSrnN01aAUPcccJGmU1D57pAdrGVo0WlDn16OP5v9uPD5/ N9CTADrrUp+Wvh82ZBzZdGGM+ekT+swU/lUA3Jnbsm6IitwGaboS/etx7AoGZza2zecV pxDB6vuFkNuh3Ucrkh0rM40zKLS/whxxxLHEk6MFAnS/PqWM/DGVhF9uOjvQlTUlkvap 94BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=U37hHuN0OpgX2w1oBuujDMHXNpPVE7yqxkafsImH4gs=; b=GM6cM3/0CYzbbB4Vx4LCX8HtCCjnmMWD2JzyRG1Ar9/IF+JrvfEFanRajhEwXEdWLf 8umJLa7RJWXQaDx5ni8z12q9aFuJtHSixKCgmXwOhloHb0sA99aFX7IpjgnmEiPZfaKX jM5H+CaQr4VIWtAF/v5FbTEJAjcoK2eowYZfaNWfL1oma1JAIDb8mx/buFd9yet6UT1v EdzEbv9ICCIVn0hJ8XhSpksJzUErUiMYtMz+3g+u7GJEFhei6aTbu+Ow75t8mvAd+D3n E3TyK6yMd0OGg/dWyisu6iY6yEMmRNRM2qzuz6THeUc8hR0Kuzqo6kwFyWyMlNtL2QiQ +WjQ== X-Gm-Message-State: AOAM531u86JjGTSEP/+CNADRVAGDl5MGrBjB8eY5sT7p3uERzcFxp2ot jg6DjlkQQ0TJcekTiWrAPLs= X-Google-Smtp-Source: ABdhPJwwoNYw4ioAbqKJDPkJgG+YPom9F2fhkkkIAYnZdftHC1g3W46Z+N1oeH2OVmx1EvPzuXUMeA== X-Received: by 2002:aa7:dacf:: with SMTP id x15mr25886606eds.134.1607459858089; Tue, 08 Dec 2020 12:37:38 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH 06/13] target/mips: Convert Rel6 Special2 opcode to decodetree Date: Tue, 8 Dec 2020 21:36:57 +0100 Message-Id: <20201208203704.243704-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201208203704.243704-1-f4bug@amsat.org> References: <20201208203704.243704-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Special2 opcode have been removed from the Release 6. Add a single decodetree entry for all the opcode class, triggering Reserved Instruction if ever used. Remove unreachable check_insn_opc_removed() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/isa-mips32r6.decode | 2 ++ target/mips/isa-mips_rel6_translate.c | 7 +++++++ target/mips/translate.c | 2 -- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/target/mips/isa-mips32r6.decode b/target/mips/isa-mips32r6.dec= ode index 027585ee042..259bac612ab 100644 --- a/target/mips/isa-mips32r6.decode +++ b/target/mips/isa-mips32r6.decode @@ -15,3 +15,5 @@ @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &lsa =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa + +REMOVED 011100 ----- ----- ----- ----- ------ # SPECIAL2 diff --git a/target/mips/isa-mips_rel6_translate.c b/target/mips/isa-mips_r= el6_translate.c index c77f3ed57e0..9ac906b1f33 100644 --- a/target/mips/isa-mips_rel6_translate.c +++ b/target/mips/isa-mips_rel6_translate.c @@ -20,6 +20,13 @@ #include "decode-isa-mips64r6.c.inc" #endif /* TARGET_MIPS64 */ =20 +bool trans_REMOVED(DisasContext *ctx, arg_REMOVED *a) +{ + gen_reserved_instruction(ctx); + + return true; +} + static bool trans_LSA(DisasContext *ctx, arg_LSA *a) { return gen_LSA(ctx, a->rd, a->rt, a->rs, a->sa); diff --git a/target/mips/translate.c b/target/mips/translate.c index 8f0a0a3830c..788b5112a80 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -27145,8 +27145,6 @@ static void decode_opc_special2_legacy(CPUMIPSState= *env, DisasContext *ctx) int rs, rt, rd; uint32_t op1; =20 - check_insn_opc_removed(ctx, ISA_MIPS32R6); - rs =3D (ctx->opcode >> 21) & 0x1f; rt =3D (ctx->opcode >> 16) & 0x1f; rd =3D (ctx->opcode >> 11) & 0x1f; --=20 2.26.2