From nobody Tue Feb 10 04:15:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.67 as permitted sender) client-ip=209.85.218.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607459854; cv=none; d=zohomail.com; s=zohoarc; b=CBaxhn+e2D7nWD5r8ajLODEclgv6udKjt1BwPctVSmDHUm+RFZCjrFVFo6ftjZIoKLklVF0bQoo++7yOhMrHO1+90E/zt6RxedcCMEaumyHMfHdHMnkaaDmA2mAdT1HOWRlcoQS+aa6Kar/AruuzMK2pYoTJ+9Y1eEdObK2rH9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607459854; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bGWb+orU5EBa5WEZB/m/zvIZ1UpmUYqQ14OUTga+crA=; b=Q6HcH7iVrUmIVvHjOXC+nVcmRXsYox0q6JKu14AqHjXnERznHFPF7yfw5Cl/UgF41qAMahaydRMWZbW5LMOqlL002uPUklcOj/Jf8nAsiVjIgy4JozsW+J72tFVt5VJI+QWLi/8bsFx+zN0gqxhhl1Okq0ZK9QJs/4F2oQzuJ5M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by mx.zohomail.com with SMTPS id 1607459854791887.8569075629819; Tue, 8 Dec 2020 12:37:34 -0800 (PST) Received: by mail-ej1-f67.google.com with SMTP id a16so26544321ejj.5 for ; Tue, 08 Dec 2020 12:37:34 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id ca4sm12286018edb.80.2020.12.08.12.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 12:37:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bGWb+orU5EBa5WEZB/m/zvIZ1UpmUYqQ14OUTga+crA=; b=Qu6VOzA09QIUgjgW9P4/iNjRYJVEeNG0bUFp7NQNMHiK/mgC+8lm+l5LpESjdlkRoy j1bZwLkledO56th/GZ4Mp2Uqfoaz9Al9p0lhoVC9gGNVJlh7CgTrKfjGc1bKZUsHF1cl 284t+hah105YFdg3/GaShnBel6z3Y+c4m0EAvs6Fnj/9pUOkEgkCbCl/n9+P/2+frtBB pGCfCWF8nrFNqypbqPH/bA1TalOmnmGUaXUFKymM9+sUO1M7cusfApVhd1GqBeqEt5O3 Z2SOwpfMXoms6JcIaMuAPl22IEurF5zUITx1QP2RNeuH/vFcCgX+NvG9kECVxm54yI2l 4EIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=bGWb+orU5EBa5WEZB/m/zvIZ1UpmUYqQ14OUTga+crA=; b=JHhrjJq3BJ4bEYD29D7rU9bpkL0d6QezQSxAbf24ErNq+nVmSF6swF/SoaPnVpMoGU 5252uL54m4v6qITagnPZMN/LHlRbB63JYscRci2bEgQWMAlbuBltsG4dXeHwFxv1XkGW EiuQHpZirWAcQI1ASp1PAuYez/u3EjS4GiXhYYDR4xbnqdbjaEhca+/mAGayeQLgVohq q/IbQ/roYAj+rYY2WZwaXkEg8TMCLy1RMR1afDXRHrqJeW4jJwye14/j4ncLp81j44E0 VIpDuIEt20cDQvLIq8Y8KItWelA6M3ZXpk6IqDfV8mR5kZSvGdiA4Om0F3iMoOsojhM1 ebsw== X-Gm-Message-State: AOAM532q7PyM+IQCgyPXSpbwGLJFWk1j8dzHYOlcXeWBai98Bgj9gFNH 3DkW3CLlrIHfAWYEOK0LvNs= X-Google-Smtp-Source: ABdhPJx3FPsI4+gFmgIxR0dwF20Q5lDR33asDcN+tv4OnbYrTeVIu79UYGD/zEINItcEA+OeU3lNsw== X-Received: by 2002:a17:906:6713:: with SMTP id a19mr25686980ejp.468.1607459853021; Tue, 08 Dec 2020 12:37:33 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH 05/13] target/mips: Remove now unreachable LSA/DLSA opcodes code Date: Tue, 8 Dec 2020 21:36:56 +0100 Message-Id: <20201208203704.243704-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201208203704.243704-1-f4bug@amsat.org> References: <20201208203704.243704-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Since we switched to decodetree-generated processing, we can remove this now unreachable code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/translate.c | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 9b333f97822..8f0a0a3830c 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -286,9 +286,6 @@ enum { R6_OPC_DCLZ =3D 0x12 | OPC_SPECIAL, R6_OPC_DCLO =3D 0x13 | OPC_SPECIAL, R6_OPC_SDBBP =3D 0x0e | OPC_SPECIAL, - - OPC_LSA =3D 0x05 | OPC_SPECIAL, - OPC_DLSA =3D 0x15 | OPC_SPECIAL, }; =20 /* Multiplication variants of the vr54xx. */ @@ -24327,9 +24324,6 @@ static void decode_opc_special_r6(CPUMIPSState *env= , DisasContext *ctx) =20 op1 =3D MASK_SPECIAL(ctx->opcode); switch (op1) { - case OPC_LSA: - gen_LSA(ctx, rd, rs, rt, extract32(ctx->opcode, 6, 2)); - break; case OPC_MULT: case OPC_MULTU: case OPC_DIV: @@ -24380,10 +24374,6 @@ static void decode_opc_special_r6(CPUMIPSState *en= v, DisasContext *ctx) } break; #if defined(TARGET_MIPS64) - case OPC_DLSA: - check_mips_64(ctx); - gen_DLSA(ctx, rd, rs, rt, extract32(ctx->opcode, 6, 2)); - break; case R6_OPC_DCLO: case R6_OPC_DCLZ: if (rt =3D=3D 0 && sa =3D=3D 1) { @@ -24645,18 +24635,14 @@ static void decode_opc_special(CPUMIPSState *env,= DisasContext *ctx) check_insn(ctx, ISA_MIPS2); gen_trap(ctx, op1, rs, rt, -1); break; - case OPC_LSA: /* OPC_PMON */ - if ((ctx->insn_flags & ISA_MIPS32R6) || ase_msa_available(env)) { - decode_opc_special_r6(env, ctx); - } else { - /* Pmon entry point, also R4010 selsl */ + case OPC_PMON: + /* Pmon entry point, also R4010 selsl */ #ifdef MIPS_STRICT_STANDARD - MIPS_INVAL("PMON / selsl"); - generate_exception_end(ctx, EXCP_RI); + MIPS_INVAL("PMON / selsl"); + generate_exception_end(ctx, EXCP_RI); #else - gen_helper_0e0i(pmon, sa); + gen_helper_0e0i(pmon, sa); #endif - } break; case OPC_SYSCALL: generate_exception_end(ctx, EXCP_SYSCALL); @@ -24747,11 +24733,6 @@ static void decode_opc_special(CPUMIPSState *env, = DisasContext *ctx) break; } break; - case OPC_DLSA: - if ((ctx->insn_flags & ISA_MIPS32R6) || ase_msa_available(env)) { - decode_opc_special_r6(env, ctx); - } - break; #endif default: if (ctx->insn_flags & ISA_MIPS32R6) { --=20 2.26.2