From nobody Tue Feb 10 15:46:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.67 as permitted sender) client-ip=209.85.208.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607459896; cv=none; d=zohomail.com; s=zohoarc; b=T0r7R6F+aWMSQ5yLxwBYYtARSDL7+9TL1Etrc+U0ynmIqNJIQwNX+k/JKhwU/51fprOc6TqJKmWHTYfj/F5CBVS24SQxjpOrIWKwtkqSqcXzc2eK0A6tArZAZHIy8CI3Wqlb3xBESI6Qq7cnaLg820e9VrzgDSDUR54Dld0y8kE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607459896; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uGmxq2xzRtTYRUJyvWqJtHGIaXfE5t1ze+OMIppltBo=; b=P28tfo3VwE22DTK50wTiN8KhzVnECl2N0wAplKRiEyMFCh505b6xyG9A6gxMS5MGFYiROzLrW+gnaLcuZoMxB/6W/GSU/sDqZy/k/C3FzgJrRBb2Om1tR+OQAef94D6rzUEOUZZWItX8dA3lunKixhGaM8A2lbprcyINZNqXbco= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by mx.zohomail.com with SMTPS id 16074598960949.008105727714224; Tue, 8 Dec 2020 12:38:16 -0800 (PST) Received: by mail-ed1-f67.google.com with SMTP id h16so7676117edt.7 for ; Tue, 08 Dec 2020 12:38:15 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id x6sm344411edl.67.2020.12.08.12.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 12:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uGmxq2xzRtTYRUJyvWqJtHGIaXfE5t1ze+OMIppltBo=; b=QelRjUSJV+xeneYtpREupdVGxwtYfBA/LFwifkTUNVBHNFI0LsEbD06qHdgM+lWTsw +Qf4RbfFCF5DJcyLy3E6di5s9aEXqKtSIBCU6Piix6451ixUlm1Yo/hTS4e8U329xpTS 5jvhkKAPBdQTC/K6NCjb33AVdlzDSHWtjl6zmiS5kqExkxGkXY5JCPfSvPdwPFmkR2CD oUu5+nJQqSamggxDKhSlWQJBnwxQkcpRzS042MzqIuASWqfpoo1XQ8SEAaPeKSvM0uLK sPgo2SF9jsMy4z9xQnN0P0ixJ48gDiQi1jAquJ6Pu52tc/8uA5SpsYvpI8lhAlwy5OKv md/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=uGmxq2xzRtTYRUJyvWqJtHGIaXfE5t1ze+OMIppltBo=; b=dxhTskCyWqO/EuPDIqww3zfgb2KtynXUPHb5D1aEua87lSXMZq49rh3xIfGuBzmQh6 qdJU4SEpDOJF1evwrqOTelXxbYwOVffpeddRFWG2W3R592On+i0OnjCpmjA3XV7f4r3X epFSo7MhYf3n9LvkTklmLtV8LOVVHeeoAp1oqAr30b4aBR00TV8L0yKw/jWjjsP7lk2q ndk/RZYzonzY/HT5XGlKK/4waM3AdUO58ezdqS/QsMnzHVI9OnejJaL2pFW+IQ8muTJu TxTwBiqEGnEnB0+g7Msqq/W33EMdq5k/unGerqHEHq8hgM7YPhR/0ol1syZKEPKHfsD4 ChGg== X-Gm-Message-State: AOAM531Xg7bcfgJEoq1KG2+gY0+zBlqaBvZbAiRbR9JJSaNo0iUJPHe0 4cTazxzMh4cX6Bkq9zHhWeY= X-Google-Smtp-Source: ABdhPJx70D7BRNckR2uVvsAKvVCnqMqmQrZDYnko37NiuV3II0GXFmpbf7YX3krNjgke3EOycN897Q== X-Received: by 2002:a50:e0c9:: with SMTP id j9mr26153237edl.380.1607459894258; Tue, 08 Dec 2020 12:38:14 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH 13/13] target/mips: Convert Rel6 LL/SC opcodes to decodetree Date: Tue, 8 Dec 2020 21:37:04 +0100 Message-Id: <20201208203704.243704-14-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201208203704.243704-1-f4bug@amsat.org> References: <20201208203704.243704-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) LL/SC opcodes have been removed from the Release 6. Add a single decodetree entry for the opcodes, triggering Reserved Instruction if ever used. Remove unreachable check_insn_opc_removed() calls. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/isa-mips32r6.decode | 2 ++ target/mips/translate.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/isa-mips32r6.decode b/target/mips/isa-mips32r6.dec= ode index 3ec50704cf2..489c20aa4e9 100644 --- a/target/mips/isa-mips32r6.decode +++ b/target/mips/isa-mips32r6.decode @@ -31,4 +31,6 @@ REMOVED 101010 ----- ----- ---------------- = # SWL REMOVED 101110 ----- ----- ---------------- # SWR =20 REMOVED 101111 ----- ----- ---------------- # CACHE +REMOVED 110000 ----- ----- ---------------- # LL REMOVED 110011 ----- ----- ---------------- # PREF +REMOVED 111000 ----- ----- ---------------- # SC diff --git a/target/mips/translate.c b/target/mips/translate.c index 009301c9ceb..90a6dfcd2b3 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28632,7 +28632,6 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); } - check_insn_opc_removed(ctx, ISA_MIPS32R6); /* Fallthrough */ case OPC_LWL: case OPC_LWR: @@ -28653,7 +28652,6 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) break; case OPC_SC: check_insn(ctx, ISA_MIPS2); - check_insn_opc_removed(ctx, ISA_MIPS32R6); if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); } --=20 2.26.2