From nobody Tue Feb 10 15:46:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.65 as permitted sender) client-ip=209.85.218.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607459885; cv=none; d=zohomail.com; s=zohoarc; b=UwNTA8FDnZuACcfnotUsNfBNpfHRoSYWDBuyFzXh/6GFYpz99yT8qP9yArUUY4jLz6q5UK4DnlLdLq1tLSI/oE6xbSGApMR9haEBFV1vwXJhOLh/saZtI+LirRHUXh3taThjF1fk9xhKDtPmVdOVAjHXr51Samuf/3gkJ8v1AEw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607459885; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1k4PcQljQCh2DE9iUcnW2jkPRc+bb/o9XTSTkfgV9ik=; b=RwO8MvaTRcbA/Hlmtxgn60fbT567V4Vi5rlNmLSWHRDGo3Qnj+4VUJDMIU9WNEIDwJ1bjH1yzN/wpMfPU6lR9ceyqkqus4YE4buKUnc+Khj1N6Akn2hou72o9JfKFRSmgyWAcDhihrXbZmsA9frg62MuRSAnCBXG2bcqwXoDeIo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by mx.zohomail.com with SMTPS id 1607459885836360.98875972340704; Tue, 8 Dec 2020 12:38:05 -0800 (PST) Received: by mail-ej1-f65.google.com with SMTP id a16so26546420ejj.5 for ; Tue, 08 Dec 2020 12:38:05 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id u3sm16446589eje.33.2020.12.08.12.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 12:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1k4PcQljQCh2DE9iUcnW2jkPRc+bb/o9XTSTkfgV9ik=; b=rEe0j+mHascWJHV81ahNxSrjSaOo6r9HobqLDIZBML7I5TDdk4mgV2vfZ5hCaPlaBm TEb9rmXcOQBO/fk+L9ig9C45geG4DCCLhz50J3jYNo7WAgA6iofFBhuTOKbE5g9gxq9f svGgODT7RsJly7e5VGAgOwTf/aJHDVT6uZC+JczzeiBfGN8DCCN7ll2l9bfcRcaTwwRa k3VvqUyOEvgp10TmjSGYZcNpVxaOfbBfs02VIEvEjRqqp1Qjc/CwiJRq8kEPUrGvarOb o15o6LtEynlHnuFEiG6/GLanB0chD+c+yX7Obng7AI5ppAauB0/6kNTBXvAEEest21Ql sSZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1k4PcQljQCh2DE9iUcnW2jkPRc+bb/o9XTSTkfgV9ik=; b=WRxEswIiJhYjYCpXJYW2qSlkheYLLWvvrWdGnpHveEmKFuxAsC6Bl9c9Ta/b/QNMvj yX8KDBjshQwwd14gYnha6C45ruHQPdP4mQYjjJKO313psTwIHfNJzNKigalXn0y6gCrE qGADKn1+QFc1yRhSErVvnZrH4yXNuYDw/FzmUWGoINHFTI1cGazxoVsjOxDcQ6MDwuEB 2EVxEmPOvyun6Jlgq/pyyS9KdYXv4bsIUnih6spPbox5tVCttDfjA0fXWO64nAlCfyOt UJjPwijrvomMCoruW09+eSrt/FBU6miezYRlIx4XVDxaWLKpI1RFZCORvC6l3QycNNzS 3Lgg== X-Gm-Message-State: AOAM532ZUFwiBzjCH+06NAqctVjbeZYapTZei23yxDLxRs8OO9/bEVCL aku4CwMyrqFbVOGvwCgjHok= X-Google-Smtp-Source: ABdhPJzBcXz9ip5vjQq810uRM8Fo20Voc4grUCoOG7daHdBkjI2IUBCV5LLaIp2lZMzFqAKQmvpVVg== X-Received: by 2002:a17:906:b306:: with SMTP id n6mr24140705ejz.473.1607459883998; Tue, 08 Dec 2020 12:38:03 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH 11/13] target/mips: Convert Rel6 LDL/LDR/SDL/SDR opcodes to decodetree Date: Tue, 8 Dec 2020 21:37:02 +0100 Message-Id: <20201208203704.243704-12-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201208203704.243704-1-f4bug@amsat.org> References: <20201208203704.243704-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) LDL/LDR/SDL/SDR opcodes have been removed from the Release 6. Add a single decodetree entry for the opcodes, triggering Reserved Instruction if ever used. Remove unreachable check_insn_opc_removed() calls. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/isa-mips64r6.decode | 6 ++++++ target/mips/translate.c | 5 +---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/target/mips/isa-mips64r6.decode b/target/mips/isa-mips64r6.dec= ode index e812224341e..8c3fc5dae9c 100644 --- a/target/mips/isa-mips64r6.decode +++ b/target/mips/isa-mips64r6.decode @@ -10,8 +10,14 @@ # (Document Number: MD00087-2B-MIPS64BIS-AFP-6.06) # =20 +&REMOVED !extern &lsa rd rt rs sa !extern =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &lsa =20 DLSA 000000 ..... ..... ..... 000 .. 010101 @lsa + +REMOVED 011010 ----- ----- ---------------- # LDL +REMOVED 011011 ----- ----- ---------------- # LDR +REMOVED 101100 ----- ----- ---------------- # SDL +REMOVED 101101 ----- ----- ---------------- # SDR diff --git a/target/mips/translate.c b/target/mips/translate.c index 962522b0e02..aeba8efeb17 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28918,11 +28918,10 @@ static void decode_opc(CPUMIPSState *env, DisasCo= ntext *ctx) if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); } + check_insn_opc_removed(ctx, ISA_MIPS32R6); /* fall through */ case OPC_LDL: case OPC_LDR: - check_insn_opc_removed(ctx, ISA_MIPS32R6); - /* fall through */ case OPC_LWU: case OPC_LD: check_insn(ctx, ISA_MIPS3); @@ -28931,8 +28930,6 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) break; case OPC_SDL: case OPC_SDR: - check_insn_opc_removed(ctx, ISA_MIPS32R6); - /* fall through */ case OPC_SD: check_insn(ctx, ISA_MIPS3); check_mips_64(ctx); --=20 2.26.2