From nobody Mon Feb 9 01:19:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607459392; cv=none; d=zohomail.com; s=zohoarc; b=Gv57a7OW9EP06uWIGjldFkKTe3XsLT7F6HrP8B7s7IHMRD13Ablwge0MYBgrtAcRSRIAxPoFKTqIZWwkQFy6OhUhr1zPThvXp/SJusYkNSlzIhjzvoorF5LbbskoXdzW8eVzNwr12+7Z7P+CxBfVR7SrnjSuxAMygbw3RCJwtO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607459392; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5Ad7MPrUrEPsjPnzQmDTkeEewqARoHTT0yNjTvWPD84=; b=bvGKOVZJji7dpU7YNHc7ImDRT6hQa9UyvbDgxQV0ik77ztcdUJsAnmjrsewy5SIl8dcSZgiLAzaJQeli7f+ANB99U329DCE4jb8IVBB8woxx/YmG74TsJqJsy/9zsAZPFcaoNQ+fMjnw8Yy2PK8qJmsaJnwfQPrgaKAIIYBgY4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607459392391203.99375869006076; Tue, 8 Dec 2020 12:29:52 -0800 (PST) Received: from localhost ([::1]:54988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmjcN-0004ax-8x for importer@patchew.org; Tue, 08 Dec 2020 15:29:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmimM-0006kQ-UK for qemu-devel@nongnu.org; Tue, 08 Dec 2020 14:36:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmimL-0005WN-3w for qemu-devel@nongnu.org; Tue, 08 Dec 2020 14:36:06 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-E9IpRlAvOBKYGLjSNUU4Ew-1; Tue, 08 Dec 2020 14:36:01 -0500 Received: by mail-wm1-f72.google.com with SMTP id h68so1278736wme.5 for ; Tue, 08 Dec 2020 11:36:01 -0800 (PST) Received: from redhat.com (bzq-79-176-44-197.red.bezeqint.net. [79.176.44.197]) by smtp.gmail.com with ESMTPSA id u6sm1396239wrm.90.2020.12.08.11.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 11:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607456164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5Ad7MPrUrEPsjPnzQmDTkeEewqARoHTT0yNjTvWPD84=; b=bc5jBCaKWVKlVeg2ytfkzqe0pGD8d5X3qrew9iY9sBmSPKTwkT6I75udJmHMiIMCSzDhKM U/DLNvx5p2gkmLhMRsi4AfHonFJ740L0Cwjlk5+gztJ7ODhGve+HT5w9798e5yIx3rg98D kiQd3rLOKAa8abmsdqUl2YgJ0XnJnZw= X-MC-Unique: E9IpRlAvOBKYGLjSNUU4Ew-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5Ad7MPrUrEPsjPnzQmDTkeEewqARoHTT0yNjTvWPD84=; b=OeaXRbq6wGGOD6CNmlfKzrEWBRrWaSgdmNdcq6wRLh46Mk4IhxxUkLgmm3bT4xH6Rm Dh6TJaHAHZST0+O2+lmlK5Ksc2Zd2AdniU+POmca7tH4qF0eZt+SgBrknp5SN4ij96Qv om8ZPaJXb/dE7Ipl/kcykSRVq/r2XOQHO2hvBqNk+zqW1Jy6HjeK7mc051bJTcNTNqDS uR8YjIq9cV68LiBF0BBRWYJ4r3pIY0yFt9NMtepTj7u3ywVvczxvd2bJL0/JfDdcRWvG sgATzf3Rybw/PXRBSnL1jrSComoPliEbGgAyciIx2gWqBV6WfpgkGHBgIbhfZcT+/wxE 92Qg== X-Gm-Message-State: AOAM531tluS0pzmkMAX6SGYnUOV0SrbFwIwoHdxSOxoEghBoMcm+dpxI i/d8+eeGkvvcUYBqfDeyL9V9xuiIMXM9D1lGRJWQqyth6umnjRSM9LjHH7lhD+DmBLCcJ/pZjTv CsFI0UVInWjmuYh+LO0itVucWugbj9DHhdDO1ma1JVqSzGDPZZDID3I4lJEPC X-Received: by 2002:a7b:c205:: with SMTP id x5mr5399514wmi.115.1607456160175; Tue, 08 Dec 2020 11:36:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKtE5DpD/7mqu6kt05nq1SJ263fBOj9HcjNwrPMi1QtTk23C6qcKPdbzqDY7mhdrnZbzdSWg== X-Received: by 2002:a7b:c205:: with SMTP id x5mr5399498wmi.115.1607456159955; Tue, 08 Dec 2020 11:35:59 -0800 (PST) Date: Tue, 8 Dec 2020 14:35:55 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL 40/66] failover: Caller of this two functions already have primary_dev Message-ID: <20201208193307.646726-41-mst@redhat.com> References: <20201208193307.646726-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201208193307.646726-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Juan Quintela Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Juan Quintela Pass it as an argument. Signed-off-by: Juan Quintela Message-Id: <20201118083748.1328-26-quintela@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 746ed3fb71..b37e9cd1d9 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3093,17 +3093,17 @@ void virtio_net_set_netclient_name(VirtIONet *n, co= nst char *name, n->netclient_type =3D g_strdup(type); } =20 -static bool failover_unplug_primary(VirtIONet *n) +static bool failover_unplug_primary(VirtIONet *n, DeviceState *dev) { HotplugHandler *hotplug_ctrl; PCIDevice *pci_dev; Error *err =3D NULL; =20 - hotplug_ctrl =3D qdev_get_hotplug_handler(n->primary_dev); + hotplug_ctrl =3D qdev_get_hotplug_handler(dev); if (hotplug_ctrl) { - pci_dev =3D PCI_DEVICE(n->primary_dev); + pci_dev =3D PCI_DEVICE(dev); pci_dev->partially_hotplugged =3D true; - hotplug_handler_unplug_request(hotplug_ctrl, n->primary_dev, &err); + hotplug_handler_unplug_request(hotplug_ctrl, dev, &err); if (err) { error_report_err(err); return false; @@ -3114,30 +3114,31 @@ static bool failover_unplug_primary(VirtIONet *n) return true; } =20 -static bool failover_replug_primary(VirtIONet *n, Error **errp) +static bool failover_replug_primary(VirtIONet *n, DeviceState *dev, + Error **errp) { Error *err =3D NULL; HotplugHandler *hotplug_ctrl; - PCIDevice *pdev =3D PCI_DEVICE(n->primary_dev); + PCIDevice *pdev =3D PCI_DEVICE(dev); BusState *primary_bus; =20 if (!pdev->partially_hotplugged) { return true; } - primary_bus =3D n->primary_dev->parent_bus; + primary_bus =3D dev->parent_bus; if (!primary_bus) { error_setg(errp, "virtio_net: couldn't find primary bus"); return false; } - qdev_set_parent_bus(n->primary_dev, primary_bus, &error_abort); + qdev_set_parent_bus(dev, primary_bus, &error_abort); qatomic_set(&n->failover_primary_hidden, false); - hotplug_ctrl =3D qdev_get_hotplug_handler(n->primary_dev); + hotplug_ctrl =3D qdev_get_hotplug_handler(dev); if (hotplug_ctrl) { - hotplug_handler_pre_plug(hotplug_ctrl, n->primary_dev, &err); + hotplug_handler_pre_plug(hotplug_ctrl, dev, &err); if (err) { goto out; } - hotplug_handler_plug(hotplug_ctrl, n->primary_dev, &err); + hotplug_handler_plug(hotplug_ctrl, dev, &err); } =20 out: @@ -3161,7 +3162,7 @@ static void virtio_net_handle_migration_primary(VirtI= ONet *n, } =20 if (migration_in_setup(s) && !should_be_hidden) { - if (failover_unplug_primary(n)) { + if (failover_unplug_primary(n, n->primary_dev)) { vmstate_unregister(VMSTATE_IF(n->primary_dev), qdev_get_vmsd(n->primary_dev), n->primary_dev); @@ -3172,7 +3173,7 @@ static void virtio_net_handle_migration_primary(VirtI= ONet *n, } } else if (migration_has_failed(s)) { /* We already unplugged the device let's plug it back */ - if (!failover_replug_primary(n, &err)) { + if (!failover_replug_primary(n, n->primary_dev, &err)) { if (err) { error_report_err(err); } --=20 MST