From nobody Tue Feb 10 15:46:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) client-ip=209.85.208.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607387837; cv=none; d=zohomail.com; s=zohoarc; b=R6DbrcjfhQ2RFVBlIhiGvbct56FzEa8aiJQNDkt7sXimzHzhnwIUKZH8iNDvHXAcpe03Gwhor44bmiuZv3HJS3/0J20/lMGX1Z2YvbaU6YuA9GD31IFN20EKFzxZr9fxik636lB4SipEO/CsXkS1cwGPumfoIObuwizSCMtP3UU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607387837; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cBcAqpVeWvYa5kT7ybzBYVgh68psdEjYqVlt8VyNVPI=; b=hoa355/2dYE2nt56qQM+fEUjAqUCQ3tE77i+b/25KWG9gYZBz10yu1/JeVQjzfvTAEdXb1NR8qhz8WL8TrTagrs6LPIP8yuWe3eOq6i5uSM0WzOv26QMY54SQeuf/5qc7wxsrCqjHGD9KkTeEo+SHsr6SAhg9sUxn44+XwTYnI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by mx.zohomail.com with SMTPS id 1607387837950214.21772200510566; Mon, 7 Dec 2020 16:37:17 -0800 (PST) Received: by mail-ed1-f66.google.com with SMTP id cw27so15767307edb.5 for ; Mon, 07 Dec 2020 16:37:17 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id c5sm15390194edm.35.2020.12.07.16.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 16:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cBcAqpVeWvYa5kT7ybzBYVgh68psdEjYqVlt8VyNVPI=; b=EF+mKy3oCXc7rxnqO3XKMyE5cT6yoc49bbljauyDu8Z4h4SwLe3V+8SOQCrOGhM34b OY1WUXROwPnpHjU5K+jvVZEEK3nuKQeMJgUnE/b+cMiD0JaKD68B0XSYqn1vCtaKv059 FKEWGFrVf5rbcdQ0WMCtJt6dtSQXd4rRTdjpg/DqjKi8d1qlXLJ4z1oqIIQoV8fg8+Bg W0uaSc11640bqgGyejQegNrJ3M8Lg/twsTuSmtKA+VI/mgd0eDPA2UzTyhsJ1f/0nOiG NR6vJJKDBeHqXG1iDQXftECja90SlFss0TsGl3GkCc7FyPipxp/aiDgm0p5pPytrzTvY 5jCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cBcAqpVeWvYa5kT7ybzBYVgh68psdEjYqVlt8VyNVPI=; b=D6nEtQywZdeOixMUiWvqy5FwR3Rc0pOl/Sql+kMYnJQPv4Lckm6labvrAxDkjbQnM7 z4oNBLgCLw5ShsBvgacnkSs/C34BqhU4KQSQj6b/WhmMXBR4ngrh5hhm85fuKQOy3tFD 3JSDRIDIoOpM3xajijmjI6bCk9RWno2lB39r7KrGVKUnrUHOBzp0rozcw/Bhg9pW9g20 o4FHJ5CXMtrANS+nmK99wh+9krBDfBLw67djXjGbJf8HFaR7NPNlsVhgwKkX8Kv8hVXe EqClvrTy5cYpfEQDQGExQqKH7yamk0EckpkbHnV0w0ppRrtQHfHE+CNW7z4MBJMmHd1n ROig== X-Gm-Message-State: AOAM533FWyjWn+PWVE5vWV0molpa4ovwt34I6lKtHTssbI6paG8OskNd YcNKq8qs4EZsDzUv8OOtZ8g= X-Google-Smtp-Source: ABdhPJwYUp7Xv29jcHxIdBN4YcvGvOJHHFZ1ZiLF9SaK7CNzI6qtsm7cRuqA13vmJvwaMSH62iP6GA== X-Received: by 2002:aa7:c749:: with SMTP id c9mr18694617eds.3.1607387835615; Mon, 07 Dec 2020 16:37:15 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, Richard Henderson , Aurelien Jarno , Huacai Chen , Jiaxun Yang Subject: [PATCH 02/17] target/mips: Simplify msa_reset() Date: Tue, 8 Dec 2020 01:36:47 +0100 Message-Id: <20201208003702.4088927-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201208003702.4088927-1-f4bug@amsat.org> References: <20201208003702.4088927-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Call msa_reset() unconditionally, but only reset the MSA registers if MSA is implemented. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 5 +---- target/mips/translate_init.c.inc | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index cb822e52c4b..b20cf1b52d9 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -31876,10 +31876,7 @@ void cpu_state_reset(CPUMIPSState *env) env->hflags |=3D MIPS_HFLAG_M16; } =20 - /* MSA */ - if (ase_msa_available(env)) { - msa_reset(env); - } + msa_reset(env); =20 compute_hflags(env); restore_fp_status(env); diff --git a/target/mips/translate_init.c.inc b/target/mips/translate_init.= c.inc index cac3d241831..3c9ec7e940a 100644 --- a/target/mips/translate_init.c.inc +++ b/target/mips/translate_init.c.inc @@ -1024,6 +1024,10 @@ static void mvp_init(CPUMIPSState *env) =20 static void msa_reset(CPUMIPSState *env) { + if (!ase_msa_available(env)) { + return; + } + #ifdef CONFIG_USER_ONLY /* MSA access enabled */ env->CP0_Config5 |=3D 1 << CP0C5_MSAEn; --=20 2.26.2