From nobody Tue Feb 10 01:34:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) client-ip=209.85.208.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607387874; cv=none; d=zohomail.com; s=zohoarc; b=U/2vDpDQWZ6LbB9z6IiZXBcdSvhe05w9EoMq497Sbt0cAQ+H9o81OtE7GG1mhNdG6FIPCZhiahznZKI3IJiTDpsgGfptgdJHY2xIknkfHEw9iIKG9uH4nz9QSREMBWRmp1Cv6+8ZhihCUyDoQPkTOFSBg4ls+uD1bbPzKeecAbg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607387874; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gl3oMtrsjL7vz0QKd+8xonphrNOt4bBvJxiMSG7akXM=; b=hRNyMQ2z8n5gVD3zgD9H2Zkf4clWAXeuXw6mQZQCtMbWksIIPfsYN2DE3FckwmdcZD9JYyEfe+2adYckzc7jvYImgQYe7uL9wq9NwJ6EhFXwQeoqPLDVtfBPK5hKVgxDC28Ehbrqt7lcPLjqmDgCujWwxkZqpQjjD2Ll8iDCd1U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by mx.zohomail.com with SMTPS id 1607387874237721.384815022742; Mon, 7 Dec 2020 16:37:54 -0800 (PST) Received: by mail-ed1-f68.google.com with SMTP id dk8so12891493edb.1 for ; Mon, 07 Dec 2020 16:37:53 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id x15sm15115763edj.91.2020.12.07.16.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 16:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gl3oMtrsjL7vz0QKd+8xonphrNOt4bBvJxiMSG7akXM=; b=TboVAIByVJ0GTYoCjsgx5sycGwMrDlzcODXfxx1jMXGpIEg7kX1aPCXixeLGMNqjaR puKTh4wbzUu/gqFvY/4rcxYBjySKkPB0MGqZwlvXfxZnVGftqffvLmN7w/SfZVbdZ23R DOxLb+qCErNCmK9sqvX/A7G0rvAqHt7M0W4MVaa38YZQ/SxKtS1fHS16h2VAMSNCNY31 DISAu86VbeTJ43Y8lHB1f9AAFf484N1mo04dEbdE6bXg8ZgveyUX1ydm7etkp4JAhnVq hOpGSVLSk08rDviDLLixC6eZ1kzzB6+U0t8G60DvfOMAUJTXN6RFgbwPbs1qkjJe7IHl 00lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gl3oMtrsjL7vz0QKd+8xonphrNOt4bBvJxiMSG7akXM=; b=JnsexI0SkezzkwXFOTzegTExI/c3EYEqBoTE9wBq9vvLrasnrBoQwl7rc/Ik6agsve SQHNGS916FkHBm2j8qppXDczQS4Sg02jPjN2TcRXimnop8x8X6BvmbPQi/GYoX70UQ9h OGDzd8JSagjVVJIgfLDN5FtPdE6EzEfYTRtCVYuqvvcDUHLMqosnOr1pzp5chEDIhlgd nwzFONTvoft+wSPS/9m+qYBg7V2J85XkMV3OMLGiyG5IH4I6joUFpfcPo62qULY2+uVm 0Gzj6+LR10JDwvhqUe3B/HV+TAtSjLbb5PBJE7qggYGoeZM5hxEl61b1p4oEMHNafnWf PwBQ== X-Gm-Message-State: AOAM533dbOKdGWwlz1SF3e1f6EAkAlrxE0okgncfxsUNUejR6E0RkM48 vg49/tsXiB3zRvIv5OBU/fo= X-Google-Smtp-Source: ABdhPJwM6x9jMd5CtJnJOHif2O47Du+oSBsYQ3wmjaIQ/FnVd6OQJzrokqJhB1bpwUJff2IimmxMqw== X-Received: by 2002:a05:6402:411:: with SMTP id q17mr22633700edv.125.1607387872222; Mon, 07 Dec 2020 16:37:52 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, Richard Henderson , Aurelien Jarno , Huacai Chen , Jiaxun Yang Subject: [PATCH 09/17] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ() Date: Tue, 8 Dec 2020 01:36:54 +0100 Message-Id: <20201208003702.4088927-10-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201208003702.4088927-1-f4bug@amsat.org> References: <20201208003702.4088927-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) In preparation of using the decodetree script, explode gen_msa_branch() as following: - OPC_BZ_V -> BxZ_V(EQ) - OPC_BNZ_V -> BxZ_V(NE) - OPC_BZ_[BHWD] -> BxZ(false) - OPC_BNZ_[BHWD] -> BxZ(true) Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 71 ++++++++++++++++++++++++++++------------- 1 file changed, 49 insertions(+), 22 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 5ed7072f275..8b1019506fe 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28623,49 +28623,76 @@ static void gen_check_zero_element(TCGv tresult, = uint8_t df, uint8_t wt) tcg_temp_free_i64(t1); } =20 +static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, int s16, TCGCond cond) +{ + TCGv_i64 t0; + + check_msa_access(ctx); + + if (ctx->hflags & MIPS_HFLAG_BMASK) { + generate_exception_end(ctx, EXCP_RI); + return true; + } + t0 =3D tcg_temp_new_i64(); + tcg_gen_or_i64(t0, msa_wr_d[wt << 1], msa_wr_d[(wt << 1) + 1]); + tcg_gen_setcondi_i64(cond, t0, t0, 0); + tcg_gen_trunc_i64_tl(bcond, t0); + tcg_temp_free_i64(t0); + + ctx->btarget =3D ctx->base.pc_next + (s16 << 2) + 4; + + ctx->hflags |=3D MIPS_HFLAG_BC; + ctx->hflags |=3D MIPS_HFLAG_BDS32; + + return true; +} + +static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool i= f_not) +{ + check_msa_access(ctx); + + if (ctx->hflags & MIPS_HFLAG_BMASK) { + generate_exception_end(ctx, EXCP_RI); + return true; + } + + gen_check_zero_element(bcond, df, wt); + if (if_not) { + tcg_gen_setcondi_tl(TCG_COND_EQ, bcond, bcond, 0); + } + + ctx->btarget =3D ctx->base.pc_next + (s16 << 2) + 4; + ctx->hflags |=3D MIPS_HFLAG_BC; + ctx->hflags |=3D MIPS_HFLAG_BDS32; + + return true; +} + static void gen_msa_branch(DisasContext *ctx, uint32_t op1) { uint8_t df =3D (ctx->opcode >> 21) & 0x3; uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; int64_t s16 =3D (int16_t)ctx->opcode; =20 - check_msa_access(ctx); - - if (ctx->hflags & MIPS_HFLAG_BMASK) { - generate_exception_end(ctx, EXCP_RI); - return; - } switch (op1) { case OPC_BZ_V: case OPC_BNZ_V: - { - TCGv_i64 t0 =3D tcg_temp_new_i64(); - tcg_gen_or_i64(t0, msa_wr_d[wt << 1], msa_wr_d[(wt << 1) + 1]); - tcg_gen_setcondi_i64((op1 =3D=3D OPC_BZ_V) ? - TCG_COND_EQ : TCG_COND_NE, t0, t0, 0); - tcg_gen_trunc_i64_tl(bcond, t0); - tcg_temp_free_i64(t0); - } + gen_msa_BxZ_V(ctx, wt, s16, (op1 =3D=3D OPC_BZ_V) ? + TCG_COND_EQ : TCG_COND_NE); break; case OPC_BZ_B: case OPC_BZ_H: case OPC_BZ_W: case OPC_BZ_D: - gen_check_zero_element(bcond, df, wt); + gen_msa_BxZ(ctx, df, wt, s16, false); break; case OPC_BNZ_B: case OPC_BNZ_H: case OPC_BNZ_W: case OPC_BNZ_D: - gen_check_zero_element(bcond, df, wt); - tcg_gen_setcondi_tl(TCG_COND_EQ, bcond, bcond, 0); + gen_msa_BxZ(ctx, df, wt, s16, true); break; } - - ctx->btarget =3D ctx->base.pc_next + (s16 << 2) + 4; - - ctx->hflags |=3D MIPS_HFLAG_BC; - ctx->hflags |=3D MIPS_HFLAG_BDS32; } =20 static void gen_msa_i8(DisasContext *ctx) --=20 2.26.2