From nobody Tue Nov 18 04:26:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607363050; cv=none; d=zohomail.com; s=zohoarc; b=YF1urX52N3xo+4eE9FF/yDJwnTRGPHkLM5Cupy8fMUW6S4Lo4KodIHsT33Vfg3ernjKT1pELpuDUMpVDPudMDj2E2yi1HLWRyxwGO1akdTvbJHYEZVarrdP5mR5/j7T9gXj7Dhxh4aORwH+QCYl2dF5K5FTVp1dI1bQyqYSx5Hw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607363050; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+8NK+JLjwh+JB5bhBvryBjlvmM1oIwUWSMq0H3Ze/7c=; b=FDUoWbI6+YoCvoyZ/dFfX2wjhC30oUN3akrT1zXMzbtg/qc+/QR8efTX9CUFknIq9N+A4qUTSWg744YaJmbbce80CgEIEfNJ8cFW8oEACS5a7SSUZ4OCeUsghCpev/oxoTItVG1jeIGbZzIhIDMRhk+PbMgP8kgo+Prc4GXJ8Rg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607363050792656.9073576559605; Mon, 7 Dec 2020 09:44:10 -0800 (PST) Received: from localhost ([::1]:33822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmKYR-00078E-Qz for importer@patchew.org; Mon, 07 Dec 2020 12:44:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmKGi-0001Vz-93 for qemu-devel@nongnu.org; Mon, 07 Dec 2020 12:25:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmKGe-0007BA-Re for qemu-devel@nongnu.org; Mon, 07 Dec 2020 12:25:47 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-5rAyZr_wNhiVFxTFA8tVHw-1; Mon, 07 Dec 2020 12:25:42 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 328941842140; Mon, 7 Dec 2020 17:25:41 +0000 (UTC) Received: from localhost (ovpn-114-128.ams2.redhat.com [10.36.114.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6905B60C5F; Mon, 7 Dec 2020 17:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607361944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8NK+JLjwh+JB5bhBvryBjlvmM1oIwUWSMq0H3Ze/7c=; b=Xalgvwr8TC0X0v3zK6tyVjJGZ45gU+IjjxuennykBfEu4wcdiRmrbZQuWwyGD02sev3bzP FhwP4zyU2Ajs5TI9Cwb28UOohw6jrwFJX0iCwWO3RGDD5povlaqKGBzDFv5R59A7ko5S/b OnVID/+76CC/BVu8lvNf7D4cVIi8iyM= X-MC-Unique: 5rAyZr_wNhiVFxTFA8tVHw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH v2 07/12] block/export: fix blk_size double byteswap Date: Mon, 7 Dec 2020 17:20:25 +0000 Message-Id: <20201207172030.251905-8-stefanha@redhat.com> In-Reply-To: <20201207172030.251905-1-stefanha@redhat.com> References: <20201207172030.251905-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, Peter Maydell , "Michael S . Tsirkin" , Coiby Xu , Max Reitz , Stefan Hajnoczi , Paolo Bonzini , Raphael Norwitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The config->blk_size field is little-endian. Use the native-endian blk_size variable to avoid double byteswapping. Fixes: 11f60f7eaee2630dd6fa0c3a8c49f792e46c4cf1 ("block/export: make vhost-= user-blk config space little-endian") Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user= -blk-server.c index 62672d1cb9..3003cff189 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -354,7 +354,7 @@ vu_blk_initialize_config(BlockDriverState *bs, config->num_queues =3D cpu_to_le16(num_queues); config->max_discard_sectors =3D cpu_to_le32(32768); config->max_discard_seg =3D cpu_to_le32(1); - config->discard_sector_alignment =3D cpu_to_le32(config->blk_size >> 9= ); + config->discard_sector_alignment =3D cpu_to_le32(blk_size >> 9); config->max_write_zeroes_sectors =3D cpu_to_le32(32768); config->max_write_zeroes_seg =3D cpu_to_le32(1); } --=20 2.28.0