From nobody Tue Nov 18 01:24:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) client-ip=209.85.208.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607122797; cv=none; d=zohomail.com; s=zohoarc; b=R8cK4rhWho9BgPbI2XRgMtu+vbudoAzMkTqw0KOcHs9eqHmf+P4L8s4T66sU1mlwS+efs7kxrt/UuUJzFWzDTL6a84O3wkoqTHxFcTeSyoth1QTJYpAnnW59ovnebY0TEIQO1E0E/vVXK4igKerCBnVPbAud5+7PEXoaMREB0N4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607122797; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=QBWY0gSLJ2OOvMeFl8vsP40E6Cg+fRCBYfmiDLBG1bo=; b=Aoebk4lvrtCW2HVbpS1NCuf5rXrTOvwJP1yt552h6zOCE6gysayHWum63mSt9meTkIOJDd7Xg+1O29j5/pfo+aM3xACYk/eHInhgWwmZsr5ewNRtLHeXxNEKs+Kov/uOEVTq+IymB0LXXhBMifMIcA/FbDubULPJOoQfFP0G2E0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by mx.zohomail.com with SMTPS id 1607122797604519.1788110661774; Fri, 4 Dec 2020 14:59:57 -0800 (PST) Received: by mail-ed1-f66.google.com with SMTP id ck29so7491768edb.8 for ; Fri, 04 Dec 2020 14:59:57 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id v24sm4387953edw.23.2020.12.04.14.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 14:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QBWY0gSLJ2OOvMeFl8vsP40E6Cg+fRCBYfmiDLBG1bo=; b=Z3Y7FCH/yESuL9NM4eDcqX8rhsx7WARNNBbeQGe/uEDy7WM55L8xzNVtEIvs/Gg3xM 7m5z2gwLPWw8o8rXId/ccY0713kTk0AtMf5ZXCTqVz0NaR8IrhXQymEz9RtksGepJ03r E8f7bCD9y/70xhiaL7qjy3CYr+7OS29ZUGnCoPhImooSVJLHdSDbZFvCbab6ktZiOuad Qx+jhvqTr9Dl6GhU4QeYik/uUl5Hp5m6Cw2T5yiN4udoZXlemHMbQuop7rsLx2k+9wT4 xDqJ/yL/CRmzO+ie5asQOWgaMLurZl18s3kt4I4d25B8dcHqZqFnekun/EtiqOH2I9tT ckRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=QBWY0gSLJ2OOvMeFl8vsP40E6Cg+fRCBYfmiDLBG1bo=; b=DkCHiGqe7mpWghfSZ8ABmM/inhihERcO7XBWxGAuqXAM8oNE17kn640L0vkDot3m7r W68QdUssPR2CrMWHUTMUi7Sds2vnzFcCKLiFbsYBe9izWb2EZmGamyWPqNoxDA8lW7RS tV1y6lT5Qi92W3/5AroG5xYkm3ok4xUpOCusLhfA2govGncXITODM8ZrxwIFiyqEBbvc JO/KvB6xmZ9eEgYwTUxt0mC2oTSOSdglnrZHTLvkzoMhQ1MDZfhwzT+FMlgU0UGXjaCO Id/8536DdP2IXnwNcnLt/lR19TOfq6DqhcTjLxqWQtXfP99WpN2HxWObr+/uHQS987Nw RJDA== X-Gm-Message-State: AOAM532zDYiXGhZ5TrXK/OmVWm3fLQ2Ek1Op2TsJMzgLahwCnyY3EhoB GEYP59/Sfxv4aEjdHHkGZNrU8ujxTSE= X-Google-Smtp-Source: ABdhPJykVD6IavRzrZjDiME+FThgqK3Gt5lyrKC5y3pjRYndt668x++cvpFNFyd6n7HMW90tfUBy/A== X-Received: by 2002:a50:c406:: with SMTP id v6mr7299359edf.367.1607122795754; Fri, 04 Dec 2020 14:59:55 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Aurelien Jarno Subject: [PATCH] target/mips: Simplify gen_msa_BxZ() 'if' condition Date: Fri, 4 Dec 2020 23:59:53 +0100 Message-Id: <20201204225953.2755588-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) As gen_check_zero_element() already produces a boolean, replace 'if (x) tcg_gen_setcondi_tl()' by tcg_gen_xori_tl(x) which already contains the if (x). Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Based-on: <20201202184415.1434484-1-f4bug@amsat.org> --- target/mips/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 8a35d4d0d03..112a5becfbb 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28778,9 +28778,7 @@ static bool gen_msa_BxZ(DisasContext *ctx, int df, = int wt, int s16, bool if_not) } =20 gen_check_zero_element(bcond, df, wt); - if (if_not) { - tcg_gen_setcondi_tl(TCG_COND_EQ, bcond, bcond, 0); - } + tcg_gen_xori_tl(bcond, bcond, if_not); =20 ctx->btarget =3D ctx->base.pc_next + (s16 << 2) + 4; ctx->hflags |=3D MIPS_HFLAG_BC; --=20 2.26.2