From nobody Tue Nov 18 02:50:37 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607061070; cv=none; d=zohomail.com; s=zohoarc; b=eIa7gVKXbLEWJo1vkDMR7peHSK0dvUh4pXGEs6PRwoXOfXRfpK8+E+jps0DkIjSwtS4RB+Hk0TEP4CcDOi02Ef2bQkPAv1LcovBMWurs55tblAkDulmdzMpmvXKcW0xFdusGu5V6FwNTO6CnqDLmYZ0XDZV2a5xHJ+nnEgST/aU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607061070; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FqXapTbha+/ZldOmjXSFSS/lsLWT3bXMRkuwYmP9DRo=; b=d6wpqvQp3uz17ETJoyCLWXjakldQYmtkksNxXdbbgTwcl/+IzEHGPCKGe56fjLTy3IBIHM+ZFEUu+ucIeQxoiYN9xLhd2p7s9rqvrFxnO2Z3YzrKTpASayBVY/FpQDt/DoxxYwGNKoVruINk3lVe+MorJhWiEjQPx2ArmfrvGwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607061070895918.5536377910296; Thu, 3 Dec 2020 21:51:10 -0800 (PST) Received: from localhost ([::1]:52340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kl3zp-0005bS-Fg for importer@patchew.org; Fri, 04 Dec 2020 00:51:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl3tW-0004B6-Df; Fri, 04 Dec 2020 00:44:38 -0500 Received: from ozlabs.org ([203.11.71.1]:47971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl3tU-000062-KJ; Fri, 04 Dec 2020 00:44:38 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4CnM8h3nJ0z9sVw; Fri, 4 Dec 2020 16:44:20 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1607060660; bh=pnJf0W657ZqIQCAsU+SbMXMq/ij/zS+RJqdmVHy+dx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UKkxc8iV11JrVmF6RVkWAi412yYd8//9vWGcbEhH6VeDetkjlJIxok/U4bUqGlqTV GHcdr5a2Mw0HrE0iN5YtpCspvp/t43OqHQoOMh8fgEiRUu2CJlB1mFe0PEaAzuONkT 4WwL1hKy7zWBcwkc/m2dv6QUtcQoNgVEeTzNztEE= From: David Gibson To: pair@us.ibm.com, pbonzini@redhat.com, frankja@linux.ibm.com, brijesh.singh@amd.com, dgilbert@redhat.com, qemu-devel@nongnu.org Subject: [for-6.0 v5 09/13] securable guest memory: Move SEV initialization into arch specific code Date: Fri, 4 Dec 2020 16:44:11 +1100 Message-Id: <20201204054415.579042-10-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201204054415.579042-1-david@gibson.dropbear.id.au> References: <20201204054415.579042-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, cohuck@redhat.com, berrange@redhat.com, Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Richard Henderson , Marcelo Tosatti , david@redhat.com, mdroth@linux.vnet.ibm.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, David Gibson , rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" While we've abstracted some (potential) differences between mechanisms for securing guest memory, the initialization is still specific to SEV. Given that, move it into x86's kvm_arch_init() code, rather than the generic kvm_init() code. Signed-off-by: David Gibson --- accel/kvm/kvm-all.c | 14 -------------- target/i386/kvm.c | 12 ++++++++++++ target/i386/sev.c | 7 ++++++- 3 files changed, 18 insertions(+), 15 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 724e9294d0..1b676da6c2 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2178,20 +2178,6 @@ static int kvm_init(MachineState *ms) =20 kvm_state =3D s; =20 - /* - * if memory encryption object is specified then initialize the memory - * encryption context. - */ - if (ms->sgm) { - Error *local_err =3D NULL; - /* FIXME handle mechanisms other than SEV */ - ret =3D sev_kvm_init(ms->sgm, &local_err); - if (ret < 0) { - error_report_err(local_err); - goto err; - } - } - ret =3D kvm_arch_init(ms, s); if (ret < 0) { goto err; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index a2934dda02..8e3617f3cd 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -42,6 +42,7 @@ #include "hw/i386/intel_iommu.h" #include "hw/i386/x86-iommu.h" #include "hw/i386/e820_memory_layout.h" +#include "sysemu/sev.h" =20 #include "hw/pci/pci.h" #include "hw/pci/msi.h" @@ -2110,6 +2111,17 @@ int kvm_arch_init(MachineState *ms, KVMState *s) uint64_t shadow_mem; int ret; struct utsname utsname; + Error *local_err =3D NULL; + + /* + * if memory encryption object is specified then initialize the + * memory encryption context (no-op otherwise) + */ + ret =3D sev_kvm_init(ms->sgm, &local_err); + if (ret < 0) { + error_report_err(local_err); + return ret; + } =20 if (!kvm_check_extension(s, KVM_CAP_IRQ_ROUTING)) { error_report("kvm: KVM_CAP_IRQ_ROUTING not supported by KVM"); diff --git a/target/i386/sev.c b/target/i386/sev.c index 022ce5fc3a..8c19f4aea6 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -628,13 +628,18 @@ sev_vm_state_change(void *opaque, int running, RunSta= te state) =20 int sev_kvm_init(SecurableGuestMemory *sgm, Error **errp) { - SevGuestState *sev =3D SEV_GUEST(sgm); + SevGuestState *sev + =3D (SevGuestState *)object_dynamic_cast(OBJECT(sgm), TYPE_SEV_GUE= ST); char *devname; int ret, fw_error; uint32_t ebx; uint32_t host_cbitpos; struct sev_user_data_status status =3D {}; =20 + if (!sev) { + return 0; + } + ret =3D ram_block_discard_disable(true); if (ret) { error_report("%s: cannot disable RAM discard", __func__); --=20 2.28.0