From nobody Tue Nov 18 01:22:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606996171; cv=none; d=zohomail.com; s=zohoarc; b=nKuhC6sNyCBTuruygUTOFwadM1WpL55H+bOqg2JFV/DGA7I8R4J558niH46BZavEkbXNzKxypLf10Jd37jziklcdF5w7dqkThe6s89xojXCpBsXuSZR18CMHEXZCgQpbs3SAjxutiP/NEEdqog+Drdpif76vzKYqE6rJ7H9MltM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606996171; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FfDnnqZhMg8ve3HQG0wHiEoFXbDMSDaubQU0AousCJA=; b=fZWH+s+6B/yseRxeJJlSAFrkmvHdeA+WNdQHZvzu/a7CUSvIj9npkuYaRFEC/Ubu9yUL/UNndcK1IOu7qmbZel5GobWKoV1ieTle+6U0DkGxmyHv7NiU2EXy8AexJCiuUW9X6/uSaY43x2vIteltitgjC6DvKb86a/47WqWSYI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606996171612551.6805520086523; Thu, 3 Dec 2020 03:49:31 -0800 (PST) Received: from localhost ([::1]:43148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkmWt-0008DT-Jk for importer@patchew.org; Thu, 03 Dec 2020 06:12:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkmTF-00039x-7W for qemu-devel@nongnu.org; Thu, 03 Dec 2020 06:08:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kkmT8-0006dA-Jj for qemu-devel@nongnu.org; Thu, 03 Dec 2020 06:08:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-J_n4vCdwNe2Z71Q2ZzTtfA-1; Thu, 03 Dec 2020 06:08:12 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2CA521005E70 for ; Thu, 3 Dec 2020 11:08:11 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-94.ams2.redhat.com [10.36.112.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id E9D7E18A2F; Thu, 3 Dec 2020 11:08:10 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4BD329D9F; Thu, 3 Dec 2020 12:08:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606993693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FfDnnqZhMg8ve3HQG0wHiEoFXbDMSDaubQU0AousCJA=; b=Fq4oQXa4Vbqcmqhd1sNsOfpvEK7B9MnujKDYg1+4r41sOxm0gwl2uPNYeVAIv5wI9lgl5R /Z/eacoJseTWIt+oNT2qTETSg/VHhqqbN5KWvKWZWb0OqIzAqUv6VL/MIFnczgtULiTSXv h+P08JEgLnR3PFD42UiBvb7X6H+yuA4= X-MC-Unique: J_n4vCdwNe2Z71Q2ZzTtfA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH 7/9] vnc: force initial resize message Date: Thu, 3 Dec 2020 12:08:03 +0100 Message-Id: <20201203110806.13556-8-kraxel@redhat.com> In-Reply-To: <20201203110806.13556-1-kraxel@redhat.com> References: <20201203110806.13556-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The vnc server should send desktop resize notifications unconditionally on a new client connect, for feature negotiation reasons. Add a bool flag to vnc_desktop_resize() to force sending the message even in case there is no size change. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 247e80d8f5c8..bdaf384f71a4 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -664,13 +664,14 @@ void vnc_framebuffer_update(VncState *vs, int x, int = y, int w, int h, } =20 =20 -static void vnc_desktop_resize(VncState *vs) +static void vnc_desktop_resize(VncState *vs, bool force) { if (vs->ioc =3D=3D NULL || !vnc_has_feature(vs, VNC_FEATURE_RESIZE)) { return; } if (vs->client_width =3D=3D pixman_image_get_width(vs->vd->server) && - vs->client_height =3D=3D pixman_image_get_height(vs->vd->server)) { + vs->client_height =3D=3D pixman_image_get_height(vs->vd->server) && + !force) { return; } =20 @@ -800,7 +801,7 @@ static void vnc_dpy_switch(DisplayChangeListener *dcl, =20 QTAILQ_FOREACH(vs, &vd->clients, next) { vnc_colordepth(vs); - vnc_desktop_resize(vs); + vnc_desktop_resize(vs, false); if (vs->vd->cursor) { vnc_cursor_define(vs); } @@ -2143,7 +2144,7 @@ static void set_encodings(VncState *vs, int32_t *enco= dings, size_t n_encodings) break; } } - vnc_desktop_resize(vs); + vnc_desktop_resize(vs, true); check_pointer_type_change(&vs->mouse_mode_notifier, NULL); vnc_led_state_change(vs); if (vs->vd->cursor) { --=20 2.27.0