From nobody Tue Nov 18 01:24:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.65 as permitted sender) client-ip=209.85.218.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1606934681; cv=none; d=zohomail.com; s=zohoarc; b=G1YaWSkpzIk1F5/vQPb30cS/VangbO3gzRP9zlWyh0tCgqLNbycMyh7gF9SrI6hmqWBq5WgF6e60jeSjC2qjgVy+oEq6BuspnnzNqqKYnhIDHk5hf7VzIIeQOr5WvpC6eYLA/sfambKfYqcxykJiQx04kst8evQ7kwTzLXUT+Bo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606934681; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EfZKBB7TEk79ikaLZVaA0qdMSWTD8SEXSh/4GRS42BA=; b=PIqZc0rC5Xw4nJdZN/kCu6e5fcuJt0qRCIrpfD/wgIR1dGy7psWWSUMtuzyPdqtVrFm4Rk9KlDn4LoYVxGYfWPGitMbau3uvvv0/B4pdrYeWsYDO1q1k31J9kG0DYL5aMmpwK0yaKiwI1ULa11T1dwBpmIgpXoSoGlsItSjPucI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by mx.zohomail.com with SMTPS id 1606934681487728.4563242855149; Wed, 2 Dec 2020 10:44:41 -0800 (PST) Received: by mail-ej1-f65.google.com with SMTP id x16so5919291ejj.7 for ; Wed, 02 Dec 2020 10:44:40 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id j20sm426900ejy.124.2020.12.02.10.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 10:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EfZKBB7TEk79ikaLZVaA0qdMSWTD8SEXSh/4GRS42BA=; b=P95A6tbhEC27Gb2iNPVIYBHFIIvucWz+VR+a4ybKvU3EiTnVdOdYajv6KzVoLOw1vi A5V1AmZVeBhnxduxA8gceXaEvcuEIXVge8O1e4n1GovoLkYDGjTiuil+mktQHpL9YvAA /BUVrienxo7FMO0jf4z1LVzfH49eNkNd8CTbt+APgo340yoKP77xI0/WAXuY39ujR0W+ inWBo6IXm1A3Qwr5oxXmVJeFB/481K9L+0E5jiJ/j1DVjBfJFy7uLyjpVfKD+fmVNXJg q26FGfDnStuNY7oJYTSdkNTZ1f9UxxxdYRtnCK+Mitu15gS/DMkF21uwmDPDYy4xFL4a G+Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=EfZKBB7TEk79ikaLZVaA0qdMSWTD8SEXSh/4GRS42BA=; b=G9MY4SBY2ZQQph8ZIK97SGw+VUyWgQ6oaekkitKB0O0/wvyupPa9aJSRHYDjUmMJjN EySdBWSJulBPr6dD/A6E3FsExkB1OWU81Kx663bzo5T4liZW/n6YI5fzNpkv0XsU+hJB ow7iePmge2YpO1T/Eg6zjcDQEPfQ+KExQ+8klITDq/wE25si9mW0aXYvL9330EaLvAET 0llXOQdqEbBEJmAvprIrp1ldvc6Eeoluy4Mk5fi7TH6uwyzeJxL0m8G58rQJC/8X8l7B kApEcpFF7ma+HgU/ZoQjnxzK9hojO+3ggca20eOvN6wL2A1cDjGVZYhWQ9DguI+dxb+n 3Oag== X-Gm-Message-State: AOAM530dNcpChdT7e7Jn97uio5ONM74FHVWbwqy0n9pdEpuocYoz39Cp ActT5ZTJENbpThiT191Xoxw= X-Google-Smtp-Source: ABdhPJy49hwDReaOMfO3lnaEZQ3M3+pPQZ3B7DhL9efpAUnk5pW2RtqwkM/bDuoXEOF/WQE/LJCZXA== X-Received: by 2002:a17:906:2a19:: with SMTP id j25mr1082013eje.506.1606934679580; Wed, 02 Dec 2020 10:44:39 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , Richard Henderson , kvm@vger.kernel.org, Aleksandar Rikalo , Paolo Bonzini , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/9] target/mips: Simplify MSA TCG logic Date: Wed, 2 Dec 2020 19:44:10 +0100 Message-Id: <20201202184415.1434484-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201202184415.1434484-1-f4bug@amsat.org> References: <20201202184415.1434484-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Only decode MSA opcodes if MSA is present (implemented). Now than check_msa_access() will only be called if MSA is present, the only way to have MIPS_HFLAG_MSA unset is if MSA is disabled (bit CP0C5_MSAEn cleared, see previous commit). Therefore we can remove the 'reserved instruction' exception. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/translate.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 803ffefba2c..a05c25e50b8 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28697,13 +28697,8 @@ static inline int check_msa_access(DisasContext *c= tx) } =20 if (unlikely(!(ctx->hflags & MIPS_HFLAG_MSA))) { - if (ctx->insn_flags & ASE_MSA) { - generate_exception_end(ctx, EXCP_MSADIS); - return 0; - } else { - generate_exception_end(ctx, EXCP_RI); - return 0; - } + generate_exception_end(ctx, EXCP_MSADIS); + return 0; } return 1; } @@ -30547,7 +30542,7 @@ static void gen_msa_vec(CPUMIPSState *env, DisasCon= text *ctx) static void gen_msa(CPUMIPSState *env, DisasContext *ctx) { uint32_t opcode =3D ctx->opcode; - check_insn(ctx, ASE_MSA); + check_msa_access(ctx); =20 switch (MASK_MSA_MINOR(opcode)) { @@ -31194,9 +31189,10 @@ static void decode_opc(CPUMIPSState *env, DisasCon= text *ctx) case OPC_BNZ_H: case OPC_BNZ_W: case OPC_BNZ_D: - check_insn(ctx, ASE_MSA); - gen_msa_branch(env, ctx, op1); - break; + if (ase_msa_available(env)) { + gen_msa_branch(env, ctx, op1); + break; + } default: MIPS_INVAL("cp1"); generate_exception_end(ctx, EXCP_RI); @@ -31385,7 +31381,9 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) #endif } else { /* MDMX: Not implemented. */ - gen_msa(env, ctx); + if (ase_msa_available(env)) { + gen_msa(env, ctx); + } } break; case OPC_PCREL: --=20 2.26.2