From nobody Tue Nov 18 01:24:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.67 as permitted sender) client-ip=209.85.218.67; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f67.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1606934670; cv=none; d=zohomail.com; s=zohoarc; b=Tsh8oKKi7w7u3bl2erpYipuCs5CiUlEDgz4lvgSP07Sj/x68H+tEWDKzgZPIb4dqf+pF34O//lRtoOuTvB2nI/8PJQNt1Cnd2QiZ0bPfGf3ygso1Yv+R0sFpYAdFOAitgnOqOpBnWlvVaOQaS628hJ8rjjlLoJTzV3XX3fXKCZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606934670; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Cd+cZl3lcOYz3Gxtj1/bjHSaDTLTKsW2lXk6GJRA4IU=; b=OQfT3NN6oJGsTsA6mEYXQ+UDw0+kBe2QVmKsmAKc9QI3FKAqBbmExHsQYpCFvlccHJBxrtYDqsFmhOoBkKRWrzUHeI5jNV1DzVWIc/mdINI+1Yzow/Fi7eoy9yZj0rP3BCVkytG5vMtoV0tqGTTpyBlPeSLK2Sp3dcUsEMy/QyY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.67 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by mx.zohomail.com with SMTPS id 1606934670641250.74625943093417; Wed, 2 Dec 2020 10:44:30 -0800 (PST) Received: by mail-ej1-f67.google.com with SMTP id jx16so5895065ejb.10 for ; Wed, 02 Dec 2020 10:44:29 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id p91sm550214edp.9.2020.12.02.10.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 10:44:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Cd+cZl3lcOYz3Gxtj1/bjHSaDTLTKsW2lXk6GJRA4IU=; b=S2pR8EmGeeVTU63mgKk5Ud1W84JypeTfvaScnRER/pLP+zhKc7dFIbwqQywoU8Sk6l 6hs/J8GZ4N4fmmVTk/zb4WGXKxjjY/ZZ9WW8CW0Qs7ylTTn25wfjNkppjruxwne46iAJ 4EZYq6ljyoPw/QqwcQvsFDrcq4iEZ31gy4PcFZclYqxksynZOnjaleoZlOb3YY69+EQK 2UwSy9tUeBNUaEyiF2s8my6cYm7deOfQb98F13nZEhSuRLY7ub88SoazSM+CpQmJYIyV ugiN1YMf3DE5AKJPngoLMuSsNhd9353DkzFOjasJ+E9+Xzd1pfWzHr1HW4rotZlGcKUI qtIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Cd+cZl3lcOYz3Gxtj1/bjHSaDTLTKsW2lXk6GJRA4IU=; b=uieP5c/IA305wOtvbz3htfNr7mk6C3cIIvHWxQ28IL+Dz2XxRo7OytpjkgSmV2xeK1 OBEIwh8hBfHXYk0ZZ9gi+VCj+u39wBitf3aLOirO1XqH4uFQdspe+HrEmRJJsT1U0h3v b8FUYSAyq3Sp+jCTu48wuOlXvQ7EY3sCSezLNDGNNS2uvQkXkbHvNtHYs/4+ZpWtkCfN /Tr6qaviIs7/RGXJBumkV9pL4XyVGZJ3TvbueE1r193QnA9pEia96379x8iPlG/dhkc2 8txMe6RV+YahSQEM96HtfKJiRq0xb/fjZ8Ffl0LxZ62UrhS9egVBl9pvI4JIrtB981os NpYg== X-Gm-Message-State: AOAM530BpPds/VvfIFULRbgNbXmxaD4CKPy7FtoetamQh/LEHrZutIyX iG5Ld10AeFT140YDj1hPYpQ= X-Google-Smtp-Source: ABdhPJwV+gLJt4YMjpfq4QmFKSJ/vB4g2/7zLmukJCqDsckb+0ljrPmo2gKywnORW4y3V4vD2C5YXQ== X-Received: by 2002:a17:906:3704:: with SMTP id d4mr1151640ejc.338.1606934668730; Wed, 02 Dec 2020 10:44:28 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , Richard Henderson , kvm@vger.kernel.org, Aleksandar Rikalo , Paolo Bonzini , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/9] target/mips: Simplify msa_reset() Date: Wed, 2 Dec 2020 19:44:08 +0100 Message-Id: <20201202184415.1434484-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201202184415.1434484-1-f4bug@amsat.org> References: <20201202184415.1434484-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Call msa_reset() inconditionally, but only reset the MSA registers if MSA is implemented. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- Maybe not very useful. --- target/mips/translate.c | 5 +---- target/mips/translate_init.c.inc | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index a7c01c2ea5b..803ffefba2c 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -31997,10 +31997,7 @@ void cpu_state_reset(CPUMIPSState *env) env->hflags |=3D MIPS_HFLAG_M16; } =20 - /* MSA */ - if (ase_msa_available(env)) { - msa_reset(env); - } + msa_reset(env); =20 compute_hflags(env); restore_fp_status(env); diff --git a/target/mips/translate_init.c.inc b/target/mips/translate_init.= c.inc index 79f75ed863c..3b069190ed8 100644 --- a/target/mips/translate_init.c.inc +++ b/target/mips/translate_init.c.inc @@ -1018,6 +1018,10 @@ static void mvp_init (CPUMIPSState *env, const mips_= def_t *def) =20 static void msa_reset(CPUMIPSState *env) { + if (!ase_msa_available(env)) { + return; + } + #ifdef CONFIG_USER_ONLY /* MSA access enabled */ env->CP0_Config5 |=3D 1 << CP0C5_MSAEn; --=20 2.26.2