From nobody Mon Feb 9 07:22:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606923188; cv=none; d=zohomail.com; s=zohoarc; b=YgHlMdZf69HASTkAX9DHOs5eP9uRFr7GuFwn1oPpKlxIr62w3n2Qt5DqfW5PEVIIJ/Os9zi7SBALARxMiLiQBdINBdR0rjOYOu5yF10Op/v3oel/T5dwPTJR0GiGmmwW6VwX/ZtvLFT91sUjjzCC3PsK1lH36szc+X7CYsGngpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606923188; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0utENm6x05s6LlV+yETgvJfBM19cBadB8y673FhcQ5I=; b=Fa9r+kyalkEae3IRkKTuuRBNDc94AIwkd/QHmeMDo/0T+3+mv08oOwwFnd+dXxrcZ5Y0eRzcgxTHZZXp36b7YAPQ6yJpSkB3ed1Hcv/FaswLodMj4OogHrOr5RfWKbSjqsQt44js5QK9ZeGBzcecduY5YXZMNU4H/Pa3yaJbyVg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606923188296245.2223108666708; Wed, 2 Dec 2020 07:33:08 -0800 (PST) Received: from localhost ([::1]:58162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkU7t-00024H-3N for importer@patchew.org; Wed, 02 Dec 2020 10:33:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkU2P-0006FX-MW for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:27:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kkU2I-00046w-00 for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:27:25 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-zL02Zw54MgWnunoTiugUHw-1; Wed, 02 Dec 2020 10:27:13 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 931A3427C9; Wed, 2 Dec 2020 15:27:12 +0000 (UTC) Received: from localhost (ovpn-114-255.ams2.redhat.com [10.36.114.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 39A715D9DB; Wed, 2 Dec 2020 15:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606922837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0utENm6x05s6LlV+yETgvJfBM19cBadB8y673FhcQ5I=; b=SkIPE+XSa9bJM7/Hk8FsXyDp4xMwZvZwWdwj44ZYfpq67ZsK2v+EFTY1NAwR/hAhbgkCbK qQaYC9qj/JBZywThUhWU1xjPBKQ+KdrMhSnKBfyPGl68tBQ2wYg8up90DiqXoIemfZcbHY HLqJFM2z6xB3p2Nt8TRdzAO3A3ZakUc= X-MC-Unique: zL02Zw54MgWnunoTiugUHw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH v2 3/4] contrib/vhost-user-input: avoid g_return_val_if() input validation Date: Wed, 2 Dec 2020 15:26:10 +0000 Message-Id: <20201202152611.677753-4-stefanha@redhat.com> In-Reply-To: <20201202152611.677753-1-stefanha@redhat.com> References: <20201202152611.677753-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Coiby Xu , Raphael Norwitz , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , Stefan Hajnoczi , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Max Reitz , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi Reviewed-by: Marc-Andr=C3=A9 Lureau --- contrib/vhost-user-input/main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/vhost-user-input/main.c b/contrib/vhost-user-input/mai= n.c index 6020c6f33a..1d79c61200 100644 --- a/contrib/vhost-user-input/main.c +++ b/contrib/vhost-user-input/main.c @@ -212,7 +212,11 @@ static int vi_get_config(VuDev *dev, uint8_t *config, = uint32_t len) { VuInput *vi =3D container_of(dev, VuInput, dev.parent); =20 - g_return_val_if_fail(len <=3D sizeof(*vi->sel_config), -1); + if (len > sizeof(*vi->sel_config)) { + g_critical("%s: len %u is larger than %zu", + __func__, len, sizeof(*vi->sel_config)); + return -1; + } =20 if (vi->sel_config) { memcpy(config, vi->sel_config, len); --=20 2.28.0