From nobody Sun Feb 8 00:03:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606741130; cv=none; d=zohomail.com; s=zohoarc; b=nObLNmO6NUcaNbcIXLDiC8HesgBJfEgTjJ/8UalpOoX8Rd0qhTyxyuu7VK5+O3VycN2bMoh7ezf+IyKwXgXm5QCdrVjB6Iv50IGpHnFvwOwb+Q/52wtYlZ3W8ogNcHc3TzXFQlIJgtHQJtIuwcbNV14IEUwCvRlALuQPz36YEDk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606741130; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=F0PTh2mwRAr6m2VagQfrs4hxWUqXQPcN4hNP1vbqQ8o=; b=K9rhTqM/mHshQtTgHJn/08yl9caERTZXSXEPokUr6uO3RaUWAE2nFbyMLo/TYxu/DLMr2lf4EGg9rVFtlYJrN84t/xnNKO2++3dedkfqE620qc2g34DcvEZ5Ip8N7VMJ8e2Hl0wfYDrsQDb6iBYcQjge1Gxe9lBTZMtN/aK7tXc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606741130055245.57662072828043; Mon, 30 Nov 2020 04:58:50 -0800 (PST) Received: from localhost ([::1]:47154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjilU-0004Ih-Tc for importer@patchew.org; Mon, 30 Nov 2020 07:58:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjicl-0004T6-77; Mon, 30 Nov 2020 07:49:47 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjich-0000cg-0o; Mon, 30 Nov 2020 07:49:46 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cl4mj1fWfzhYQ8; Mon, 30 Nov 2020 20:49:09 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 30 Nov 2020 20:49:23 +0800 From: Alex Chen To: Subject: [PATCH] qemu-nbd: Fix a memleak in qemu_nbd_client_list() Date: Mon, 30 Nov 2020 12:36:51 +0000 Message-ID: <20201130123651.17543-1-alex.chen@huawei.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=alex.chen@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When the qio_channel_socket_connect_sync() fails we should goto 'out' label to free the 'sioc' instead of return. Reported-by: Euler Robot Signed-off-by: Alex Chen Reviewed-by: Alberto Garcia --- qemu-nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index a7075c5419..47587a709e 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -181,7 +181,7 @@ static int qemu_nbd_client_list(SocketAddress *saddr, Q= CryptoTLSCreds *tls, sioc =3D qio_channel_socket_new(); if (qio_channel_socket_connect_sync(sioc, saddr, &err) < 0) { error_report_err(err); - return EXIT_FAILURE; + goto out; } rc =3D nbd_receive_export_list(QIO_CHANNEL(sioc), tls, hostname, &list, &err); --=20 2.19.1