From nobody Mon Feb 9 20:02:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) client-ip=209.85.128.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1606739204; cv=none; d=zohomail.com; s=zohoarc; b=fjt1lmIEbAHE+IitRA3jCv5DcrLU3TsKQI7DtmFlnO0pvDV798nj9TuwkrwyGvpkfVIC1CIwsQdlpW/ABfBDIWthDgwlg+lUVquqfAFWtG1M0Ap9gOJYu0z7Wogc4Vpd6ZyShP8tnM46R8idvJpeq3F3sEPvgZ644G4WZvnEb00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606739204; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=VA7NaFf2Q2lCqaq14OKvgdpQy3QN9t5ZRZL0R3j554M=; b=EMOxwlymXGy6OA2Lw8ZhLXw1U9LYNWyN8AXor93emxolJoi2OH3GE1Hctgtz3DzmQXarY73JSp6vheqKVEA5S/WGWSxw+j83qza5bHdBKXwurVsQ+Magkg5f+lNORGGvZ9vZ7RXh2RzQG3e1m+zbEvfBYQ8EvU39oTus0rV9FDQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.zohomail.com with SMTPS id 1606739203999364.03079769082217; Mon, 30 Nov 2020 04:26:43 -0800 (PST) Received: by mail-wm1-f65.google.com with SMTP id k10so11924325wmi.3 for ; Mon, 30 Nov 2020 04:26:43 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id r1sm26983621wra.97.2020.11.30.04.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 04:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VA7NaFf2Q2lCqaq14OKvgdpQy3QN9t5ZRZL0R3j554M=; b=H8O4moXlrZ9kjAyrDN5KyH8VOnD5lgzIOU8sjSgS86YkfwS0Bl2fVoG513JXLYrsnq mpCksJZr1WZKuH9pCn2jGbFWFxdvF/NiYZqCRfWsuhg46dOO91eGlauk98krLj7zzEYw aOmfW6PSfdciLnlCCqAQeT7HobbOWyhrbfRHH5W8Lu6qij8XTrpBtaeU9IHGDaKNOkPl VE+S7W/ELyoNY4x/EWCiXfQvFZ7w/mYytXDg2qGNkf6ZZRrIgip4NnbwcdtIDJjEsWsD FEwy3ad9gwHPvNttBFiAXZ2d4wCpVEt2tRWPcAfCurVpqVXmfp44gjBDJkmKD6nqaBrB tSgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=VA7NaFf2Q2lCqaq14OKvgdpQy3QN9t5ZRZL0R3j554M=; b=tftiCEcsBNZfFucq/lo5aDHW05Q/wLxPi0onyOMBMsXh81ysQjoa2ALwHPXB4Niggm WevGXHeJ3YRhPVwrk009r/q30hKmgUIqVnvxWKlW90/HkVxAKzsIJ0AY0lLyw9EwZBIM DB3w3Z12AWm3a+8/pIRyxpQ1Hv2Nq2NF/+bzrdDjMb5qRpPj6LOG/daAv5yYNeT59VJF f7VTtjh+25GmDsOLFJHTQ1pkR+W7/InXtI7k0FPD7MlOs4bvOZ09NeJ9LNUUzFL+oera XkTIBzNf74Wn2mOs2XTGbeJxA9y1L3OnIVqsYkm/hiRjJw0givotMG/slKntUH01dF3L 4qAQ== X-Gm-Message-State: AOAM533GlE8+8W8B6s7yT9/cmyYVHVYmS2jeR0aiS0LX8OSU9UwgpTQO ek4Qwoc/46zsMELSik6VoIY7l+idl1Q= X-Google-Smtp-Source: ABdhPJzyf6uzSMIXLNlVMMIB+VodbgrlRX0DK/fU07d5jfTymasH5yGwvsQ9Cyto1il1bKD62ivDow== X-Received: by 2002:a1c:98c7:: with SMTP id a190mr1263205wme.184.1606739202209; Mon, 30 Nov 2020 04:26:42 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Cleber Rosa , Richard Henderson , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] decodetree: Allow use of hex/bin format for argument field values Date: Mon, 30 Nov 2020 13:26:39 +0100 Message-Id: <20201130122639.2431070-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) ISA datasheets often use binary or hexadecimal constant values. By doing base conversion, we might introduce bugs. Safer is to copy/paste the datasheet value. Add support for bin/hex constants in argument field token. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Is there a more pythonic way to write this if/elif/else loop without re.fullmatch? --- scripts/decodetree.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 47aa9caf6d1..d2ecc61813f 100644 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -849,9 +849,15 @@ def parse_generic(lineno, parent_pat, name, toks): continue =20 # 'Foo=3Dnumber' sets an argument field to a constant value - if re.fullmatch(re_C_ident + '=3D[+-]?[0-9]+', t): + if re.fullmatch(re_C_ident + '=3D[+-]?(0[bx])?[0-9]+', t): (fname, value) =3D t.split('=3D') - value =3D int(value) + if re.fullmatch('[+-]?0b[0-9]+', value): + base =3D 2 + elif re.fullmatch('[+-]?0x[0-9]+', value): + base =3D 16 + else: + base =3D 10 + value =3D int(value, base) flds =3D add_field(lineno, flds, fname, ConstField(value)) continue =20 --=20 2.26.2