[PATCH 0/4] User creatable object property setting fixes

Kevin Wolf posted 4 patches 3 years, 3 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201130105615.21799-1-kwolf@redhat.com
Maintainers: Vikram Garhwal <fnu.vikram@xilinx.com>, Pavel Pisa <pisa@cmp.felk.cvut.cz>, Jason Wang <jasowang@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>
crypto/secret.c         | 14 --------------
crypto/secret_common.c  | 21 ++++++++++++++++++---
crypto/secret_keyring.c | 14 --------------
crypto/tlscredsanon.c   |  3 +--
crypto/tlscredspsk.c    |  3 +--
crypto/tlscredsx509.c   |  3 +--
net/can/can_host.c      |  5 +++++
7 files changed, 26 insertions(+), 37 deletions(-)
[PATCH 0/4] User creatable object property setting fixes
Posted by Kevin Wolf 3 years, 3 months ago
While writing a QAPI schema for all user creatable QOM objects, I found
a few problems in the existing property setting code of objects.

This series fixes some crashes and memory leaks related to property
setting in user creatable objects.

There are many more problems of the sort that updating a property at
runtime is allowed by most objects, but they aren't actually prepared to
handle the update, so it doesn't result in the expected behaviour. I'm
not trying to fix bugs of this class in this series.

Kevin Wolf (4):
  crypto: Move USER_CREATABLE to secret_common base class
  crypto: Forbid broken unloading of secrets
  crypto: Fix memory leaks in set_loaded for tls-*
  can-host: Fix crash when 'canbus' property is not set

 crypto/secret.c         | 14 --------------
 crypto/secret_common.c  | 21 ++++++++++++++++++---
 crypto/secret_keyring.c | 14 --------------
 crypto/tlscredsanon.c   |  3 +--
 crypto/tlscredspsk.c    |  3 +--
 crypto/tlscredsx509.c   |  3 +--
 net/can/can_host.c      |  5 +++++
 7 files changed, 26 insertions(+), 37 deletions(-)

-- 
2.28.0


Re: [PATCH 0/4] User creatable object property setting fixes
Posted by Daniel P. Berrangé 3 years, 3 months ago
On Mon, Nov 30, 2020 at 11:56:11AM +0100, Kevin Wolf wrote:
> While writing a QAPI schema for all user creatable QOM objects, I found
> a few problems in the existing property setting code of objects.
> 
> This series fixes some crashes and memory leaks related to property
> setting in user creatable objects.
> 
> There are many more problems of the sort that updating a property at
> runtime is allowed by most objects, but they aren't actually prepared to
> handle the update, so it doesn't result in the expected behaviour. I'm
> not trying to fix bugs of this class in this series.
> 
> Kevin Wolf (4):
>   crypto: Move USER_CREATABLE to secret_common base class
>   crypto: Forbid broken unloading of secrets
>   crypto: Fix memory leaks in set_loaded for tls-*

I've queued these three patches

>   can-host: Fix crash when 'canbus' property is not set
> 
>  crypto/secret.c         | 14 --------------
>  crypto/secret_common.c  | 21 ++++++++++++++++++---
>  crypto/secret_keyring.c | 14 --------------
>  crypto/tlscredsanon.c   |  3 +--
>  crypto/tlscredspsk.c    |  3 +--
>  crypto/tlscredsx509.c   |  3 +--
>  net/can/can_host.c      |  5 +++++
>  7 files changed, 26 insertions(+), 37 deletions(-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|