From nobody Mon Feb 9 10:54:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) client-ip=209.85.128.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1606731753; cv=none; d=zohomail.com; s=zohoarc; b=F3YFm/jqlVYnkAjmgQRGT4Cun8dE30DiAaTWVTNBdaXR34xdnWUuxr/QpEAxMW9WOmS1kSqAQnuw88Wtvb7NBITzhpeCwePhR4PA72ndjQurOBkDgs5PqdnT//2F3b2A8a/h9+DBt5JGOGPrcHrLeKrv/9PMKqc4kkI2o1gzVbQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606731753; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=wGVntoN2liXaamI1cMHbBYcL2IQ5cPw3L1dFFi7CllQ=; b=T/yqjHxciJlRt1ugNVOk2GLZ0p6pXiFG8pYNR/qWYfGYfYpxqEvvYU7S4Q4qfxxcKa0TKFrRaufRvQBN/TNxnQLyMjo+uxfpMUD++oflRYA1V1D6Rdz1+kxH1Sujc16GcfwXI+dKneXOj8X7+rGn0WFUmO1qtD+Zl9sa+JCGbdg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.zohomail.com with SMTPS id 1606731753043675.6916241641507; Mon, 30 Nov 2020 02:22:33 -0800 (PST) Received: by mail-wm1-f65.google.com with SMTP id f190so21171279wme.1 for ; Mon, 30 Nov 2020 02:22:32 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id r21sm28649555wrc.16.2020.11.30.02.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 02:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wGVntoN2liXaamI1cMHbBYcL2IQ5cPw3L1dFFi7CllQ=; b=ljUO8XVByb95avqkx0maT4FhOmfFyLID16Ad+yciKvAV9FlwxM1nG7hBjzZA8cuZlx okNmYJg0UGU2YK85V6xAc0JyT18EMbDV64kWeHYv7fcGoO44GTYPm0/wZySXAFfi2w0/ 3ajFqVbeGfmaj1/TUcFcelZDUKGmULHOVSiE4SYBH7O2bBzbz88pYEjE7SiOvivTDAVA SbNGgZy/X+1JlZNbSKt449mZxxyfDhrMcqFPtsc2OdJ0jC2lSlUXBPBCd4EYe73ESI58 zahl1wc3cs6y87GLKTpcNSNe4BhLFe25OQNZrlTNLpW2Qe2NovY0+2TdCRHMOK4M2I3N axfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=wGVntoN2liXaamI1cMHbBYcL2IQ5cPw3L1dFFi7CllQ=; b=FsRcMMd+l8IsNHMgqxvDYVBBXyfcD1MrtqLouuFn12S30zJPp3U5OD1Jw8dg4sPdoN TQPacc38b5duxyzR0C+GfmBhGNTvtrFNKOTlbOL0bIUBF6/4S4cGinRKUVwGNiieuuKQ 6Xz0/Vk7VgKjj74bz0DhkIxHl/dsfz7DBEZEIEKRgzbEnrWUZP+xxvf4+s7AEWEecw/S +cgAqO5wgYbj9j2WmoZ0CwNZ+3MsuVWX/XSa4MWNKP3iyyKOfBHyakhfIT2P9ZR/1m4l AEgaC5iYobeG/vYHhC1IXYq5AVIW7avsmMsBOvYEKd0PxfaHWN9EVQFneXjf/UDwqdgv 5yFg== X-Gm-Message-State: AOAM533Qde978GAejZKo9+5bTx9n2V5eYfpZZ5tIW5FsgLGdndRRmxKy DVquNZrIFlPBow+prQmKKy4= X-Google-Smtp-Source: ABdhPJynN2tUxs+/TleLaGuFEBQKXDVSeeLgOY9vCvk4VHILuvgkkBOXWzHYKX5DTtJB7tv18kwWkQ== X-Received: by 2002:a1c:ddc4:: with SMTP id u187mr22660490wmg.55.1606731751047; Mon, 30 Nov 2020 02:22:31 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Huacai Chen , qemu-devel@nongnu.org, Jiaxun Yang Cc: Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo Subject: [PATCH] target/mips: Allow executing MSA instructions on Loongson-3A4000 Date: Mon, 30 Nov 2020 11:22:28 +0100 Message-Id: <20201130102228.2395100-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The Loongson-3A4000 is a GS464V-based processor with MIPS MSA ASE: https://www.mail-archive.com/qemu-devel@nongnu.org/msg763059.html Commit af868995e1b correctly set the 'MSA present' bit of Config3 register, but forgot to allow the MSA instructions decoding in insn_flags, so executing them triggers a 'Reserved Instruction'. Fix by adding the ASE_MSA mask to insn_flags. Fixes: af868995e1b ("target/mips: Add Loongson-3 CPU definition") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Huacai Chen Reviewed-by: Richard Henderson --- Buggy since 5.1, so probably not a big deal. --- target/mips/translate_init.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/translate_init.c.inc b/target/mips/translate_init.= c.inc index ea85d5c6a79..79f75ed863c 100644 --- a/target/mips/translate_init.c.inc +++ b/target/mips/translate_init.c.inc @@ -832,7 +832,7 @@ const mips_def_t mips_defs[] =3D .mmu_type =3D MMU_TYPE_R4000, }, { - .name =3D "Loongson-3A4000", + .name =3D "Loongson-3A4000", /* GS464V-based */ .CP0_PRid =3D 0x14C000, /* 64KB I-cache and d-cache. 4 way with 32 bit cache line size. */ .CP0_Config0 =3D MIPS_CONFIG0 | (0x1 << CP0C0_AR) | (0x2 << CP0C0_= AT) | @@ -885,7 +885,7 @@ const mips_def_t mips_defs[] =3D .CP1_fcr31_rw_bitmask =3D 0xFF83FFFF, .SEGBITS =3D 48, .PABITS =3D 48, - .insn_flags =3D CPU_LOONGSON3A, + .insn_flags =3D CPU_LOONGSON3A | ASE_MSA, .mmu_type =3D MMU_TYPE_R4000, }, { --=20 2.26.2