From nobody Tue Feb 10 18:54:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606461908; cv=none; d=zohomail.com; s=zohoarc; b=AdwR0JqNBp3UDkd6JRAYU7kk+oip4GmxN+RjsNZQtQfDLRckhCtQ4kgblMPl1xdMhqAi1w8fVzJG0rr++MlJ+AVATCsmsclwpi3mLE3RAF0lIRRaOMwzVh2H1CnadQCopg2Id6g1bupC6KDN+y0EBIJUKRvA61ADstUrys6aYIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606461908; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sVKMEmthZd6PabCHyp6gqRgfddDRO+KJhcuJYvRLUWU=; b=mIWbXGzUoCg3M5aCbrNMwiTf40zM/hHfesBA8itT0d2sMyu+Wsm10EVbu1wLxvGSovBzRX5oCsAljcC7/Y5l+6KCRI+Xfd6p1vpxcp3m5urtjevBZoDFqyhs+603EVlvFaibDJqVvS2I74Ut7wNtuCD6xeYRD7azZtzAp+XjwGo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606461908628692.157847970536; Thu, 26 Nov 2020 23:25:08 -0800 (PST) Received: from localhost ([::1]:39258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiY7v-0007rW-Gb for importer@patchew.org; Fri, 27 Nov 2020 02:25:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1p-0002Eu-RE; Fri, 27 Nov 2020 02:18:49 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1n-0007gv-Uc; Fri, 27 Nov 2020 02:18:49 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZB4jvbzkZVH; Fri, 27 Nov 2020 15:18:10 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:33 +0800 From: Gan Qixin To: , Subject: [PATCH 2/7] digic-timer: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:17:58 +0800 Message-ID: <20201127071803.2479462-3-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=ganqixin@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Antony Pavlov , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the digic_ti= mer_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 288 byte(s) in 3 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db78 in ptimer_init /qemu/hw/core/ptimer.c:432 #3 0xaaabf5b04084 in digic_timer_init /qemu/hw/timer/digic-timer.c:142 #4 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #5 0xaaabf633ca04 in object_initialize_child_with_propsv /qemu/qom/obje= ct.c:564 #6 0xaaabf633cc08 in object_initialize_child_with_props /qemu/qom/objec= t.c:547 #7 0xaaabf5b40e84 in digic_init /qemu/hw/arm/digic.c:46 #8 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #9 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #10 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds= .c:153 #11 0xaaabf653d8ec in qmp_marshal_device_list_properties /qemu/qapi/qap= i-commands-qdev.c:59 #12 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Antony Pavlov --- hw/timer/digic-timer.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/timer/digic-timer.c b/hw/timer/digic-timer.c index 32612228da..86075987fb 100644 --- a/hw/timer/digic-timer.c +++ b/hw/timer/digic-timer.c @@ -154,6 +154,13 @@ static void digic_timer_init(Object *obj) sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->iomem); } =20 +static void digic_timer_finalize(Object *obj) +{ + DigicTimerState *s =3D DIGIC_TIMER(obj); + + ptimer_free(s->ptimer); +} + static void digic_timer_class_init(ObjectClass *klass, void *class_data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -163,11 +170,12 @@ static void digic_timer_class_init(ObjectClass *klass= , void *class_data) } =20 static const TypeInfo digic_timer_info =3D { - .name =3D TYPE_DIGIC_TIMER, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(DigicTimerState), - .instance_init =3D digic_timer_init, - .class_init =3D digic_timer_class_init, + .name =3D TYPE_DIGIC_TIMER, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(DigicTimerState), + .instance_init =3D digic_timer_init, + .instance_finalize =3D digic_timer_finalize, + .class_init =3D digic_timer_class_init, }; =20 static void digic_timer_register_type(void) --=20 2.23.0