From nobody Tue Feb 10 07:42:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390411; cv=none; d=zohomail.com; s=zohoarc; b=ACwxhP6t0Ks53sy96jvjeJP/D3ETXkjRENNxHjAT3JDLbxmf3o9S9dEOmGSGb7sa5ONKdZONTw2BYTb+HAiGtO3p5/tbwhxOMqwC2E8wls3QzrQlhf3XRTtXhex8QrXG9QEAetlV9ER7mUqkp+moyTN+t49q+Y1qa0CVfavVeMU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390411; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pamFUNJ2aY02RuGQt8qXkzT5bVlD8eZB3RBULf2jugo=; b=fzedxR35JMpn9f9R9dLuk+9MY/DfXljpqh+w2wutO4r+eJXKjkpslP4pe2RrqupqnR81wmRlhldTltGAgVtsoQn3abjaJC0q00VoyVNndwYffgpdSQTp9S53W9ouapBWzbwX1MKxJOt2ZiUXOPVLLCQdzdOGgF5BLXO4duRv2EQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390411634782.9178190732868; Thu, 26 Nov 2020 03:33:31 -0800 (PST) Received: from localhost ([::1]:59496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFWk-0005Hi-DT for importer@patchew.org; Thu, 26 Nov 2020 06:33:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFT8-0002zx-NG for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFT6-0006Db-FE for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:46 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-vhVUIS7ZNWiGMWNXX0ZZAQ-1; Thu, 26 Nov 2020 06:29:38 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E91F100C666; Thu, 26 Nov 2020 11:29:37 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 618C910023AD; Thu, 26 Nov 2020 11:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pamFUNJ2aY02RuGQt8qXkzT5bVlD8eZB3RBULf2jugo=; b=aaY0nJ/Bjq4K9r3lZE1HJQiyF8ssalPZTCjqGo0YVb08oHE0xotKvFjMcFj/Js0M+ZjsUW WoELy1ry5xdD96EinX3wSoLKuWXDeA9S6ni2R0OBNM3IFMGqgWJYD6Butjh8RkKz4SppBZ AwiLFeWTNoYhsJYHFXDlqGU9Semha/M= X-MC-Unique: vhVUIS7ZNWiGMWNXX0ZZAQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler Date: Thu, 26 Nov 2020 15:29:04 +0400 Message-Id: <20201126112915.525285-3-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. We can safely remove the special case introduced in commit a281ebc11a6 ("virtio: add missing mb() on notification"). With clang 3.8 (xenial amd64) __ATOMIC_RELAXED is defined, so the chunk to remove (which is x86-specific), isn't reached. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- include/qemu/atomic.h | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index c409257c11..8f4b3a80fb 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -241,23 +241,6 @@ =20 #else /* __ATOMIC_RELAXED */ =20 -/* - * We use GCC builtin if it's available, as that can use mfence on - * 32-bit as well, e.g. if built with -march=3Dpentium-m. However, on - * i386 the spec is buggy, and the implementation followed it until - * 4.3 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D36793). - */ -#if defined(__i386__) || defined(__x86_64__) -#if !G_GNUC_CHECK_VERSION(4, 4) -#if defined __x86_64__ -#define smp_mb() ({ asm volatile("mfence" ::: "memory"); (void)0; }) -#else -#define smp_mb() ({ asm volatile("lock; addl $0,0(%%esp) " ::: "memory"= ); (void)0; }) -#endif -#endif -#endif - - #ifdef __alpha__ #define smp_read_barrier_depends() asm volatile("mb":::"memory") #endif --=20 2.29.0