From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390413; cv=none; d=zohomail.com; s=zohoarc; b=RrMoiItVDiLq3v4mqVRvEWk1RfnlyDWOnLizfqmH19Vt6xyGCilYhQI9YmOApNlLIzKn0eIjAOhb0k2Py/AW4lh35aVroIQsejaOMaDf52txaN/sq/goDNuf7jP0DdUPIMDuTKc8Gx/PKjJl9NYYHCVO+CszjjoNU5EkxRuB6zo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390413; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uvXy6fMA3vnxysjVAMTnksBKZrrzhKQ3Qd/G/ALPoNY=; b=nv4hzb+99dZu1mVbLYY7QO70213QIXsOWvMqcG2EMF8BY+N0SCV7Syzgl/yRzwlj8/naEvBEXSL6NpipMVY13LbUSnxH+MwWLm5yTciVEIFMZKkJF+fT1KBtgzA3OsL1Xam962X3Wkd0oN9MfBR/tvoQ+/t2SCTL7yFLCSg2xj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390413247149.99406578366904; Thu, 26 Nov 2020 03:33:33 -0800 (PST) Received: from localhost ([::1]:59650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFWl-0005Mj-OC for importer@patchew.org; Thu, 26 Nov 2020 06:33:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFT6-0002zV-NB for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35237) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFT0-0006BL-5I for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:40 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-EyWBCdzdMgu3wMLMG3NB3w-1; Thu, 26 Nov 2020 06:29:33 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1FDD2100C662; Thu, 26 Nov 2020 11:29:32 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 96AC85D6AD; Thu, 26 Nov 2020 11:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvXy6fMA3vnxysjVAMTnksBKZrrzhKQ3Qd/G/ALPoNY=; b=cEI2VoR1MBbsBCyLXrEQQATmiLJtMOQ2wtYjgCcoA+D4vvvLNujrSKwRYM48iHZh7UB7LJ HadKHyOVueY+XHtrBp3KEDHdQtc6BaXomABAdCegohUZhykwzEeJNjbqbOln5tV3zDuFLG qN7Klc4A304nn45hDWZhSMsaRyrTGTo= X-MC-Unique: EyWBCdzdMgu3wMLMG3NB3w-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 01/13] compiler.h: replace QEMU_GNUC_PREREQ macro Date: Thu, 26 Nov 2020 15:29:03 +0400 Message-Id: <20201126112915.525285-2-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau Replace it with glib G_GNUC_CHECK_VERSION. Available since 2.42, the macro received a small correction in 2.55.1 (glib d44afbadda8a "macros: make G_GNUC_CHECK_VERSION() portable" which was apparently harmless). Signed-off-by: Marc-Andr=C3=A9 Lureau --- include/qemu/atomic.h | 2 +- include/qemu/compiler.h | 15 +++------------ scripts/cocci-macro-file.h | 1 - accel/tcg/cpu-exec.c | 2 +- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index c1d211a351..c409257c11 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -248,7 +248,7 @@ * 4.3 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D36793). */ #if defined(__i386__) || defined(__x86_64__) -#if !QEMU_GNUC_PREREQ(4, 4) +#if !G_GNUC_CHECK_VERSION(4, 4) #if defined __x86_64__ #define smp_mb() ({ asm volatile("mfence" ::: "memory"); (void)0; }) #else diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index c76281f354..cf044bab4a 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -7,21 +7,12 @@ #ifndef COMPILER_H #define COMPILER_H =20 +#include "glib-compat.h" + #if defined __clang_analyzer__ || defined __COVERITY__ #define QEMU_STATIC_ANALYSIS 1 #endif =20 -/*------------------------------------------------------------------------= ---- -| The macro QEMU_GNUC_PREREQ tests for minimum version of the GNU C compil= er. -| The code is a copy of SOFTFLOAT_GNUC_PREREQ, see softfloat-macros.h. -*-------------------------------------------------------------------------= ---*/ -#if defined(__GNUC__) && defined(__GNUC_MINOR__) -# define QEMU_GNUC_PREREQ(maj, min) \ - ((__GNUC__ << 16) + __GNUC_MINOR__ >=3D ((maj) << 16) + (min)) -#else -# define QEMU_GNUC_PREREQ(maj, min) 0 -#endif - #define QEMU_NORETURN __attribute__ ((__noreturn__)) =20 #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) @@ -104,7 +95,7 @@ sizeof(QEMU_BUILD_BUG_ON_STRUCT(x))) =20 #if defined __GNUC__ -# if !QEMU_GNUC_PREREQ(4, 4) +# if !G_GNUC_CHECK_VERSION(4, 4) /* gcc versions before 4.4.x don't support gnu_printf, so use printf. */ # define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m))) # else diff --git a/scripts/cocci-macro-file.h b/scripts/cocci-macro-file.h index c6bbc05ba3..20eea6b708 100644 --- a/scripts/cocci-macro-file.h +++ b/scripts/cocci-macro-file.h @@ -19,7 +19,6 @@ */ =20 /* From qemu/compiler.h */ -#define QEMU_GNUC_PREREQ(maj, min) 1 #define QEMU_NORETURN __attribute__ ((__noreturn__)) #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) #define QEMU_SENTINEL __attribute__((sentinel)) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 58aea605d8..21a46d2e85 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -724,7 +724,7 @@ int cpu_exec(CPUState *cpu) =20 /* prepare setjmp context for exception handling */ if (sigsetjmp(cpu->jmp_env, 0) !=3D 0) { -#if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6) +#if defined(__clang__) || !G_GNUC_CHECK_VERSION(4, 6) /* Some compilers wrongly smash all local variables after * siglongjmp. There were bug reports for gcc 4.5.0 and clang. * Reload essential local variables here for those compilers. --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390411; cv=none; d=zohomail.com; s=zohoarc; b=ACwxhP6t0Ks53sy96jvjeJP/D3ETXkjRENNxHjAT3JDLbxmf3o9S9dEOmGSGb7sa5ONKdZONTw2BYTb+HAiGtO3p5/tbwhxOMqwC2E8wls3QzrQlhf3XRTtXhex8QrXG9QEAetlV9ER7mUqkp+moyTN+t49q+Y1qa0CVfavVeMU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390411; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pamFUNJ2aY02RuGQt8qXkzT5bVlD8eZB3RBULf2jugo=; b=fzedxR35JMpn9f9R9dLuk+9MY/DfXljpqh+w2wutO4r+eJXKjkpslP4pe2RrqupqnR81wmRlhldTltGAgVtsoQn3abjaJC0q00VoyVNndwYffgpdSQTp9S53W9ouapBWzbwX1MKxJOt2ZiUXOPVLLCQdzdOGgF5BLXO4duRv2EQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390411634782.9178190732868; Thu, 26 Nov 2020 03:33:31 -0800 (PST) Received: from localhost ([::1]:59496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFWk-0005Hi-DT for importer@patchew.org; Thu, 26 Nov 2020 06:33:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFT8-0002zx-NG for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFT6-0006Db-FE for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:46 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-vhVUIS7ZNWiGMWNXX0ZZAQ-1; Thu, 26 Nov 2020 06:29:38 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E91F100C666; Thu, 26 Nov 2020 11:29:37 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 618C910023AD; Thu, 26 Nov 2020 11:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pamFUNJ2aY02RuGQt8qXkzT5bVlD8eZB3RBULf2jugo=; b=aaY0nJ/Bjq4K9r3lZE1HJQiyF8ssalPZTCjqGo0YVb08oHE0xotKvFjMcFj/Js0M+ZjsUW WoELy1ry5xdD96EinX3wSoLKuWXDeA9S6ni2R0OBNM3IFMGqgWJYD6Butjh8RkKz4SppBZ AwiLFeWTNoYhsJYHFXDlqGU9Semha/M= X-MC-Unique: vhVUIS7ZNWiGMWNXX0ZZAQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler Date: Thu, 26 Nov 2020 15:29:04 +0400 Message-Id: <20201126112915.525285-3-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. We can safely remove the special case introduced in commit a281ebc11a6 ("virtio: add missing mb() on notification"). With clang 3.8 (xenial amd64) __ATOMIC_RELAXED is defined, so the chunk to remove (which is x86-specific), isn't reached. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- include/qemu/atomic.h | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index c409257c11..8f4b3a80fb 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -241,23 +241,6 @@ =20 #else /* __ATOMIC_RELAXED */ =20 -/* - * We use GCC builtin if it's available, as that can use mfence on - * 32-bit as well, e.g. if built with -march=3Dpentium-m. However, on - * i386 the spec is buggy, and the implementation followed it until - * 4.3 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D36793). - */ -#if defined(__i386__) || defined(__x86_64__) -#if !G_GNUC_CHECK_VERSION(4, 4) -#if defined __x86_64__ -#define smp_mb() ({ asm volatile("mfence" ::: "memory"); (void)0; }) -#else -#define smp_mb() ({ asm volatile("lock; addl $0,0(%%esp) " ::: "memory"= ); (void)0; }) -#endif -#endif -#endif - - #ifdef __alpha__ #define smp_read_barrier_depends() asm volatile("mb":::"memory") #endif --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390561; cv=none; d=zohomail.com; s=zohoarc; b=MmSoN3lSvG+qwmyAFt/rK4dcXQ9fhbFwo2lLHehUjjZUcaKYWYKeOkpt9rtdnJi8GHgIhdeZi+wBkp+hJtqPSeqpkFdG+/m6ePk5bNDOcqMwCRLh5Ywk+RZw4ZgmhsM3ZDkYp+Sr3Z+5OWVresCzVH+G1ySFjJZMtFwoWB1mBJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yq72ZXsOrZi6bAKzAH/K2zyAAuHXa9g20zqwbghdyIo=; b=bGSVwMFzXRx+LLoEjZtFEnpvVXFGEOEVexmH147z9o84S9L5x7hLo/EONYnA8f3zI9NVtNKrDhl21e/Lm14xsbQGLAzUYdKoxzo9V4bvgokGTv13WyHfDuhdcqJJkCa9u6LeeHL8q3+7KBVOP9AKGIIF+O8y53vBaSMkTpw4NvA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390561826793.7886624711205; Thu, 26 Nov 2020 03:36:01 -0800 (PST) Received: from localhost ([::1]:39736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFZA-0000Uy-Oh for importer@patchew.org; Thu, 26 Nov 2020 06:36:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFTF-00031I-5f for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFT9-0006Eu-2U for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:29:52 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75-bcMAyPJ_Nj6wZ-wZFcz6vQ-1; Thu, 26 Nov 2020 06:29:44 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C94F81CBF5; Thu, 26 Nov 2020 11:29:43 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id E55495C1C2; Thu, 26 Nov 2020 11:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yq72ZXsOrZi6bAKzAH/K2zyAAuHXa9g20zqwbghdyIo=; b=GLPtuVHARgOWPQU43X9edu+GdPcaXsS2tmN6KrxwBcCDLaVwYkg2WAsyWXOxSlSKAlRZCl to2LaPIUqx3kaeZ4ITEhiWp5XnsqAtCOgtlqUgFl5hyNLEsqJH5D3lop65uNDkvC1OiniR hfF+NWel/Skja0r8aT6wPx7iTWK5e2g= X-MC-Unique: bcMAyPJ_Nj6wZ-wZFcz6vQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 03/13] accel/tcg: Remove special case for GCC < 4.6 Date: Thu, 26 Nov 2020 15:29:05 +0400 Message-Id: <20201126112915.525285-4-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8. We can safely remove the special case for GCC 4.6 introduced in commit 0448f5f8b81 ("cpu-exec: Fix compiler warning (-Werror=3Dclobbered)"). No change for Clang as we don't know. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau --- accel/tcg/cpu-exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 21a46d2e85..37a88edb6d 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -724,7 +724,7 @@ int cpu_exec(CPUState *cpu) =20 /* prepare setjmp context for exception handling */ if (sigsetjmp(cpu->jmp_env, 0) !=3D 0) { -#if defined(__clang__) || !G_GNUC_CHECK_VERSION(4, 6) +#if defined(__clang__) /* Some compilers wrongly smash all local variables after * siglongjmp. There were bug reports for gcc 4.5.0 and clang. * Reload essential local variables here for those compilers. --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390702; cv=none; d=zohomail.com; s=zohoarc; b=QtXE3iq7JrX/WaXbDLMf9rxtxlW6e1IhQEGaxogTpLY/gT+Xv1n4Q1VymW3PskrDPj3c385G65ObgCnR+QclyFFwCbmiYRNuxFAjd5A1i2vbkdaTLmyOMyjes0cIi1AbEVI7t2Ml6oEPxvEViC+o3b30a5GJUz0pq2I9zSsmiPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390702; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vppOc7As0ly3CbTnT2t7M9gbpVQR4ebgr3OXipwj2Vw=; b=Qe3RTGw1QT86ZPpYVW+AnQYGeYeE4SQrMCjGWxli1Z77NrM6m9gDFtOXhXhhJEcOLNCwjLVmOyrXvjxOrbJ500VAhl+V7N6D4vNJy32DRZa2Po1GaBYBi9VPHwnDMIxDCxeNOYd4lEOKqLyBYmOuaJlSXnkJyC4Pf878Lvx6Mr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390702679641.0745978017478; Thu, 26 Nov 2020 03:38:22 -0800 (PST) Received: from localhost ([::1]:48114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFbQ-0003sY-ME for importer@patchew.org; Thu, 26 Nov 2020 06:38:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFTQ-00035H-GH for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:39066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFTK-0006GA-H7 for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:04 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-Xrwrim4kO_eE5nUsEmfd5w-1; Thu, 26 Nov 2020 06:29:52 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AD01835B48; Thu, 26 Nov 2020 11:29:51 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5B8819C78; Thu, 26 Nov 2020 11:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vppOc7As0ly3CbTnT2t7M9gbpVQR4ebgr3OXipwj2Vw=; b=Jktik/pdvIfdzTbV54IED6GuZ4nXE3lrLNqAMLSl71bd3m3eXcA0gUf6uTKBKNUSf3IILs +P9HX785CgBq9SKPpX6x8JZUcUrGIRMCzwsnbhSxFpE2x1wOXofNvmcpfDs0yeo26QFmvj J2Pm+7F/RhluC/4PwQ+1Y9djd5sl/fA= X-MC-Unique: Xrwrim4kO_eE5nUsEmfd5w-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 04/13] compiler.h: remove GCC < 3 __builtin_expect fallback Date: Thu, 26 Nov 2020 15:29:06 +0400 Message-Id: <20201126112915.525285-5-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >=3D 4.8. (clang >=3D 3.8 advertizes itself as GCC >=3D 4.2 compatible) Signed-off-by: Marc-Andr=C3=A9 Lureau --- include/qemu/compiler.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index cf044bab4a..ae3e0df34c 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -35,10 +35,6 @@ #endif =20 #ifndef likely -#if __GNUC__ < 3 -#define __builtin_expect(x, n) (x) -#endif - #define likely(x) __builtin_expect(!!(x), 1) #define unlikely(x) __builtin_expect(!!(x), 0) #endif --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390890; cv=none; d=zohomail.com; s=zohoarc; b=AfksebL3OFUvX4R8AMcqRVZL248s8U6aW7dW1ieVlF4enr6gcitLYEFrLU1ZxLWInCk0xkcca4+tgxBOvmGJ2CxkjRKbRRbhzkgytuEqIeSJsPDfl7PudDJ2T5BtMgxEqUXF4cTLaEj3CEOcapoTiQ1mr5sKv2Y7Uf8SglH42I0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eVWbpz/51ynGh1k4+ZtIc1itvsguFX9OWEYfbfcFaI0=; b=CKPz/GlazvE7zilbLSMEKZKqMz/w/t4ZWvkEwQE7oluygB5GngknZ8Lg1XNw1jCV4Mn6UqHBfVty74wZp9z45AjgQjGNUqGDco+omgug/Xafmb3gcdShhUUitk01+xiYjK8XuzhWycEhtE8lwM0q8vG8v9gVXoj/zxdpjQkI3Hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390890913782.8909900222266; Thu, 26 Nov 2020 03:41:30 -0800 (PST) Received: from localhost ([::1]:53564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFeT-0006HB-NL for importer@patchew.org; Thu, 26 Nov 2020 06:41:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFTT-000366-Ne for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFTQ-0006Iw-7V for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-sKUy671INfWUwHLtgh69Xw-1; Thu, 26 Nov 2020 06:30:01 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 756C09CC17; Thu, 26 Nov 2020 11:29:59 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D4555D9C6; Thu, 26 Nov 2020 11:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eVWbpz/51ynGh1k4+ZtIc1itvsguFX9OWEYfbfcFaI0=; b=EbY+e+7xt7rrcahfYHT79EOJ+xYHf7O1elshxMPMnw9+iU99wtCWUloJVQVEIBtsxsrm6P HudPiIMB3RD2HCK3+kO9msK1jySsfyQO9IZ7JFAtPtIxS7xBuqFPswr3Jb2jpufe98Troj RTY0GfadZsOcdgenys+F9lDP+SdjSmc= X-MC-Unique: sKUy671INfWUwHLtgh69Xw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4 Date: Thu, 26 Nov 2020 15:29:07 +0400 Message-Id: <20201126112915.525285-6-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >=3D 4.8. (clang >=3D 3.8 advertizes itself as GCC >=3D 4.2 compatible) Signed-off-by: Marc-Andr=C3=A9 Lureau Acked-by: Alex Benn=C3=A9e --- include/qemu/qemu-plugin.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index bab8b0d4b3..5775e82c4e 100644 --- a/include/qemu/qemu-plugin.h +++ b/include/qemu/qemu-plugin.h @@ -28,13 +28,8 @@ #endif #define QEMU_PLUGIN_LOCAL #else - #if __GNUC__ >=3D 4 - #define QEMU_PLUGIN_EXPORT __attribute__((visibility("default"))) - #define QEMU_PLUGIN_LOCAL __attribute__((visibility("hidden"))) - #else - #define QEMU_PLUGIN_EXPORT - #define QEMU_PLUGIN_LOCAL - #endif + #define QEMU_PLUGIN_EXPORT __attribute__((visibility("default"))) + #define QEMU_PLUGIN_LOCAL __attribute__((visibility("hidden"))) #endif =20 typedef uint64_t qemu_plugin_id_t; --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606391042; cv=none; d=zohomail.com; s=zohoarc; b=gYASB+dYuwtGGuLKPBUxoCi5lOT79/me0POBJDOJT+Ru9uRPrDFlZYMu/LnU7sYE4e1tlYNHdefR6SvgVBFYssxx4SU8H1DuWDxaiKaOSca9mY7nKHcaD1bvZg3rcFPPaxqie5MBvQ18DlYLFjTxLDwjQVIUOdoaYQ5xWnjUHO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606391042; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XSQt7vWtFj7RLJo/oMCLyt2nMum6CuqjIroq4/xTxMQ=; b=Kyq249MSHpSBd80qnMpWDdVJn01OkP7yDBUwc3Hzu1qc70E78c/9FEhLc0pIwVAYzMUwJt0tlySu0sh5GxQLg+I7bCcvQdrU5IcWa4W1YB3+WGCKv2j/617IA4HUgpIi4k4v9TrmIp0qL9l0F/iRlMIxybSokFDDBfnNKyMgfXo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606391042070216.18042303887114; Thu, 26 Nov 2020 03:44:02 -0800 (PST) Received: from localhost ([::1]:57942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFgu-00087r-O9 for importer@patchew.org; Thu, 26 Nov 2020 06:44:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFTa-0003Bp-UN for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49121) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFTV-0006L5-K0 for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:14 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-3iZZu_i5NuWNc7aPKfcMmw-1; Thu, 26 Nov 2020 06:30:05 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EEB049CC03; Thu, 26 Nov 2020 11:30:04 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD8E41C936; Thu, 26 Nov 2020 11:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XSQt7vWtFj7RLJo/oMCLyt2nMum6CuqjIroq4/xTxMQ=; b=fHf1W5tQiq0RCf0hCCr1FzGIcYU3NuxWzu8eOtIBXpKvvpolDMhAwkwnv+3GD1SkGLgK66 3E7YzWG9kaNReYxUxG+S9T77OPfYdxm5VXLqajKbI3TB61awtjYNbB0GA6pWhhymKVD0ep XLc4TGaycKKJa8L5Cl592taTOYBn7/0= X-MC-Unique: 3iZZu_i5NuWNc7aPKfcMmw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 06/13] tests: remove GCC < 4 fallbacks Date: Thu, 26 Nov 2020 15:29:08 +0400 Message-Id: <20201126112915.525285-7-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >=3D 4.8. (clang >=3D 3.8 advertizes itself as GCC >=3D 4.2 compatible) Signed-off-by: Marc-Andr=C3=A9 Lureau Acked-by: Alex Benn=C3=A9e Reviewed-by: Peter Maydell --- tests/tcg/arm/fcvt.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c index 617626bc63..7ac47b564e 100644 --- a/tests/tcg/arm/fcvt.c +++ b/tests/tcg/arm/fcvt.c @@ -73,11 +73,9 @@ static void print_int64(int i, int64_t num) =20 #ifndef SNANF /* Signaling NaN macros, if supported. */ -# if __GNUC_PREREQ(3, 3) -# define SNANF (__builtin_nansf ("")) -# define SNAN (__builtin_nans ("")) -# define SNANL (__builtin_nansl ("")) -# endif +# define SNANF (__builtin_nansf ("")) +# define SNAN (__builtin_nans ("")) +# define SNANL (__builtin_nansl ("")) #endif =20 float single_numbers[] =3D { -SNANF, --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390563; cv=none; d=zohomail.com; s=zohoarc; b=UQH5kD0gb+PK1siFVyHbrsR35zbDE6mMUdlGtzSW44FL4eK3OfOb5CXCrASy5ORgLZrn7+VM6G7ECaBOlt2+XGrP5uOw3bbUk/CLNq6JGjuW+mpEMzW6BoIXBL9Y1PQ+laCnbfVxnDonRDOHCz8uVmulhGm/ROYNwHWUILqu9f8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390563; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iHYSa9kEpwoKzIqL0kHciIz6Aw/ueVjJb1/YiLOQ2lU=; b=HpdQ9E+sV8SDt0m236uDm/KrYale9aiwpIktK4eyJOrgGeTJD6SZxEcEaXRyx+D6Y4bGyqls5zQPfdvIv6G8S6waLgy8gu3TXPF6mWrg1IGq6R7AjlCfJuMCUeTcDrRh94gPoLI6PBbgeCktZIef3w+St3cUFQllkOuGYNv2aBc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390563754878.716840179799; Thu, 26 Nov 2020 03:36:03 -0800 (PST) Received: from localhost ([::1]:39954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFZC-0000aG-Km for importer@patchew.org; Thu, 26 Nov 2020 06:36:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFTh-0003NO-E6 for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFTf-0006Qg-Hl for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:21 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-coOtc-lROBCOtl73WNzlYA-1; Thu, 26 Nov 2020 06:30:14 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 962B78049C1; Thu, 26 Nov 2020 11:30:13 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A33560C6A; Thu, 26 Nov 2020 11:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iHYSa9kEpwoKzIqL0kHciIz6Aw/ueVjJb1/YiLOQ2lU=; b=P6hV7tyW1K0RJBDxk+z2UCc/9Ka7AD5iUv9vjFUTlKTldlDcLp+ahL2YaKfJCd8B/tV7lb MJsox2+wC7U6kJnc573GOeFyNJ/U9fx5EmMX86ry9YVJ7eHOgvZr2WqpptGVz+ZV9X5EHF A+d6HvY0AEJ6avE+0bUlrD3ARBXv5do= X-MC-Unique: coOtc-lROBCOtl73WNzlYA-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 07/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON Date: Thu, 26 Nov 2020 15:29:09 +0400 Message-Id: <20201126112915.525285-8-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau This allows to get rid of a check for older GCC version (which was a bit bogus too since it was falling back on c++ version..) Signed-off-by: Marc-Andr=C3=A9 Lureau --- tools/virtiofsd/fuse_common.h | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tools/virtiofsd/fuse_common.h b/tools/virtiofsd/fuse_common.h index 5aee5193eb..a2484060b6 100644 --- a/tools/virtiofsd/fuse_common.h +++ b/tools/virtiofsd/fuse_common.h @@ -809,15 +809,6 @@ void fuse_remove_signal_handlers(struct fuse_session *= se); * * On 32bit systems please add -D_FILE_OFFSET_BITS=3D64 to your compile fl= ags! */ - -#if defined(__GNUC__) && \ - (__GNUC__ > 4 || __GNUC__ =3D=3D 4 && __GNUC_MINOR__ >=3D 6) && \ - !defined __cplusplus -_Static_assert(sizeof(off_t) =3D=3D 8, "fuse: off_t must be 64bit"); -#else -struct _fuse_off_t_must_be_64bit_dummy_struct { - unsigned _fuse_off_t_must_be_64bit:((sizeof(off_t) =3D=3D 8) ? 1 : -1); -}; -#endif +QEMU_BUILD_BUG_ON(sizeof(off_t) !=3D 8); =20 #endif /* FUSE_COMMON_H_ */ --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390546; cv=none; d=zohomail.com; s=zohoarc; b=Vl0k1TF3ykBx/SYcPGqRlUno0mxMRnM4bYh7RxVxVBNTc6OIlvDJRw2lWjh3UYJoVPunCFvkRTkKNYkk824adtx74+whUNdfREkZxsUAHZCW3voNf2lwvNir8k3Hw3D9PNKm8TdwkZmwVubbleuP41a23oEDZ8c0tmqo4W950qA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390546; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G3iS5tbgAUt5o638Uwh1tdG52FZYERASa/j3DWExxFQ=; b=JK0IAD72TkR1+cBhuqXsrGHAJEcxILEvFjI/KFmXmOUopNeIZLy1F7SbbQ8w+Y/6PW0R6ebSdJtJ7uvaIoIXDI1vXrfdzK1VGDkoECXHB+z/7lPFVDUDczjsYpdY7U/aD/MQMJ+RgsOM00geoKl7ifknofNLVEVP4fsdt/4t1Y4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390546755713.8399740828355; Thu, 26 Nov 2020 03:35:46 -0800 (PST) Received: from localhost ([::1]:38242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFYv-0008E8-H8 for importer@patchew.org; Thu, 26 Nov 2020 06:35:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFTo-0003Zh-7U for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFTm-0006V7-Fx for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:27 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-yzFydN8jNiugVDmObzPiqg-1; Thu, 26 Nov 2020 06:30:23 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C253100C66C; Thu, 26 Nov 2020 11:30:22 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB1BE1002391; Thu, 26 Nov 2020 11:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G3iS5tbgAUt5o638Uwh1tdG52FZYERASa/j3DWExxFQ=; b=KjzPPTEgdNUNrn+ZGdUyRK6v11PnY+zARdO0KPY3rGw4tFavenPulqNhCbsCCTwLyuQrwF f8c899lR+OiEmYWJkp++L9LhIY7vLTXf7xiG/FDdF2CrfcUw6FixZN7jDNuTlThtBFyKoc b86i++0b9atkOX+pST6t185jjErapTc= X-MC-Unique: yzFydN8jNiugVDmObzPiqg-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 08/13] compiler.h: explicit case for Clang printf attribute Date: Thu, 26 Nov 2020 15:29:10 +0400 Message-Id: <20201126112915.525285-9-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >=3D 4.8, we could thus drop earlier version checks. Except clang advertizes itself as GCC 4.2.1. Since clang doesn't support gnu_printf, make that case explicitely and drop GCC version check. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- include/qemu/compiler.h | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index ae3e0df34c..108bfdb391 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -90,18 +90,16 @@ #define QEMU_BUILD_BUG_ON_ZERO(x) (sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)) - \ sizeof(QEMU_BUILD_BUG_ON_STRUCT(x))) =20 -#if defined __GNUC__ -# if !G_GNUC_CHECK_VERSION(4, 4) - /* gcc versions before 4.4.x don't support gnu_printf, so use printf. */ -# define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m))) -# else - /* Use gnu_printf when supported (qemu uses standard format strings). */ -# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) -# if defined(_WIN32) - /* Map __printf__ to __gnu_printf__ because we want standard format st= rings - * even when MinGW or GLib include files use __printf__. */ -# define __printf__ __gnu_printf__ -# endif +#if defined(__clang__) + /* clang doesn't support gnu_printf, so use printf. */ +# define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m))) +#elif defined(__GNUC__) + /* Use gnu_printf (qemu uses standard format strings). */ +# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) +# if defined(_WIN32) + /* Map __printf__ to __gnu_printf__ because we want standard format str= ings + * even when MinGW or GLib include files use __printf__. */ +# define __printf__ __gnu_printf__ # endif #else #define GCC_FMT_ATTR(n, m) --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390689; cv=none; d=zohomail.com; s=zohoarc; b=d4ORnEeY8f7XnSmuxwl1/M5KF1c97BuSiext7yMW7OKmB2py92rU/jxOIxdlhd473tKsis4HZUSAPWvGX1oSVUj1OScyZHcQCXRc/ambabHLN2UlmwlIjk6TjYQSgPkT32+YlyzzNUmapK3a5ywtN4Oe3kHLYZUlAeUmOXJ61yA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390689; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nM2YOWlL4oKxjru1lmnZu7dVtPS06ZweI/bTapfx3O4=; b=a0LryyMPq2FFA5C2/+AOlPkkwwGOG/BDYqZZm3zFO7iCFZVAPXp0M9ULOBSrRNmMkgv1V3bFLa/Q29mVw4PDOC7eWSHgsixTSE90dSXZWu2JY8yXPIRrcIu1FujxrYLDyY9a9x0Ct3vKLUb2mRsOjmWydJyYVEJYW1c/UMdqYAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390689907748.5975592604584; Thu, 26 Nov 2020 03:38:09 -0800 (PST) Received: from localhost ([::1]:47784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFbE-0003kL-Mi for importer@patchew.org; Thu, 26 Nov 2020 06:38:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFTv-0003kJ-Ow for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFTs-0006XE-Fk for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:35 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-WJLo0Jd-NR2c4b9I2Xgi-g-1; Thu, 26 Nov 2020 06:30:29 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 983A0190A7A0; Thu, 26 Nov 2020 11:30:28 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C95E1001E73; Thu, 26 Nov 2020 11:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nM2YOWlL4oKxjru1lmnZu7dVtPS06ZweI/bTapfx3O4=; b=PsS+EWdvA+R9kVtnNopbghS+103obClxaMHd9uJJzKHB+UPT1yv34vJ0UqZhToSe6rF/n/ 8D8jCt1b2TRdisiSqCGplF4nkgznu8Y2FmOrE53jxt3Eyb884pjyz1d3dyPfb0kV0pDMIm 4W0l96c22THfUS0/PyP0wN2NAuOIgVE= X-MC-Unique: WJLo0Jd-NR2c4b9I2Xgi-g-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 09/13] audio: remove GNUC & MSVC check Date: Thu, 26 Nov 2020 15:29:11 +0400 Message-Id: <20201126112915.525285-10-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau QEMU requires either GCC or Clang, which both advertize __GNUC__. Drop MSVC fallback path. Signed-off-by: Marc-Andr=C3=A9 Lureau --- audio/audio.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 46578e4a58..d7a00294de 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -122,13 +122,7 @@ int audio_bug (const char *funcname, int cond) =20 #if defined AUDIO_BREAKPOINT_ON_BUG # if defined HOST_I386 -# if defined __GNUC__ - __asm__ ("int3"); -# elif defined _MSC_VER - _asm _emit 0xcc; -# else - abort (); -# endif + __asm__ ("int3"); # else abort (); # endif --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606391195; cv=none; d=zohomail.com; s=zohoarc; b=LAh25UsFIvEh5ASj/mTsBgHiAeFuiOY1XApDDZeXwBx7Q8mbNLPPxKfRj+P3GNH57Dh6/GPTMylWuDk16HCtu3Zl8s4s3wyBf6a3C7trALaPePci0d7S7kO8GD924kC8VTrAI1q+SFHbVPqq+twhuUJLOlCZ9jiTqRR0IwuoFxo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606391195; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bJfxR8iE/ekObIgENFS5uk+Teh5Zrfon3J6p5gZpF/M=; b=Qc97d/ZwhOlzDRxoKtboQwXhbkKxFsa/fK/QqNR471SRZQX4jtPNuj3Spetdvvb8r81kJ0D9n+Xmjb52inleICa0POwmlXBW7js1JFfIsacabCDlFNzN8ZsKNj8/4xudkp/vLlo1fbVdzcRNiCIzudi9eYXjUs9HPzF5HOsC9uQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606391195135232.49233840659406; Thu, 26 Nov 2020 03:46:35 -0800 (PST) Received: from localhost ([::1]:34192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFjN-0001j7-Jp for importer@patchew.org; Thu, 26 Nov 2020 06:46:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFU3-00041y-7e for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFU1-0006aj-Cy for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:42 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-elP0U3LnOjGFkd5z20UEgQ-1; Thu, 26 Nov 2020 06:30:38 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5FFCE100C662; Thu, 26 Nov 2020 11:30:37 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id E452860C05; Thu, 26 Nov 2020 11:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJfxR8iE/ekObIgENFS5uk+Teh5Zrfon3J6p5gZpF/M=; b=R3zxoY+BrPk2ahofi4pFRGiRlLrOA4vIaIIYdDnj4xve4tq145F22RJqSxrIP7JQ8b7++B Qc620Bb8DDkJ8muHIny852ouRKkIwA6nqf7EB14SaoDIOpcyaaUzaHU0l3nKE8DubqOsBR OeSPWYblUMLRHHlYMFDMTkt8R/0PcIE= X-MC-Unique: elP0U3LnOjGFkd5z20UEgQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 10/13] poison: remove GNUC check Date: Thu, 26 Nov 2020 15:29:12 +0400 Message-Id: <20201126112915.525285-11-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- include/exec/poison.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/poison.h b/include/exec/poison.h index 7b9ac361dc..d7ae1f23e7 100644 --- a/include/exec/poison.h +++ b/include/exec/poison.h @@ -3,7 +3,6 @@ =20 #ifndef HW_POISON_H #define HW_POISON_H -#ifdef __GNUC__ =20 #pragma GCC poison TARGET_I386 #pragma GCC poison TARGET_X86_64 @@ -93,4 +92,3 @@ #pragma GCC poison CONFIG_SOFTMMU =20 #endif -#endif --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606391342; cv=none; d=zohomail.com; s=zohoarc; b=f5FlpDHa0/3uY1fluiWr8UAE4jajXOcjVAS4EYjOZdLFgGWRhrVRgr5ayJckPZtka2YSL6C/VStWlnCyozLQAVFKbJuts2EZbsipvDB+Xqf4ch5F9h7QLe28ozfXl+1seYMUVe/WaQ41HMibSdfvDNedMxtmz0s/+7oTuqKDbVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606391342; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Anas+Ip5rfAmmLWsIrmXzri9ludYH3kXDTxP+SHHB58=; b=JVo+GbpDKoG2CCfr/+oZMUP0Z/j2+vtnpCq41nFIMePN2mO+ez0UnsGZPwThu28JhqKcgIG/RKAJ1scDj5tIOP+oHIE2suPhX5M01WIbuQtLWzfqqZJhJPpso7dRI9K1EfjZogdRn+ktduBIXxzLFg+WbaKjab7yR3tLjLA2EL4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606391342871272.01045721610024; Thu, 26 Nov 2020 03:49:02 -0800 (PST) Received: from localhost ([::1]:38882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFll-0003hO-Q0 for importer@patchew.org; Thu, 26 Nov 2020 06:49:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFU9-0004Ei-Qu for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFU8-0006d8-1X for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:49 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-8WVdMjZnOIuIzwAUrB7xNw-1; Thu, 26 Nov 2020 06:30:43 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 573DA100D684; Thu, 26 Nov 2020 11:30:42 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A00D5D9C6; Thu, 26 Nov 2020 11:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Anas+Ip5rfAmmLWsIrmXzri9ludYH3kXDTxP+SHHB58=; b=iQkr9UyOHUYU7enspdz6x6eIBXqRrS/E7zquF4dcdiGXzE+4I9KfIq7ed0iJjRcryYSQp9 yskXcEJR96/FGl/8NvVd3dp4aJRMMix5EgdZ1iONsS8i+gg4jzsHYu7P/PMz0ScVGBfAOY 3qPd7u84C7r/6XEBacW6w8sIvzAZkjg= X-MC-Unique: 8WVdMjZnOIuIzwAUrB7xNw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 11/13] xen: remove GNUC check Date: Thu, 26 Nov 2020 15:29:13 +0400 Message-Id: <20201126112915.525285-12-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions Signed-off-by: Marc-Andr=C3=A9 Lureau --- include/hw/xen/interface/io/ring.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/include/hw/xen/interface/io/ring.h b/include/hw/xen/interface/= io/ring.h index 5d048b335c..115705f3f4 100644 --- a/include/hw/xen/interface/io/ring.h +++ b/include/hw/xen/interface/io/ring.h @@ -206,21 +206,12 @@ typedef struct __name##_back_ring __name##_back_ring_t #define RING_HAS_UNCONSUMED_RESPONSES(_r) \ ((_r)->sring->rsp_prod - (_r)->rsp_cons) =20 -#ifdef __GNUC__ #define RING_HAS_UNCONSUMED_REQUESTS(_r) ({ \ unsigned int req =3D (_r)->sring->req_prod - (_r)->req_cons; \ unsigned int rsp =3D RING_SIZE(_r) - \ ((_r)->req_cons - (_r)->rsp_prod_pvt); \ req < rsp ? req : rsp; \ }) -#else -/* Same as above, but without the nice GCC ({ ... }) syntax. */ -#define RING_HAS_UNCONSUMED_REQUESTS(_r) \ - ((((_r)->sring->req_prod - (_r)->req_cons) < \ - (RING_SIZE(_r) - ((_r)->req_cons - (_r)->rsp_prod_pvt))) ? \ - ((_r)->sring->req_prod - (_r)->req_cons) : \ - (RING_SIZE(_r) - ((_r)->req_cons - (_r)->rsp_prod_pvt))) -#endif =20 /* Direct access to individual ring elements, by index. */ #define RING_GET_REQUEST(_r, _idx) \ --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606390666; cv=none; d=zohomail.com; s=zohoarc; b=RN3L0Da8h2A5A4SudiLfI3VFndpbS+xH06Zk9crq2xOe8C9XSKsjJfc8FlwsdeJ0lozvArdia3t2ZUDDXrDUY98z+f/Fo7hAw9I9BsV8m9Q9BypcqGvNECTRH/x29hDzsSr732RHAC0Cb0Ri/mQmdW6h6p9esCaOXDtcko5z4cA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606390666; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HUbagllB6aSqe2toADC1Gstjc1ag32tbrFS/wjOOmXo=; b=QozYczPdw2k8X0EZ4QMjjq7BPhoI1ez4JEcmnwSnNNm5TYX+sTkv6ZyGKsHHTU1EJ9cowqdeQX5uQRkE7tkrZUh1aHzKRijgDI6UscQ7B1jXr7lUE5oilOYfMsDShGIQc0GxY71Z5EbBNZpiKDo0zXnYEXtl1mrIsFuvWEpnj0E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606390666856174.51731501467634; Thu, 26 Nov 2020 03:37:46 -0800 (PST) Received: from localhost ([::1]:46810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFar-0003M3-OR for importer@patchew.org; Thu, 26 Nov 2020 06:37:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFUG-0004Si-Sc for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:28330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFUF-0006fF-1S for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:30:56 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-562-HjYbacLzP9ar5Cf4OD7p6g-1; Thu, 26 Nov 2020 06:30:52 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD76A100F772; Thu, 26 Nov 2020 11:30:50 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 681565C1BD; Thu, 26 Nov 2020 11:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HUbagllB6aSqe2toADC1Gstjc1ag32tbrFS/wjOOmXo=; b=MucZnb9tu1YPP9zAhfrf5IEGavMntDHKdG5Kx5+A0IRuPXp21lOq6neZGFaBukDH/m9wjl N3fDydanH35eH9xON+ouQFpvWleCgcpfWlY/gElYNrxPfDPnlBrUWqhCfSJcWK4fFpoCjy bAbr7TbHVVSQVYG53gYOAIkoLU2IEx8= X-MC-Unique: HjYbacLzP9ar5Cf4OD7p6g-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 12/13] compiler: remove GNUC check Date: Thu, 26 Nov 2020 15:29:14 +0400 Message-Id: <20201126112915.525285-13-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions. Signed-off-by: Marc-Andr=C3=A9 Lureau --- include/qemu/compiler.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 108bfdb391..f492baf341 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -55,14 +55,10 @@ (offsetof(container, field) + sizeof_field(container, field)) =20 /* Convert from a base type to a parent type, with compile time checking. = */ -#ifdef __GNUC__ #define DO_UPCAST(type, field, dev) ( __extension__ ( { \ char __attribute__((unused)) offset_must_be_zero[ \ -offsetof(type, field)]; \ container_of(dev, type, field);})) -#else -#define DO_UPCAST(type, field, dev) container_of(dev, type, field) -#endif =20 #define typeof_field(type, field) typeof(((type *)0)->field) #define type_check(t1,t2) ((t1*)0 - (t2*)0) @@ -93,7 +89,7 @@ #if defined(__clang__) /* clang doesn't support gnu_printf, so use printf. */ # define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m))) -#elif defined(__GNUC__) +#else /* Use gnu_printf (qemu uses standard format strings). */ # define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) # if defined(_WIN32) @@ -101,8 +97,6 @@ * even when MinGW or GLib include files use __printf__. */ # define __printf__ __gnu_printf__ # endif -#else -#define GCC_FMT_ATTR(n, m) #endif =20 #ifndef __has_warning --=20 2.29.0 From nobody Tue May 7 13:54:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606391523; cv=none; d=zohomail.com; s=zohoarc; b=F91szyuVo1Zyi0uJ14YuOIvyd3tD3g2Vifk0v8BgU8GU4olMPZ40ek3IJ3+frcaUomo/VLZQJWdjmTmAnVlVKkolIVxQumo+GkIqapBhUcBDAhWwh2g5ilHEvp20kEaKKA78nWY5P35C38bsU6ky/CWS+wnzrcqlFBpjlvy0nGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606391523; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UTevGdfibyme3XURRVx8yzU7J+hfx+OKI5/cvGjuQhY=; b=Zj9QvnyIjZyf10fy+suB8aM6BrvWOjUkU/atLffWlKqHJrdWD3pWPVSmCB2JHuHh71gM3x0wVYRFjTI3nAn4njg01yHtmXRMPzHAlViZz5BcBgwD6qAKvR3toyTW5HIqpj5fJ2XKj/3xUj380AV5ykTtD1cyXQ6AmRX1BqEcQGU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606391523435469.46723566472576; Thu, 26 Nov 2020 03:52:03 -0800 (PST) Received: from localhost ([::1]:44864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiFog-0006It-7i for importer@patchew.org; Thu, 26 Nov 2020 06:52:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiFUR-0004ae-6T for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:31:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:27685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiFUN-0006lz-Ng for qemu-devel@nongnu.org; Thu, 26 Nov 2020 06:31:06 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-NWNXdqDwOpO4ey4uRz-1wQ-1; Thu, 26 Nov 2020 06:31:00 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 771AF100F340; Thu, 26 Nov 2020 11:30:59 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3451E60BFA; Thu, 26 Nov 2020 11:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606390262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UTevGdfibyme3XURRVx8yzU7J+hfx+OKI5/cvGjuQhY=; b=ivZRUrkudf3ROHHvPrjupkqJi+mGdTEkrqXvSYeLrxjcJJKvE+Clea+YAEddntsocodJ+g jWrsqZmfeVWUGuIrE8X6HThcXypHaf3DRrdMVT/zp4jBGI2Wjn54sWwneyqZaKUSQslYEl dn2hEgkJbn0Fa1ArEkfAg4gl6oggLOU= X-MC-Unique: NWNXdqDwOpO4ey4uRz-1wQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v2 13/13] linux-user: remove GNUC check Date: Thu, 26 Nov 2020 15:29:15 +0400 Message-Id: <20201126112915.525285-14-marcandre.lureau@redhat.com> In-Reply-To: <20201126112915.525285-1-marcandre.lureau@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , philmd@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- linux-user/strace.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 11fea14fba..e00275fcb5 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -24,7 +24,6 @@ struct syscallname { abi_long, abi_long, abi_long); }; =20 -#ifdef __GNUC__ /* * It is possible that target doesn't have syscall that uses * following flags but we don't want the compiler to warn @@ -32,9 +31,6 @@ struct syscallname { * functions. It is ok to keep them while not used. */ #define UNUSED __attribute__ ((unused)) -#else -#define UNUSED -#endif =20 /* * Structure used to translate flag values into strings. This is --=20 2.29.0