From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277315; cv=none; d=zohomail.com; s=zohoarc; b=oG82p4bTKZlAKDJIVGWGS9syH5w0mhMjdcessOS6g6mlf9EGpdJESBvog9PWKOoW0Qoisq+wrJD31acgeEi5TamGff2V5uaNHw84xIMMxQLb64vnqZNRVNFoayY7pkUnAvT51s8ThRKzOXPEMJ9oMno1TceP94piJVq3rmTwtog= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277315; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nu/Ovkj+6UMFJbUMB5ay1PUB81CaPlCNyUgEjjeQxrc=; b=iNMCAn1I4LBQVrBS+UKCL6N37NxaTg08KiWqT3rU4drKm0XpAObKmGEKzmtjLkwUY4Vv6Fjkm2tLQxfLerBTtY8Zx+UOO9HQFDwg4Eg1OffoK5NQBt9Q/ILjRMmHlbX6Pj2/CclnT3pfCkPDZ8oh3Tv3aqz2JDdrOKSKY2ACdes= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277315552798.3258333349272; Tue, 24 Nov 2020 20:08:35 -0800 (PST) Received: from localhost ([::1]:48182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khm6c-0006QO-8a for importer@patchew.org; Tue, 24 Nov 2020 23:08:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm4v-0004fA-W5 for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:50 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:33076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm4u-00060n-9R for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:49 -0500 Received: by mail-pg1-x541.google.com with SMTP id 81so1218822pgf.0 for ; Tue, 24 Nov 2020 20:06:47 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nu/Ovkj+6UMFJbUMB5ay1PUB81CaPlCNyUgEjjeQxrc=; b=AKEyKHrJslwxk/lcm9Q9s77PG0gmeaWgvdWkQD3YenuURG8qC+p+BffZbgnDgKX582 EG+iK++2sVR+LMp0/l9RY10u/eHGsc7RdIIFWCsjL5vdiicHfz6aQiI2BHYM1WspI4xb QjCYzS1eURaqZ0XyoOTCqoRPU81pctycyrifMRnjB3z7SdPJe1ga8WZExbBGT5sprnfY eIl38jh5BtrBJ0OA46rjXLvHKzdElawTWFjQXC8BCviPOEi8kROVd09+mlDDEfL4Y7CX B4tYnyaLmUarvQjfyeJEpGfLbu9PVyLmHZXYJ7ITJCGykE1YAcDSWM3fsWFtYAqWx3rm nhkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nu/Ovkj+6UMFJbUMB5ay1PUB81CaPlCNyUgEjjeQxrc=; b=pPRdHLhui83E5mIZzeRWDft39rxrZK+ZxVpDesontU02joBG7TrLjFnWj08do/hmq+ V6p2cYySyR2HT00emtDktwsiMusG9aPb8jZNujLdSrEdk3z4Z2oS65Ez6LM7HRsIyGJU LFhxWcYJ0s0Azyj4OFN3jaBlIsZcM4C+wRH8IA1L54gF0WVmKbwEi+m+ZID/AQtVvW7D /nuvNxqyV8d2Aq6A25337bV0n2EifN1hPaEtzb817EXNRh0XnLaBhtf7VSzJLF3ux2L0 7oEjByqtLRlrKJzpeFWXw4U8w53itNEpg3J7OuSpPURsE1qh8a2cCCIJZ3CEGlL2ojjG NtjQ== X-Gm-Message-State: AOAM531/sr+O5jyi+NN/71h4NE+sHpWQ48snQcSNwCf1cpAf7Z/Ni12y dIJ8/P5jU4C7vDMLrrdSZ9kn8fSDxL8u6Q== X-Google-Smtp-Source: ABdhPJzenlruFW3fiTaLsvcQeMEWw5lyBCOpLVf1z4C8pNVvakNOGdXgzdtGDSPYa5Yb+zTptjVoqA== X-Received: by 2002:a17:90a:fe0e:: with SMTP id ck14mr1773081pjb.80.1606277206639; Tue, 24 Nov 2020 20:06:46 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 01/11] target/arm: Enforce word alignment for LDRD/STRD Date: Tue, 24 Nov 2020 20:06:32 -0800 Message-Id: <20201125040642.2339476-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::541; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x541.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 6d04ca3a8a..17883d00f4 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6458,7 +6458,7 @@ static bool trans_LDRD_rr(DisasContext *s, arg_ldst_r= r *a) addr =3D op_addr_rr_pre(s, a); =20 tmp =3D tcg_temp_new_i32(); - gen_aa32_ld_i32(s, tmp, addr, mem_idx, MO_UL | s->be_data); + gen_aa32_ld_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN_4 | s->be_data= ); store_reg(s, a->rt, tmp); =20 tcg_gen_addi_i32(addr, addr, 4); @@ -6487,7 +6487,7 @@ static bool trans_STRD_rr(DisasContext *s, arg_ldst_r= r *a) addr =3D op_addr_rr_pre(s, a); =20 tmp =3D load_reg(s, a->rt); - gen_aa32_st_i32(s, tmp, addr, mem_idx, MO_UL | s->be_data); + gen_aa32_st_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN_4 | s->be_data= ); tcg_temp_free_i32(tmp); =20 tcg_gen_addi_i32(addr, addr, 4); @@ -6595,7 +6595,7 @@ static bool op_ldrd_ri(DisasContext *s, arg_ldst_ri *= a, int rt2) addr =3D op_addr_ri_pre(s, a); =20 tmp =3D tcg_temp_new_i32(); - gen_aa32_ld_i32(s, tmp, addr, mem_idx, MO_UL | s->be_data); + gen_aa32_ld_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN_4 | s->be_data= ); store_reg(s, a->rt, tmp); =20 tcg_gen_addi_i32(addr, addr, 4); @@ -6634,7 +6634,7 @@ static bool op_strd_ri(DisasContext *s, arg_ldst_ri *= a, int rt2) addr =3D op_addr_ri_pre(s, a); =20 tmp =3D load_reg(s, a->rt); - gen_aa32_st_i32(s, tmp, addr, mem_idx, MO_UL | s->be_data); + gen_aa32_st_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN_4 | s->be_data= ); tcg_temp_free_i32(tmp); =20 tcg_gen_addi_i32(addr, addr, 4); --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277439; cv=none; d=zohomail.com; s=zohoarc; b=npgUa7CxNZsc4AqOWco1vpKbRG+TZ9fd8LIqEhBbPNlOLuXvwycH5F528xYAWXp47b05Ru0RR2mvc36WYCshvNdG4X68jM0wAJCI9wdeb1j4UvNgQYPmBxvnyGFIbJy9VUiP7gMVI3qxHP7OABjdXcGPToFNXIzHw02HZk7oIzo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277439; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dUvIZnJazJaOEZboAW1OJSDBnVf8XIUz/RaJk/SSM4M=; b=mA7phe410RBkROazAfnLxRD+5rrN81WFPI9haec2pGOlQB4mT12nIpTwAbLP3Jwt7+jd3m2jHgoC3cgrFFM1GeRci1n+5fUTXcFeYb6/6R1WxZMzNGOxnumktGUC55ZyHsUvB6Xr0nLA1tzS+wVhWGRWWTne+x8E9OM3PAhvDGg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277439138176.55849280437326; Tue, 24 Nov 2020 20:10:39 -0800 (PST) Received: from localhost ([::1]:56700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khm8c-0001T1-0T for importer@patchew.org; Tue, 24 Nov 2020 23:10:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm4w-0004gN-Sc for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:50 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:34484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm4v-00061p-Dg for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:50 -0500 Received: by mail-pl1-x641.google.com with SMTP id l11so464441plt.1 for ; Tue, 24 Nov 2020 20:06:49 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dUvIZnJazJaOEZboAW1OJSDBnVf8XIUz/RaJk/SSM4M=; b=gKo6nG+2jXZE3ogTrnzyGe3McgptHnSF8F6CBBoMM2Q1cJxRZP3ua3mgjowIt5vE0k 6/P+GHygWDH8cuUMEizCIhUO+NAGIEdLWg5j9m3fZE+8DXpLtvMpTRnqTOOvZj5F/5du kY6L/SlyQUevSvHLir/mAQSfl8ImPXj+jQ9EYnBVWKgyX5HDxj9MQp2hUoZ7ILfFNS1C vg2y0LoVj5dEC9I/fp3r0wh6Ts48kwG0FOu4ocODVVPAqYVXiLdcndY5i5Nf6uUgZ6zu z6o2nnk17tpk61aCnII1ZMBu11tYs9VM9ePmcRs2xRYPM+grCB1wB/dhLDmEP3b2HZ02 hFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dUvIZnJazJaOEZboAW1OJSDBnVf8XIUz/RaJk/SSM4M=; b=at7lNpP/hhE73C8cwWNxLSZD7JLd9gpCHMU16dh6zSXnlB9K8LHMlOGOd+TKa8+QIe PiMdeLu2m2D9Q6yEKhc3ujMS+jV4iWX5djOaylChBrN68ThTHZ5HRnVWOkEEHJvte1NV V2Fkct2agvLEI/XPG5ISu39qJdRueKTDNwrZzUqbEQBwufU51p12fIgcrzKA3izIwxQ6 GQvTdJ+ThzY7VYfpjDeRNxfI9qdCduYQYWWbZKGQv5+F579HiqKsJfKAUOnwVsMLgi0O U8YKMU+CLAN1B6ag0ME6mOL8cJW3UONDb5jLajSg3xDxDygtDrDBAZws9X9aEYvdtP2l WpqQ== X-Gm-Message-State: AOAM530APYbN0wEoGGhUV1y96SqSEZohWV/mR/HxoVjYaxD384DrCe1l WCqFxhautEFPwHVc2lKy6zi/DYkI7UN2dg== X-Google-Smtp-Source: ABdhPJyGmnSUMEkJY27qWB9YHgw+FVaPTafkE04FKKlTCdH1k6sAud48KBBMpc86FJqNUdgJKybqSA== X-Received: by 2002:a17:902:9a8e:b029:d8:d989:4f80 with SMTP id w14-20020a1709029a8eb02900d8d9894f80mr1514185plp.32.1606277207801; Tue, 24 Nov 2020 20:06:47 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 02/11] target/arm: Enforce alignment for LDA/LDAH/STL/STLH Date: Tue, 24 Nov 2020 20:06:33 -0800 Message-Id: <20201125040642.2339476-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 17883d00f4..73b3d8cbbf 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6876,7 +6876,7 @@ static bool op_stl(DisasContext *s, arg_STL *a, MemOp= mop) =20 static bool trans_STL(DisasContext *s, arg_STL *a) { - return op_stl(s, a, MO_UL); + return op_stl(s, a, MO_UL | MO_ALIGN); } =20 static bool trans_STLB(DisasContext *s, arg_STL *a) @@ -6886,7 +6886,7 @@ static bool trans_STLB(DisasContext *s, arg_STL *a) =20 static bool trans_STLH(DisasContext *s, arg_STL *a) { - return op_stl(s, a, MO_UW); + return op_stl(s, a, MO_UW | MO_ALIGN); } =20 static bool op_ldrex(DisasContext *s, arg_LDREX *a, MemOp mop, bool acq) @@ -7033,7 +7033,7 @@ static bool op_lda(DisasContext *s, arg_LDA *a, MemOp= mop) =20 static bool trans_LDA(DisasContext *s, arg_LDA *a) { - return op_lda(s, a, MO_UL); + return op_lda(s, a, MO_UL | MO_ALIGN); } =20 static bool trans_LDAB(DisasContext *s, arg_LDA *a) @@ -7043,7 +7043,7 @@ static bool trans_LDAB(DisasContext *s, arg_LDA *a) =20 static bool trans_LDAH(DisasContext *s, arg_LDA *a) { - return op_lda(s, a, MO_UW); + return op_lda(s, a, MO_UW | MO_ALIGN); } =20 /* --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277519; cv=none; d=zohomail.com; s=zohoarc; b=ObOfcBG7WKIAYl6cXb7jOJjko6XH3AuXlQwr9pqNVSXFnWVuPeU4P9Be/mby1vfCZlfHmvJCbr8LMlAbQznr7S+ngD/Bj1tF4sa8q7/XcB5+tKyNCrgKNjMb1NcqVBtLK3ePD5C7ytppn4YQTU/Wf0tjjz4dKwgTaU3ClwnifuM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277519; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CeRrpuz8AyToTR5rNqSx2nYuSkShEOKR3hSvhU0d5PE=; b=jqP7PbsCratBNvcYiSvqQMYn7jURd1PhbZOlhrcNTSRo938ST/23jlkg1I686MphIsvIIY8To3DRV58osZpfaHXrONTYQKHNuMyaShNb0zE6g0iRKMJqrulZkc2JimLgAosaTuqkpGBqB03doiYIWMl1NWMLdjzg+BBjp4fiFkA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277519502141.25712093378274; Tue, 24 Nov 2020 20:11:59 -0800 (PST) Received: from localhost ([::1]:33102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khm9s-0003RG-P7 for importer@patchew.org; Tue, 24 Nov 2020 23:11:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm4z-0004mM-Em for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:53 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:39952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm4w-000626-Jm for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:53 -0500 Received: by mail-pg1-x544.google.com with SMTP id t37so1186462pga.7 for ; Tue, 24 Nov 2020 20:06:50 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CeRrpuz8AyToTR5rNqSx2nYuSkShEOKR3hSvhU0d5PE=; b=acPV/Ah429b3YcECViVoxv+ryYJKhc4SL5NQI6ZIKrNgoT0izAyAnTe9Z2/k1s1fsD 1I80CcVYJmvnok+Rmxy5CfieRDTamaUC4n6eKvBQgKYw1hXzwNG/J1hP8sKv5ccsS1A8 iwB+rN4+lSHA8+vq9pvqAI75Nllva5kV+zI66MiKDwfH4U7a6vIR6fHE67cOjMzuYLe7 U76WjTTF/bVBvtWFwuSwj/TCCrGUxcoHKyRXU66TfVFnLVCx+ZYZ+x8drKtGdrTGbv/Y gXVRcZShWsWcqkes0oZoOcL3p30KJeTP/EYcotZpWJK4Kc7id5vZAN0O2jWY9OMOHey0 V8bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CeRrpuz8AyToTR5rNqSx2nYuSkShEOKR3hSvhU0d5PE=; b=AEBSIdU80xIiuPU/fKM+gB91jgbNBSOA6BbXRH9pIBbLdRZdQFVczK21GJwIzIZROJ 9XbuLTHmVgT/Z6HniiFifHqx4HZRYvLo/rx/lFrR7WkrBfn23WVg6Q8VdaHUTWYk3dXj H2vXRvExKJrnvM7txwRHOrj0vfjUaGeQpBFmyKPQglPK3nEvMkMaFWRLBXnII9m+JZOC NMDjFjJpwhED+lZPiguB8cBRFauAmuyxEKEq/kJZWvMFSNrw4Nia2ZtdHHhQIbhA5rEa gymTm3BG9n/gQG3gXcpZwvLBVJQvnps5SDi6VZ22G6scJ4WClkz9O5dyGU/jztliPuh1 A6zA== X-Gm-Message-State: AOAM530fjk4ztQWgHTtcjAxFpp7EDHCpPpracL94JUusnDszbGK+WSS7 /M6ks5ft0AcxBtOzb5OFgSOxPf6x6o6/0A== X-Google-Smtp-Source: ABdhPJwD7iG9xdZhIJbjuntO+lv2P3aKgdHiSq7Ge2piU6PIssduCbu0GpoD+4cd9Y5j2Oo4e1GD0g== X-Received: by 2002:a17:90a:5d0e:: with SMTP id s14mr1843248pji.53.1606277209110; Tue, 24 Nov 2020 20:06:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 03/11] target/arm: Enforce alignment for LDM/STM Date: Tue, 24 Nov 2020 20:06:34 -0800 Message-Id: <20201125040642.2339476-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::544; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x544.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 73b3d8cbbf..fe4400fa6c 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7814,7 +7814,7 @@ static bool op_stm(DisasContext *s, arg_ldst_block *a= , int min_n) } else { tmp =3D load_reg(s, i); } - gen_aa32_st32(s, tmp, addr, mem_idx); + gen_aa32_st_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN | s->be_da= ta); tcg_temp_free_i32(tmp); =20 /* No need to add after the last transfer. */ @@ -7889,7 +7889,7 @@ static bool do_ldm(DisasContext *s, arg_ldst_block *a= , int min_n) } =20 tmp =3D tcg_temp_new_i32(); - gen_aa32_ld32u(s, tmp, addr, mem_idx); + gen_aa32_ld_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN | s->be_da= ta); if (user) { tmp2 =3D tcg_const_i32(i); gen_helper_set_user_reg(cpu_env, tmp2, tmp); --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277319; cv=none; d=zohomail.com; s=zohoarc; b=CML35tHDUb1JPviJ1scbKAk5GOgKP9y5VJI+6ilzO+jn6eec8wnTY7etMNBz2m2eX6A7rd0PYPx3wIF5w/x6iM8arNV2KUGuzR1X4swsO2FeoBzD21wKoqGRBdcF8km8fpFW5h70Vu+FpuYSK+//FgKfmHaZudiHVoX6dQfje/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277319; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y78iUWT/hOzRMHIOoD0erIhCqyR5Mxb52awjOekSD+Q=; b=kpCuL8dpMJZ+BYeO2k/zo4YLfLqBiMs3fwQ1luAzgbZocuTVAAEJnA7t+SxErCx0mFqoO33LITqwz8RSe9388psZ71utYkdbEtv1d62nmAElDI85k1fu/bU6HQSMRjRBxOyACxVtR24lBeDky15NANqunZ5gxup9TVtNKCeHxfE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277319627796.1440053465084; Tue, 24 Nov 2020 20:08:39 -0800 (PST) Received: from localhost ([::1]:48630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khm6g-0006br-Id for importer@patchew.org; Tue, 24 Nov 2020 23:08:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm4z-0004lZ-4z for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:53 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:40005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm4x-00062T-Om for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:52 -0500 Received: by mail-pf1-x443.google.com with SMTP id b6so1087784pfp.7 for ; Tue, 24 Nov 2020 20:06:51 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y78iUWT/hOzRMHIOoD0erIhCqyR5Mxb52awjOekSD+Q=; b=bC2RLLNcAclmhM3NQj+ZQwLRNUosmXiAPMpXDQI7MDU+mk9yI+25CcgC7pfmmcSN+k L0dtygWruuvqMcy2vama8ceJLHZwDrsWHTAlm5cuvrwuefhl1Fkiezv2JQZ7HrjXsAmP 8yBg4q4MO2ygWD7R+WM4dPuxwRuVhHrWiS+EDEPuOOBxy/MPH4l21BZ7zLBen1sbDj+1 bZsCfoi1y3J4m9ncRSVOjYBOZz1WcHrg4RcNLsGwe4nf9BcfaHpkPxaw0anqeqqwO2o4 c9rDNmY9r6oXSUQxWy6Dh2u+EVq0WJ+QWGOmlCUvDlOHdXIoTHLOgSZmrfiyozERbcXz 6fnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y78iUWT/hOzRMHIOoD0erIhCqyR5Mxb52awjOekSD+Q=; b=MF3WzvO8TpOGeKliF8J7Wwua0VNtBeiOnJh0xp76fCmpYiBhOewo1ZPQ0bYqmR62QV G56qTgZj3txGE1z6nlP4s0yrf2dpjiq0X/bI/0QgjUSVEVwa0zoZ0jX86M4miMJQsF2u DJ3vw6SYBQkXI0H22Q8bgurT0J8PLh8FWY4I7utTxSd4p+ENbxakWnLBTgACLftmxXNc 0M0YPl29O31DCjyFQCFlmZfS8Eeqoa0lf7e07o192aAa8z1K/qqN7hVfxG9aOiIQKaRU WYEIv8zzD2ILR9xxNFNo7LiihuhP1XZY1Gb2YlcXL8/qKFG0nuqmrhUp6uT9hDk9e1xF kHgQ== X-Gm-Message-State: AOAM532QJTy9BFvzD3VDOXGApHcGt6FNzUlyJ1GO6WujVU06yhRl5Fkc 3iHXrjAh/Cy5Q3eotpAPSWEAyFb1re1rJw== X-Google-Smtp-Source: ABdhPJzaFlNrGd4qhFit+0+Kh5r8nOgEeMhFEbZ3ZBH3D4kgdLV39Yp7lPS4uo9Ju00erda88uZrIw== X-Received: by 2002:a17:90a:fb41:: with SMTP id iq1mr1860037pjb.140.1606277210180; Tue, 24 Nov 2020 20:06:50 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 04/11] target/arm: Enforce alignment for RFE Date: Tue, 24 Nov 2020 20:06:35 -0800 Message-Id: <20201125040642.2339476-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index fe4400fa6c..4406f6a67c 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8250,10 +8250,12 @@ static bool trans_RFE(DisasContext *s, arg_RFE *a) =20 /* Load PC into tmp and CPSR into tmp2. */ t1 =3D tcg_temp_new_i32(); - gen_aa32_ld32u(s, t1, addr, get_mem_index(s)); + gen_aa32_ld_i32(s, t1, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); tcg_gen_addi_i32(addr, addr, 4); t2 =3D tcg_temp_new_i32(); - gen_aa32_ld32u(s, t2, addr, get_mem_index(s)); + gen_aa32_ld_i32(s, t2, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); =20 if (a->w) { /* Base writeback. */ --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277669; cv=none; d=zohomail.com; s=zohoarc; b=N5YdUUBjkgpQZrA+HvMe9xOtRgGz6UvsrTWg6ZA0m/tLP5iD48WgqxgTiUln9Px8uF1CfotnnibnMESa2mh0mREFkiu8A2brnu8iPj2H71IF4Ghm/yhGtIaU085UCDTyG7XT/nU4hx3Ve1JtuBLxgP6i7sxzTnPgzdjpBcwbtLA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277669; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=usLpa97UISiu51HArLZeAu/Edm945VN7Y5GLMB1hA7U=; b=TCIt137YyhKjFWInah3h1sK7AjDtJ+8Q6aztlY8Y71SYMKU8oClTEbvIzytQfH60lNUeN1BwWf0ubNLKPH9j3zBhyoBFq9ph+IfMOP5fqxtsYc0nOROlobciaV45TtFPlLwPFbodoY/xU/sHSSeyc6Num1DTM5pv1SLRVgyPCTg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277669431702.4379928653409; Tue, 24 Nov 2020 20:14:29 -0800 (PST) Received: from localhost ([::1]:41290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khmCK-0006qH-DB for importer@patchew.org; Tue, 24 Nov 2020 23:14:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm50-0004pX-Jl for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:54 -0500 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:42531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm4z-00063A-5w for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:54 -0500 Received: by mail-pl1-x642.google.com with SMTP id s2so447045plr.9 for ; Tue, 24 Nov 2020 20:06:52 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=usLpa97UISiu51HArLZeAu/Edm945VN7Y5GLMB1hA7U=; b=ztB3+QrxyaDLIZWsrVjXeWUXH/7rMuNkbGaSlsbQKy3nYfu8gthCaloTptR+zarihh 9JwfEjDS8C+GHluSDCJ+DJtTCi/WgECQUcwEXGXQ41eQKfQYhSKiM9VmQezcgJoB4D4K rT3hxHGfWaXLdSnO23V8PdwfU5kSxZ2yR6SWzDuefSzBHHP3b2ZYHnrb+r+f66G+X/nT QIsBzeXwkifvzucacKP7G9qxwhlvsdyT71r4R4O6oYMRVcZKoONw4lNXleVeWkr2hHRj JxB5Ha6UCG15YMiwZByktriZhguj9+HqV8P2ZOWhMqVsMZUadyNqKeDb8u669UYedCUJ EdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=usLpa97UISiu51HArLZeAu/Edm945VN7Y5GLMB1hA7U=; b=hqOTsi8zCgUiCGtesqvAf8zd3+Ygu15hZzXxzSN3wT5HTMBdTmEtpfyCvdk9OFZu+/ Tku4FdKlglMNt+iNtk+cc/G8vIBWtG51xYUn7Mq0ty4aSmrdGeeckUm08eEV4N1Db5AL tmr07wiKmzMv0K9xzabN7MVzda3S4SDmGJLlvxs7IsxO6A+DeGRukHHnIh771HpMExVm SkwUX/mvxxSdOZGRj6C3RtJFs/kydEDpR4Hdyq438a/IE1nMxf6M02EQbmlldGwhmC/V aNICobdnFEX6TdOtqv+Y/bbGOBbQC2xp9wE+ddZDB/Q8/GOvcXb1+Y38AvlMNs+FLNNc w87Q== X-Gm-Message-State: AOAM533WGhKNvYS4DqBF20HXiApa+zD9+KiMqCFNoXCmORrAM6gm473p pKZBb+EjiuaM38EaweF0J8OwTi9j0boGQw== X-Google-Smtp-Source: ABdhPJybDGu6JRpDWqHvj+5EKKghhilm+95AGUk6b++q/gP9p+vGWxW6qmklBF6IbZL5Gq51klQX0w== X-Received: by 2002:a17:902:ac81:b029:da:f96:1b47 with SMTP id h1-20020a170902ac81b02900da0f961b47mr669831plr.78.1606277211568; Tue, 24 Nov 2020 20:06:51 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 05/11] target/arm: Enforce alignment for SRS Date: Tue, 24 Nov 2020 20:06:36 -0800 Message-Id: <20201125040642.2339476-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::642; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x642.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 4406f6a67c..b1f43bfb8f 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -5124,11 +5124,13 @@ static void gen_srs(DisasContext *s, } tcg_gen_addi_i32(addr, addr, offset); tmp =3D load_reg(s, 14); - gen_aa32_st32(s, tmp, addr, get_mem_index(s)); + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); tcg_temp_free_i32(tmp); tmp =3D load_cpu_field(spsr); tcg_gen_addi_i32(addr, addr, 4); - gen_aa32_st32(s, tmp, addr, get_mem_index(s)); + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); tcg_temp_free_i32(tmp); if (writeback) { switch (amode) { --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277457; cv=none; d=zohomail.com; s=zohoarc; b=PVHdpO2Obc/0CdHLbXdAEcE3PDPAhsdH13yXRmo0SEvf2Nj0ogrPK3UJ8czmAYAQvIkTDK10LGrhhIQaFKBJT81bi4sIDvy8GpSz//4f+6XlShfcYx8yeOfS7XTlBZFHLMDeQ7+nmd/eRMNJWbNc+M0dXoYL0q652D5JhdK1e1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277457; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Wu5Kt3iN7e6z3sUpws6R3XP7/Dj8XZZymOVS+ThDJek=; b=Gaqxi+EcCjti8XXAB1odfEt+YwBJ6go8rk1VIoaj+P/KBYrx7YQs22Y4+/MIid7gwlcpjwu4ty5kijrdHJ2NDiebxZaRGq32TIthHJZD0k4bOqYEx3MsDYmE7exPhDAUbvDvJ2qBRLkmqU9bIasInEqwtE53pG9d3cEm2KTlAqk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160627745749352.91822476261518; Tue, 24 Nov 2020 20:10:57 -0800 (PST) Received: from localhost ([::1]:58346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khm8t-000290-9G for importer@patchew.org; Tue, 24 Nov 2020 23:10:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm51-0004t9-RV for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:55 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:41605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm50-00063s-6S for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:55 -0500 Received: by mail-pf1-x443.google.com with SMTP id t8so1084502pfg.8 for ; Tue, 24 Nov 2020 20:06:53 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wu5Kt3iN7e6z3sUpws6R3XP7/Dj8XZZymOVS+ThDJek=; b=G/ezqJF/80UzEjCfBVtjm4leY8YH0zUhtNhTnGWR4tGn6HtDRVkFqRtP1njB2uclMl 9F+uyGlUSao3mvwrsvIPQ/PVMW+iqZ/km7c2vSAV28ipiZgDfR/GI3dm97OKEc46xg8Y wFDEyVuRjnq17GRz/BGkai+EGR61jLkDIaObLnnsG/0jclZnl6Eiv5NteasbB5dtxdt8 TctK79qGJ6kuLfG/ell5UE3u6ub0cyPI48H1aVVniL+N5/4tGLm2tcYDyDNj3T+jLw8L BQKCYpUWNuhXAgwDeiNc2ymElUocG9ym+9+8t7QfaaOoAKg1+kPHjanQobWYtkN9nCG2 QazQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wu5Kt3iN7e6z3sUpws6R3XP7/Dj8XZZymOVS+ThDJek=; b=c99FMGsYPRfr4iZY1xbHw6ep+UXsLbBUYWadkrM7aEKjFmVc2g5hKKB0UOhI6fLqKN fTl2FW9h64bps9zzn8mCXcRrfvO3o+WnxfidLTBzp3z4uFmBQhCEZz65MpgQFIUe+IPs J5iDEhrYUy6Pooezh3Mx+6WuCER6XEG8AnGbTVNYMjRl/gSC5Po3KEdxrm45ZUjeMerB IYcBbxlqXykm41truT565j4KBSzERtefAAVQpIu0qmTcN3VrV9FCf4oSyRw0NQYFrHjI JKgDy08wt74/rsUkgb7H9QIxgK1+0k8bjgtGXJXT46N1NXJEVBeUkjgXAlyQl8t58o+u oOeQ== X-Gm-Message-State: AOAM531K6vJ9bSXLNz7VpKuxM/cWxtGBoJQ3FiiFhqJYGvSS1VhND1UG 2z9R3a0Q/3Cbaj0Ekj8/ThoYUJar/qpKTw== X-Google-Smtp-Source: ABdhPJzUwwClqFCsItdZUaEp73h1FTR5N4M4Pou27YaGGp/y/nyM7WbXYUzX44KdhZYrjw2QyrsQJQ== X-Received: by 2002:a17:90a:e016:: with SMTP id u22mr1821185pjy.195.1606277212724; Tue, 24 Nov 2020 20:06:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 06/11] target/arm: Enforce alignment for VLDM/VSTM Date: Tue, 24 Nov 2020 20:06:37 -0800 Message-Id: <20201125040642.2339476-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate-vfp.c.inc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-vfp.c.inc b/target/arm/translate-vfp.c.inc index 96948f5a2d..58b31ecc3f 100644 --- a/target/arm/translate-vfp.c.inc +++ b/target/arm/translate-vfp.c.inc @@ -1065,12 +1065,14 @@ static bool trans_VLDM_VSTM_sp(DisasContext *s, arg= _VLDM_VSTM_sp *a) for (i =3D 0; i < n; i++) { if (a->l) { /* load */ - gen_aa32_ld32u(s, tmp, addr, get_mem_index(s)); + gen_aa32_ld_i32(s, tmp, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); vfp_store_reg32(tmp, a->vd + i); } else { /* store */ vfp_load_reg32(tmp, a->vd + i); - gen_aa32_st32(s, tmp, addr, get_mem_index(s)); + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); } tcg_gen_addi_i32(addr, addr, offset); } @@ -1148,12 +1150,14 @@ static bool trans_VLDM_VSTM_dp(DisasContext *s, arg= _VLDM_VSTM_dp *a) for (i =3D 0; i < n; i++) { if (a->l) { /* load */ - gen_aa32_ld64(s, tmp, addr, get_mem_index(s)); + gen_aa32_ld_i64(s, tmp, addr, get_mem_index(s), + MO_Q | MO_ALIGN_4 | s->be_data); vfp_store_reg64(tmp, a->vd + i); } else { /* store */ vfp_load_reg64(tmp, a->vd + i); - gen_aa32_st64(s, tmp, addr, get_mem_index(s)); + gen_aa32_st_i64(s, tmp, addr, get_mem_index(s), + MO_Q | MO_ALIGN_4 | s->be_data); } tcg_gen_addi_i32(addr, addr, offset); } --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277385; cv=none; d=zohomail.com; s=zohoarc; b=V6E8xWP7CNMunFd1SaaDZLu6fi1SaxU4owgIR7scXOsEMHl39LRqtTXozTmqIiaVaUIT8LawpXptWOt6tXhGyzf99RhPhq6Ub9SxePrF8O6Sxa69cTOy3xuPukdfTqFAvlTJES2Gr3Moz9/ctU6Q4oRZDGUh/Pcp4qDA5s2kVSA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277385; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wlXlRdc0Ps4lTbxrXVpBLYGv+DVDYQ5KsE5wMhxDQbM=; b=HNzqQbJGUnm+qgn6kBV5m7Xd2RtJuVnuMGp+SUzRjIJ76jrwT8vR3knyxRi8WoD0i2hV/HUJ0Ft0ayNGuzz6S2RyZsL3q09QldcM6s+Be387/l8RnxOMgM9gK/7DP1nZzDMbr991TKZlgsz+TfSMogwKy6a3zbAFkAx+c4vi46w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277385184846.0879131164082; Tue, 24 Nov 2020 20:09:45 -0800 (PST) Received: from localhost ([::1]:53460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khm7k-00008L-3m for importer@patchew.org; Tue, 24 Nov 2020 23:09:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm53-0004wX-6n for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:57 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:42820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm51-00064B-G1 for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:56 -0500 Received: by mail-pf1-x443.google.com with SMTP id 131so1082279pfb.9 for ; Tue, 24 Nov 2020 20:06:55 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wlXlRdc0Ps4lTbxrXVpBLYGv+DVDYQ5KsE5wMhxDQbM=; b=NNRKuJv7HLZcC5szZ1uyUbuBzCZmY4Q1NklB4u8+mYUaKrlbadAHYSZZY55YHXdFfk irt4OI52mFuRR6gEjsxlOPG9GozlmHhGIKSM4OavI29Y38fdPGkJ+3drRIeE0QZYoojp DvEAwrfG8FK13p68DDvikQklLZA3/G6aOoGQqfopLEAU/nkHHezgC7sgDJBVR56JkAFA CmmQjGohxTsuYD0agAjAL2f36vDLctFYa3Gm4Fj8dfc7HUWGAaYhD1sPMblpVQIPrEdi uGg49K3wb7s3uD6Dua3QsAvd456Dp+aCTiuCARZ64P6pe8SpE/H3pPIEJsTsIEZA0ZXW kmRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wlXlRdc0Ps4lTbxrXVpBLYGv+DVDYQ5KsE5wMhxDQbM=; b=gksaH4st4zLjgT+dX6ydMrHowJzeK02EC3cpWlvRau1lHkj6dlXQjLF/oM5ub1+avE +SEBs7Hbo4DoZZeuoUAMk7tlnKwT/fYHp13phpS3YRy9jngz9nlNoVKeSq9dJMj9f6zC c0VhA4e3OX6p//zQZMAtOEpIwIkpr+kGAGQ8itXA3eUerXR7taGkYZ8Atg0yc6cBpHpl OWedePdY7RrSl7rZyn51RhWgyqfxavHTvlIPMh0RBRyyKWtQHW1AJd6oO0L2cRJEsrGn Qd1j55BrsNaHaMEBC9cud42TaSZy4fEmuuMW11aQsW+kQRtuAuST0ZBNv5ggJzF8tTuv 08kw== X-Gm-Message-State: AOAM532eIr953A47qpOxxYxQTcSgG0udHw2xBD04Li6E4r7UQanarTPO KhpvajpRcp2kt+eXLRq4lXQP9N5roniNhA== X-Google-Smtp-Source: ABdhPJxMMV1/J6reZ5p3WIKZjSi2t9CbtvDiwfeNMmMh6yPRkJcJ+zKnPM51Ur2T6TIZTePMkdbGsA== X-Received: by 2002:a17:90b:4b0a:: with SMTP id lx10mr1838625pjb.128.1606277213961; Tue, 24 Nov 2020 20:06:53 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 07/11] target/arm: Enforce alignment for VLDR/VSTR Date: Tue, 24 Nov 2020 20:06:38 -0800 Message-Id: <20201125040642.2339476-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate-vfp.c.inc | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/target/arm/translate-vfp.c.inc b/target/arm/translate-vfp.c.inc index 58b31ecc3f..51e85c2767 100644 --- a/target/arm/translate-vfp.c.inc +++ b/target/arm/translate-vfp.c.inc @@ -926,11 +926,13 @@ static bool trans_VLDR_VSTR_hp(DisasContext *s, arg_V= LDR_VSTR_sp *a) addr =3D add_reg_for_lit(s, a->rn, offset); tmp =3D tcg_temp_new_i32(); if (a->l) { - gen_aa32_ld16u(s, tmp, addr, get_mem_index(s)); + gen_aa32_ld_i32(s, tmp, addr, get_mem_index(s), + MO_UW | MO_ALIGN | s->be_data); vfp_store_reg32(tmp, a->vd); } else { vfp_load_reg32(tmp, a->vd); - gen_aa32_st16(s, tmp, addr, get_mem_index(s)); + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), + MO_UW | MO_ALIGN | s->be_data); } tcg_temp_free_i32(tmp); tcg_temp_free_i32(addr); @@ -960,11 +962,13 @@ static bool trans_VLDR_VSTR_sp(DisasContext *s, arg_V= LDR_VSTR_sp *a) addr =3D add_reg_for_lit(s, a->rn, offset); tmp =3D tcg_temp_new_i32(); if (a->l) { - gen_aa32_ld32u(s, tmp, addr, get_mem_index(s)); + gen_aa32_ld_i32(s, tmp, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); vfp_store_reg32(tmp, a->vd); } else { vfp_load_reg32(tmp, a->vd); - gen_aa32_st32(s, tmp, addr, get_mem_index(s)); + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), + MO_UL | MO_ALIGN | s->be_data); } tcg_temp_free_i32(tmp); tcg_temp_free_i32(addr); @@ -1001,11 +1005,13 @@ static bool trans_VLDR_VSTR_dp(DisasContext *s, arg= _VLDR_VSTR_dp *a) addr =3D add_reg_for_lit(s, a->rn, offset); tmp =3D tcg_temp_new_i64(); if (a->l) { - gen_aa32_ld64(s, tmp, addr, get_mem_index(s)); + gen_aa32_ld_i64(s, tmp, addr, get_mem_index(s), + MO_Q | MO_ALIGN_4 | s->be_data); vfp_store_reg64(tmp, a->vd); } else { vfp_load_reg64(tmp, a->vd); - gen_aa32_st64(s, tmp, addr, get_mem_index(s)); + gen_aa32_st_i64(s, tmp, addr, get_mem_index(s), + MO_Q | MO_ALIGN_4 | s->be_data); } tcg_temp_free_i64(tmp); tcg_temp_free_i32(addr); --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277759; cv=none; d=zohomail.com; s=zohoarc; b=ZLVvjkxRvKr0U69008shKjc2WWYqL7f0VFPXFRbjhYgbpMFh5HwAe3SIZAnWv53bJXM1cRJxH9VBUSU2Pl+gpl6xrtOuYC2pOa5VEAvw2oGNmZ6hk6dO2ICDllyAlS2cL1AnVV/XdkZT9g/jnIf7H7NW4kjXAN1nR0v3IfLXv9o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277759; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f97D77kFtW+HRq202SBVTA2C2Bh99/g/k3cnzM7yNVs=; b=KSRXZ8TfBspTzrTisgwpCM0bbu/DxPrI2wuFCiC0X57fGSi7iDdWifOIFpsGXhHASKoOcIogcK5b/scybYTdwRJXb494XymsNQgJmzr8rivKPpKnFgGDryw+2vKt8+0kM53qsC6MtnmrKZTu6S0Uimtuvt/TpfDJavaF8phmAWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160627775923072.23003170863296; Tue, 24 Nov 2020 20:15:59 -0800 (PST) Received: from localhost ([::1]:44454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khmDm-0008Fz-30 for importer@patchew.org; Tue, 24 Nov 2020 23:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm54-00050S-IU for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:58 -0500 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:34946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm52-00065C-Re for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:58 -0500 Received: by mail-pl1-x644.google.com with SMTP id x15so461733pll.2 for ; Tue, 24 Nov 2020 20:06:56 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f97D77kFtW+HRq202SBVTA2C2Bh99/g/k3cnzM7yNVs=; b=DV3kYu+qBd+dgDvVz3rVr18hb2jU3aBK4pbAxcxG1O+f2bYJjleUeKirIXnuwKLSox cuA5+KLfPfSMBdUwdxfRKBR2/TLSuqeHk7fyhMysBZnD2N8qZmCb6tidWjnBwNmtVrNT fV1qUV8P/7kTSeuEsyVMHRO6t39VninK93moAY7BGFOevuVreJd+QVLpAX0iMOP1SCQ5 5S/xwFVqZL3Q6cErtnml+POrpWfl+/nmCW+wpDGsWNwTZnHx8BGIRI1WIp9NxzAFxJgY kjq5heJTP2zFWagvZyGd3d6SL4mt6Nsrb5AvNSvZBZUe542bQlp0IM2KwG3uYdNTjGmv o9kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f97D77kFtW+HRq202SBVTA2C2Bh99/g/k3cnzM7yNVs=; b=kLKtZgLktNV9hor3/JYpxcnwGEO4r2m51OiGLR3ljGXMQUX756htKYG2Rxe2ecN/HI BWTkj94scD7ng9d9P0isEvE6nI7lfpoc+Lku+1nP8ss0vca2x4XhtsnMWGxiDMxqMqLc OwEv+NCmb8f3Q4qCcZD+ezAW0sbPKdFOydajpay1qp4LhDeZXr3o4asUGQZVvkz6TtZe KBVOtqxvB/X2j8BRKRiM+rdpMNM3cjf2KqRiXrVH7RZVaXqYef7gh4lgM37Srlq66LoL Xy6FSjRllbBbvKCdWAbf9N0+RjPFRnpW+Ult4TLwsoLEA95cRijxuGxyJSamdilmouwN 1HhQ== X-Gm-Message-State: AOAM5304KD4H38LzL/xBywlrZr5iP2/cjJ+dRBeZyDaRMj8aiE9oGr96 DvUjiSr9S5msNcRhdqhph3QU0r0eUMYdmw== X-Google-Smtp-Source: ABdhPJyJ06r+JinSUmshFEKVAlobdHsMT6uCbqL1W+lLl+/vrMPHY09MT/OVyNGZ3MEVDWazgP6sLA== X-Received: by 2002:a17:902:8d82:b029:d8:c5e8:9785 with SMTP id v2-20020a1709028d82b02900d8c5e89785mr1452546plo.5.1606277215199; Tue, 24 Nov 2020 20:06:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 08/11] target/arm: Enforce alignment for VLD1 (all lanes) Date: Tue, 24 Nov 2020 20:06:39 -0800 Message-Id: <20201125040642.2339476-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x644.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate-neon.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.= inc index f6c68e30ab..32e47331a5 100644 --- a/target/arm/translate-neon.c.inc +++ b/target/arm/translate-neon.c.inc @@ -518,6 +518,7 @@ static bool trans_VLD_all_lanes(DisasContext *s, arg_VL= D_all_lanes *a) int reg, stride, vec_size; int vd =3D a->vd; int size =3D a->size; + MemOp mop =3D size | s->be_data | (a->a ? MO_ALIGN : 0); int nregs =3D a->n + 1; TCGv_i32 addr, tmp; =20 @@ -559,8 +560,7 @@ static bool trans_VLD_all_lanes(DisasContext *s, arg_VL= D_all_lanes *a) addr =3D tcg_temp_new_i32(); load_reg_var(s, addr, a->rn); for (reg =3D 0; reg < nregs; reg++) { - gen_aa32_ld_i32(s, tmp, addr, get_mem_index(s), - s->be_data | size); + gen_aa32_ld_i32(s, tmp, addr, get_mem_index(s), mop); if ((vd & 1) && vec_size =3D=3D 16) { /* * We cannot write 16 bytes at once because the --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277598; cv=none; d=zohomail.com; s=zohoarc; b=SHPuJh3MEpYMEetXrU+L7P0tmpjP0c7viV1WKWSMyqF97vYyPC45Hd+0I4iiuS0xSxnijDPI9ZYRz/TYRlUTpHzqG8c/u/y8cLD9wJ1Snbcd4cWSvSKtCd8oKFBT4fSYAKLDrvt05MZ9z5m/kwVHT24LER/UIlkRdVRzwEPw0RI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277598; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hIrGetngsQpn6DynYHLevrPArG00BLTGCrdQJNoe/Gs=; b=n1FkMKtSOfhp/P0tJs+gVvjG9GfCYMrHTnLZkg/1eC014UTImzJRIg637owORuRLNx+dAm1tH5PBQLDAmJqbc32YQw78HLitUZ2HwcwY2N+OIxRDP0a/rJHx4A9NH+jsvDcJKaYxZOLaKVXVZ5zL9Z6GfyJRCNxejiJe78VFWVU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277598775126.94364375389262; Tue, 24 Nov 2020 20:13:18 -0800 (PST) Received: from localhost ([::1]:37050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khmBB-000532-Li for importer@patchew.org; Tue, 24 Nov 2020 23:13:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm55-00053O-Mw for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:59 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:38579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm54-00065X-2Q for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:06:59 -0500 Received: by mail-pl1-x643.google.com with SMTP id l1so456037pld.5 for ; Tue, 24 Nov 2020 20:06:57 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hIrGetngsQpn6DynYHLevrPArG00BLTGCrdQJNoe/Gs=; b=m64eETgyNScp2D+qMQhBNQ4Igs4QupOgTKQo148uBsW3wEN25ZggV4sibRp7O8R5gh prjXaZo9ntMfDLLB0lV9ym8t2zIj0mCRAitnxh/PWZcAPvB8xSwlLiurYWaJrqwnHnVU ELHefi7a4pxXwI1JLHleZMlxFFIxQxxVDlHxPDU7oeve/Brx50+mEOet/sJtwdbsTLH9 ykEIo0v3X5niGp1a5+Hy3xCoTlvYrwwBXYZ8pFlAgwdGdmU3DGtZle9otB0jw9nRPH76 S8D77zT7jdIG+L9zQQnJYK48bR8wi8Wg4zUemm5A8CKcuhv5VAFTl3eHmggLB57sZKkb hMPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hIrGetngsQpn6DynYHLevrPArG00BLTGCrdQJNoe/Gs=; b=hoZXy5CSMIxnMgXO31QePjxrjd6kOvQ4Eivx9KtOMvR7r/V4tstMegNYaQ+ULx8meR yW1zRf6tdwzFINBwO9HyC5jDHWF9HOYlOEN4DU6VW0DiQJam5gGyjNzUlTPkBBjHYBdn 14teOSNlpGmu1hqQ/NNkNk6d0iiIAfpRwn8B8n4rygmUL202LWOyEJkLZmr/6L1ZLV46 palksns7zrnLXGH9S03Xl74mu8CzVjII9Waqq5RVzr2Xodqj+aWoJjX+mPE2DhT7iQSS Ge22PT08EJDT3A8rnJ0osQb/Y6hNVdggasRBuapNG1grSOSZg4kjqMbd3ABrluDy+CKo 5doQ== X-Gm-Message-State: AOAM531za4wUGEQSSRVfqY0eYGCKSq/vUZPpwn+1RR2WXIY/CQomaDkd gWScEd9x8YAs3zmGlN/HtjRSZG5u9ZIkQw== X-Google-Smtp-Source: ABdhPJwun44iIOHwu8QRRnvanFgNYAnL3L/6cclMWAYBrMRbQtcTiJusPOAOBri+zXLwLErII/1CLw== X-Received: by 2002:a17:902:167:b029:d8:cfe5:bdee with SMTP id 94-20020a1709020167b02900d8cfe5bdeemr1461916plb.11.1606277216434; Tue, 24 Nov 2020 20:06:56 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 09/11] target/arm: Enforce alignment for VLDn/VSTn (multiple) Date: Tue, 24 Nov 2020 20:06:40 -0800 Message-Id: <20201125040642.2339476-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::643; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x643.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate-neon.c.inc | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.= inc index 32e47331a5..c4be019d9c 100644 --- a/target/arm/translate-neon.c.inc +++ b/target/arm/translate-neon.c.inc @@ -427,9 +427,12 @@ static void gen_neon_ldst_base_update(DisasContext *s,= int rm, int rn, =20 static bool trans_VLDST_multiple(DisasContext *s, arg_VLDST_multiple *a) { + static const MemOp mop_align[4] =3D { + 0, MO_ALIGN_8, MO_ALIGN_16, MO_ALIGN_32 + }; /* Neon load/store multiple structures */ int nregs, interleave, spacing, reg, n; - MemOp endian =3D s->be_data; + MemOp mop, endian =3D s->be_data; int mmu_idx =3D get_mem_index(s); int size =3D a->size; TCGv_i64 tmp64; @@ -487,6 +490,10 @@ static bool trans_VLDST_multiple(DisasContext *s, arg_= VLDST_multiple *a) addr =3D tcg_temp_new_i32(); tmp =3D tcg_const_i32(1 << size); load_reg_var(s, addr, a->rn); + + /* Enforce the requested alignment for the first memory operation. */ + mop =3D endian | size | mop_align[a->align]; + for (reg =3D 0; reg < nregs; reg++) { for (n =3D 0; n < 8 >> size; n++) { int xs; @@ -494,13 +501,16 @@ static bool trans_VLDST_multiple(DisasContext *s, arg= _VLDST_multiple *a) int tt =3D a->vd + reg + spacing * xs; =20 if (a->l) { - gen_aa32_ld_i64(s, tmp64, addr, mmu_idx, endian | size= ); + gen_aa32_ld_i64(s, tmp64, addr, mmu_idx, mop); neon_store_element64(tt, n, size, tmp64); } else { neon_load_element64(tmp64, tt, n, size); - gen_aa32_st_i64(s, tmp64, addr, mmu_idx, endian | size= ); + gen_aa32_st_i64(s, tmp64, addr, mmu_idx, mop); } tcg_gen_add_i32(addr, addr, tmp); + + /* Subsequent memory operations inherit alignment */ + mop &=3D ~MO_AMASK; } } } --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277656; cv=none; d=zohomail.com; s=zohoarc; b=Br0913MFppMNISo34xO0TDRgFS1ZIDId9FKj38sgCznUsOzomhtKMybaplEhgn4GuN9YlecXpJM2B9zn8/9+WzK9qEpL0A+2OyXc9BVp+M+1Y2HsLoo7agxzD2mPaQ7vg9D1iHZ76ykuwjaUAOernFupjHdixgigFIHSRYM89Kk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277656; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A0GArN05QL42PJKkh5e5g8eJMWLUKLJQ2bxbC2/N0XQ=; b=Uj5WzEz7+o1sYPghcHAgO2fOhtE90+dYmGrCX+xbJa9NK7+11KFQ5oBjGIEPM9xH5HWWsFRWiDmCnALtt8iH3lQv853xXcaKzqbRHpFWhminSM5Qff0pnhpwKP3NlIRiZeKq7fWwIRWlB8TkGMREXHefqDF7Bo++mmwM8Vb8ucU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277656768151.79251270790814; Tue, 24 Nov 2020 20:14:16 -0800 (PST) Received: from localhost ([::1]:40010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khmC7-0006IX-GT for importer@patchew.org; Tue, 24 Nov 2020 23:14:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm56-000565-KS for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:07:00 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:36447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm55-00065o-2U for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:07:00 -0500 Received: by mail-pl1-x643.google.com with SMTP id r2so459273pls.3 for ; Tue, 24 Nov 2020 20:06:58 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A0GArN05QL42PJKkh5e5g8eJMWLUKLJQ2bxbC2/N0XQ=; b=WaKb39oevq8pC/DZQaDhKHTXB2Lkb16p2n10ECBRxvi2+o1kh2KvB2F53K7JbHYSqb A3VBAzXqLIp11BaYWzP24ORfgTB7cTSKTAiXgJ5mWaknBnZm7tON7dSf4x/M4Bud6g4y URl+gyuMteTjxczZEyKVNnJ9RwYuO6f2PNrKrgKVd9sQOsFBOWbxearUOu17nS112Bfg 0uo1cQ59LccSCa22QW5CtcvvXEEYxN2oXpSDbmog4Wz17HJd24IqyuWK4glILR6bboof FmJsdPLzkgaDevhU0z5McDc0BEFuyu0tEqimU4yp6SZbVxoR8HJ5n2uftqgwvH/d6dGL fdgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A0GArN05QL42PJKkh5e5g8eJMWLUKLJQ2bxbC2/N0XQ=; b=oXNx17Vh6h3lrz8obMgQFGrULZfAmxVKnLp36T+1UPTEj2i5m3NG6x+VTlFK6vDqzU V/DGNxnc7JJT/jTW254bVFF3EMJ70F19dlh0BJRKxNCEeEJN0LP9YmTXr8/n/ch+WJ79 cHTYLQyEaXvj/hpHUeXPNF8HHexm6dUnTTGFhP+8jg+aNT2W5jAiQnZcAAVy4SqmPRt7 Wf8hSvkNOiGk3Z8XGM37R7MqNjxKUnQtksslS467Ek1gAAUBh8+hUKzPUU7eo+d1kTtc Y+k5hgiz8Rcq3qpYXRRUQpPE9PbC/4SF7+kANWrz7l85i75mx8RVkanFU5c38VTXb7ye q1Rw== X-Gm-Message-State: AOAM532GpYFJIhSepH7m2g4z3R2OZX4sqBD+LRDCmaoqCdT9IUW2j6jw enC3ZMO1cd1F9qxnP6eEZMNf5nyXWPCqcA== X-Google-Smtp-Source: ABdhPJxFDaPBmX/htfRNEb+Fl0K5ak5b+Jhe08pR5s2fRUovvSfDr5l9EjSEtRzF5lAlcGkHrmwQXg== X-Received: by 2002:a17:902:930a:b029:d8:ca83:3108 with SMTP id bc10-20020a170902930ab02900d8ca833108mr1637830plb.60.1606277217482; Tue, 24 Nov 2020 20:06:57 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 10/11] target/arm: Fix decode of align in VLDST_single Date: Tue, 24 Nov 2020 20:06:41 -0800 Message-Id: <20201125040642.2339476-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::643; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x643.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" The encoding of size =3D 2 and size =3D 3 had the incorrect decode for align, overlapping the stride field. This error was hidden by what should have been unnecessary masking in translate. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/neon-ls.decode | 4 ++-- target/arm/translate-neon.c.inc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/neon-ls.decode b/target/arm/neon-ls.decode index c17f5019e3..0a2a0e15db 100644 --- a/target/arm/neon-ls.decode +++ b/target/arm/neon-ls.decode @@ -46,7 +46,7 @@ VLD_all_lanes 1111 0100 1 . 1 0 rn:4 .... 11 n:2 size:2 = t:1 a:1 rm:4 \ =20 VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 00 n:2 reg_idx:3 align:1 rm:4= \ vd=3D%vd_dp size=3D0 stride=3D1 -VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 01 n:2 reg_idx:2 align:2 rm:4= \ +VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 01 n:2 reg_idx:2 . align:1 rm= :4 \ vd=3D%vd_dp size=3D1 stride=3D%imm1_5_p1 -VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 10 n:2 reg_idx:1 align:3 rm:4= \ +VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 10 n:2 reg_idx:1 . align:2 rm= :4 \ vd=3D%vd_dp size=3D2 stride=3D%imm1_6_p1 diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.= inc index c4be019d9c..330b5fc7b0 100644 --- a/target/arm/translate-neon.c.inc +++ b/target/arm/translate-neon.c.inc @@ -616,7 +616,7 @@ static bool trans_VLDST_single(DisasContext *s, arg_VLD= ST_single *a) switch (nregs) { case 1: if (((a->align & (1 << a->size)) !=3D 0) || - (a->size =3D=3D 2 && ((a->align & 3) =3D=3D 1 || (a->align & 3= ) =3D=3D 2))) { + (a->size =3D=3D 2 && (a->align =3D=3D 1 || a->align =3D=3D 2))= ) { return false; } break; @@ -631,7 +631,7 @@ static bool trans_VLDST_single(DisasContext *s, arg_VLD= ST_single *a) } break; case 4: - if ((a->size =3D=3D 2) && ((a->align & 3) =3D=3D 3)) { + if (a->size =3D=3D 2 && a->align =3D=3D 3) { return false; } break; --=20 2.25.1 From nobody Fri May 3 12:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1606277859; cv=none; d=zohomail.com; s=zohoarc; b=VWmQEX7MKgczs0SToOKooefU/DqbhoXV2iHQzGJV1jY6pO8wXmtzjj3joy30wogtp3WGuCOlan27yi14QQlYN+odLH6b3pr9XvRA0LTe3WEC2fknuOmLEbK2VH0ssjmNukDHTWOsIC6u+3KXCX9EMfII8fT+f+2GGWz5BAFWP1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606277859; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bswwFH6M3LzgrGioTuBuBml8sz+8WXNnbRNFMSINy5c=; b=gO9qscbwmWxTI6qag8kvwllAryjmHb3DPblDK7K28Vw+hg98nadB8l313tdCxFxTi7gmdyh/WE3lp7dv4GdDKIi4NbznKBxVcavWtxMt+u+C+rv7IE4EnWB2FeeDSKs/BM1JOm+R/q8OS6oIXqr7o3clniA65W7gaOTn+WZyy8Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606277859791852.7503675793195; Tue, 24 Nov 2020 20:17:39 -0800 (PST) Received: from localhost ([::1]:46886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khmFO-0000tn-H6 for importer@patchew.org; Tue, 24 Nov 2020 23:17:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khm57-00059F-Qs for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:07:01 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:38578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khm56-00066s-9R for qemu-devel@nongnu.org; Tue, 24 Nov 2020 23:07:01 -0500 Received: by mail-pl1-x641.google.com with SMTP id l1so456075pld.5 for ; Tue, 24 Nov 2020 20:06:59 -0800 (PST) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id f7sm447806pfe.30.2020.11.24.20.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bswwFH6M3LzgrGioTuBuBml8sz+8WXNnbRNFMSINy5c=; b=cPfStF8QWfXHzmeHyUAwYMr95YL+SgbOyg+t/I7RgWFMOjg6Mnj/Uj/PkrlTspdXrr vaweJ4fHkxzT7rTzGDD+8QXxlri67W1A9ePAECiLTQRSHdIGEY9rBnjU+ei7Ox8vkgnH 5qhBHXcknXBh7ZJAeWPJWNdEbX7xwPFR+GrDAbROduL4G2QIhSXa+iovkxal2xkkCYss W1qoV1fle1pV88fz9UM08pzFmw6ezytjI5jR5dgGqB/JSoAOOBvcBJ7Dz6jbhXPR8ZNh iOnOmVG8dCeYATKrSPhHqCCf6TKwEEVuHmTrGZWNJBpFX4PbYHplCduEjR9u41vydADU RFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bswwFH6M3LzgrGioTuBuBml8sz+8WXNnbRNFMSINy5c=; b=UYLtHvCktYnPprFKHTZAGuSMraD9Ou9pBdiftRVAA7ouaztVHG+pyYLpGg3BAhNLz8 X5bs839kUEkzNWfrgIbQYieKcWPcBb934zPz7lWTcpWRFzQjWKxr43Qtabe5v5WJ5xAX Y6WyW259DkQ7joeQgULdkW3XNiQPIHjDlhZT/kUwvcCX+koh07OrPMQ9HzyAIUVNMWbq mWagmxJYbl6suYdjgqAmAh4RwZjxsvZw2AICZUzmYbN8xDgPvZ0AM3/RLXvbrS+vuX1V WbHCBhZYNt76KO0HtttIubodfP2S7EnqlzU2/zxjDEKryM+ca8rb47D0piGTykNUKEw1 pFEA== X-Gm-Message-State: AOAM5308OCKShWtJsgtgsC5qST2+OKWPeDqdXjcvb/q+rzzKXUKucqwP YyWM4C3zrMB3BYoLoWOJLDr67tUiGvqlnw== X-Google-Smtp-Source: ABdhPJzc3GuKmI6Y9PNbGdFU7ZNgInk/1fblltE9ZDG2nZmcQpd/9evaVqDrttzglWTjMmkVg1PjRQ== X-Received: by 2002:a17:902:ff07:b029:d8:eea2:afae with SMTP id f7-20020a170902ff07b02900d8eea2afaemr1604511plj.18.1606277218752; Tue, 24 Nov 2020 20:06:58 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 11/11] target/arm: Enforce alignment for VLDn/VSTn (single) Date: Tue, 24 Nov 2020 20:06:42 -0800 Message-Id: <20201125040642.2339476-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201125040642.2339476-1-richard.henderson@linaro.org> References: <20201125040642.2339476-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate-neon.c.inc | 39 ++++++++++++++++++++++++++------- 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.= inc index 330b5fc7b0..160dc3d755 100644 --- a/target/arm/translate-neon.c.inc +++ b/target/arm/translate-neon.c.inc @@ -602,6 +602,7 @@ static bool trans_VLDST_single(DisasContext *s, arg_VLD= ST_single *a) int nregs =3D a->n + 1; int vd =3D a->vd; TCGv_i32 addr, tmp; + MemOp mop; =20 if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { return false; @@ -651,25 +652,47 @@ static bool trans_VLDST_single(DisasContext *s, arg_V= LDST_single *a) return true; } =20 + mop =3D s->be_data | a->size; + if (a->align) { + static const MemOp mop_align[] =3D { + MO_ALIGN_2, MO_ALIGN_4, MO_ALIGN_8, MO_ALIGN_16 + }; + + switch (nregs) { + case 1: + mop |=3D MO_ALIGN; + break; + case 2: + mop |=3D mop_align[a->size]; + break; + case 3: + /* the align field is repurposed for VLD3 */ + break; + case 4: + mop |=3D mop_align[a->size + a->align]; + break; + default: + g_assert_not_reached(); + } + } + tmp =3D tcg_temp_new_i32(); addr =3D tcg_temp_new_i32(); load_reg_var(s, addr, a->rn); - /* - * TODO: if we implemented alignment exceptions, we should check - * addr against the alignment encoded in a->align here. - */ + for (reg =3D 0; reg < nregs; reg++) { if (a->l) { - gen_aa32_ld_i32(s, tmp, addr, get_mem_index(s), - s->be_data | a->size); + gen_aa32_ld_i32(s, tmp, addr, get_mem_index(s), mop); neon_store_element(vd, a->reg_idx, a->size, tmp); } else { /* Store */ neon_load_element(tmp, vd, a->reg_idx, a->size); - gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), - s->be_data | a->size); + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), mop); } vd +=3D a->stride; tcg_gen_addi_i32(addr, addr, 1 << a->size); + + /* Subsequent memory operations inherit alignment */ + mop &=3D ~MO_AMASK; } tcg_temp_free_i32(addr); tcg_temp_free_i32(tmp); --=20 2.25.1