From nobody Sat May 4 02:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) client-ip=209.85.128.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1606225561; cv=none; d=zohomail.com; s=zohoarc; b=G3CInv9KH/t8jsqsgq3R8qoCyun8p+OwrfTNmf/zn8lzdgUPgWreKUOjY2Z+NyeniDaMHL5P0FHB+GzX/u3fVDveHt6PIPofH52+nZvAZWO2d+tf2hETS+cG/I7MsF8zdDFYd26JsrrVr1YgjpCBsJDyc7SD9Y5TvdlY1MA7hiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606225561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=C2xrswIYQC3MHerh1wrJ1i0Bm0rEq5AoBCCydf63AYQ=; b=I2RGpWK56fnx+ZeYstbbQh6BJ9CeO3xejjLk7834QkF797pdR1j7PvZTI2lioCQ8LSdwJaTRQUUYjAZ1YYe/lrFhFL4vcT1S1EFgP6E5hi4UqeDnBaM54qg+ZHMRPUcZbiVjZV7nP4qiLI8jNlOUqr/Hyu5lMLuyu7uzyQxwRfg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.zohomail.com with SMTPS id 1606225561158778.471608254331; Tue, 24 Nov 2020 05:46:01 -0800 (PST) Received: by mail-wm1-f65.google.com with SMTP id x13so2074175wmj.1 for ; Tue, 24 Nov 2020 05:46:00 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id n9sm5435719wmd.4.2020.11.24.05.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 05:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C2xrswIYQC3MHerh1wrJ1i0Bm0rEq5AoBCCydf63AYQ=; b=KGJ6N+gnHC4p7WgaBKxKTSWAyFrMgC3LXrZ1UbVk+meMzDgRW3RgieVRCkBnpQ8Qjm RI2j6FTAxpgYqGTe6SQdrfoY4AJYOB3gOVNAyxesUxOWB0gljloRrNLZEAdcL0cgROQN Yhr0EMa/OiOu0EusuUTXflcCF7bMG3t590Q8stE19MyKHjv8V9bqQAXfpWPEkWtncmqh WEYt9bQXIrz3xnhmLMJlY5wXBLA8RaD4Z7KgVSuiJxlhSGQnzUt8DGcbyzUABXpFDAhB JYz5O4o5xii44SJTuXKMPabehBXeDt2hlH8IAiYgVtF6m+l6ks3no7gvlsE0G59WtGTH ac9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=C2xrswIYQC3MHerh1wrJ1i0Bm0rEq5AoBCCydf63AYQ=; b=nwMeTjkHI75Q2mT1TZ83G1tAme78aBk4i9oFamAvJX+VSRxtibYxB7R/udKdMiuMqA MazMRFOtKIScRW7ktcAZN74JRN4loWlLt/ng556EbDYTMRuaHjNvgtHIrdnZg62oJx2a C+g6Lt8wyhvQXJmgRrLBxWdHno43kghOQed/VxseE8lF+8QcqWEqf+Tc5mibLt3maBuZ PMfhdAM5GqOkcgJHGmgn0QwoD0DBJrMJwYhspNB82umC94pcW3LMkYMNPdfp7J1GuFJJ wK9gAib5Ix/umvZyD+pr+v0gM2d1PzKbpVYG2e36Vcguwkqz9JjLGEmtwqnTBzUkk67A ol9w== X-Gm-Message-State: AOAM532MtSootp1sr72B4HMdiPqHnIWbXBtstzt29qBYhsdV4nAmY0jB juJDCDiQX/HAwRF5N/UePzR5+qUsVGs= X-Google-Smtp-Source: ABdhPJyW35xLXLxXXgJqhg4M3z2cGls94V0ljRdjsJqr397GIdDbfQ9t5vkP9bX8583wPM4ggqo4Ug== X-Received: by 2002:a1c:41c4:: with SMTP id o187mr4648565wma.48.1606225559244; Tue, 24 Nov 2020 05:45:59 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Maciej W . Rozycki" , Mateja Marjanovic , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno Subject: [PATCH-for-5.2?] target/mips/translate: Check R6 reserved encoding for Load Linked Word Date: Tue, 24 Nov 2020 14:45:57 +0100 Message-Id: <20201124134557.569388-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Release 6 recoded the 'Load Linked Word' using SPECIAL3 opcode, this opcode (0b110000) is now reserved. Ref: A.2 Instruction Bit Encoding Tables: "6Rm instructions signal a Reserved Instruction exception when executed by a Release 6 implementation." The check was added in commit 4368b29a26e ("target-mips: move LL and SC instructions") but got lost during latter refactor in commit d9224450208 ("target-mips: Tighten ISA level checks"). Fixes: d9224450208 ("target-mips: Tighten ISA level checks") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index c64a1bc42e1..b1e7c674d3f 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -30993,6 +30993,7 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) break; case OPC_LL: /* Load and stores */ check_insn(ctx, ISA_MIPS2); + check_insn_opc_removed(ctx, ISA_MIPS32R6); if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); } --=20 2.26.2