From nobody Thu May 2 23:37:54 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606221068; cv=none; d=zohomail.com; s=zohoarc; b=SXNHV88uKoYjkRvfd35bQNPnWPwBEDi1Kzto6vj91ZxQbTkfo9nnM1E1LmThbNW0ofAS2Lwbt7cYpHUd3y1kA2TvHiVtOcg/0gw+X1deYMRkrR7Y0fpY4uyikn7/iW0kmGjn4y889CS0tiyFnRusaiUkpws8pGZEBzKpfx88GVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606221068; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=w16Fyyak3V+56+b4078EYuedaI8VWVp+kB4PkHonqJA=; b=k2O8sLYkcsN7hxutJVlP1BkpIA00/bUgtJIPOrojODu5I5ekKPTFHjrCDw+GdQWBoz1kCcXKHftZ93sfdN4TIWasEGlwY7gx46L+G0oiKJGI3NRwHa+h2hFOQD0uv8Lm8quqQNIPqiqQW3JgXM+OUviZ7Q1CO4Bjk+f3YOQ2ucI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606221068009755.8710555273346; Tue, 24 Nov 2020 04:31:08 -0800 (PST) Received: from localhost ([::1]:40724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khXTO-0005Lt-8F for importer@patchew.org; Tue, 24 Nov 2020 07:31:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khXS6-0004Pd-CH for qemu-devel@nongnu.org; Tue, 24 Nov 2020 07:29:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khXS4-0005DD-RS for qemu-devel@nongnu.org; Tue, 24 Nov 2020 07:29:46 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-135-RP9dlDd6OD-QLp6BAsb76Q-1; Tue, 24 Nov 2020 07:29:41 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B79D98145E3 for ; Tue, 24 Nov 2020 12:29:40 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8345360875; Tue, 24 Nov 2020 12:29:37 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8AC9F17535; Tue, 24 Nov 2020 13:29:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606220983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w16Fyyak3V+56+b4078EYuedaI8VWVp+kB4PkHonqJA=; b=DhTGX+E5fwA17KgzVCySVBS+FqpGFGcqOy5doKlEXJiFflfATqjuQvVazhfZhDYJXkH0Ox F8YArC1OhO6c2uHcrq0zsa+9/OH3yhD5zJFXZMojmO4D5eHpRoKhHJJi8pCncME5/cG8mX dfg7Nztrx/c6tFFUa9VwWn/v6r72I+Q= X-MC-Unique: RP9dlDd6OD-QLp6BAsb76Q-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH] qxl: fix segfault Date: Tue, 24 Nov 2020 13:29:36 +0100 Message-Id: <20201124122936.30588-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Add missing sanity check. Reproducer: run qemu with "-device qxl" but without "-spice ..." Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine") Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau --- ui/console.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index e07d2c380df7..53dee8e26b17 100644 --- a/ui/console.c +++ b/ui/console.c @@ -264,7 +264,9 @@ static void gui_setup_refresh(DisplayState *ds) =20 void graphic_hw_update_done(QemuConsole *con) { - qemu_co_queue_restart_all(&con->dump_queue); + if (con) { + qemu_co_queue_restart_all(&con->dump_queue); + } } =20 void graphic_hw_update(QemuConsole *con) --=20 2.27.0