From nobody Wed May 1 13:41:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1606214292; cv=none; d=zohomail.com; s=zohoarc; b=lrygyk8oUURmDySRdTEzN6nqtxTgR6564ZwPgiufwIBzwgh+jADgVkugQS+e79/SuodABTLRZa4d6KtFJPttui735Y59wXjbDWARg22NX5r/p12TiWbrJawVkdwBmo6yj6pLBqNMdijpOdzC4UhxU6Ie244CxFyF+N9lGb560mQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606214292; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=pXPYz5S1V8THmQFQE2Dw6eRg7/CvEX28euLcNTUQWsY=; b=fuM0OYCTLX8fxe3b+xBp3CHUtJ6uEsmP+4GF8QreFUZNBC2tink7BetPrL2bLREZQrNpIihmRPievzCkaB7F7zhiSdSXAUj5zFRVBPnIjoCBN0u57806U9eM5RU0Hr/BfvWGqrQKQ1LVrHYsxxu9uvFPKYJHm+AWLh3KL4hLQro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 1606214292883899.7163943853576; Tue, 24 Nov 2020 02:38:12 -0800 (PST) Received: by mail-wr1-f66.google.com with SMTP id e7so4245398wrv.6 for ; Tue, 24 Nov 2020 02:38:12 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id q5sm27274266wrf.41.2020.11.24.02.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 02:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pXPYz5S1V8THmQFQE2Dw6eRg7/CvEX28euLcNTUQWsY=; b=pL7N23NEkdwhw3kEsKSaKlFmUjbmmXp3JSA5WXobDeoCrNcZ3Ag+EZNclD+BkiQzjq mUQ9cd2mwpWrh4yEmzGVnOVOijoD9z6AK2nK5l/zqtZJLTRk4CXY19jfaqrIo9QoKfyo HvlR19Y6B5MmYZPxjz7aZqkPSyeYDMG/eDDIYZpy739loSeFNfweaX22pQ8r1/MPYqcL dbyx2dh7xmXAcqq3ooRyqC9vDvSDZNqSuA7NOAp3JwI0zwKbQorguZlOMl5FYcgyUb3L e4V76gM20j9cOZEHam/8Ygllj0Df3ap3a19QplErkH129jow0I9AY/oMkxd01G1jHCmC llNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=pXPYz5S1V8THmQFQE2Dw6eRg7/CvEX28euLcNTUQWsY=; b=NCrYNffNao2Te92bK+p70h+Lab9qtXkoNjtEqSbMYLBiQzUhT9mP8E+Jz+r5HDkjKU 35eAzKuOkFcW5ezHkV/k/D1Te/1ghXMO1F6XWcBCCTO//A4hFRfZLl7FBHIdARIh0ZfH kTbEWSabXahyhR8iy5KfTOlw3W/YI52y2SbqQUf4DxOgq6gjBcWAsUBmv3n8pyOvHBjg 63e8BeWbdrh0CRe0qRi+EFEBU2M4j6d/9cP/FHVetpqznl+cZdf17Rfl8HsTn4NY7fhh uWrxUNUhQ5QKlxLQoK+PBv1J45QiVGZcErvcAY1WP9JucPV8ap4hetVtcwaEeQeVayqd NmWw== X-Gm-Message-State: AOAM531AfOp6vDY0T2TAfsG07XRRUda4dNpPEQLX8TY43sqAyHeRst7L fGYZndaoPkXMR7ZDU98owA0= X-Google-Smtp-Source: ABdhPJxYN2X/xqMk2elK0uJC1BuLGa4jPTqKs7T0VnRzYjo2EPanjHkHXfRk+WBilE/KlC/ylxfZQA== X-Received: by 2002:adf:c648:: with SMTP id u8mr4440544wrg.215.1606214291006; Tue, 24 Nov 2020 02:38:11 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson , Aurelien Jarno , Mateja Marjanovic , Jiaxun Yang Subject: [PATCH] target/mips/translate: Simplify PCPYH using deposit/extract Date: Tue, 24 Nov 2020 11:38:08 +0100 Message-Id: <20201124103808.499948-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Simplify (and optimize) the Parallel Copy Halfword instruction using deposit() / extract() helpers. Ref: C790-Specific Instruction Set, Appendix B-63. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 35 ++++++++++------------------------- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index c64a1bc42e1..17a28557c2c 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -25220,34 +25220,19 @@ static void gen_mmi_pcpyh(DisasContext *ctx) tcg_gen_movi_i64(cpu_mmr[rd], 0); } else { TCGv_i64 t0 =3D tcg_temp_new(); - TCGv_i64 t1 =3D tcg_temp_new(); - uint64_t mask =3D (1ULL << 16) - 1; =20 - tcg_gen_andi_i64(t0, cpu_gpr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); + tcg_gen_extract_i64(t0, cpu_gpr[a->rt], 0, 16); + tcg_gen_deposit_i64(cpu_gpr[a->rd], cpu_gpr[a->rd], t0, 0, 16); + tcg_gen_deposit_i64(cpu_gpr[a->rd], cpu_gpr[a->rd], t0, 16, 16); + tcg_gen_deposit_i64(cpu_gpr[a->rd], cpu_gpr[a->rd], t0, 32, 16); + tcg_gen_deposit_i64(cpu_gpr[a->rd], cpu_gpr[a->rd], t0, 48, 16); =20 - tcg_gen_mov_i64(cpu_gpr[rd], t1); + tcg_gen_extract_i64(t0, cpu_gpr_hi[a->rt], 0, 16); + tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], cpu_gpr_hi[a->rd], t0, 0, 1= 6); + tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], cpu_gpr_hi[a->rd], t0, 16, = 16); + tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], cpu_gpr_hi[a->rd], t0, 32, = 16); + tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], cpu_gpr_hi[a->rd], t0, 48, = 16); =20 - tcg_gen_andi_i64(t0, cpu_mmr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_mmr[rd], t1); - - tcg_temp_free(t0); tcg_temp_free(t1); } } --=20 2.26.2