From nobody Thu Apr 25 15:13:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605860361; cv=none; d=zohomail.com; s=zohoarc; b=VCgOerFLVHNeNcc5F/CBn63SJ+CWKflOdlQD4IfoQfrk/0Dp8B5QSbr/0rPyBRnveaAUBb+bfj44zYbFHtIBHQ5AGbnE/8aWdaxGWU9RjXkMoCWZsYFd4mHYWD/ljGzGdQ1lA3Uxyyqpuw9yGdcnK5UFp9sFQoHMPkrmxNq63Ww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605860361; h=Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=tIwF4tLiGV6KZVvwaGfM84Gt/NwgPoNFu0ENB4P6Nj4=; b=CiJgA9d1XIoh6aFjoMHFQ4ov/IR6iyE7enrJLKahoonK6aOUDH+NZHtXE5j0R5xxcXmO+n/HEz6wrmPOUSexPAJFtdeKsBgLn9/u0SUV0JCJz4ZbbyYa0ZkWhBHUT8xKP9IyJlJvs07qC1vm5+P/4IBRolXZHaDYZHKK1e9lVSM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605860361273235.40081219195383; Fri, 20 Nov 2020 00:19:21 -0800 (PST) Received: from localhost ([::1]:59990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg1dX-0000hk-Nm for importer@patchew.org; Fri, 20 Nov 2020 03:19:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg1cS-0000DE-BL for qemu-devel@nongnu.org; Fri, 20 Nov 2020 03:18:12 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:58722 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg1cP-0005Xp-HV for qemu-devel@nongnu.org; Fri, 20 Nov 2020 03:18:11 -0500 Received: from host86-179-247-26.range86-179.btcentralplus.com ([86.179.247.26] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kg1ca-0005O1-2b; Fri, 20 Nov 2020 08:18:21 +0000 From: Mark Cave-Ayland To: f4bug@amsat.org, gson@gson.org, 1892540@bugs.launchpad.net, qemu-devel@nongnu.org Date: Fri, 20 Nov 2020 08:17:54 +0000 Message-Id: <20201120081754.18250-1-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.179.247.26 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH for-5.2] hw/display/tcx: add missing 64-bit access for framebuffer blitter X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Commit ae5643ecc6 "hw/display/tcx: Allow 64-bit accesses to framebuffer sti= ppler and blitter" enabled 64-bit access for the TCX framebuffer stippler and bli= tter but missed applying the change to one of the blitter MemoryRegions. Whilst the original change works for me on my local NetBSD test image, the = latest NetBSD ISO panics on startup without this fix. Signed-off-by: Mark Cave-Ayland Fixes: ae5643ecc6 ("hw/display/tcx: Allow 64-bit accesses to framebuffer st= ippler and blitter") Buglink: https://bugs.launchpad.net/bugs/1892540 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/tcx.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 878ecc8c50..3799d29b75 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -649,10 +649,14 @@ static const MemoryRegionOps tcx_blit_ops =3D { .read =3D tcx_blit_readl, .write =3D tcx_blit_writel, .endianness =3D DEVICE_NATIVE_ENDIAN, - .valid =3D { + .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, }, + .valid =3D { + .min_access_size =3D 4, + .max_access_size =3D 8, + }, }; =20 static const MemoryRegionOps tcx_rblit_ops =3D { --=20 2.20.1