From nobody Tue May 7 06:50:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605782046; cv=none; d=zohomail.com; s=zohoarc; b=TPpuuKJiIshxSXEHSCoMHVK63JCoV6iC8YohZ910u9R2qJPXh9JrARlwAbaj+RykaczMhibdGEjbglIqadz+h8ohNJrJfmNdmN6Dm5d/BOgMA57mVs3piDtRjsL5U7RgXuxQyVmaIxyXWgFcyai2voWhWr9odp7Oysbhw1Ce5Bw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605782046; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=67+5A7Lw/CKiVeQEGb5PuiunFj9yz7T8LGeU84HjuIk=; b=daRwrz2Ou+p2LSogXyCPH7NnaQAyQ0Cux8AD7cTxuyahsCTh08QeKmm6ta7TZHls2TTSQ3F4r7q5X0x+e3adIPiAi9s+qJzPAgb/bIEeBNXMkdXxG089t+MdABQuxDdvmYm7lkobGYPonBL+sXQEEc6tcYXmQVRSbAh7Ukxe+Wk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605782046775674.1143139018333; Thu, 19 Nov 2020 02:34:06 -0800 (PST) Received: from localhost ([::1]:36670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfhGO-0002MP-SS for importer@patchew.org; Thu, 19 Nov 2020 05:34:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfhEt-0000rJ-Go for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kfhEr-0007XD-6s for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:31 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-108-H-pt5ftIPV2Gwl-RbwCcqA-1; Thu, 19 Nov 2020 05:32:26 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A71FF18957E9 for ; Thu, 19 Nov 2020 10:32:25 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.193.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52D8360854; Thu, 19 Nov 2020 10:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605781948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=67+5A7Lw/CKiVeQEGb5PuiunFj9yz7T8LGeU84HjuIk=; b=A6TlGmXMZWZ3XTiQwOh1vV8pBhV1QJwPLWK3wnjGs5hIyHLlg/4aHFvnaD66W0qFcZsZxM VQ4kjnSRfGQ84kQvX8CADvf/H99unP4ttQmP+nWeI3tKY9DQFOa57f0s8GD8MFLH0tkeO4 RPgLNsfc0ncW+1VsLOHqEEPIGY0/Y48= X-MC-Unique: H-pt5ftIPV2Gwl-RbwCcqA-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org Subject: [PATCH 1/5] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn() Date: Thu, 19 Nov 2020 11:32:17 +0100 Message-Id: <20201119103221.1665171-2-vkuznets@redhat.com> In-Reply-To: <20201119103221.1665171-1-vkuznets@redhat.com> References: <20201119103221.1665171-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vkuznets@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 23:36:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Marcelo Tosatti , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" As a preparation to expanding Hyper-V CPU features early, move hyperv_vendor_id initialization to x86_cpu_realizefn(). Introduce x86_cpu_hyperv_realize() to not not pollute x86_cpu_realizefn() itself. Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 23 ++++++++++++++++++++++- target/i386/cpu.h | 3 ++- target/i386/kvm.c | 25 ++++++++++--------------- 3 files changed, 34 insertions(+), 17 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 5a8c96072e41..2a6885753378 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6509,6 +6509,25 @@ static void x86_cpu_filter_features(X86CPU *cpu, boo= l verbose) } } =20 +static void x86_cpu_hyperv_realize(X86CPU *cpu) +{ + size_t len; + + /* Hyper-V vendor id */ + if (!cpu->hyperv_vendor) { + memcpy(cpu->hyperv_vendor_id, "Microsoft Hv", 12); + } else { + len =3D strlen(cpu->hyperv_vendor); + + if (len > 12) { + warn_report("hv-vendor-id truncated to 12 characters"); + len =3D 12; + } + memset(cpu->hyperv_vendor_id, 0, 12); + memcpy(cpu->hyperv_vendor_id, cpu->hyperv_vendor, len); + } +} + static void x86_cpu_realizefn(DeviceState *dev, Error **errp) { CPUState *cs =3D CPU(dev); @@ -6680,6 +6699,8 @@ static void x86_cpu_realizefn(DeviceState *dev, Error= **errp) env->cache_info_amd.l3_cache =3D &legacy_l3_cache; } =20 + /* Process Hyper-V enlightenments */ + x86_cpu_hyperv_realize(cpu); =20 cpu_exec_realizefn(cs, &local_err); if (local_err !=3D NULL) { @@ -7198,7 +7219,7 @@ static Property x86_cpu_properties[] =3D { DEFINE_PROP_UINT32("min-xlevel2", X86CPU, env.cpuid_min_xlevel2, 0), DEFINE_PROP_UINT64("ucode-rev", X86CPU, ucode_rev, 0), DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU, full_cpuid_auto_leve= l, true), - DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor_id), + DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor), DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true), DEFINE_PROP_BOOL("lmce", X86CPU, enable_lmce, false), DEFINE_PROP_BOOL("l3-cache", X86CPU, enable_l3_cache, true), diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 88e8586f8fb4..be640bf45c29 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1655,11 +1655,12 @@ struct X86CPU { uint64_t ucode_rev; =20 uint32_t hyperv_spinlock_attempts; - char *hyperv_vendor_id; + char *hyperv_vendor; bool hyperv_synic_kvm_only; uint64_t hyperv_features; bool hyperv_passthrough; OnOffAuto hyperv_no_nonarch_cs; + uint32_t hyperv_vendor_id[3]; =20 bool check_cpuid; bool enforce_cpuid; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index a2934dda027c..788a2cf2ec51 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1205,6 +1205,13 @@ static int hyperv_handle_properties(CPUState *cs, memcpy(cpuid_ent, &cpuid->entries[0], cpuid->nent * sizeof(cpuid->entries[0])); =20 + c =3D cpuid_find_entry(cpuid, HV_CPUID_VENDOR_AND_MAX_FUNCTIONS, 0= ); + if (c) { + cpu->hyperv_vendor_id[0] =3D c->ebx; + cpu->hyperv_vendor_id[1] =3D c->ecx; + cpu->hyperv_vendor_id[2] =3D c->edx; + } + c =3D cpuid_find_entry(cpuid, HV_CPUID_FEATURES, 0); if (c) { env->features[FEAT_HYPERV_EAX] =3D c->eax; @@ -1279,23 +1286,11 @@ static int hyperv_handle_properties(CPUState *cs, =20 c =3D &cpuid_ent[cpuid_i++]; c->function =3D HV_CPUID_VENDOR_AND_MAX_FUNCTIONS; - if (!cpu->hyperv_vendor_id) { - memcpy(signature, "Microsoft Hv", 12); - } else { - size_t len =3D strlen(cpu->hyperv_vendor_id); - - if (len > 12) { - error_report("hv-vendor-id truncated to 12 characters"); - len =3D 12; - } - memset(signature, 0, 12); - memcpy(signature, cpu->hyperv_vendor_id, len); - } c->eax =3D hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS) ? HV_CPUID_NESTED_FEATURES : HV_CPUID_IMPLEMENT_LIMITS; - c->ebx =3D signature[0]; - c->ecx =3D signature[1]; - c->edx =3D signature[2]; + c->ebx =3D cpu->hyperv_vendor_id[0]; + c->ecx =3D cpu->hyperv_vendor_id[1]; + c->edx =3D cpu->hyperv_vendor_id[2]; =20 c =3D &cpuid_ent[cpuid_i++]; c->function =3D HV_CPUID_INTERFACE; --=20 2.26.2 From nobody Tue May 7 06:50:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605782048; cv=none; d=zohomail.com; s=zohoarc; b=Epn8Xx1uFQnLzWUjcXF05ugv6qaSpX3Dkyj9mkqXBZ0IVS0vjG03ySwgHf5G8vsoaqLgW7nsEEiYH2syCjt52KAQoUCWUc4jVvxe/8uSMg0sq0Dd0v9p8KpADcV12VJ0/dmhw+hf7LHqx+8WNE6/d9xV3Ujil3/P6oJb7Ai4e9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605782048; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=omc7TRuONExAhVIJ0XSu8a+uM7zNFhfUz/mxNMAY6rM=; b=lGUv6bsbd1rRRLwi0g7GMBJHqBzSjG5eLnJw3vfJVwZEbNkkh6TDP/mMnLtT8G04YO3j4x90rAW1SGIun3TA/ssKn/IIWH/W2n/i+Xtzk+P0EEcmOcfn7j2TvE11xUYoVLBThLOSC9EFVdY5X6TRfvB+yuBYRJentKqIVSqINq4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605782048022136.55996108607246; Thu, 19 Nov 2020 02:34:08 -0800 (PST) Received: from localhost ([::1]:36834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfhGQ-0002Qi-HX for importer@patchew.org; Thu, 19 Nov 2020 05:34:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfhEu-0000rg-MC for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kfhEs-0007Xb-Ga for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:32 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-lUJQlZyGMV-Esfq5xmlFIA-1; Thu, 19 Nov 2020 05:32:28 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CC70801B1F for ; Thu, 19 Nov 2020 10:32:27 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.193.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 088DA60854; Thu, 19 Nov 2020 10:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605781949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=omc7TRuONExAhVIJ0XSu8a+uM7zNFhfUz/mxNMAY6rM=; b=Lm6z7RlGdSwnA09gRkKToSq++BRdc9MQ0ZZF+FTzDcBqV4M0TqmwLyo9dF5w+oXNdQs0id AJcqCSAHJSiAyTnWxqe1kC5G3rBVYtE78yh3iWWvuy8zT7W7v6+EH52Z88f9e2MFbu4a+0 6hm2rmF7v8w1ioweTBf6mT016EqYWxY= X-MC-Unique: lUJQlZyGMV-Esfq5xmlFIA-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org Subject: [PATCH 2/5] i386: move hyperv_interface_id initialization to x86_cpu_realizefn() Date: Thu, 19 Nov 2020 11:32:18 +0100 Message-Id: <20201119103221.1665171-3-vkuznets@redhat.com> In-Reply-To: <20201119103221.1665171-1-vkuznets@redhat.com> References: <20201119103221.1665171-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vkuznets@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 23:36:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Marcelo Tosatti , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" As a preparation to expanding Hyper-V CPU features early, move hyperv_interface_id initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 6 ++++++ target/i386/cpu.h | 1 + target/i386/kvm.c | 18 ++++++++++++------ 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 2a6885753378..18a73ca4708b 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6526,6 +6526,12 @@ static void x86_cpu_hyperv_realize(X86CPU *cpu) memset(cpu->hyperv_vendor_id, 0, 12); memcpy(cpu->hyperv_vendor_id, cpu->hyperv_vendor, len); } + + /* 'Hv#1' interface identification*/ + cpu->hyperv_interface_id[0] =3D 0x31237648; + cpu->hyperv_interface_id[1] =3D 0; + cpu->hyperv_interface_id[2] =3D 0; + cpu->hyperv_interface_id[3] =3D 0; } =20 static void x86_cpu_realizefn(DeviceState *dev, Error **errp) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index be640bf45c29..1f30d642007c 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1661,6 +1661,7 @@ struct X86CPU { bool hyperv_passthrough; OnOffAuto hyperv_no_nonarch_cs; uint32_t hyperv_vendor_id[3]; + uint32_t hyperv_interface_id[4]; =20 bool check_cpuid; bool enforce_cpuid; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 788a2cf2ec51..eb09766ec9b7 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1168,7 +1168,6 @@ static int hyperv_handle_properties(CPUState *cs, CPUX86State *env =3D &cpu->env; struct kvm_cpuid2 *cpuid; struct kvm_cpuid_entry2 *c; - uint32_t signature[3]; uint32_t cpuid_i =3D 0; int r; =20 @@ -1212,6 +1211,14 @@ static int hyperv_handle_properties(CPUState *cs, cpu->hyperv_vendor_id[2] =3D c->edx; } =20 + c =3D cpuid_find_entry(cpuid, HV_CPUID_INTERFACE, 0); + if (c) { + cpu->hyperv_interface_id[0] =3D c->eax; + cpu->hyperv_interface_id[1] =3D c->ebx; + cpu->hyperv_interface_id[2] =3D c->ecx; + cpu->hyperv_interface_id[3] =3D c->edx; + } + c =3D cpuid_find_entry(cpuid, HV_CPUID_FEATURES, 0); if (c) { env->features[FEAT_HYPERV_EAX] =3D c->eax; @@ -1294,11 +1301,10 @@ static int hyperv_handle_properties(CPUState *cs, =20 c =3D &cpuid_ent[cpuid_i++]; c->function =3D HV_CPUID_INTERFACE; - memcpy(signature, "Hv#1\0\0\0\0\0\0\0\0", 12); - c->eax =3D signature[0]; - c->ebx =3D 0; - c->ecx =3D 0; - c->edx =3D 0; + c->eax =3D cpu->hyperv_interface_id[0]; + c->ebx =3D cpu->hyperv_interface_id[1]; + c->ecx =3D cpu->hyperv_interface_id[2]; + c->edx =3D cpu->hyperv_interface_id[3]; =20 c =3D &cpuid_ent[cpuid_i++]; c->function =3D HV_CPUID_VERSION; --=20 2.26.2 From nobody Tue May 7 06:50:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605782050; cv=none; d=zohomail.com; s=zohoarc; b=cFXD4xuF/gGTzrWKKOP8VHKo/Dgh3KHMdcyKX6JBPz6t/2zzJtXdzBSZO4c+hHo+4MHBTDc7oq5LKO+hkXeJ+HgC92qym0TDIurxe5Esd1jgWubE1rk4m1AgSDgLcsn3r01jiYqklU5jyjOxUDqufIw2dAGxW2QDkIO6NE0l7kY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605782050; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ccVsbNk2QdwM3pGNv4kZj49rkrzkM9UrTzWxML6Yezs=; b=CZgDZ3FjQgoVLoCmvOzO6o/5KT2FPm4apvceZCZ8RCuN6BaHcTzeVsGUzw6Y/o4DqJTzxxZo+TqNeyKan8ERu70rs2aND2msLQThvYwHWQQ44D1zRRRB4LhkqEHmj3On5n8Ih9L7+YJLhRv6axIg66w7WbWMNiXFyLRwsE4uCgs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160578205052836.21777825610536; Thu, 19 Nov 2020 02:34:10 -0800 (PST) Received: from localhost ([::1]:37202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfhGT-0002Zk-Cs for importer@patchew.org; Thu, 19 Nov 2020 05:34:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfhEw-0000u3-Hr for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kfhEu-0007Yh-Pg for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:34 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-m8vPc7BlN3eZFz6yN1xzeQ-1; Thu, 19 Nov 2020 05:32:29 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F323A1005D54 for ; Thu, 19 Nov 2020 10:32:28 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.193.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B76060854; Thu, 19 Nov 2020 10:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605781951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ccVsbNk2QdwM3pGNv4kZj49rkrzkM9UrTzWxML6Yezs=; b=Vy119d603FH4lQep71aqqXn36Ere5eCqxjeabx+tcfHsM0iZHQkzV9fybCQCbN1BVhVzFd 7CwoVfrLVB8GqALhK15u0T0plmrdbLEQ8Ox3GAR8CQjGe8O56LOWLIEgwxb8qRCkk2Ex0e E2s6IZvRBkZwG26f+NQ658ijvI6uu/k= X-MC-Unique: m8vPc7BlN3eZFz6yN1xzeQ-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org Subject: [PATCH 3/5] i386: move hyperv_version_id initialization to x86_cpu_realizefn() Date: Thu, 19 Nov 2020 11:32:19 +0100 Message-Id: <20201119103221.1665171-4-vkuznets@redhat.com> In-Reply-To: <20201119103221.1665171-1-vkuznets@redhat.com> References: <20201119103221.1665171-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vkuznets@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/19 03:44:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Marcelo Tosatti , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" As a preparation to expanding Hyper-V CPU features early, move hyperv_version_id initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 4 ++++ target/i386/cpu.h | 1 + target/i386/kvm.c | 14 ++++++++++++-- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 18a73ca4708b..9e182929d29d 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6532,6 +6532,10 @@ static void x86_cpu_hyperv_realize(X86CPU *cpu) cpu->hyperv_interface_id[1] =3D 0; cpu->hyperv_interface_id[2] =3D 0; cpu->hyperv_interface_id[3] =3D 0; + + /* Hypervisor system identity */ + cpu->hyperv_version_id[0] =3D 0x00001bbc; + cpu->hyperv_version_id[1] =3D 0x00060001; } =20 static void x86_cpu_realizefn(DeviceState *dev, Error **errp) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 1f30d642007c..913927356c55 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1662,6 +1662,7 @@ struct X86CPU { OnOffAuto hyperv_no_nonarch_cs; uint32_t hyperv_vendor_id[3]; uint32_t hyperv_interface_id[4]; + uint32_t hyperv_version_id[4]; =20 bool check_cpuid; bool enforce_cpuid; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index eb09766ec9b7..58a2528c6c41 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1219,6 +1219,14 @@ static int hyperv_handle_properties(CPUState *cs, cpu->hyperv_interface_id[3] =3D c->edx; } =20 + c =3D cpuid_find_entry(cpuid, HV_CPUID_VERSION, 0); + if (c) { + cpu->hyperv_version_id[0] =3D c->eax; + cpu->hyperv_version_id[1] =3D c->ebx; + cpu->hyperv_version_id[2] =3D c->ecx; + cpu->hyperv_version_id[3] =3D c->edx; + } + c =3D cpuid_find_entry(cpuid, HV_CPUID_FEATURES, 0); if (c) { env->features[FEAT_HYPERV_EAX] =3D c->eax; @@ -1308,8 +1316,10 @@ static int hyperv_handle_properties(CPUState *cs, =20 c =3D &cpuid_ent[cpuid_i++]; c->function =3D HV_CPUID_VERSION; - c->eax =3D 0x00001bbc; - c->ebx =3D 0x00060001; + c->eax =3D cpu->hyperv_version_id[0]; + c->ebx =3D cpu->hyperv_version_id[1]; + c->ecx =3D cpu->hyperv_version_id[2]; + c->edx =3D cpu->hyperv_version_id[3]; =20 c =3D &cpuid_ent[cpuid_i++]; c->function =3D HV_CPUID_FEATURES; --=20 2.26.2 From nobody Tue May 7 06:50:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605782170; cv=none; d=zohomail.com; s=zohoarc; b=F8AL4pFSmRDR5eG+faKmkklYYHb5ghs+y4/AcfAlBFRNNFyuX+JETh1wqFbkHpAm0j+euDYAL22iRlbIJlbUBMSNtkduMbGpf0ax+tnsX3spP5n91M5Xm12c+TIJBPfJ4Tuokp7rJMK8NE77i74rEPpu3T1pu/A9srKGorXXFWc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605782170; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qDY3p5tyvrzawRbC9R90nyX4k0K9UXvXdNNRJVMI38w=; b=P/48UWS6JG3ZGmDvA+P+VmFWdNxW15BoBwuIY/MsKT/cUlSufOp32U03CKQagGkdIOrStxGlzstMdAjjXr3npLRDYEUBT5Ih/oWk5ieDvzyJmR3weuxMfNDBPCdAy3GsWYBbQpqNBKJpH4KiEVi6l6ynhNPEUkvoOVwuzHhuxSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605782170643172.76288001196372; Thu, 19 Nov 2020 02:36:10 -0800 (PST) Received: from localhost ([::1]:43688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfhIP-0005Ez-Gb for importer@patchew.org; Thu, 19 Nov 2020 05:36:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfhEy-0000xP-7c for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kfhEw-0007Z4-F1 for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:35 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-enRaRFRGMHq_QcCNkFNlew-1; Thu, 19 Nov 2020 05:32:31 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C269318957E8 for ; Thu, 19 Nov 2020 10:32:30 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.193.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7255560854; Thu, 19 Nov 2020 10:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605781953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qDY3p5tyvrzawRbC9R90nyX4k0K9UXvXdNNRJVMI38w=; b=X2/JJ+U0FiBQhVx8RHSuXneJ509YiSBOpg30LjKCsOY3pP2mEIHdupQvp3M+eihZmn0w9V BEa2QF6OKnD0eVYK8EmHARhpapdETOvd/oBG7jpmj0Zsz+bj7yRMXR1wX//flm8yCqMCAO 7xAslbS6d0noWhDDUXmVNK5dkm1mXvw= X-MC-Unique: enRaRFRGMHq_QcCNkFNlew-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org Subject: [PATCH 4/5] i386: move hyperv_limits initialization to x86_cpu_realizefn() Date: Thu, 19 Nov 2020 11:32:20 +0100 Message-Id: <20201119103221.1665171-5-vkuznets@redhat.com> In-Reply-To: <20201119103221.1665171-1-vkuznets@redhat.com> References: <20201119103221.1665171-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vkuznets@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/19 03:44:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Marcelo Tosatti , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" As a preparation to expanding Hyper-V CPU features early, move hyperv_limits initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 5 +++++ target/i386/cpu.h | 1 + target/i386/kvm.c | 13 ++++++++++++- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 9e182929d29d..83aca942d87c 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6536,6 +6536,11 @@ static void x86_cpu_hyperv_realize(X86CPU *cpu) /* Hypervisor system identity */ cpu->hyperv_version_id[0] =3D 0x00001bbc; cpu->hyperv_version_id[1] =3D 0x00060001; + + /* Hypervisor implementation limits */ + cpu->hyperv_limits[0] =3D 64; + cpu->hyperv_limits[1] =3D 0; + cpu->hyperv_limits[2] =3D 0; } =20 static void x86_cpu_realizefn(DeviceState *dev, Error **errp) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 913927356c55..c95f20f59b15 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1663,6 +1663,7 @@ struct X86CPU { uint32_t hyperv_vendor_id[3]; uint32_t hyperv_interface_id[4]; uint32_t hyperv_version_id[4]; + uint32_t hyperv_limits[3]; =20 bool check_cpuid; bool enforce_cpuid; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 58a2528c6c41..446ab2ef1793 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1233,6 +1233,15 @@ static int hyperv_handle_properties(CPUState *cs, env->features[FEAT_HYPERV_EBX] =3D c->ebx; env->features[FEAT_HYPERV_EDX] =3D c->edx; } + + c =3D cpuid_find_entry(cpuid, HV_CPUID_IMPLEMENT_LIMITS, 0); + if (c) { + cpu->hv_max_vps =3D c->eax; + cpu->hyperv_limits[0] =3D c->ebx; + cpu->hyperv_limits[1] =3D c->ecx; + cpu->hyperv_limits[2] =3D c->edx; + } + c =3D cpuid_find_entry(cpuid, HV_CPUID_ENLIGHTMENT_INFO, 0); if (c) { env->features[FEAT_HV_RECOMM_EAX] =3D c->eax; @@ -1335,7 +1344,9 @@ static int hyperv_handle_properties(CPUState *cs, c =3D &cpuid_ent[cpuid_i++]; c->function =3D HV_CPUID_IMPLEMENT_LIMITS; c->eax =3D cpu->hv_max_vps; - c->ebx =3D 0x40; + c->ebx =3D cpu->hyperv_limits[0]; + c->ecx =3D cpu->hyperv_limits[1]; + c->edx =3D cpu->hyperv_limits[2]; =20 if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) { __u32 function; --=20 2.26.2 From nobody Tue May 7 06:50:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605782056; cv=none; d=zohomail.com; s=zohoarc; b=k2wO5lOPGdkTuNRcVjudDnBVQH60OQK9CGEboA1RlgLTBlFjXL+OQa6NKnl35J6IJSzdz9PimldWpQRMCxRW7AtVCgwggCQieyUlI8M9frRtFYgMwlmiXb9V3xGiQ7yNT+z24zuiHXSFW3+hX9ZnIyS3fFuF3KbH2u58AJYCLa8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605782056; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z9AWBek5mw1pq2Z1ZGIrsfVafF/UZRDeON3p3EpMOFo=; b=Ihg5ncTWRChAwpndXPxLMly0pFG/zYHYxmBrql5Hmxr7gkBFoce4heV5QBAeUrCJCor+B5W6SceLWqvne2ddgrx8M1am9a4uBFqEfJWcGS6FnM2i33zKYdtTWvCaf/YTDheEvOCkuGh/ZmF5sCeJV+s8xvfGCqorKx7OZigvaR0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16057820568331010.3623791148059; Thu, 19 Nov 2020 02:34:16 -0800 (PST) Received: from localhost ([::1]:37782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfhGZ-0002q5-Of for importer@patchew.org; Thu, 19 Nov 2020 05:34:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfhF0-00011n-3b for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:22542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kfhEx-0007a4-Rq for qemu-devel@nongnu.org; Thu, 19 Nov 2020 05:32:37 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-sENi3HptNC2rZbOPWYPLcQ-1; Thu, 19 Nov 2020 05:32:33 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6698CE745 for ; Thu, 19 Nov 2020 10:32:32 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.193.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E39860854; Thu, 19 Nov 2020 10:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605781955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z9AWBek5mw1pq2Z1ZGIrsfVafF/UZRDeON3p3EpMOFo=; b=MpAty5dELIMFahWVvpbzWxfbAqVW3oejkCVmPqXnIZzgE0yQ45W1TgNRTxS9Vm4EYZBRey /ihctTHaOn+xZJwRRdwBO4uPqCjpZzZsbnQQQ/MUNAVU7jcydnTMpEXHVgmSJaMpUhvgst g6OhzoOmvo2392eK4AaYrfyrULJxUIE= X-MC-Unique: sENi3HptNC2rZbOPWYPLcQ-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org Subject: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types Date: Thu, 19 Nov 2020 11:32:21 +0100 Message-Id: <20201119103221.1665171-6-vkuznets@redhat.com> In-Reply-To: <20201119103221.1665171-1-vkuznets@redhat.com> References: <20201119103221.1665171-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vkuznets@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 23:36:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Marcelo Tosatti , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Enabling Hyper-V emulation for a Windows VM is a tiring experience as it requires listing all currently supported enlightenments ("hv_*" CPU features) explicitly. We do have a 'hv_passthrough' mode enabling everything but it can't be used in production as it prevents migration. Introduce a simple 'hyperv=3Don' option for all x86 machine types enabling all currently supported Hyper-V enlightenments. Later, when new enlightenments get implemented, we will be adding them to newer machine types only (by disabling them for legacy machine types) thus preserving migration. Signed-off-by: Vitaly Kuznetsov Reviewed-by: Eduardo Habkost --- docs/hyperv.txt | 8 ++++++++ hw/i386/x86.c | 30 ++++++++++++++++++++++++++++++ include/hw/i386/x86.h | 7 +++++++ target/i386/cpu.c | 14 ++++++++++++++ 4 files changed, 59 insertions(+) diff --git a/docs/hyperv.txt b/docs/hyperv.txt index 5df00da54fc4..1a76a07f8417 100644 --- a/docs/hyperv.txt +++ b/docs/hyperv.txt @@ -29,6 +29,14 @@ When any set of the Hyper-V enlightenments is enabled, Q= EMU changes hypervisor identification (CPUID 0x40000000..0x4000000A) to Hyper-V. KVM identificati= on and features are kept in leaves 0x40000100..0x40000101. =20 +Hyper-V enlightenments can be enabled in bulk by specifying 'hyperv=3Don' = to an +x86 machine type: + + qemu-system-x86_64 -machine q35,accel=3Dkvm,kernel-irqchip=3Dsplit,hyper= v=3Don ... + +Note, new enlightenments are only added to the latest (in-develompent) mac= hine +type, older machine types keep the list of the supported features intact to +safeguard migration. =20 3. Existing enlightenments =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 5944fc44edca..57f27d56ecc6 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -1171,6 +1171,20 @@ static void x86_machine_set_acpi(Object *obj, Visito= r *v, const char *name, visit_type_OnOffAuto(v, name, &x86ms->acpi, errp); } =20 +static bool x86_machine_get_hyperv(Object *obj, Error **errp) +{ + X86MachineState *x86ms =3D X86_MACHINE(obj); + + return x86ms->hyperv_enabled; +} + +static void x86_machine_set_hyperv(Object *obj, bool value, Error **errp) +{ + X86MachineState *x86ms =3D X86_MACHINE(obj); + + x86ms->hyperv_enabled =3D value; +} + static void x86_machine_initfn(Object *obj) { X86MachineState *x86ms =3D X86_MACHINE(obj); @@ -1194,6 +1208,16 @@ static void x86_machine_class_init(ObjectClass *oc, = void *data) x86mc->save_tsc_khz =3D true; nc->nmi_monitor_handler =3D x86_nmi; =20 + /* Hyper-V features enabled with 'hyperv=3Don' */ + x86mc->default_hyperv_features =3D BIT(HYPERV_FEAT_RELAXED) | + BIT(HYPERV_FEAT_VAPIC) | BIT(HYPERV_FEAT_TIME) | + BIT(HYPERV_FEAT_CRASH) | BIT(HYPERV_FEAT_RESET) | + BIT(HYPERV_FEAT_VPINDEX) | BIT(HYPERV_FEAT_RUNTIME) | + BIT(HYPERV_FEAT_SYNIC) | BIT(HYPERV_FEAT_STIMER) | + BIT(HYPERV_FEAT_FREQUENCIES) | BIT(HYPERV_FEAT_REENLIGHTENMENT) | + BIT(HYPERV_FEAT_TLBFLUSH) | BIT(HYPERV_FEAT_EVMCS) | + BIT(HYPERV_FEAT_IPI) | BIT(HYPERV_FEAT_STIMER_DIRECT); + object_class_property_add(oc, X86_MACHINE_SMM, "OnOffAuto", x86_machine_get_smm, x86_machine_set_smm, NULL, NULL); @@ -1205,6 +1229,12 @@ static void x86_machine_class_init(ObjectClass *oc, = void *data) NULL, NULL); object_class_property_set_description(oc, X86_MACHINE_ACPI, "Enable ACPI"); + + object_class_property_add_bool(oc, X86_MACHINE_HYPERV, + x86_machine_get_hyperv, x86_machine_set_hyperv); + + object_class_property_set_description(oc, X86_MACHINE_HYPERV, + "Enable Hyper-V enlightenments"); } =20 static const TypeInfo x86_machine_info =3D { diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h index 739fac50871b..598abd1be806 100644 --- a/include/hw/i386/x86.h +++ b/include/hw/i386/x86.h @@ -38,6 +38,9 @@ struct X86MachineClass { bool save_tsc_khz; /* Enables contiguous-apic-ID mode */ bool compat_apic_id_mode; + + /* Hyper-V features enabled with 'hyperv=3Don' */ + uint64_t default_hyperv_features; }; =20 struct X86MachineState { @@ -71,10 +74,14 @@ struct X86MachineState { * will be translated to MSI messages in the address space. */ AddressSpace *ioapic_as; + + /* Hyper-V emulation */ + bool hyperv_enabled; }; =20 #define X86_MACHINE_SMM "smm" #define X86_MACHINE_ACPI "acpi" +#define X86_MACHINE_HYPERV "hyperv" =20 #define TYPE_X86_MACHINE MACHINE_TYPE_NAME("x86") OBJECT_DECLARE_TYPE(X86MachineState, X86MachineClass, X86_MACHINE) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 83aca942d87c..63a931679d73 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -53,6 +53,7 @@ #include "sysemu/tcg.h" #include "hw/qdev-properties.h" #include "hw/i386/topology.h" +#include "hw/i386/x86.h" #ifndef CONFIG_USER_ONLY #include "exec/address-spaces.h" #include "hw/i386/apic_internal.h" @@ -6511,8 +6512,21 @@ static void x86_cpu_filter_features(X86CPU *cpu, boo= l verbose) =20 static void x86_cpu_hyperv_realize(X86CPU *cpu) { + X86MachineState *x86ms =3D X86_MACHINE(qdev_get_machine()); + X86MachineClass *x86mc =3D X86_MACHINE_GET_CLASS(x86ms); + uint64_t feat; size_t len; =20 + if (x86ms->hyperv_enabled) { + feat =3D x86mc->default_hyperv_features; + /* Enlightened VMCS is only available on Intel/VMX */ + if (!cpu_has_vmx(&cpu->env)) { + feat &=3D ~BIT(HYPERV_FEAT_EVMCS); + } + + cpu->hyperv_features |=3D feat; + } + /* Hyper-V vendor id */ if (!cpu->hyperv_vendor) { memcpy(cpu->hyperv_vendor_id, "Microsoft Hv", 12); --=20 2.26.2