From nobody Sat May 4 16:07:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605721847; cv=none; d=zohomail.com; s=zohoarc; b=R+LEphtcpmdaLJzXmT2qCjF8FKAkNTsWmUb8DVYLp6VA6e1pDrDJSnh5G9Y6w7nMKd7Xwr6vu9OcvKWKwcdnjgX9j2JfIGx/Dg6qA6HOq2OwCjuhE9OpgMKfRQUpgMwiPzzAjVBdikAsrTKMslXD2WNLbY+QPSX7ob769qSsFdc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605721847; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=lZgIjar1NGJFLnfYQJ2qL73zqFaHJXDnBPzvme9TW9U=; b=L1AGGCUqMWaOi9JlkaEUFeX67jWst/d8NCGCFNEyWOKf/2gOd1gtKBNVV8qWriMNRwiKdgnwpSk65xta+5RJSk8bf6KbfK2czPvwU+GJexppzb3yw0OTW1HwbmA7xeZcuESHl1U81wtD3Iow3gqHHkijHNbooiQeWrPdST5FeJg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605721847469739.1958832507603; Wed, 18 Nov 2020 09:50:47 -0800 (PST) Received: from localhost ([::1]:43562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfRbR-0004Gf-RH for importer@patchew.org; Wed, 18 Nov 2020 12:50:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfRZI-0002vr-7x for qemu-devel@nongnu.org; Wed, 18 Nov 2020 12:48:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kfRZB-00066L-Av for qemu-devel@nongnu.org; Wed, 18 Nov 2020 12:48:28 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-6FHuctyfMZG4DaqrORxNgg-1; Wed, 18 Nov 2020 12:48:17 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C85956D24D; Wed, 18 Nov 2020 17:48:16 +0000 (UTC) Received: from localhost (ovpn-114-60.ams2.redhat.com [10.36.114.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68BD51964D; Wed, 18 Nov 2020 17:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605721701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lZgIjar1NGJFLnfYQJ2qL73zqFaHJXDnBPzvme9TW9U=; b=CsuArevB5CTFVEwb1Lq8s1GQTInS88m+34j/OG0QeTlWW4ln/gf0Mts7rzNUnF5KiJDyo7 AMhTB0S8OCnvfs2UIXtThK1jPht+lvmE1oMVqKk3V1FsUEHP8c6SmxSH2ccseArqH19NHE 8EMQ2EwKR+bfEDXrFnAkHN4ErBc4ov4= X-MC-Unique: 6FHuctyfMZG4DaqrORxNgg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH] trace: use STAP_SDT_V2 to work around symbol visibility Date: Wed, 18 Nov 2020 17:48:09 +0000 Message-Id: <20201118174809.686094-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/17 19:41:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , rjones@redhat.com, fche@redhat.com, kraxel@redhat.com, Stefan Hajnoczi , wcohen@redhat.com, mrezanin@redhat.com, ddepaula@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" QEMU binaries no longer launch successfully with recent SystemTap releases. This is because modular QEMU builds link the sdt semaphores into the main binary instead of into the shared objects where they are used. The symbol visibility of semaphores is 'hidden' and the dynamic linker prints an error during module loading: $ ./configure --enable-trace-backends=3Ddtrace --enable-modules ... ... Failed to open module: /builddir/build/BUILD/qemu-4.2.0/s390x-softmmu/../= block-curl.so: undefined symbol: qemu_curl_close_semaphore The long-term solution is to generate per-module dtrace .o files and link them into the module instead of the main binary. In the short term we can define STAP_SDT_V2 so /usr/bin/dtrace produces an .o file with 'default' symbol visibility instead of 'hidden'. This workaround is small and easier to merge for QEMU 5.2. Cc: Daniel P. Berrang=C3=A9 Cc: wcohen@redhat.com Cc: fche@redhat.com Cc: kraxel@redhat.com Cc: rjones@redhat.com Cc: mrezanin@redhat.com Cc: ddepaula@redhat.com Signed-off-by: Stefan Hajnoczi --- trace/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/meson.build b/trace/meson.build index d5fc45c628..52be7c5b2c 100644 --- a/trace/meson.build +++ b/trace/meson.build @@ -44,7 +44,7 @@ foreach dir : [ '.' ] + trace_events_subdirs trace_dtrace_o =3D custom_target(fmt.format('trace-dtrace', 'o'), output: fmt.format('trace-dtrace', 'o= '), input: trace_dtrace, - command: [ 'dtrace', '-o', '@OUTPUT@'= , '-G', '-s', '@INPUT@' ]) + command: [ 'dtrace', '-DSTAP_SDT_V2',= '-o', '@OUTPUT@', '-G', '-s', '@INPUT@' ]) trace_ss.add(trace_dtrace_o) endif =20 --=20 2.28.0