[RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds

Alex Bennée posted 1 patch 3 years, 4 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201118140739.18377-1-alex.bennee@linaro.org
.cirrus.yml | 2 ++
1 file changed, 2 insertions(+)
[RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
Posted by Alex Bennée 3 years, 4 months ago
These seem to trigger timeouts with some regularity.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .cirrus.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.cirrus.yml b/.cirrus.yml
index f0209b7a3e..08db7c419f 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -18,6 +18,7 @@ freebsd_12_task:
     - gmake -j$(sysctl -n hw.ncpu) check V=1
 
 macos_task:
+  timeout_in: 90m
   osx_instance:
     image: catalina-base
   install_script:
@@ -32,6 +33,7 @@ macos_task:
     - gmake check V=1
 
 macos_xcode_task:
+  timeout_in: 90m
   osx_instance:
     # this is an alias for the latest Xcode
     image: catalina-xcode
-- 
2.20.1


Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
Posted by Thomas Huth 3 years, 4 months ago
On 18/11/2020 15.07, Alex Bennée wrote:
> These seem to trigger timeouts with some regularity.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .cirrus.yml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.cirrus.yml b/.cirrus.yml
> index f0209b7a3e..08db7c419f 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -18,6 +18,7 @@ freebsd_12_task:
>      - gmake -j$(sysctl -n hw.ncpu) check V=1
>  
>  macos_task:
> +  timeout_in: 90m
>    osx_instance:
>      image: catalina-base
>    install_script:
> @@ -32,6 +33,7 @@ macos_task:
>      - gmake check V=1
>  
>  macos_xcode_task:
> +  timeout_in: 90m
>    osx_instance:
>      # this is an alias for the latest Xcode
>      image: catalina-xcode
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

... we could maybe also split the --target-list between the two jobs if they
take too long...


Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
Posted by Philippe Mathieu-Daudé 3 years, 3 months ago
On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
> On 18/11/2020 15.07, Alex Bennée wrote:
> > These seem to trigger timeouts with some regularity.
> >
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > ---
> >  .cirrus.yml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/.cirrus.yml b/.cirrus.yml
> > index f0209b7a3e..08db7c419f 100644
> > --- a/.cirrus.yml
> > +++ b/.cirrus.yml
> > @@ -18,6 +18,7 @@ freebsd_12_task:
> >      - gmake -j$(sysctl -n hw.ncpu) check V=1
> >
> >  macos_task:
> > +  timeout_in: 90m
> >    osx_instance:
> >      image: catalina-base
> >    install_script:
> > @@ -32,6 +33,7 @@ macos_task:
> >      - gmake check V=1
> >
> >  macos_xcode_task:
> > +  timeout_in: 90m
> >    osx_instance:
> >      # this is an alias for the latest Xcode
> >      image: catalina-xcode
> >
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> ... we could maybe also split the --target-list between the two jobs if they
> take too long...

Maybe it's time, 90min reached:
https://cirrus-ci.com/task/5774549872541696

Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
Posted by 罗勇刚 (Yonggang Luo) 3 years, 3 months ago
On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
>
> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
> > On 18/11/2020 15.07, Alex Bennée wrote:
> > > These seem to trigger timeouts with some regularity.
> > >
> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > > ---
> > >  .cirrus.yml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/.cirrus.yml b/.cirrus.yml
> > > index f0209b7a3e..08db7c419f 100644
> > > --- a/.cirrus.yml
> > > +++ b/.cirrus.yml
> > > @@ -18,6 +18,7 @@ freebsd_12_task:
> > >      - gmake -j$(sysctl -n hw.ncpu) check V=1
> > >
> > >  macos_task:
> > > +  timeout_in: 90m
> > >    osx_instance:
> > >      image: catalina-base
> > >    install_script:
> > > @@ -32,6 +33,7 @@ macos_task:
> > >      - gmake check V=1
> > >
> > >  macos_xcode_task:
> > > +  timeout_in: 90m
> > >    osx_instance:
> > >      # this is an alias for the latest Xcode
> > >      image: catalina-xcode
> > >
> >
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> >
> > ... we could maybe also split the --target-list between the two jobs if
they
> > take too long...
>
> Maybe it's time, 90min reached:
> https://cirrus-ci.com/task/5774549872541696
>
Even two hour doesn't working, don't know why

--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo
Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
Posted by Alex Bennée 3 years, 3 months ago
罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:

> On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
>>
>> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
>> > On 18/11/2020 15.07, Alex Bennée wrote:
>> > > These seem to trigger timeouts with some regularity.
>> > >
>> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> > > ---
>> > >  .cirrus.yml | 2 ++
>> > >  1 file changed, 2 insertions(+)
>> > >
>> > > diff --git a/.cirrus.yml b/.cirrus.yml
>> > > index f0209b7a3e..08db7c419f 100644
>> > > --- a/.cirrus.yml
>> > > +++ b/.cirrus.yml
>> > > @@ -18,6 +18,7 @@ freebsd_12_task:
>> > >      - gmake -j$(sysctl -n hw.ncpu) check V=1
>> > >
>> > >  macos_task:
>> > > +  timeout_in: 90m
>> > >    osx_instance:
>> > >      image: catalina-base
>> > >    install_script:
>> > > @@ -32,6 +33,7 @@ macos_task:
>> > >      - gmake check V=1
>> > >
>> > >  macos_xcode_task:
>> > > +  timeout_in: 90m
>> > >    osx_instance:
>> > >      # this is an alias for the latest Xcode
>> > >      image: catalina-xcode
>> > >
>> >
>> > Reviewed-by: Thomas Huth <thuth@redhat.com>
>> >
>> > ... we could maybe also split the --target-list between the two jobs if
> they
>> > take too long...
>>
>> Maybe it's time, 90min reached:
>> https://cirrus-ci.com/task/5774549872541696
>>
> Even two hour doesn't working, don't know why

It seems to have jumped up quite considerably over a short period which
makes me think the underlying cause is something is getting stuck on
MacOS. Unfortunately it's hard to debug with just the logs because
whatever is taking the time might not be the last thing in the logs.

Having a time-per-test metric would be useful here.

-- 
Alex Bennée

Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
Posted by Thomas Huth 3 years, 3 months ago
On 14/12/2020 10.24, Alex Bennée wrote:
> 
> 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:
> 
>> On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
>> wrote:
>>>
>>> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
>>>> On 18/11/2020 15.07, Alex Bennée wrote:
>>>>> These seem to trigger timeouts with some regularity.
>>>>>
>>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>>>> ---
>>>>>  .cirrus.yml | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/.cirrus.yml b/.cirrus.yml
>>>>> index f0209b7a3e..08db7c419f 100644
>>>>> --- a/.cirrus.yml
>>>>> +++ b/.cirrus.yml
>>>>> @@ -18,6 +18,7 @@ freebsd_12_task:
>>>>>      - gmake -j$(sysctl -n hw.ncpu) check V=1
>>>>>
>>>>>  macos_task:
>>>>> +  timeout_in: 90m
>>>>>    osx_instance:
>>>>>      image: catalina-base
>>>>>    install_script:
>>>>> @@ -32,6 +33,7 @@ macos_task:
>>>>>      - gmake check V=1
>>>>>
>>>>>  macos_xcode_task:
>>>>> +  timeout_in: 90m
>>>>>    osx_instance:
>>>>>      # this is an alias for the latest Xcode
>>>>>      image: catalina-xcode
>>>>>
>>>>
>>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>>>
>>>> ... we could maybe also split the --target-list between the two jobs if
>> they
>>>> take too long...
>>>
>>> Maybe it's time, 90min reached:
>>> https://cirrus-ci.com/task/5774549872541696
>>>
>> Even two hour doesn't working, don't know why
> 
> It seems to have jumped up quite considerably over a short period which
> makes me think the underlying cause is something is getting stuck on
> MacOS. Unfortunately it's hard to debug with just the logs because
> whatever is taking the time might not be the last thing in the logs.
> 
> Having a time-per-test metric would be useful here.

Didn't Daniel post such a patch some weeks ago?

 Thomas


Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
Posted by Daniel P. Berrangé 3 years, 3 months ago
On Mon, Dec 14, 2020 at 10:33:09AM +0100, Thomas Huth wrote:
> On 14/12/2020 10.24, Alex Bennée wrote:
> > 
> > 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:
> > 
> >> On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> wrote:
> >>>
> >>> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
> >>>> On 18/11/2020 15.07, Alex Bennée wrote:
> >>>>> These seem to trigger timeouts with some regularity.
> >>>>>
> >>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >>>>> ---
> >>>>>  .cirrus.yml | 2 ++
> >>>>>  1 file changed, 2 insertions(+)
> >>>>>
> >>>>> diff --git a/.cirrus.yml b/.cirrus.yml
> >>>>> index f0209b7a3e..08db7c419f 100644
> >>>>> --- a/.cirrus.yml
> >>>>> +++ b/.cirrus.yml
> >>>>> @@ -18,6 +18,7 @@ freebsd_12_task:
> >>>>>      - gmake -j$(sysctl -n hw.ncpu) check V=1
> >>>>>
> >>>>>  macos_task:
> >>>>> +  timeout_in: 90m
> >>>>>    osx_instance:
> >>>>>      image: catalina-base
> >>>>>    install_script:
> >>>>> @@ -32,6 +33,7 @@ macos_task:
> >>>>>      - gmake check V=1
> >>>>>
> >>>>>  macos_xcode_task:
> >>>>> +  timeout_in: 90m
> >>>>>    osx_instance:
> >>>>>      # this is an alias for the latest Xcode
> >>>>>      image: catalina-xcode
> >>>>>
> >>>>
> >>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
> >>>>
> >>>> ... we could maybe also split the --target-list between the two jobs if
> >> they
> >>>> take too long...
> >>>
> >>> Maybe it's time, 90min reached:
> >>> https://cirrus-ci.com/task/5774549872541696
> >>>
> >> Even two hour doesn't working, don't know why
> > 
> > It seems to have jumped up quite considerably over a short period which
> > makes me think the underlying cause is something is getting stuck on
> > MacOS. Unfortunately it's hard to debug with just the logs because
> > whatever is taking the time might not be the last thing in the logs.
> > 
> > Having a time-per-test metric would be useful here.
> 
> Didn't Daniel post such a patch some weeks ago?

I posted a nasty hack for it, but Paolo has integrated nice support for
it into Meson git master

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|