From nobody Fri Apr 26 13:27:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605554323; cv=none; d=zohomail.com; s=zohoarc; b=NAIdkBTql7/zqDtUXbuC9V6DwXna/xiJL5tpOE8BdyrrqcqfzEjFS/GtIPhOr9NC57I1X1No+Yx8Bg4EM/wO50lPEhOpqGnE0IjkXLvXWqf9Y7SP7ZXFoA+/UfLKD7OO8DMJXO9x57/Ija9oTvE6RkvzWSzsWAIqujNk2PJ+Z4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605554323; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=FP+6K7dWuv9nHaPailucVADYNP7nrAAjHdzMcWJhEvQ=; b=F1V4Th8uUdSiiS+flKrA57ljzDEU/VOMyti/d3u+Tlfflmke0i4JFAvS1mhDoMrTrSUTvfOU1nHPeYvyr1fizoUn9OQdHjSmEA+3Q5zc9b/hrFiCPnfhol6sC21JWoegA4Ffti/jQrd2ICPgOgR+XY6Vn2ItcP1vxYh/7UPm9Gc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160555432308492.3184341149564; Mon, 16 Nov 2020 11:18:43 -0800 (PST) Received: from localhost ([::1]:47290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kek1R-00012L-Vg for importer@patchew.org; Mon, 16 Nov 2020 14:18:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQt-0003sX-Ce for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:40:55 -0500 Received: from mx2.suse.de ([195.135.220.15]:45334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQo-0000lH-Oj for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:40:55 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 41A94AE1C; Mon, 16 Nov 2020 18:40:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Hannes Reinecke To: Paolo Bonzini Subject: [PATCH 1/7] scsi-disk: Add sg_io callback to evaluate status Date: Mon, 16 Nov 2020 19:40:35 +0100 Message-Id: <20201116184041.60465-2-hare@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201116184041.60465-1-hare@suse.de> References: <20201116184041.60465-1-hare@suse.de> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:53:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Hannes Reinecke Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add a separate sg_io callback to allow us to evaluate the various states returned by the SG_IO ioctl. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index dd23a38d6a..5d6c892f29 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -76,7 +76,6 @@ typedef struct SCSIDiskReq { struct iovec iov; QEMUIOVector qiov; BlockAcctCookie acct; - unsigned char *status; } SCSIDiskReq; =20 #define SCSI_DISK_F_REMOVABLE 0 @@ -188,7 +187,7 @@ static bool scsi_disk_req_check_error(SCSIDiskReq *r, i= nt ret, bool acct_failed) return true; } =20 - if (ret < 0 || (r->status && *r->status)) { + if (ret < 0 || r->req.status) { return scsi_handle_rw_error(r, -ret, acct_failed); } =20 @@ -452,11 +451,11 @@ static bool scsi_handle_rw_error(SCSIDiskReq *r, int = error, bool acct_failed) * whether the error has to be handled by the guest or should = rather * pause the host. */ - assert(r->status && *r->status); + assert(r->req.status); if (scsi_sense_buf_is_guest_recoverable(r->req.sense, sizeof(r= ->req.sense))) { /* These errors are handled by guest. */ sdc->update_sense(&r->req); - scsi_req_complete(&r->req, *r->status); + scsi_req_complete(&r->req, r->req.status); return true; } error =3D scsi_sense_buf_to_errno(r->req.sense, sizeof(r->req.= sense)); @@ -2688,8 +2687,24 @@ typedef struct SCSIBlockReq { =20 /* CDB passed to SG_IO. */ uint8_t cdb[16]; + BlockCompletionFunc *cb; + void *cb_opaque; } SCSIBlockReq; =20 +static void scsi_block_sgio_complete(void *opaque, int ret) +{ + SCSIBlockReq *req =3D (SCSIBlockReq *)opaque; + SCSIDiskReq *r =3D &req->req; + SCSISense sense; + + r->req.status =3D sg_io_sense_from_errno(-ret, &req->io_header, &sense= ); + if (r->req.status =3D=3D CHECK_CONDITION && + req->io_header.status !=3D CHECK_CONDITION) + scsi_req_build_sense(&r->req, sense); + + req->cb(req->cb_opaque, ret); +} + static BlockAIOCB *scsi_block_do_sgio(SCSIBlockReq *req, int64_t offset, QEMUIOVector *iov, int direction, @@ -2768,9 +2783,11 @@ static BlockAIOCB *scsi_block_do_sgio(SCSIBlockReq *= req, io_header->timeout =3D s->qdev.io_timeout * 1000; io_header->usr_ptr =3D r; io_header->flags |=3D SG_FLAG_DIRECT_IO; + req->cb =3D cb; + req->cb_opaque =3D opaque; trace_scsi_disk_aio_sgio_command(r->req.tag, req->cdb[0], lba, nb_logical_blocks, io_header->timeout= ); - aiocb =3D blk_aio_ioctl(s->qdev.conf.blk, SG_IO, io_header, cb, opaque= ); + aiocb =3D blk_aio_ioctl(s->qdev.conf.blk, SG_IO, io_header, scsi_block= _sgio_complete, req); assert(aiocb !=3D NULL); return aiocb; } @@ -2884,7 +2901,6 @@ static int32_t scsi_block_dma_command(SCSIRequest *re= q, uint8_t *buf) return 0; } =20 - r->req.status =3D &r->io_header.status; return scsi_disk_dma_command(req, buf); } =20 --=20 2.16.4 From nobody Fri Apr 26 13:27:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605553123; cv=none; d=zohomail.com; s=zohoarc; b=Tn4sRZlVyZpXJzjOMUrn+XzlU7UrDbuO4930StXx+Ktpif8XfiUEPfIZYPKrq6aioKmsOc4KjkwDCkiyX1EaG8/cr00JkWFmIm+vSP5jyJnwm4/Fj5bEWNK7Pfz7v25S50KVbjpZNbygE5KaocPmDYrWtAV5jxN3Ad7P6jkjfoE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605553123; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=YtZo3uZ7D3NrUb6m5h8a86cBSV/SxheYjh51X9hDPhw=; b=QP+M5LX6aErwA6XMlD9uMk6hDQSD8P4iK3bUzwLAt0v1Tyw+sJVLgDKmRLtOH1FQbo1p5Qb9AGlqIptvgtkAAIqKhYG21yB61xx+wQQitHtBabRU8+SqP/RJFk+yiFFeaW679QcpOURacdh74+uhMkMGq6IWgvNf1RNk80n7+vk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160555312345016.5802053605953; Mon, 16 Nov 2020 10:58:43 -0800 (PST) Received: from localhost ([::1]:39082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keji6-0001q7-AM for importer@patchew.org; Mon, 16 Nov 2020 13:58:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQt-0003tp-Ui for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:40:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:45328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQo-0000lE-O1 for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:40:55 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 42CA9B00D; Mon, 16 Nov 2020 18:40:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Hannes Reinecke To: Paolo Bonzini Subject: [PATCH 2/7] scsi: drop 'result' argument from command_complete callback Date: Mon, 16 Nov 2020 19:40:36 +0100 Message-Id: <20201116184041.60465-3-hare@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201116184041.60465-1-hare@suse.de> References: <20201116184041.60465-1-hare@suse.de> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:53:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Hannes Reinecke Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The command complete callback has a SCSIRequest as the first argument, and the status field of that structure is identical to the 'status' argument. So drop the argument from the callback. Signed-off-by: Hannes Reinecke --- hw/scsi/esp-pci.c | 5 ++--- hw/scsi/esp.c | 7 +++---- hw/scsi/lsi53c895a.c | 6 +++--- hw/scsi/megasas.c | 6 ++---- hw/scsi/mptsas.c | 5 +++-- hw/scsi/scsi-bus.c | 2 +- hw/scsi/spapr_vscsi.c | 10 +++++----- hw/scsi/virtio-scsi.c | 5 ++--- hw/scsi/vmw_pvscsi.c | 4 ++-- hw/usb/dev-storage.c | 6 +++--- hw/usb/dev-uas.c | 7 +++---- include/hw/scsi/esp.h | 2 +- include/hw/scsi/scsi.h | 2 +- 13 files changed, 31 insertions(+), 36 deletions(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index 2ce96dc56e..4d7c2cab56 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -329,13 +329,12 @@ static const VMStateDescription vmstate_esp_pci_scsi = =3D { } }; =20 -static void esp_pci_command_complete(SCSIRequest *req, uint32_t status, - size_t resid) +static void esp_pci_command_complete(SCSIRequest *req, size_t resid) { ESPState *s =3D req->hba_private; PCIESPState *pci =3D container_of(s, PCIESPState, esp); =20 - esp_command_complete(req, status, resid); + esp_command_complete(req, resid); pci->dma_regs[DMA_WBC] =3D 0; pci->dma_regs[DMA_STAT] |=3D DMA_STAT_DONE; } diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index b84e0fe33e..93d9c9c7b9 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -485,8 +485,7 @@ static void esp_report_command_complete(ESPState *s, ui= nt32_t status) } } =20 -void esp_command_complete(SCSIRequest *req, uint32_t status, - size_t resid) +void esp_command_complete(SCSIRequest *req, size_t resid) { ESPState *s =3D req->hba_private; =20 @@ -495,11 +494,11 @@ void esp_command_complete(SCSIRequest *req, uint32_t = status, * interrupt has been handled. */ trace_esp_command_complete_deferred(); - s->deferred_status =3D status; + s->deferred_status =3D req->status; s->deferred_complete =3D true; return; } - esp_report_command_complete(s, status); + esp_report_command_complete(s, req->status); } =20 void esp_transfer_data(SCSIRequest *req, uint32_t len) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 7d13c7dc1c..a4e58580e4 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -787,14 +787,14 @@ static int lsi_queue_req(LSIState *s, SCSIRequest *re= q, uint32_t len) } =20 /* Callback to indicate that the SCSI layer has completed a command. */ -static void lsi_command_complete(SCSIRequest *req, uint32_t status, size_t= resid) +static void lsi_command_complete(SCSIRequest *req, size_t resid) { LSIState *s =3D LSI53C895A(req->bus->qbus.parent); int out; =20 out =3D (s->sstat1 & PHASE_MASK) =3D=3D PHASE_DO; - trace_lsi_command_complete(status); - s->status =3D status; + trace_lsi_command_complete(req->status); + s->status =3D req->status; s->command_complete =3D 2; if (s->waiting && s->dbc !=3D 0) { /* Raise phase mismatch for short transfers. */ diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index e24c12d7ee..35867dbd40 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -1852,13 +1852,12 @@ static void megasas_xfer_complete(SCSIRequest *req,= uint32_t len) } } =20 -static void megasas_command_complete(SCSIRequest *req, uint32_t status, - size_t resid) +static void megasas_command_complete(SCSIRequest *req, size_t resid) { MegasasCmd *cmd =3D req->hba_private; uint8_t cmd_status =3D MFI_STAT_OK; =20 - trace_megasas_command_complete(cmd->index, status, resid); + trace_megasas_command_complete(cmd->index, req->status, resid); =20 if (req->io_canceled) { return; @@ -1873,7 +1872,6 @@ static void megasas_command_complete(SCSIRequest *req= , uint32_t status, return; } } else { - req->status =3D status; trace_megasas_scsi_complete(cmd->index, req->status, cmd->iov_size, req->cmd.xfer); if (req->status !=3D GOOD) { diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 135e7d96e4..d4fbfb2da7 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -1133,7 +1133,7 @@ static QEMUSGList *mptsas_get_sg_list(SCSIRequest *sr= eq) } =20 static void mptsas_command_complete(SCSIRequest *sreq, - uint32_t status, size_t resid) + size_t resid) { MPTSASRequest *req =3D sreq->hba_private; MPTSASState *s =3D req->dev; @@ -1143,7 +1143,8 @@ static void mptsas_command_complete(SCSIRequest *sreq, hwaddr sense_buffer_addr =3D req->dev->sense_buffer_high_addr | req->scsi_io.SenseBufferLowAddr; =20 - trace_mptsas_command_complete(s, req->scsi_io.MsgContext, status, resi= d); + trace_mptsas_command_complete(s, req->scsi_io.MsgContext, + sreq->status, resid); =20 sense_len =3D scsi_req_get_sense(sreq, sense_buf, SCSI_SENSE_BUF_SIZE); if (sense_len > 0) { diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 3284a5d1fb..17ce3238d7 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -1415,7 +1415,7 @@ void scsi_req_complete(SCSIRequest *req, int status) =20 scsi_req_ref(req); scsi_req_dequeue(req); - req->bus->info->complete(req, req->status, req->resid); + req->bus->info->complete(req, req->resid); =20 /* Cancelled requests might end up being completed instead of cancelle= d */ notifier_list_notify(&req->cancel_notifiers, req); diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c index 4aa0224c47..d653b5a6ad 100644 --- a/hw/scsi/spapr_vscsi.c +++ b/hw/scsi/spapr_vscsi.c @@ -551,19 +551,19 @@ static void vscsi_transfer_data(SCSIRequest *sreq, ui= nt32_t len) } =20 /* Callback to indicate that the SCSI layer has completed a transfer. */ -static void vscsi_command_complete(SCSIRequest *sreq, uint32_t status, siz= e_t resid) +static void vscsi_command_complete(SCSIRequest *sreq, size_t resid) { VSCSIState *s =3D VIO_SPAPR_VSCSI_DEVICE(sreq->bus->qbus.parent); vscsi_req *req =3D sreq->hba_private; int32_t res_in =3D 0, res_out =3D 0; =20 - trace_spapr_vscsi_command_complete(sreq->tag, status, req); + trace_spapr_vscsi_command_complete(sreq->tag, sreq->status, req); if (req =3D=3D NULL) { fprintf(stderr, "VSCSI: Can't find request for tag 0x%x\n", sreq->= tag); return; } =20 - if (status =3D=3D CHECK_CONDITION) { + if (sreq->status =3D=3D CHECK_CONDITION) { req->senselen =3D scsi_req_get_sense(req->sreq, req->sense, sizeof(req->sense)); trace_spapr_vscsi_command_complete_sense_data1(req->senselen, @@ -574,8 +574,8 @@ static void vscsi_command_complete(SCSIRequest *sreq, u= int32_t status, size_t re req->sense[12], req->sense[13], req->sense[14], req->sense= [15]); } =20 - trace_spapr_vscsi_command_complete_status(status); - if (status =3D=3D 0) { + trace_spapr_vscsi_command_complete_status(sreq->status); + if (sreq->status =3D=3D 0) { /* We handle overflows, not underflows for normal commands, * but hopefully nobody cares */ diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index c9873d5af7..64cd852d82 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -493,8 +493,7 @@ static void virtio_scsi_complete_cmd_req(VirtIOSCSIReq = *req) virtio_scsi_complete_req(req); } =20 -static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status, - size_t resid) +static void virtio_scsi_command_complete(SCSIRequest *r, size_t resid) { VirtIOSCSIReq *req =3D r->hba_private; uint8_t sense[SCSI_SENSE_BUF_SIZE]; @@ -506,7 +505,7 @@ static void virtio_scsi_command_complete(SCSIRequest *r= , uint32_t status, } =20 req->resp.cmd.response =3D VIRTIO_SCSI_S_OK; - req->resp.cmd.status =3D status; + req->resp.cmd.status =3D r->status; if (req->resp.cmd.status =3D=3D GOOD) { req->resp.cmd.resid =3D virtio_tswap32(vdev, resid); } else { diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index a63d25de48..0da378ed50 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -511,7 +511,7 @@ pvscsi_write_sense(PVSCSIRequest *r, uint8_t *sense, in= t len) } =20 static void -pvscsi_command_complete(SCSIRequest *req, uint32_t status, size_t resid) +pvscsi_command_complete(SCSIRequest *req, size_t resid) { PVSCSIRequest *pvscsi_req =3D req->hba_private; PVSCSIState *s; @@ -528,7 +528,7 @@ pvscsi_command_complete(SCSIRequest *req, uint32_t stat= us, size_t resid) pvscsi_req->cmp.hostStatus =3D BTSTAT_DATARUN; } =20 - pvscsi_req->cmp.scsiStatus =3D status; + pvscsi_req->cmp.scsiStatus =3D req->status; if (pvscsi_req->cmp.scsiStatus =3D=3D CHECK_CONDITION) { uint8_t sense[SCSI_SENSE_BUF_SIZE]; int sense_len =3D diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 648340323f..d1aeebe2ce 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -284,17 +284,17 @@ static void usb_msd_transfer_data(SCSIRequest *req, u= int32_t len) } } =20 -static void usb_msd_command_complete(SCSIRequest *req, uint32_t status, si= ze_t resid) +static void usb_msd_command_complete(SCSIRequest *req, size_t resid) { MSDState *s =3D DO_UPCAST(MSDState, dev.qdev, req->bus->qbus.parent); USBPacket *p =3D s->packet; =20 - DPRINTF("Command complete %d tag 0x%x\n", status, req->tag); + DPRINTF("Command complete %d tag 0x%x\n", req->status, req->tag); =20 s->csw.sig =3D cpu_to_le32(0x53425355); s->csw.tag =3D cpu_to_le32(req->tag); s->csw.residue =3D cpu_to_le32(s->data_len); - s->csw.status =3D status !=3D 0; + s->csw.status =3D req->status !=3D 0; =20 if (s->packet) { if (s->data_len =3D=3D 0 && s->mode =3D=3D USB_MSDM_DATAOUT) { diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index cec071d96c..202e9cc4b7 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -597,17 +597,16 @@ static void usb_uas_scsi_transfer_data(SCSIRequest *r= , uint32_t len) } } =20 -static void usb_uas_scsi_command_complete(SCSIRequest *r, - uint32_t status, size_t resid) +static void usb_uas_scsi_command_complete(SCSIRequest *r, size_t resid) { UASRequest *req =3D r->hba_private; =20 - trace_usb_uas_scsi_complete(req->uas->dev.addr, req->tag, status, resi= d); + trace_usb_uas_scsi_complete(req->uas->dev.addr, req->tag, r->status, r= esid); req->complete =3D true; if (req->data) { usb_uas_complete_data_packet(req); } - usb_uas_queue_sense(req, status); + usb_uas_queue_sense(req, r->status); scsi_req_unref(req->req); } =20 diff --git a/include/hw/scsi/esp.h b/include/hw/scsi/esp.h index 60cc3047a5..d8a6263c13 100644 --- a/include/hw/scsi/esp.h +++ b/include/hw/scsi/esp.h @@ -151,7 +151,7 @@ struct SysBusESPState { =20 void esp_dma_enable(ESPState *s, int irq, int level); void esp_request_cancelled(SCSIRequest *req); -void esp_command_complete(SCSIRequest *req, uint32_t status, size_t resid); +void esp_command_complete(SCSIRequest *req, size_t resid); void esp_transfer_data(SCSIRequest *req, uint32_t len); void esp_hard_reset(ESPState *s); uint64_t esp_reg_read(ESPState *s, uint32_t saddr); diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h index 21a6249743..23a9b23e50 100644 --- a/include/hw/scsi/scsi.h +++ b/include/hw/scsi/scsi.h @@ -123,7 +123,7 @@ struct SCSIBusInfo { int (*parse_cdb)(SCSIDevice *dev, SCSICommand *cmd, uint8_t *buf, void *hba_private); void (*transfer_data)(SCSIRequest *req, uint32_t arg); - void (*complete)(SCSIRequest *req, uint32_t arg, size_t resid); + void (*complete)(SCSIRequest *req, size_t resid); void (*cancel)(SCSIRequest *req); void (*change)(SCSIBus *bus, SCSIDevice *dev, SCSISense sense); QEMUSGList *(*get_sg_list)(SCSIRequest *req); --=20 2.16.4 From nobody Fri Apr 26 13:27:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605553339; cv=none; d=zohomail.com; s=zohoarc; b=FJM4iVyLbetmbIFWgXEfcdVSBDWwL/rRy3ZIrwtTYt0iMedA+3RSCY38ClVIqM9fNmqQGLYJyXk3KArhcRnNzEeVf858xVaHshgmpRgpFTEZxGfNRqYrXUU6gQQx7Tf/3wja6fMF/j9G32KZpC4IOwhK0zslXZTxc89wZN28Hu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605553339; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=KQAXpMu4LcMBChR8viVcqttblb551DyD6x3L8O5VjZs=; b=SIL457GODnmUI7dnGyliZKNzM4DOWQkAG9YaiKj0VUBZ6iQ2MPlE/MtTQLtfFqVqWwno4/O7xImhMyJSYnEq99jxCnA58f78twSmHsTZq4YRVp7UHxpHdfXu0zbxk1U/sAur4IlscTTCppDciOx/PAhyuAsNRn8cEoTavQvC3+E= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605553339925829.1673466397348; Mon, 16 Nov 2020 11:02:19 -0800 (PST) Received: from localhost ([::1]:47414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejla-0005Qc-IJ for importer@patchew.org; Mon, 16 Nov 2020 14:02:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejR2-0003yL-Cp for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:45330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQo-0000lF-Q5 for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:03 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 436F6B011; Mon, 16 Nov 2020 18:40:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Hannes Reinecke To: Paolo Bonzini Subject: [PATCH 3/7] scsi-disk: convert more errno values back to SCSI statuses Date: Mon, 16 Nov 2020 19:40:37 +0100 Message-Id: <20201116184041.60465-4-hare@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201116184041.60465-1-hare@suse.de> References: <20201116184041.60465-1-hare@suse.de> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:53:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Hannes Reinecke Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini Linux has some OS-specific (and sometimes weird) mappings for various SCSI statuses and sense codes. The most important is probably RESERVATION CONFLICT. Add them so that they can be reported back to the guest kernel. Cc: Hannes Reinecke Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 5d6c892f29..797779afd6 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -460,6 +460,25 @@ static bool scsi_handle_rw_error(SCSIDiskReq *r, int e= rror, bool acct_failed) } error =3D scsi_sense_buf_to_errno(r->req.sense, sizeof(r->req.= sense)); break; +#ifdef CONFIG_LINUX + /* These errno mapping are specific to Linux. For more inform= ation: + * - scsi_decide_disposition in drivers/scsi/scsi_error.c + * - scsi_result_to_blk_status in drivers/scsi/scsi_lib.c + * - blk_errors[] in block/blk-core.c + */ + case EBADE: + /* DID_NEXUS_FAILURE -> BLK_STS_NEXUS. */ + scsi_req_complete(&r->req, RESERVATION_CONFLICT); + break; + case ENODATA: + /* DID_MEDIUM_ERROR -> BLK_STS_MEDIUM. */ + scsi_check_condition(r, SENSE_CODE(READ_ERROR)); + break; + case EREMOTEIO: + /* DID_TARGET_FAILURE -> BLK_STS_TARGET. */ + scsi_req_complete(&r->req, HARDWARE_ERROR); + break; +#endif case ENOMEDIUM: scsi_check_condition(r, SENSE_CODE(NO_MEDIUM)); break; --=20 2.16.4 From nobody Fri Apr 26 13:27:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605553146; cv=none; d=zohomail.com; s=zohoarc; b=aLG4F7HoeVCyiBt4sRa8kDYhp4UxrPQM2dEbSJTdGhhXFiGuMrcWNuwWy3jXe1QV6oYwPHNa0CrucbjCsNTPcLNsNI7cjpU1eiunCFEjq9aBty1togKxQXvbASxd77lVxhUn+qXDRW5exbLet4deBAYxifRswSPV6tjJyVHeWuw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605553146; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=Y6EQyoz5IS59AQfESbIwVQMbBWpkgsLSfUswzXCi6wY=; b=lQppnRahjS/t0ALGK0wv+ant4tXQV4wInYxvn7fp1B6Rtp0ZaccSzKyLITCe5ItFSt+hzvWF0jSzScgp8rioaexyOm74sMxFckm3oRgKRV8QgAzp4GbjSkHYr38BQAgpcmMvTuFuo4agRMpqIWK7JdA0Ql4ekutSKFAaItk7iEE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605553146189939.3284961454959; Mon, 16 Nov 2020 10:59:06 -0800 (PST) Received: from localhost ([::1]:40030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejiP-0002Dk-DS for importer@patchew.org; Mon, 16 Nov 2020 13:59:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQx-0003vB-ND for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:40:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:45332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQo-0000lG-QZ for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:40:59 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4682CB012; Mon, 16 Nov 2020 18:40:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Hannes Reinecke To: Paolo Bonzini Subject: [PATCH 4/7] scsi: Rename linux-specific SG_ERR codes to generic SCSI_HOST error codes Date: Mon, 16 Nov 2020 19:40:38 +0100 Message-Id: <20201116184041.60465-5-hare@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201116184041.60465-1-hare@suse.de> References: <20201116184041.60465-1-hare@suse.de> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:53:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Hannes Reinecke Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We really should make a distinction between legitimate sense codes (ie if one is running against an emulated block device or for pass-through sense codes), and the intermediate errors generated during processing of the command, which really are not sense codes but refer to some specific internal status. And this internal state is not necessarily linux-specific, but rather can refer to the qemu implementation itself. So rename the linux-only SG_ERR codes to SCSI_HOST codes and make them available generally. Signed-off-by: Hannes Reinecke --- include/scsi/utils.h | 23 ++++++++++++++++------- scsi/utils.c | 6 +++--- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/include/scsi/utils.h b/include/scsi/utils.h index fbc5588279..a55ba2c1ea 100644 --- a/include/scsi/utils.h +++ b/include/scsi/utils.h @@ -16,6 +16,22 @@ enum SCSIXferMode { SCSI_XFER_TO_DEV, /* WRITE, MODE_SELECT, ... */ }; =20 +enum SCSIHostStatus { + SCSI_HOST_OK, + SCSI_HOST_NO_LUN, + SCSI_HOST_BUSY, + SCSI_HOST_TIME_OUT, + SCSI_HOST_BAD_RESPONSE, + SCSI_HOST_ABORTED, + SCSI_HOST_ERROR =3D 0x07, + SCSI_HOST_RESET =3D 0x08, + SCSI_HOST_TRANSPORT_DISRUPTED =3D 0xe, + SCSI_HOST_TARGET_FAILURE =3D 0x10, + SCSI_HOST_RESERVATION_ERROR =3D 0x11, + SCSI_HOST_ALLOCATION_FAILURE =3D 0x12, + SCSI_HOST_MEDIUM_ERROR =3D 0x13, +}; + typedef struct SCSICommand { uint8_t buf[SCSI_CMD_BUF_SIZE]; int len; @@ -122,13 +138,6 @@ int scsi_cdb_length(uint8_t *buf); #define SG_ERR_DRIVER_TIMEOUT 0x06 #define SG_ERR_DRIVER_SENSE 0x08 =20 -#define SG_ERR_DID_OK 0x00 -#define SG_ERR_DID_NO_CONNECT 0x01 -#define SG_ERR_DID_BUS_BUSY 0x02 -#define SG_ERR_DID_TIME_OUT 0x03 - -#define SG_ERR_DRIVER_SENSE 0x08 - int sg_io_sense_from_errno(int errno_value, struct sg_io_hdr *io_hdr, SCSISense *sense); #endif diff --git a/scsi/utils.c b/scsi/utils.c index b37c283014..262ef1c3ea 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -576,9 +576,9 @@ int sg_io_sense_from_errno(int errno_value, struct sg_i= o_hdr *io_hdr, return CHECK_CONDITION; } } else { - if (io_hdr->host_status =3D=3D SG_ERR_DID_NO_CONNECT || - io_hdr->host_status =3D=3D SG_ERR_DID_BUS_BUSY || - io_hdr->host_status =3D=3D SG_ERR_DID_TIME_OUT || + if (io_hdr->host_status =3D=3D SCSI_HOST_NO_LUN || + io_hdr->host_status =3D=3D SCSI_HOST_BUSY || + io_hdr->host_status =3D=3D SCSI_HOST_TIME_OUT || (io_hdr->driver_status & SG_ERR_DRIVER_TIMEOUT)) { return BUSY; } else if (io_hdr->host_status) { --=20 2.16.4 From nobody Fri Apr 26 13:27:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605554548; cv=none; d=zohomail.com; s=zohoarc; b=SAsvz0e9YqwNv3fBELhjnVuLJprBvKErYzzEJH4lvBwZ8+KtXUgXrM8S/QI3FiUFFhdFLgOzMvUx1xgeX9S2Ev3rFWWSpn4JKAuSrdwKFbimTv11IqLkdAjfpShV05S8SgyVkWrwtLEzOWwUs94mgBPqwhmIGn6O0WGjVDK3ec0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605554548; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=6xnLYu0+18fvLsLuitKliiUTgOCIk4z43pjObahhsLY=; b=B7EX5SWqsU5moI/tLxuDVhGZsj9Ahgrajla46AWUvKbnnVbkydfwIIJcw2gY5QAo0c3HgVMVSwIwtqbYcoDgb/KkpvWzW34Uc823bBlOw0e8nB0az1p4VwZhduKljvjBKWQ01fHs4MqE+00O934mHE7bY28ia/MD8hUOkxyLMig= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605554548619201.39107841828604; Mon, 16 Nov 2020 11:22:28 -0800 (PST) Received: from localhost ([::1]:55280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kek54-0004RE-Fv for importer@patchew.org; Mon, 16 Nov 2020 14:22:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQy-0003wN-Gp for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:45372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQt-0000oY-1a for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:00 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 64837B016; Mon, 16 Nov 2020 18:40:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Hannes Reinecke To: Paolo Bonzini Subject: [PATCH 5/7] scsi: Add mapping for generic SCSI_HOST status to sense codes Date: Mon, 16 Nov 2020 19:40:39 +0100 Message-Id: <20201116184041.60465-6-hare@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201116184041.60465-1-hare@suse.de> References: <20201116184041.60465-1-hare@suse.de> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:53:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Hannes Reinecke Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" As we don't have a driver-specific mapping (yet) we should provide for a detailed mapping from host_status to SCSI sense codes. Signed-off-by: Hannes Reinecke --- scsi/utils.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-= ---- 1 file changed, 55 insertions(+), 5 deletions(-) diff --git a/scsi/utils.c b/scsi/utils.c index 262ef1c3ea..ae68881184 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -252,6 +252,21 @@ const struct SCSISense sense_code_LUN_COMM_FAILURE =3D= { .key =3D ABORTED_COMMAND, .asc =3D 0x08, .ascq =3D 0x00 }; =20 +/* Command aborted, LUN does not respond to selection */ +const struct SCSISense sense_code_LUN_NOT_RESPONDING =3D { + .key =3D ABORTED_COMMAND, .asc =3D 0x05, .ascq =3D 0x00 +}; + +/* Command aborted, Command Timeout during processing */ +const struct SCSISense sense_code_COMMAND_TIMEOUT =3D { + .key =3D ABORTED_COMMAND, .asc =3D 0x2e, .ascq =3D 0x02 +}; + +/* Command aborted, Commands cleared by device server */ +const struct SCSISense sense_code_COMMAND_ABORTED =3D { + .key =3D ABORTED_COMMAND, .asc =3D 0x2f, .ascq =3D 0x02 +}; + /* Medium Error, Unrecovered read error */ const struct SCSISense sense_code_READ_ERROR =3D { .key =3D MEDIUM_ERROR, .asc =3D 0x11, .ascq =3D 0x00 @@ -568,6 +583,14 @@ int sg_io_sense_from_errno(int errno_value, struct sg_= io_hdr *io_hdr, switch (errno_value) { case EDOM: return TASK_SET_FULL; + case EBADE: + return RESERVATION_CONFLICT; + case ENODATA: + *sense =3D SENSE_CODE(READ_ERROR); + return CHECK_CONDITION; + case EREMOTEIO: + *sense =3D SENSE_CODE(LUN_COMM_FAILURE); + return CHECK_CONDITION; case ENOMEM: *sense =3D SENSE_CODE(TARGET_FAILURE); return CHECK_CONDITION; @@ -576,14 +599,41 @@ int sg_io_sense_from_errno(int errno_value, struct sg= _io_hdr *io_hdr, return CHECK_CONDITION; } } else { - if (io_hdr->host_status =3D=3D SCSI_HOST_NO_LUN || - io_hdr->host_status =3D=3D SCSI_HOST_BUSY || - io_hdr->host_status =3D=3D SCSI_HOST_TIME_OUT || - (io_hdr->driver_status & SG_ERR_DRIVER_TIMEOUT)) { + switch (io_hdr->host_status) { + case SCSI_HOST_NO_LUN: + *sense =3D SENSE_CODE(LUN_NOT_RESPONDING); + return CHECK_CONDITION; + case SCSI_HOST_BUSY: return BUSY; - } else if (io_hdr->host_status) { + case SCSI_HOST_TIME_OUT: + *sense =3D SENSE_CODE(COMMAND_TIMEOUT); + return CHECK_CONDITION; + case SCSI_HOST_BAD_RESPONSE: + *sense =3D SENSE_CODE(LUN_COMM_FAILURE); + return CHECK_CONDITION; + case SCSI_HOST_ABORTED: + *sense =3D SENSE_CODE(COMMAND_ABORTED); + return CHECK_CONDITION; + case SCSI_HOST_RESET: + *sense =3D SENSE_CODE(RESET); + return CHECK_CONDITION; + case SCSI_HOST_TRANSPORT_DISRUPTED: *sense =3D SENSE_CODE(I_T_NEXUS_LOSS); return CHECK_CONDITION; + case SCSI_HOST_TARGET_FAILURE: + *sense =3D SENSE_CODE(TARGET_FAILURE); + return CHECK_CONDITION; + case SCSI_HOST_RESERVATION_ERROR: + return RESERVATION_CONFLICT; + case SCSI_HOST_ALLOCATION_FAILURE: + *sense =3D SENSE_CODE(SPACE_ALLOC_FAILED); + return CHECK_CONDITION; + case SCSI_HOST_MEDIUM_ERROR: + *sense =3D SENSE_CODE(READ_ERROR); + return CHECK_CONDITION; + } + if (io_hdr->driver_status & SG_ERR_DRIVER_TIMEOUT) { + return BUSY; } else if (io_hdr->status) { return io_hdr->status; } else if (io_hdr->driver_status & SG_ERR_DRIVER_SENSE) { --=20 2.16.4 From nobody Fri Apr 26 13:27:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605553097; cv=none; d=zohomail.com; s=zohoarc; b=LZNijH0BKVdtPun88KWA01VhmobZZ9Fkd4/gHfrvDr2u9sCKSfU9/eLmlqwGUW6tzeO32pVQudZj8GnXnFjndW4Y0ytr4awFfY4eqVrw9c8pu1uVCIe8LQR/TyJgGttEcfi/f3dqNRfVcQIodceMPg+Il4B2zzPygtL96ZadQmg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605553097; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=cg2InckjSnZU9Qaq6vQAv+UafFweCgNE7PMBbRdpoEY=; b=HJnVSc626b5B5uqFTpwH/TwyFbpDgGFs3OPTM7V4L3YRYoHNrkW5v7iJlRupulCMRM9Gq3XvTRjyrBk7cy9tOF53leL9GCgFdVn+ucKTZtE9j8pMD9n9zHfXIRCWDdF1LIO03LVV5u+pbsu44jbRW4fX6Mg210j9JHEJHxkBJD8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605553097086536.2150026528653; Mon, 16 Nov 2020 10:58:17 -0800 (PST) Received: from localhost ([::1]:37152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejhf-000133-PC for importer@patchew.org; Mon, 16 Nov 2020 13:58:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejR3-00040r-Fq for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:45374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQt-0000oa-1y for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:05 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6487FB018; Mon, 16 Nov 2020 18:40:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Hannes Reinecke To: Paolo Bonzini Subject: [PATCH 6/7] scsi: split sg_io_sense_from_errno() in two functions Date: Mon, 16 Nov 2020 19:40:40 +0100 Message-Id: <20201116184041.60465-7-hare@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201116184041.60465-1-hare@suse.de> References: <20201116184041.60465-1-hare@suse.de> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:53:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Hannes Reinecke Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently sg_io_sense_from_errno() converts the two input parameters 'errno' and 'io_hdr' into sense code and SCSI status. This patch splits this off into two functions scsi_sense_from_errno() and scsi_sense_from_host_status(), both of which are available generically. This allows us to use the function scsi_sense_from_errno() in scsi-disk.c instead of the switch statement, allowing us to consolidate the errno handling. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 72 +++++++++++-------------- hw/scsi/scsi-generic.c | 19 +++++-- include/scsi/utils.h | 6 +-- scsi/qemu-pr-helper.c | 14 +++-- scsi/utils.c | 139 ++++++++++++++++++++++++++-------------------= ---- 5 files changed, 134 insertions(+), 116 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 797779afd6..6eb0aa3d27 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -445,8 +445,7 @@ static bool scsi_handle_rw_error(SCSIDiskReq *r, int er= ror, bool acct_failed) if (acct_failed) { block_acct_failed(blk_get_stats(s->qdev.conf.blk), &r->acct); } - switch (error) { - case 0: + if (error =3D=3D 0) { /* A passthrough command has run and has produced sense data; = check * whether the error has to be handled by the guest or should = rather * pause the host. @@ -459,41 +458,16 @@ static bool scsi_handle_rw_error(SCSIDiskReq *r, int = error, bool acct_failed) return true; } error =3D scsi_sense_buf_to_errno(r->req.sense, sizeof(r->req.= sense)); - break; -#ifdef CONFIG_LINUX - /* These errno mapping are specific to Linux. For more inform= ation: - * - scsi_decide_disposition in drivers/scsi/scsi_error.c - * - scsi_result_to_blk_status in drivers/scsi/scsi_lib.c - * - blk_errors[] in block/blk-core.c - */ - case EBADE: - /* DID_NEXUS_FAILURE -> BLK_STS_NEXUS. */ - scsi_req_complete(&r->req, RESERVATION_CONFLICT); - break; - case ENODATA: - /* DID_MEDIUM_ERROR -> BLK_STS_MEDIUM. */ - scsi_check_condition(r, SENSE_CODE(READ_ERROR)); - break; - case EREMOTEIO: - /* DID_TARGET_FAILURE -> BLK_STS_TARGET. */ - scsi_req_complete(&r->req, HARDWARE_ERROR); - break; -#endif - case ENOMEDIUM: - scsi_check_condition(r, SENSE_CODE(NO_MEDIUM)); - break; - case ENOMEM: - scsi_check_condition(r, SENSE_CODE(TARGET_FAILURE)); - break; - case EINVAL: - scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); - break; - case ENOSPC: - scsi_check_condition(r, SENSE_CODE(SPACE_ALLOC_FAILED)); - break; - default: - scsi_check_condition(r, SENSE_CODE(IO_ERROR)); - break; + } else { + SCSISense sense; + int status; + + status =3D scsi_sense_from_errno(error, &sense); + if (status =3D=3D CHECK_CONDITION) + scsi_build_sense(r->req.sense, sense); + sdc->update_sense(&r->req); + scsi_req_complete(&r->req, status); + return true; } } =20 @@ -2714,13 +2688,29 @@ static void scsi_block_sgio_complete(void *opaque, = int ret) { SCSIBlockReq *req =3D (SCSIBlockReq *)opaque; SCSIDiskReq *r =3D &req->req; + sg_io_hdr_t io_hdr =3D req->io_header; SCSISense sense; + int status; =20 - r->req.status =3D sg_io_sense_from_errno(-ret, &req->io_header, &sense= ); - if (r->req.status =3D=3D CHECK_CONDITION && - req->io_header.status !=3D CHECK_CONDITION) + status =3D scsi_sense_from_errno(-ret, &sense); + if (status =3D=3D CHECK_CONDITION) { scsi_req_build_sense(&r->req, sense); - + } else if (status =3D=3D GOOD && + io_hdr.host_status !=3D SCSI_HOST_OK) { + status =3D scsi_sense_from_host_status(io_hdr.host_status, &sense); + if (status =3D=3D CHECK_CONDITION) { + scsi_req_build_sense(&r->req, sense); + } + } else if (io_hdr.status =3D=3D CHECK_CONDITION || + io_hdr.driver_status & SG_ERR_DRIVER_SENSE) { + status =3D CHECK_CONDITION; + r->req.sense_len =3D io_hdr.sb_len_wr; + } else if (io_hdr.driver_status & SG_ERR_DRIVER_TIMEOUT) { + status =3D BUSY; + } else if (io_hdr.status) { + status =3D io_hdr.status; + } + r->req.status =3D status; req->cb(req->cb_opaque, ret); } =20 diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 8687336438..a2b85678b5 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -74,6 +74,7 @@ static void scsi_command_complete_noio(SCSIGenericReq *r,= int ret) { int status; SCSISense sense; + sg_io_hdr_t io_hdr =3D r->io_header; =20 assert(r->req.aiocb =3D=3D NULL); =20 @@ -81,13 +82,23 @@ static void scsi_command_complete_noio(SCSIGenericReq *= r, int ret) scsi_req_cancel_complete(&r->req); goto done; } - status =3D sg_io_sense_from_errno(-ret, &r->io_header, &sense); + status =3D scsi_sense_from_errno(-ret, &sense); if (status =3D=3D CHECK_CONDITION) { - if (r->io_header.driver_status & SG_ERR_DRIVER_SENSE) { - r->req.sense_len =3D r->io_header.sb_len_wr; - } else { + scsi_req_build_sense(&r->req, sense); + } else if (status =3D=3D GOOD && + io_hdr.host_status !=3D SCSI_HOST_OK) { + status =3D scsi_sense_from_host_status(io_hdr.host_status, &sense); + if (status =3D=3D CHECK_CONDITION) { scsi_req_build_sense(&r->req, sense); } + } else if (io_hdr.status =3D=3D CHECK_CONDITION || + io_hdr.driver_status & SG_ERR_DRIVER_SENSE) { + status =3D CHECK_CONDITION; + r->req.sense_len =3D io_hdr.sb_len_wr; + } else if (io_hdr.driver_status & SG_ERR_DRIVER_TIMEOUT) { + status =3D BUSY; + } else if (io_hdr.status !=3D GOOD) { + status =3D io_hdr.status; } =20 trace_scsi_generic_command_complete_noio(r, r->req.tag, status); diff --git a/include/scsi/utils.h b/include/scsi/utils.h index a55ba2c1ea..581caf15e0 100644 --- a/include/scsi/utils.h +++ b/include/scsi/utils.h @@ -137,9 +137,9 @@ int scsi_cdb_length(uint8_t *buf); #ifdef CONFIG_LINUX #define SG_ERR_DRIVER_TIMEOUT 0x06 #define SG_ERR_DRIVER_SENSE 0x08 - -int sg_io_sense_from_errno(int errno_value, struct sg_io_hdr *io_hdr, - SCSISense *sense); #endif =20 +int scsi_sense_from_errno(int errno_value, SCSISense *sense); +int scsi_sense_from_host_status(uint8_t host_status, SCSISense *sense); + #endif diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index d26faaf91e..e6e217a61b 100644 --- a/scsi/qemu-pr-helper.c +++ b/scsi/qemu-pr-helper.c @@ -134,7 +134,7 @@ static int do_sgio_worker(void *opaque) PRHelperSGIOData *data =3D opaque; struct sg_io_hdr io_hdr; int ret; - int status; + int status =3D GOOD; SCSISense sense_code; =20 memset(data->sense, 0, PR_HELPER_SENSE_SIZE); @@ -149,8 +149,16 @@ static int do_sgio_worker(void *opaque) io_hdr.dxferp =3D (char *)data->buf; io_hdr.dxfer_len =3D data->sz; ret =3D ioctl(data->fd, SG_IO, &io_hdr); - status =3D sg_io_sense_from_errno(ret < 0 ? errno : 0, &io_hdr, - &sense_code); + + if (ret < 0) { + status =3D scsi_sense_from_errno(errno, &sense_code); + } + if (status =3D=3D GOOD && io_hdr.host_status !=3D SCSI_HOST_OK) { + status =3D scsi_sense_from_host_status(io_hdr.host_status, &sense_= code); + } + if (status =3D=3D GOOD && io_hdr.driver_status & SG_ERR_DRIVER_SENSE) { + status =3D CHECK_CONDITION; + } if (status =3D=3D GOOD) { data->sz -=3D io_hdr.resid; } else { diff --git a/scsi/utils.c b/scsi/utils.c index ae68881184..6cb75154e8 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -575,72 +575,81 @@ const char *scsi_command_name(uint8_t cmd) return names[cmd]; } =20 +int scsi_sense_from_errno(int errno_value, SCSISense *sense) +{ + switch (errno_value) { + case 0: + return GOOD; + case EDOM: + return TASK_SET_FULL; #ifdef CONFIG_LINUX -int sg_io_sense_from_errno(int errno_value, struct sg_io_hdr *io_hdr, - SCSISense *sense) + /* These errno mapping are specific to Linux. For more informatio= n: + * - scsi_decide_disposition in drivers/scsi/scsi_error.c + * - scsi_result_to_blk_status in drivers/scsi/scsi_lib.c + * - blk_errors[] in block/blk-core.c + */ + case EBADE: + return RESERVATION_CONFLICT; + case ENODATA: + *sense =3D SENSE_CODE(READ_ERROR); + return CHECK_CONDITION; + case EREMOTEIO: + *sense =3D SENSE_CODE(LUN_COMM_FAILURE); + return CHECK_CONDITION; +#endif + case ENOMEDIUM: + *sense =3D SENSE_CODE(NO_MEDIUM); + return CHECK_CONDITION; + case ENOMEM: + *sense =3D SENSE_CODE(TARGET_FAILURE); + return CHECK_CONDITION; + case EINVAL: + *sense =3D SENSE_CODE(INVALID_FIELD); + return CHECK_CONDITION; + case ENOSPC: + *sense =3D SENSE_CODE(SPACE_ALLOC_FAILED); + return CHECK_CONDITION; + default: + *sense =3D SENSE_CODE(IO_ERROR); + return CHECK_CONDITION; + } +} + +int scsi_sense_from_host_status(uint8_t host_status, + SCSISense *sense) { - if (errno_value !=3D 0) { - switch (errno_value) { - case EDOM: - return TASK_SET_FULL; - case EBADE: - return RESERVATION_CONFLICT; - case ENODATA: - *sense =3D SENSE_CODE(READ_ERROR); - return CHECK_CONDITION; - case EREMOTEIO: - *sense =3D SENSE_CODE(LUN_COMM_FAILURE); - return CHECK_CONDITION; - case ENOMEM: - *sense =3D SENSE_CODE(TARGET_FAILURE); - return CHECK_CONDITION; - default: - *sense =3D SENSE_CODE(IO_ERROR); - return CHECK_CONDITION; - } - } else { - switch (io_hdr->host_status) { - case SCSI_HOST_NO_LUN: - *sense =3D SENSE_CODE(LUN_NOT_RESPONDING); - return CHECK_CONDITION; - case SCSI_HOST_BUSY: - return BUSY; - case SCSI_HOST_TIME_OUT: - *sense =3D SENSE_CODE(COMMAND_TIMEOUT); - return CHECK_CONDITION; - case SCSI_HOST_BAD_RESPONSE: - *sense =3D SENSE_CODE(LUN_COMM_FAILURE); - return CHECK_CONDITION; - case SCSI_HOST_ABORTED: - *sense =3D SENSE_CODE(COMMAND_ABORTED); - return CHECK_CONDITION; - case SCSI_HOST_RESET: - *sense =3D SENSE_CODE(RESET); - return CHECK_CONDITION; - case SCSI_HOST_TRANSPORT_DISRUPTED: - *sense =3D SENSE_CODE(I_T_NEXUS_LOSS); - return CHECK_CONDITION; - case SCSI_HOST_TARGET_FAILURE: - *sense =3D SENSE_CODE(TARGET_FAILURE); - return CHECK_CONDITION; - case SCSI_HOST_RESERVATION_ERROR: - return RESERVATION_CONFLICT; - case SCSI_HOST_ALLOCATION_FAILURE: - *sense =3D SENSE_CODE(SPACE_ALLOC_FAILED); - return CHECK_CONDITION; - case SCSI_HOST_MEDIUM_ERROR: - *sense =3D SENSE_CODE(READ_ERROR); - return CHECK_CONDITION; - } - if (io_hdr->driver_status & SG_ERR_DRIVER_TIMEOUT) { - return BUSY; - } else if (io_hdr->status) { - return io_hdr->status; - } else if (io_hdr->driver_status & SG_ERR_DRIVER_SENSE) { - return CHECK_CONDITION; - } else { - return GOOD; - } + switch (host_status) { + case SCSI_HOST_NO_LUN: + *sense =3D SENSE_CODE(LUN_NOT_RESPONDING); + return CHECK_CONDITION; + case SCSI_HOST_BUSY: + return BUSY; + case SCSI_HOST_TIME_OUT: + *sense =3D SENSE_CODE(COMMAND_TIMEOUT); + return CHECK_CONDITION; + case SCSI_HOST_BAD_RESPONSE: + *sense =3D SENSE_CODE(LUN_COMM_FAILURE); + return CHECK_CONDITION; + case SCSI_HOST_ABORTED: + *sense =3D SENSE_CODE(COMMAND_ABORTED); + return CHECK_CONDITION; + case SCSI_HOST_RESET: + *sense =3D SENSE_CODE(RESET); + return CHECK_CONDITION; + case SCSI_HOST_TRANSPORT_DISRUPTED: + *sense =3D SENSE_CODE(I_T_NEXUS_LOSS); + return CHECK_CONDITION; + case SCSI_HOST_TARGET_FAILURE: + *sense =3D SENSE_CODE(TARGET_FAILURE); + return CHECK_CONDITION; + case SCSI_HOST_RESERVATION_ERROR: + return RESERVATION_CONFLICT; + case SCSI_HOST_ALLOCATION_FAILURE: + *sense =3D SENSE_CODE(SPACE_ALLOC_FAILED); + return CHECK_CONDITION; + case SCSI_HOST_MEDIUM_ERROR: + *sense =3D SENSE_CODE(READ_ERROR); + return CHECK_CONDITION; } + return GOOD; } -#endif --=20 2.16.4 From nobody Fri Apr 26 13:27:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605553291; cv=none; d=zohomail.com; s=zohoarc; b=LeSIf5Hh0Y+FwFmK6vqP/w0Rt+uhDYUfLJJKTg57WIkbKJnSRu+Tsl8jGi82FX609EPSUzU6ioYYOH3ONTQD/HDdiq1Zt7N7sHTD5EdB6w2t+6BmF/Ys9xXD4ROYtzRS15VghIHvURhwwWpBOtVXu7eHeaDjblZDnmvFO6omieU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605553291; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=2u2mbUDRF44lEdP6HW9FVLA625HTxsMsSduZlLaQEsI=; b=TUnlRLZzKcZ2j4TDoj2quy2Ay1OjJl376HG1w/PYaS0LFk/ILXT+tFp8HmMphMy06J5CsclMJ6FdKsWhzNqWvYbCn9horwFX714TNtYQ8Pu5nqqNcOY1mMJzi6t3G4YHRjNv8vMNJ2DGf6EVn6MoU2EX4PdOV4mTdg6Gwq6EHYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605553291093524.5025537044271; Mon, 16 Nov 2020 11:01:31 -0800 (PST) Received: from localhost ([::1]:45664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejkn-0004fJ-EK for importer@patchew.org; Mon, 16 Nov 2020 14:01:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejR3-000426-Ur for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:45376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejQu-0000qc-V5 for qemu-devel@nongnu.org; Mon, 16 Nov 2020 13:41:05 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6BA07B019; Mon, 16 Nov 2020 18:40:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Hannes Reinecke To: Paolo Bonzini Subject: [PATCH 7/7] scsi: move host_status handling into SCSI drivers Date: Mon, 16 Nov 2020 19:40:41 +0100 Message-Id: <20201116184041.60465-8-hare@suse.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201116184041.60465-1-hare@suse.de> References: <20201116184041.60465-1-hare@suse.de> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 12:53:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Hannes Reinecke Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Some SCSI drivers like virtio have an internal mapping for the host_status. This patch moves the host_status translation into the SCSI drivers to allow those drivers to set up the correct values. Signed-off-by: Hannes Reinecke --- hw/scsi/esp.c | 10 ++++++++++ hw/scsi/lsi53c895a.c | 11 +++++++++++ hw/scsi/megasas.c | 9 +++++++++ hw/scsi/mptsas.c | 9 +++++++++ hw/scsi/scsi-disk.c | 10 ++++------ hw/scsi/scsi-generic.c | 8 +++----- hw/scsi/spapr_vscsi.c | 12 +++++++++++- hw/scsi/virtio-scsi.c | 41 +++++++++++++++++++++++++++++++++++++++-- hw/scsi/vmw_pvscsi.c | 25 +++++++++++++++++++++++++ include/hw/scsi/scsi.h | 3 ++- 10 files changed, 123 insertions(+), 15 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 93d9c9c7b9..fc88cfac23 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -28,6 +28,8 @@ #include "migration/vmstate.h" #include "hw/irq.h" #include "hw/scsi/esp.h" +#include "scsi/utils.h" +#include "scsi/constants.h" #include "trace.h" #include "qemu/log.h" #include "qemu/module.h" @@ -489,6 +491,14 @@ void esp_command_complete(SCSIRequest *req, size_t res= id) { ESPState *s =3D req->hba_private; =20 + if (req->host_status !=3D SCSI_HOST_OK) { + SCSISense sense; + + req->status =3D scsi_sense_from_host_status(req->host_status, &sen= se); + if (req->status =3D=3D CHECK_CONDITION) { + scsi_req_build_sense(req, sense); + } + } if (s->rregs[ESP_RSTAT] & STAT_INT) { /* Defer handling command complete until the previous * interrupt has been handled. diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index a4e58580e4..b6aa98c95a 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -18,6 +18,8 @@ #include "hw/irq.h" #include "hw/pci/pci.h" #include "hw/scsi/scsi.h" +#include "scsi/utils.h" +#include "scsi/constants.h" #include "migration/vmstate.h" #include "sysemu/dma.h" #include "qemu/log.h" @@ -792,6 +794,15 @@ static void lsi_command_complete(SCSIRequest *req, siz= e_t resid) LSIState *s =3D LSI53C895A(req->bus->qbus.parent); int out; =20 + if (req->host_status !=3D SCSI_HOST_OK) { + SCSISense sense; + + req->status =3D scsi_sense_from_host_status(req->host_status, &sen= se); + if (req->status =3D=3D CHECK_CONDITION) { + scsi_req_build_sense(req, sense); + } + } + out =3D (s->sstat1 & PHASE_MASK) =3D=3D PHASE_DO; trace_lsi_command_complete(req->status); s->status =3D req->status; diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 35867dbd40..1f7d806ffa 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -1857,6 +1857,15 @@ static void megasas_command_complete(SCSIRequest *re= q, size_t resid) MegasasCmd *cmd =3D req->hba_private; uint8_t cmd_status =3D MFI_STAT_OK; =20 + if (req->host_status !=3D SCSI_HOST_OK) { + SCSISense sense; + + req->status =3D scsi_sense_from_host_status(req->host_status, &sen= se); + if (req->status =3D=3D CHECK_CONDITION) { + scsi_req_build_sense(req, sense); + } + } + trace_megasas_command_complete(cmd->index, req->status, resid); =20 if (req->io_canceled) { diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index d4fbfb2da7..be3875ce94 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -1143,6 +1143,15 @@ static void mptsas_command_complete(SCSIRequest *sre= q, hwaddr sense_buffer_addr =3D req->dev->sense_buffer_high_addr | req->scsi_io.SenseBufferLowAddr; =20 + if (sreq->host_status =3D=3D SCSI_HOST_OK) { + SCSISense sense; + + sreq->status =3D scsi_sense_from_host_status(sreq->host_status, &s= ense); + if (sreq->status =3D=3D CHECK_CONDITION) { + scsi_req_build_sense(sreq, sense); + } + } + trace_mptsas_command_complete(s, req->scsi_io.MsgContext, sreq->status, resid); =20 diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 6eb0aa3d27..c0cb63707d 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1840,7 +1840,7 @@ static void scsi_disk_emulate_write_data(SCSIRequest = *req) case VERIFY_10: case VERIFY_12: case VERIFY_16: - if (r->req.status =3D=3D -1) { + if (r->req.status =3D=3D GOOD) { scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); } break; @@ -2122,7 +2122,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest = *req, uint8_t *buf) } =20 illegal_request: - if (r->req.status =3D=3D -1) { + if (r->req.status =3D=3D GOOD) { scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); } return 0; @@ -2697,10 +2697,8 @@ static void scsi_block_sgio_complete(void *opaque, i= nt ret) scsi_req_build_sense(&r->req, sense); } else if (status =3D=3D GOOD && io_hdr.host_status !=3D SCSI_HOST_OK) { - status =3D scsi_sense_from_host_status(io_hdr.host_status, &sense); - if (status =3D=3D CHECK_CONDITION) { - scsi_req_build_sense(&r->req, sense); - } + status =3D INTERMEDIATE_GOOD; + r->req.host_status =3D io_hdr.host_status; } else if (io_hdr.status =3D=3D CHECK_CONDITION || io_hdr.driver_status & SG_ERR_DRIVER_SENSE) { status =3D CHECK_CONDITION; diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index a2b85678b5..eac108fc6e 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -86,11 +86,9 @@ static void scsi_command_complete_noio(SCSIGenericReq *r= , int ret) if (status =3D=3D CHECK_CONDITION) { scsi_req_build_sense(&r->req, sense); } else if (status =3D=3D GOOD && - io_hdr.host_status !=3D SCSI_HOST_OK) { - status =3D scsi_sense_from_host_status(io_hdr.host_status, &sense); - if (status =3D=3D CHECK_CONDITION) { - scsi_req_build_sense(&r->req, sense); - } + io_hdr.host_status !=3D SCSI_HOST_OK) { + status =3D INTERMEDIATE_GOOD; + r->req.host_status =3D io_hdr.host_status; } else if (io_hdr.status =3D=3D CHECK_CONDITION || io_hdr.driver_status & SG_ERR_DRIVER_SENSE) { status =3D CHECK_CONDITION; diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c index d653b5a6ad..9327a493c3 100644 --- a/hw/scsi/spapr_vscsi.c +++ b/hw/scsi/spapr_vscsi.c @@ -556,6 +556,16 @@ static void vscsi_command_complete(SCSIRequest *sreq, = size_t resid) VSCSIState *s =3D VIO_SPAPR_VSCSI_DEVICE(sreq->bus->qbus.parent); vscsi_req *req =3D sreq->hba_private; int32_t res_in =3D 0, res_out =3D 0; + uint8_t status =3D sreq->status; + + if (sreq->host_status !=3D SCSI_HOST_OK) { + SCSISense sense; + + sreq->status =3D scsi_sense_from_host_status(sreq->host_status, &s= ense); + if (sreq->status =3D=3D CHECK_CONDITION) { + scsi_req_build_sense(sreq, sense); + } + } =20 trace_spapr_vscsi_command_complete(sreq->tag, sreq->status, req); if (req =3D=3D NULL) { @@ -575,7 +585,7 @@ static void vscsi_command_complete(SCSIRequest *sreq, s= ize_t resid) } =20 trace_spapr_vscsi_command_complete_status(sreq->status); - if (sreq->status =3D=3D 0) { + if (sreq->status =3D=3D GOOD) { /* We handle overflows, not underflows for normal commands, * but hopefully nobody cares */ diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 64cd852d82..62c56713d8 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -504,8 +504,45 @@ static void virtio_scsi_command_complete(SCSIRequest *= r, size_t resid) return; } =20 - req->resp.cmd.response =3D VIRTIO_SCSI_S_OK; - req->resp.cmd.status =3D r->status; + if (r->host_status !=3D SCSI_HOST_OK) { + req->resp.cmd.status =3D GOOD; + switch (r->host_status) { + case SCSI_HOST_NO_LUN: + req->resp.cmd.response =3D VIRTIO_SCSI_S_INCORRECT_LUN; + break; + case SCSI_HOST_BUSY: + req->resp.cmd.response =3D VIRTIO_SCSI_S_BUSY; + break; + case SCSI_HOST_TIME_OUT: + case SCSI_HOST_ABORTED: + req->resp.cmd.response =3D VIRTIO_SCSI_S_ABORTED; + break; + case SCSI_HOST_BAD_RESPONSE: + req->resp.cmd.response =3D VIRTIO_SCSI_S_BAD_TARGET; + break; + case SCSI_HOST_RESET: + req->resp.cmd.response =3D VIRTIO_SCSI_S_RESET; + break; + case SCSI_HOST_TRANSPORT_DISRUPTED: + req->resp.cmd.response =3D VIRTIO_SCSI_S_TRANSPORT_FAILURE; + break; + case SCSI_HOST_TARGET_FAILURE: + req->resp.cmd.response =3D VIRTIO_SCSI_S_TARGET_FAILURE; + break; + case SCSI_HOST_RESERVATION_ERROR: + req->resp.cmd.response =3D VIRTIO_SCSI_S_NEXUS_FAILURE; + break; + case SCSI_HOST_ALLOCATION_FAILURE: + case SCSI_HOST_MEDIUM_ERROR: + case SCSI_HOST_ERROR: + default: + req->resp.cmd.response =3D VIRTIO_SCSI_S_FAILURE; + break; + } + } else { + req->resp.cmd.response =3D VIRTIO_SCSI_S_OK; + req->resp.cmd.status =3D r->status; + } if (req->resp.cmd.status =3D=3D GOOD) { req->resp.cmd.resid =3D virtio_tswap32(vdev, resid); } else { diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 0da378ed50..2583105dfd 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -522,6 +522,31 @@ pvscsi_command_complete(SCSIRequest *req, size_t resid) } s =3D pvscsi_req->dev; =20 + if (req->host_status !=3D SCSI_HOST_OK) { + switch (req->host_status) { + case SCSI_HOST_NO_LUN: + pvscsi_req->cmp.hostStatus =3D BTSTAT_LUNMISMATCH; + break; + case SCSI_HOST_BUSY: + pvscsi_req->cmp.hostStatus =3D BTSTAT_ABORTQUEUE; + break; + case SCSI_HOST_TIME_OUT: + case SCSI_HOST_ABORTED: + pvscsi_req->cmp.hostStatus =3D BTSTAT_SENTRST; + break; + case SCSI_HOST_BAD_RESPONSE: + pvscsi_req->cmp.hostStatus =3D BTSTAT_SELTIMEO; + break; + case SCSI_HOST_RESET: + pvscsi_req->cmp.hostStatus =3D BTSTAT_BUSRESET; + break; + default: + pvscsi_req->cmp.hostStatus =3D BTSTAT_HASOFTWARE; + break; + } + req->status =3D GOOD; + } + if (resid) { /* Short transfer. */ trace_pvscsi_command_complete_data_run(); diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h index 23a9b23e50..a097fecb2a 100644 --- a/include/hw/scsi/scsi.h +++ b/include/hw/scsi/scsi.h @@ -27,7 +27,8 @@ struct SCSIRequest { uint32_t refcount; uint32_t tag; uint32_t lun; - uint32_t status; + uint8_t status; + uint8_t host_status; void *hba_private; size_t resid; SCSICommand cmd; --=20 2.16.4