From nobody Sun May 5 03:06:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605536424; cv=none; d=zohomail.com; s=zohoarc; b=nnc8hzIJgHlBdrp6yEJLs98YwL9zppVf0Os3cr0pcebgCUVai/gVCuSvGmoAT/WkBd6INqDOytM5r12ZWAjDJkeBy6rTlcmvwNJo+mZQBrpT2bN44E6NM0RbUzErjq6pMnwfN2Q0m/cFWOd48h6Kz6U04xmxttehGzSxtWRgurE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605536424; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=4uwRh4bZfP7cngHz9zCdfnvaZf77hnRSxoFvfnToyCA=; b=bTxdCqG2rGC+6EHbKotbIjblZzgmuHcSPEas4B/MNr42DkVaGfLwTrXYxkGjCLE7LZ14BT3EdfVu0NQmW5psa1EMPcIQQ8Wb+/d0amPQ0B9RzAPMsPRbwk9KV51hkFi/kaFGMtyF2/ioRtlCVVo54VDgfG76keyBzqAPrGzoBJI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605536424582199.0179358335903; Mon, 16 Nov 2020 06:20:24 -0800 (PST) Received: from localhost ([::1]:60674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kefMk-0006dO-Dn for importer@patchew.org; Mon, 16 Nov 2020 09:20:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kefLL-00064A-Il; Mon, 16 Nov 2020 09:18:55 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:2151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kefLF-0001cl-Pj; Mon, 16 Nov 2020 09:18:55 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CZWPv6Vl4z6wn9; Mon, 16 Nov 2020 22:18:11 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 22:18:16 +0800 From: Peng Liang To: Subject: [PATCH] ui/vnc: Add missing lock for send_color_map Date: Mon, 16 Nov 2020 22:13:38 +0800 Message-ID: <20201116141338.148911-1-liangpeng10@huawei.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=liangpeng10@huawei.com; helo=szxga07-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 09:18:25 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liangpeng10@huawei.com, zhang.zhanghailiang@huawei.com, qemu-stable@nongnu.org, xiexiangyou@huawei.com, kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" vnc_write() should be locked after the RFB protocol is initialized. Fixes: 0c426e4534b4 ("vnc: Add support for color map") Cc: qemu-stable@nongnu.org Reported-by: Euler Robot Signed-off-by: Peng Liang --- ui/vnc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 49235056f7a8..ca3fc376aeb5 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2156,6 +2156,7 @@ static void send_color_map(VncState *vs) { int i; =20 + vnc_lock_output(vs); vnc_write_u8(vs, VNC_MSG_SERVER_SET_COLOUR_MAP_ENTRIES); vnc_write_u8(vs, 0); /* padding */ vnc_write_u16(vs, 0); /* first color */ @@ -2168,6 +2169,7 @@ static void send_color_map(VncState *vs) vnc_write_u16(vs, (((i >> pf->gshift) & pf->gmax) << (16 - pf->gbi= ts))); vnc_write_u16(vs, (((i >> pf->bshift) & pf->bmax) << (16 - pf->bbi= ts))); } + vnc_unlock_output(vs); } =20 static void set_pixel_format(VncState *vs, int bits_per_pixel, --=20 2.28.0