From nobody Mon Apr 29 12:05:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605495051; cv=none; d=zohomail.com; s=zohoarc; b=kexLaWpqglIdy6efoW2sjwVfOPwRErAUXVuKyIuRt3h9xpKbnth9VSLVj/1vHNJMgO+AAcSSKFt4K35jcHirAVPjIpYvBcvZdzCNgIPDaIn3ctuK2MxXlH9LtA4zyJUppYYxdowqlizbvLbMiHSnBUD9nBpUSlC7I7O2lZG06dw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605495051; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xeSaAqtzgaDkVp07mTEivuMHn6RP5d0Gs9PZ+3Sgryg=; b=OVLJhqGu4RJvYBNu7uPV9bK8zGUHdBFIsY7wRcs77QZVgEBy7igc/PIBzKAUYJwRnKtm12MjS0VFWpPAagFCa9eQUky47SQlTDVeRQhJtrR4UxJRCf1WwznVVSzNUWXZYXmCxyyr6upjbPkJB8CunUaEmXYXZlyrgvCF14EXRYM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605495051327984.7915705210909; Sun, 15 Nov 2020 18:50:51 -0800 (PST) Received: from localhost ([::1]:40700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keUbR-0008Fg-HF for importer@patchew.org; Sun, 15 Nov 2020 21:50:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZj-0006Xt-4n; Sun, 15 Nov 2020 21:49:03 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZf-0002sI-E7; Sun, 15 Nov 2020 21:49:02 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CZD6L0f8ZzhbCG; Mon, 16 Nov 2020 10:48:42 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 10:48:45 +0800 From: Chen Qun To: , Subject: [PATCH v3 1/7] target/i386: silence the compiler warnings in gen_shiftd_rm_T1 Date: Mon, 16 Nov 2020 10:48:04 +0800 Message-ID: <20201116024810.2415819-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=szxga06-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 21:48:52 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , zhang.zhanghailiang@huawei.com, Richard Henderson , Paolo Bonzini , ganqixin@huawei.com, Euler Robot , Chen Qun , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" The current "#ifdef TARGET_X86_64" statement affects the compiler's determination of fall through. When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showe= d warning: target/i386/translate.c: In function =E2=80=98gen_shiftd_rm_T1=E2=80=99: target/i386/translate.c:1773:12: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] if (is_right) { ^ target/i386/translate.c:1782:5: note: here case MO_32: ^~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- v1->v2: Add comments to explain the two case of fall through, depending on whether TARGET_X86_64 is defined. Cc: Thomas Huth Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- target/i386/translate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index caea6f5fb1..77cb66208e 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -1777,9 +1777,12 @@ static void gen_shiftd_rm_T1(DisasContext *s, MemOp = ot, int op1, } else { tcg_gen_deposit_tl(s->T1, s->T0, s->T1, 16, 16); } - /* FALLTHRU */ -#ifdef TARGET_X86_64 + /* + * If TARGET_X86_64 defined then fall through into MO_32 case, + * otherwise fall through default case. + */ case MO_32: +#ifdef TARGET_X86_64 /* Concatenate the two 32-bit values and use a 64-bit shift. */ tcg_gen_subi_tl(s->tmp0, count, 1); if (is_right) { --=20 2.27.0 From nobody Mon Apr 29 12:05:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605495179; cv=none; d=zohomail.com; s=zohoarc; b=B/vzfnnaKhz16g7kT8YVD46W+7pWt1yLwzBNnCmzkCL9tcxLwo+k08l3Um5372CzgeGkVZkhOvk5wNRvgPNcrBOn+95aYMm2HesBjx273i65xzRzGEsQenBjUTDmMX4h0s+XG+uz1cEdlVjG4kBc5xqKI6YrAapjeneANjSjVSY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605495179; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fB50RNfINbiBiT1AmmySBxtnWhey8amwFcrkaolDaJ8=; b=hEyXDQZs9/cevsD0OUns/D4DO8OQf8T10pe8m/ylcaW2IAA9tXNQujAOCgrdOJRKf/Poakf37kUPFn1PoJ0IFgCqP7VoKs6ZqOrYbtVCl8P5INe2h4Vfb0JOpRovxUan8D6tdhiaGAMyC7sGpEsnujqy1o5wXT9xbTaV1hHqjEg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605495179673382.7763399375125; Sun, 15 Nov 2020 18:52:59 -0800 (PST) Received: from localhost ([::1]:49724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keUdW-0003Wz-LF for importer@patchew.org; Sun, 15 Nov 2020 21:52:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZk-0006YI-8T; Sun, 15 Nov 2020 21:49:04 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:2146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZg-0002sT-MM; Sun, 15 Nov 2020 21:49:03 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CZD6M5ZFpz6xHl; Mon, 16 Nov 2020 10:48:43 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 10:48:46 +0800 From: Chen Qun To: , Subject: [PATCH v3 2/7] hw/intc/arm_gicv3_kvm: silence the compiler warnings Date: Mon, 16 Nov 2020 10:48:05 +0800 Message-ID: <20201116024810.2415819-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=kuhn.chenqun@huawei.com; helo=szxga07-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 21:14:23 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, qemu-arm@nongnu.org, ganqixin@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showe= d warning: hw/intc/arm_gicv3_kvm.c: In function =E2=80=98kvm_arm_gicv3_put=E2=80=99: hw/intc/arm_gicv3_kvm.c:484:13: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] kvm_gicc_access(s, ICC_AP0R_EL1(1), ncpu, ®64, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/intc/arm_gicv3_kvm.c:485:9: note: here default: ^~~~~~~ hw/intc/arm_gicv3_kvm.c:495:13: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] kvm_gicc_access(s, ICC_AP1R_EL1(2), ncpu, ®64, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/intc/arm_gicv3_kvm.c:496:9: note: here case 6: ^~~~ hw/intc/arm_gicv3_kvm.c:498:13: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] kvm_gicc_access(s, ICC_AP1R_EL1(1), ncpu, ®64, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/intc/arm_gicv3_kvm.c:499:9: note: here default: ^~~~~~~ hw/intc/arm_gicv3_kvm.c: In function =E2=80=98kvm_arm_gicv3_get=E2=80=99: hw/intc/arm_gicv3_kvm.c:634:37: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G0][2] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:635:9: note: here case 6: ^~~~ hw/intc/arm_gicv3_kvm.c:637:37: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G0][1] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:638:9: note: here default: ^~~~~~~ hw/intc/arm_gicv3_kvm.c:648:39: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G1NS][2] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:649:9: note: here case 6: ^~~~ hw/intc/arm_gicv3_kvm.c:651:39: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G1NS][1] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:652:9: note: here default: ^~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/intc/arm_gicv3_kvm.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index 187eb054e0..d040a5d1e9 100644 --- a/hw/intc/arm_gicv3_kvm.c +++ b/hw/intc/arm_gicv3_kvm.c @@ -478,9 +478,11 @@ static void kvm_arm_gicv3_put(GICv3State *s) kvm_gicc_access(s, ICC_AP0R_EL1(3), ncpu, ®64, true); reg64 =3D c->icc_apr[GICV3_G0][2]; kvm_gicc_access(s, ICC_AP0R_EL1(2), ncpu, ®64, true); + /* fall through */ case 6: reg64 =3D c->icc_apr[GICV3_G0][1]; kvm_gicc_access(s, ICC_AP0R_EL1(1), ncpu, ®64, true); + /* fall through */ default: reg64 =3D c->icc_apr[GICV3_G0][0]; kvm_gicc_access(s, ICC_AP0R_EL1(0), ncpu, ®64, true); @@ -492,9 +494,11 @@ static void kvm_arm_gicv3_put(GICv3State *s) kvm_gicc_access(s, ICC_AP1R_EL1(3), ncpu, ®64, true); reg64 =3D c->icc_apr[GICV3_G1NS][2]; kvm_gicc_access(s, ICC_AP1R_EL1(2), ncpu, ®64, true); + /* fall through */ case 6: reg64 =3D c->icc_apr[GICV3_G1NS][1]; kvm_gicc_access(s, ICC_AP1R_EL1(1), ncpu, ®64, true); + /* fall through */ default: reg64 =3D c->icc_apr[GICV3_G1NS][0]; kvm_gicc_access(s, ICC_AP1R_EL1(0), ncpu, ®64, true); @@ -631,9 +635,11 @@ static void kvm_arm_gicv3_get(GICv3State *s) c->icc_apr[GICV3_G0][3] =3D reg64; kvm_gicc_access(s, ICC_AP0R_EL1(2), ncpu, ®64, false); c->icc_apr[GICV3_G0][2] =3D reg64; + /* fall through */ case 6: kvm_gicc_access(s, ICC_AP0R_EL1(1), ncpu, ®64, false); c->icc_apr[GICV3_G0][1] =3D reg64; + /* fall through */ default: kvm_gicc_access(s, ICC_AP0R_EL1(0), ncpu, ®64, false); c->icc_apr[GICV3_G0][0] =3D reg64; @@ -645,9 +651,11 @@ static void kvm_arm_gicv3_get(GICv3State *s) c->icc_apr[GICV3_G1NS][3] =3D reg64; kvm_gicc_access(s, ICC_AP1R_EL1(2), ncpu, ®64, false); c->icc_apr[GICV3_G1NS][2] =3D reg64; + /* fall through */ case 6: kvm_gicc_access(s, ICC_AP1R_EL1(1), ncpu, ®64, false); c->icc_apr[GICV3_G1NS][1] =3D reg64; + /* fall through */ default: kvm_gicc_access(s, ICC_AP1R_EL1(0), ncpu, ®64, false); c->icc_apr[GICV3_G1NS][0] =3D reg64; --=20 2.27.0 From nobody Mon Apr 29 12:05:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605495319; cv=none; d=zohomail.com; s=zohoarc; b=VT+tSkR84igWg4Zo0ExZEfTDiGlnhNhdR/js4b2Timo5zzAT26UqEsEk+PYGbxfFJIPciy0LrDg98U6edchQhxkz8BN49kSMxVzZY3MPMMVrXyCGPIR1MaGQ7IIPvojmf4b78dZeAVNDy8tKNex8hWONhtrS5p5/twJMVSdL65Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605495319; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CBbkMEFtJiAxi9jACzVe3R//zNs93mr6rR/HqPPIsNs=; b=L+zZKjr8/kts/nIof+nDFqCj3tAB5GfjQLv57zA091XRmD2xQ1qS16cVXUD1a54zbmUBwvNjP6s96Dih0BCBgaBeh9ctyLKuwjnMJxV2EKIRL72BdjIN2/FF1EhAVF8oqB4NEuWaeYRJSxc5WFDDwk4aC1nGeViKZWkR4yoI1VU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160549531977918.0055933872668; Sun, 15 Nov 2020 18:55:19 -0800 (PST) Received: from localhost ([::1]:54780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keUfm-0005dr-JV for importer@patchew.org; Sun, 15 Nov 2020 21:55:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZl-0006bk-TO; Sun, 15 Nov 2020 21:49:05 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZh-0002sX-Rd; Sun, 15 Nov 2020 21:49:05 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CZD6H4YMkzkX2L; Mon, 16 Nov 2020 10:48:39 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 10:48:48 +0800 From: Chen Qun To: , Subject: [PATCH v3 3/7] accel/tcg/user-exec: silence the compiler warnings Date: Mon, 16 Nov 2020 10:48:06 +0800 Message-ID: <20201116024810.2415819-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 21:16:58 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , zhang.zhanghailiang@huawei.com, Riku Voipio , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , ganqixin@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showe= d warning: ../accel/tcg/user-exec.c: In function =E2=80=98handle_cpu_signal=E2=80=99: ../accel/tcg/user-exec.c:169:13: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] 169 | cpu_exit_tb_from_sighandler(cpu, old_set); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../accel/tcg/user-exec.c:172:9: note: here 172 | default: Mark the cpu_exit_tb_from_sighandler() function with QEMU_NORETURN to fix i= t. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: Alex Benn=C3=A9e --- v1->v2: Add QEMU_NORETURN to cpu_exit_tb_from_sighandler() function to avoid the compiler warnings(Base on Thomas's and Richard's comments). Cc: Thomas Huth Cc: Riku Voipio Cc: Richard Henderson Cc: Paolo Bonzini --- accel/tcg/user-exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index 4ebe25461a..293ee86ea4 100644 --- a/accel/tcg/user-exec.c +++ b/accel/tcg/user-exec.c @@ -49,7 +49,8 @@ __thread uintptr_t helper_retaddr; /* exit the current TB from a signal handler. The host registers are restored in a state compatible with the CPU emulator */ -static void cpu_exit_tb_from_sighandler(CPUState *cpu, sigset_t *old_set) +static void QEMU_NORETURN cpu_exit_tb_from_sighandler(CPUState *cpu, + sigset_t *old_set) { /* XXX: use siglongjmp ? */ sigprocmask(SIG_SETMASK, old_set, NULL); --=20 2.27.0 From nobody Mon Apr 29 12:05:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605495070; cv=none; d=zohomail.com; s=zohoarc; b=f4m0mTg/PKXQLCggyFf9/PuJ6BD/+PAzEHCpmkmxQdrSjA0IxVNXr75O9WrxxAeRoMDJaUN/nrQF8cRkVW5sgWwy4hLNgae8oPeDrzhPCVDANDA1as5FOEZOBTfC+ZzpyKa2SNtF1lDO5PJCt66wyzHBcjuA6UoE5RU0KMLMYtU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605495070; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VCkCmCBRtCC6gaUqRNVZVMoj7Oz0+C/kiFtVbm4RgPs=; b=YVshs8GvHX/EeEGCHcQP82SakA9Z3RIi8TJAiS+dBOeQDIe7C8/CcVhYy+AoJ4C+UbxRW8Qjtcv1UbHnHtd7k6PQluHJ2vyRq0JWS0vzrpalU2xUU+wPp9bMiZ0ArjWIHSoRaTvYP9IQB9x2UNoiqBH5sWPBMox8C7JiL99r0u8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605495070831529.5295259311667; Sun, 15 Nov 2020 18:51:10 -0800 (PST) Received: from localhost ([::1]:42742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keUbl-0000jg-Jn for importer@patchew.org; Sun, 15 Nov 2020 21:51:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZk-0006Yp-Ib; Sun, 15 Nov 2020 21:49:04 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZh-0002sV-Lu; Sun, 15 Nov 2020 21:49:04 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CZD6M3Xjpz15Jdf; Mon, 16 Nov 2020 10:48:43 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 10:48:49 +0800 From: Chen Qun To: , Subject: [PATCH v3 4/7] target/sparc/translate: silence the compiler warnings Date: Mon, 16 Nov 2020 10:48:07 +0800 Message-ID: <20201116024810.2415819-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 21:16:58 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , ganqixin@huawei.com, Euler Robot , Chen Qun , Artyom Tarasenko Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showe= d warning: target/sparc/translate.c: In function =E2=80=98gen_st_asi=E2=80=99: target/sparc/translate.c:2320:12: warning: this statement may fall through = [-Wimplicit-fallthrough=3D] 2320 | if (!(dc->def->features & CPU_FEATURE_HYPV)) { | ^ target/sparc/translate.c:2329:5: note: here 2329 | case GET_ASI_DIRECT: | ^~~~ The "fall through" statement place is not correctly identified by the compi= ler. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Mark Cave-Ayland Cc: Artyom Tarasenko --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 1a4efd4ed6..a3d9aaa46b 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -2324,8 +2324,8 @@ static void gen_st_asi(DisasContext *dc, TCGv src, TC= Gv addr, } /* in OpenSPARC T1+ CPUs TWINX ASIs in store instructions * are ST_BLKINIT_ ASIs */ - /* fall through */ #endif + /* fall through */ case GET_ASI_DIRECT: gen_address_mask(dc, addr); tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop); --=20 2.27.0 From nobody Mon Apr 29 12:05:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605495066; cv=none; d=zohomail.com; s=zohoarc; b=ZIhWOeeE4aGrw8rWVLzSro3u71NmS0HLrBGd5YsZCsB1C5E4CBHQp5WBjMPiDVrT331HH/P2Mu3sEPFyoGJBKydEpG+t6RhpsY4rxrBacYvlaFOqoDSX2ZwHA5dP5ixmeOKsjzKWN9e+BsGiImc0IfmIcgcgLWu1nb7Pvb8dSNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605495066; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CdGnvJnOa39X0NkdAeeg/F/LMAM3UsoEht7IcRfs3fk=; b=LQwevdoXuHeXWPb5+B80bcbdFdIVH4za8r65X1vV08uxuGN2JZfq8j5JIJK/eXfPtk22/Ew/ad6fvauJNtOI9QvGPoEAQ2u9rCmksrKFT4goMG7+GAa1n2a/YSrQ+vG334Booproj4f761JBY/SiwzQI3roeAMd9Rov0hN7l3s0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605495066724696.2953921202788; Sun, 15 Nov 2020 18:51:06 -0800 (PST) Received: from localhost ([::1]:42268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keUbh-0000Xr-J3 for importer@patchew.org; Sun, 15 Nov 2020 21:51:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZn-0006f5-AR; Sun, 15 Nov 2020 21:49:07 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZk-0002t9-Co; Sun, 15 Nov 2020 21:49:06 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CZD6N3NFfzkYgn; Mon, 16 Nov 2020 10:48:44 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 10:48:51 +0800 From: Chen Qun To: , Subject: [PATCH v3 5/7] target/sparc/win_helper: silence the compiler warnings Date: Mon, 16 Nov 2020 10:48:08 +0800 Message-ID: <20201116024810.2415819-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 21:16:58 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Mark Cave-Ayland , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , ganqixin@huawei.com, Euler Robot , Chen Qun , Artyom Tarasenko Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showe= d warning: target/sparc/win_helper.c: In function =E2=80=98get_gregset=E2=80=99: target/sparc/win_helper.c:304:9: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] 304 | trace_win_helper_gregset_error(pstate); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ target/sparc/win_helper.c:306:5: note: here 306 | case 0: | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v1->v2: Combine the /* fall through */ to the preceding comments (Base on Philippe's comments). Cc: Philippe Mathieu-Daud=C3=A9 Cc: Mark Cave-Ayland Cc: Artyom Tarasenko --- target/sparc/win_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/win_helper.c b/target/sparc/win_helper.c index 8290a21142..e78660b60a 100644 --- a/target/sparc/win_helper.c +++ b/target/sparc/win_helper.c @@ -302,7 +302,7 @@ static inline uint64_t *get_gregset(CPUSPARCState *env,= uint32_t pstate) switch (pstate) { default: trace_win_helper_gregset_error(pstate); - /* pass through to normal set of global registers */ + /* fall through to normal set of global registers */ case 0: return env->bgregs; case PS_AG: --=20 2.27.0 From nobody Mon Apr 29 12:05:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605495185; cv=none; d=zohomail.com; s=zohoarc; b=Oj7XGjgXHQg37jTfvz50wUSi6e3IjkHG+pggxS0yiqMEOtsQ44YPAr4G16rBoOziWPlM0jyq6kokqKItnz4YQn7d+Qvzovv2IzuYJe5/LI8mSJ8f/RyUsGZrqBkmtuYO1KSqrOvEQ8seJPCGm14Sd/3BzloHveKLNun0PwsZFaY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605495185; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9Rtml89J/zb4wFg+34f/pJ2Nss0At76a937f6OXGIRQ=; b=kfN4zfehMizuHbmuyObJZNc8DsfUfKwo8zpDafrNoEBy/esBJB/Cjjdj2Dfigh0Z5LeBdJaZ7lLx/Mt9WhAXpsJwXIsYXesD1aFY6kFDU38BaOVRoPzftBLkAgvZNcdxFqC7zOYJP37NDdL5/Pu8Po0l5a4yZCsKYbxQur9kQFU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605495185775519.8542532703101; Sun, 15 Nov 2020 18:53:05 -0800 (PST) Received: from localhost ([::1]:50226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keUdc-0003jz-OH for importer@patchew.org; Sun, 15 Nov 2020 21:53:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZm-0006cJ-42; Sun, 15 Nov 2020 21:49:06 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZk-0002t4-9j; Sun, 15 Nov 2020 21:49:05 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CZD6N30F8zkYgD; Mon, 16 Nov 2020 10:48:44 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 10:48:52 +0800 From: Chen Qun To: , Subject: [PATCH v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN Date: Mon, 16 Nov 2020 10:48:09 +0800 Message-ID: <20201116024810.2415819-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 21:16:58 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , zhang.zhanghailiang@huawei.com, ganqixin@huawei.com, Euler Robot , Chen Qun , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: hw/ppc/ppc.c: In function =E2=80=98ppc6xx_set_irq=E2=80=99: hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-f= allthrough=3D] 118 | if (level) { | ^ hw/ppc/ppc.c:123:9: note: here 123 | case PPC6xx_INPUT_INT: | ^~~~ According to the discussion, a break statement needs to be added here. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Thomas Huth Acked-by: David Gibson --- v1->v2: Add a "break" statement here instead of /* fall through */ comments (Base on Thomas's and David review). Cc: Thomas Huth Cc: David Gibson --- hw/ppc/ppc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..1b98272076 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int l= evel) } else { cpu_ppc_tb_stop(env); } + break; case PPC6xx_INPUT_INT: /* Level sensitive - active high */ LOG_IRQ("%s: set the external IRQ state to %d\n", --=20 2.27.0 From nobody Mon Apr 29 12:05:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605495213; cv=none; d=zohomail.com; s=zohoarc; b=Ygizt/BOkEJYmI7ijvHEID5NqUdMmEi9072BplFTmMW+VAtXNlIyYgj5UXr45wldiBWTJnKd0l5Hnf5XbH5lGWIgAqTX4eryerLCOhmFMTAcZmyJlLNklW7RiaLGlWBmzGlCQu+0YWo4G4+kuhtfGclBXPSjKSv0GAZe3I0bG98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605495213; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OsQJfNij4Jadk7S4VH3epzZbqO1aAp9FxwRLJzly01Y=; b=Iu0amsh3YwMtR1SAcZS4JsfUMongQulvyE4xaaorNeaYDLxbh0G25DpWokHTR9krlqche3v8NUDdyVfQumAZRE749w9nLwa7ZShmrIKXgPbK0dKUnSL8OJC2XtkUsaMY8nJwYF7zMVhN+GWyHmcTxBWdiwiJiEtiT5ckFe526c4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605495213354393.96747015133826; Sun, 15 Nov 2020 18:53:33 -0800 (PST) Received: from localhost ([::1]:51164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keUe4-00047W-92 for importer@patchew.org; Sun, 15 Nov 2020 21:53:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZn-0006eT-14; Sun, 15 Nov 2020 21:49:07 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keUZk-0002t6-Bz; Sun, 15 Nov 2020 21:49:06 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CZD6N39K6zkYgP; Mon, 16 Nov 2020 10:48:44 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 16 Nov 2020 10:48:53 +0800 From: Chen Qun To: , Subject: [PATCH v3 7/7] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings Date: Mon, 16 Nov 2020 10:48:10 +0800 Message-ID: <20201116024810.2415819-8-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> References: <20201116024810.2415819-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 21:16:58 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , zhang.zhanghailiang@huawei.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , ganqixin@huawei.com, Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: target/ppc/mmu_helper.c: In function =E2=80=98dump_mmu=E2=80=99: target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] 1351 | if (ppc64_v3_radix(env_archcpu(env))) { | ^ target/ppc/mmu_helper.c:1358:5: note: here 1358 | default: | ^~~~~~~ Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment. And add the break statement to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Acked-by: David Gibson --- v1->v2: replace the TODO by a LOG_UNIMP call and add break statement(Base o= n Philippe's comments) Cc: Thomas Huth Cc: David Gibson Cc: Philippe Mathieu-Daud=C3=A9 --- target/ppc/mmu_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 8972714775..3bb50546f8 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env) break; case POWERPC_MMU_3_00: if (ppc64_v3_radix(env_archcpu(env))) { - /* TODO - Unsupported */ + qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU is unsupported\n", + __func__); } else { dump_slb(env_archcpu(env)); - break; } + break; #endif default: qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__); --=20 2.27.0