From nobody Mon Feb 9 16:01:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605302687; cv=none; d=zohomail.com; s=zohoarc; b=HkBpwFoJPHw8tGzw/g1vhXx/0UelrYhozOzigeN7NGcnKh3VHens9RGyL6EJVKD8VxlfLFRN5N8/ocI2pm+96uE25EcKc/WBQGfAIkhxAw/AaUHZrF/i4eQQvlMHX2j8J1wROoN918DE/jBHNc6QsEeP6Q4T/pk4gom0vsC29ZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605302687; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OjbYSUyEkl7ynwQOyHy83UdnMetYOmxrv+n5LDxoPJw=; b=mxl+0/nQ3KltZrFD8mQeNYYNcCT67wogh1pjHF/s73sCNJxdfp1q2MMOkAtF6YtJRIXXVI2DrBbc9ShDnjBCwknUDGUP/OLHpsbBPB0M6D9GzswXrUMGtAjjsRF2jw7O93POsJnUwm9aAULR5FpeBQ7TLk/Cm5u9XTDD3oxZ7x8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160530268749748.53476875233696; Fri, 13 Nov 2020 13:24:47 -0800 (PST) Received: from localhost ([::1]:40086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdgYo-0007CN-EK for importer@patchew.org; Fri, 13 Nov 2020 16:24:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdgRn-00024r-K6 for qemu-devel@nongnu.org; Fri, 13 Nov 2020 16:17:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdgRj-0005Qt-Ri for qemu-devel@nongnu.org; Fri, 13 Nov 2020 16:17:31 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-xfDyGr5HP4ehFJzb85BCiA-1; Fri, 13 Nov 2020 16:17:24 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7761480F041; Fri, 13 Nov 2020 21:17:23 +0000 (UTC) Received: from localhost (ovpn-114-96.ams2.redhat.com [10.36.114.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FD42100164C; Fri, 13 Nov 2020 21:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605302246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OjbYSUyEkl7ynwQOyHy83UdnMetYOmxrv+n5LDxoPJw=; b=PkXwj7RRL87iJJPs4X9PnOtKxa4Qhiqfvv+z1MU4nh6PBZKlzH3FJYGinxx/ZPqWAPdLxU Xt1M9mFDCKw0XDZobcxRXVSNovrD+xThP/QkqP5DUzunEoubcijMzAQcR+rQoCRhMvHO98 uAWWE9eNz25EmeT7TWplHDJlRNyQEAU= X-MC-Unique: xfDyGr5HP4ehFJzb85BCiA-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH 1/3] quorum: Require WRITE perm with rewrite-corrupted Date: Fri, 13 Nov 2020 22:17:16 +0100 Message-Id: <20201113211718.261671-2-mreitz@redhat.com> In-Reply-To: <20201113211718.261671-1-mreitz@redhat.com> References: <20201113211718.261671-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 16:09:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Using rewrite-corrupted means quorum may issue writes to its children just from receiving read requests from its parents. Thus, it must take the WRITE permission when rewrite-corrupted is used. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block/quorum.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index b70d365ba9..01e49e94a3 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -1195,7 +1195,12 @@ static void quorum_child_perm(BlockDriverState *bs, = BdrvChild *c, uint64_t perm, uint64_t shared, uint64_t *nperm, uint64_t *nshared) { + BDRVQuorumState *s =3D bs->opaque; + *nperm =3D perm & DEFAULT_PERM_PASSTHROUGH; + if (s->rewrite_corrupted) { + *nperm |=3D BLK_PERM_WRITE; + } =20 /* * We cannot share RESIZE or WRITE, as this would make the --=20 2.28.0