From nobody Mon Feb 9 06:01:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605219777; cv=none; d=zohomail.com; s=zohoarc; b=M6xalG57rO/LbjYqaVVWVBSjAW40aT6MtpVT7R0LpUEpdVcQfna3EGE7bXBZtWHCOP25ep1HAcvGzd/fofQRpyu/sRBGLUasDYHokah7g9YNHFRxD9ziVPMYXV76IQbgsr0D9d4WclubNxuuA7YPzsr22KZ1DuAnSgCm5ynAzDg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605219777; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ja/YmWt/OMSFvhSVMA3UOQ10xojvR9RvVHDVddUDRaY=; b=IH15nJG4LS/jxtRJHNH3n0lAIShbq9F1BXMABjSOmGGwCZnL+0GFXFW/H9l9VuIJAlxqbRpRmluIJS3X9VSOq8+SGOj8zf3I/DqToA9AjhKDPstvxW3SrAlnk7Zv5wPCAOEA2HQ0GE89XzHCCSXqcEiD8mMGdvE3VvrGZKF//4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605219777029245.2869252913638; Thu, 12 Nov 2020 14:22:57 -0800 (PST) Received: from localhost ([::1]:42118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdKzX-0007VZ-TO for importer@patchew.org; Thu, 12 Nov 2020 17:22:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdKQr-0007wt-LY for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:47:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdKQp-0003gS-Ov for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:47:05 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-NoCWWUqNOCWnU2OuJdpIXw-1; Thu, 12 Nov 2020 16:46:59 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 764B7184217D; Thu, 12 Nov 2020 21:46:58 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D2D85B4C2; Thu, 12 Nov 2020 21:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605217621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ja/YmWt/OMSFvhSVMA3UOQ10xojvR9RvVHDVddUDRaY=; b=aHd30YwuJfPw4TuBuqsQeDIbFu/ZYmd5SR2f0bINOk9HIEFPoLktwRg3eAwtgQAR0FzsD5 svn9ojTLflsqV42u1psX192LYrnwpjCjWDdvoB95rBS48zXLn0uzQ7guSEU0Z0jmRLg9Po 46Jlfsmnm7aBnrpn8O0KjVRtKgWwnDs= X-MC-Unique: NoCWWUqNOCWnU2OuJdpIXw-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH v3 43/53] qdev: Move static_prop_release_dynamic_prop() closer to its usage Date: Thu, 12 Nov 2020 16:43:40 -0500 Message-Id: <20201112214350.872250-44-ehabkost@redhat.com> In-Reply-To: <20201112214350.872250-1-ehabkost@redhat.com> References: <20201112214350.872250-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 16:09:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. Berrange" , John Snow , Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Igor Mammedov , Stefan Berger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Move the function closer to where it's used, to make refactor and review simpler. While doing it, reformat the comment at the top to follow coding style. Signed-off-by: Eduardo Habkost --- This is a new patch added in v3 of the series. --- Cc: Paolo Bonzini Cc: "Daniel P. Berrang=C3=A9" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- hw/core/qdev-properties.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 83fd45add0..7aa5d2ff45 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -521,20 +521,6 @@ const PropertyInfo prop_info_size32 =3D { =20 /* --- support for array properties --- */ =20 -/* object property release callback for dynamically-created properties: - * we call the underlying element's property release hook, and - * then free the memory we allocated when we added the property. - */ -static void static_prop_release_dynamic_prop(Object *obj, const char *name, - void *opaque) -{ - Property *prop =3D opaque; - if (prop->info->release) { - prop->info->release(obj, name, opaque); - } - g_free(prop); -} - static void set_prop_arraylen(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { @@ -816,6 +802,21 @@ const PropertyInfo prop_info_link =3D { .create =3D create_link_property, }; =20 +/* + * Property release callback for dynamically-created properties: + * We call the underlying element's property release hook, and + * then free the memory we allocated when we added the property. + */ +static void static_prop_release_dynamic_prop(Object *obj, const char *name, + void *opaque) +{ + Property *prop =3D opaque; + if (prop->info->release) { + prop->info->release(obj, name, opaque); + } + g_free(prop); +} + ObjectProperty * object_property_add_field(Object *obj, const char *name, Property *prop, --=20 2.28.0