From nobody Mon Feb 9 12:09:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605219245; cv=none; d=zohomail.com; s=zohoarc; b=AEVTZvCEG8lGmwnR3Lugcjc26juyNJn0gbRv/RaRmGHHl60Zk6EfNzg+cYtpcywxqgcWJgtgo/AYw+RLk5fKvkWfP7YEIIcwGfSMP6yBmmO8B2VWfcvT8dpFyRLDgxd4j4PH0aSW0vTYEieylHzLFUy+zXqfjKIXIsw+p7iO7NY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605219245; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qi/zfVz1M40pnEprIV3M8fmvBwq9LUvwFczHJz+Xazo=; b=mtjLdYfbz8SRDsJxMNjcgDlLexRDj8MpAN/51LzNBifLijLanroLcfUvFovka2xEKtNCxbZyEAUpM5gFd89HvGSs0k21wezF5QHcvGvb5ORrCOPva3XnYROirHvQncZ/Ff8RIcKeHcwtNPBb4+aq2Oa8OpU9OkYijcoQPclPvak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605219245651565.3425613452157; Thu, 12 Nov 2020 14:14:05 -0800 (PST) Received: from localhost ([::1]:48716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdKqy-0006dY-Di for importer@patchew.org; Thu, 12 Nov 2020 17:14:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdKQY-0007rp-U3 for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:46:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdKQX-0003f2-2s for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:46:46 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-Qq9Qzm0GNR-bs8XyseLi3Q-1; Thu, 12 Nov 2020 16:46:42 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C8F94237F; Thu, 12 Nov 2020 21:46:41 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FF7C60C13; Thu, 12 Nov 2020 21:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605217604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qi/zfVz1M40pnEprIV3M8fmvBwq9LUvwFczHJz+Xazo=; b=QARq28wyxjFb/fT5i4XeA8j9JlrsQZ5Yu+cO8hrxcdmTud3IPsjYkpsvpPPfXK5VWZujLa 8k1is1gh85vbfEtqPR9Dg/GXY3RyqJN/ZL3yuw77bT2BG4NSVjtL6hDoHsWWrHdYFsIsnr Bslrjp0tq2gekyaS7JyXTxIf490FZ/I= X-MC-Unique: Qq9Qzm0GNR-bs8XyseLi3Q-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH v3 37/53] qdev: Remove ArrayElementProperty.propname field Date: Thu, 12 Nov 2020 16:43:34 -0500 Message-Id: <20201112214350.872250-38-ehabkost@redhat.com> In-Reply-To: <20201112214350.872250-1-ehabkost@redhat.com> References: <20201112214350.872250-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 16:09:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. Berrange" , John Snow , Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Igor Mammedov , Stefan Berger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Now that we don't save the property name in Property.name anymore, we don't need the to keep the property name string alive after the property was registered. We can remove the ArrayElementProperty.propname field, and free the string immediately after registering the property. Signed-off-by: Eduardo Habkost --- This is a new patch added in v2 of the series --- Cc: Paolo Bonzini Cc: "Daniel P. Berrang=C3=A9" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- hw/core/qdev-properties.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index ad08c80e67..2ab1c9688a 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -529,7 +529,6 @@ const PropertyInfo prop_info_size32 =3D { */ typedef struct { struct Property prop; - char *propname; ObjectPropertyRelease *release; } ArrayElementProperty; =20 @@ -543,7 +542,6 @@ static void array_element_release(Object *obj, const ch= ar *name, void *opaque) if (p->release) { p->release(obj, name, opaque); } - g_free(p->propname); g_free(p); } =20 @@ -587,11 +585,10 @@ static void set_prop_arraylen(Object *obj, Visitor *v= , const char *name, */ *arrayptr =3D eltptr =3D g_malloc0(*alenptr * prop->arrayfieldsize); for (i =3D 0; i < *alenptr; i++, eltptr +=3D prop->arrayfieldsize) { - char *propname =3D g_strdup_printf("%s[%d]", arrayname, i); + g_autofree char *propname =3D g_strdup_printf("%s[%d]", arrayname,= i); ArrayElementProperty *arrayprop =3D g_new0(ArrayElementProperty, 1= ); ObjectProperty *elmop; arrayprop->release =3D prop->arrayinfo->release; - arrayprop->propname =3D propname; arrayprop->prop.info =3D prop->arrayinfo; /* This ugly piece of pointer arithmetic sets up the offset so * that when the underlying get/set hooks call qdev_get_prop_ptr --=20 2.28.0