From nobody Mon Feb 9 10:30:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605218994; cv=none; d=zohomail.com; s=zohoarc; b=egRJgnInRJSvYK/2kKjdUMBGikvx4aSnMdJCcBlqFcoYGyPYmG/5o0zQwyO3+DUxvzM5Td/DHdjeKbhTMRi6cbTmf32mlVLbLz/HIdSPZWEFjBO/C22zWs0mU8bZHdUXNwfOgw8v2cVqqHCFDCdUkT55cGohrbt6iLfxWorko5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605218994; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9SbFl2yOXu+0VCiayKzhvj7M0fCoKeZLWqJHQW7JehU=; b=G+eKdWAccfQ9hmHKi5IYSZygpRJ4JmMcTAO3LQ7Qxq6hw5RKfPcQIOhNU8CFqoiniFVCTBqGewGdvm+z3TcUL56yCDbO4PiZE3VHmrShxCKZOLyY7JUafHz3Gt1qiuvejmOAvb+VQ3YEaF+jRsejqzpfphT5Bm73WczzGlWoMKE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605218994851199.66792359603858; Thu, 12 Nov 2020 14:09:54 -0800 (PST) Received: from localhost ([::1]:37646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdKmv-0001se-HY for importer@patchew.org; Thu, 12 Nov 2020 17:09:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdKQL-0007ZT-NL for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:46:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdKQJ-0003ds-Rl for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:46:33 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-1iwRfYxGPNGZwOrYNYlQbg-1; Thu, 12 Nov 2020 16:46:27 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 43445190A3E2; Thu, 12 Nov 2020 21:46:26 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9E415D9CA; Thu, 12 Nov 2020 21:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605217591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9SbFl2yOXu+0VCiayKzhvj7M0fCoKeZLWqJHQW7JehU=; b=UaIVcoQTq2KyGfxxupt7Zq0drITOqmkqHADiEmj0yKWR9pBE6+qDs8p4EJtymXuftvohcU GMRlFLet1sTOZJQJ3ue6cgYtjmEH0OSLNiVMfe2TQxb/igsS1LUaVYqjLsFBLP5djwwQR7 FjeTOkOMY7/qKr9qfI6QDFXhzYVltRw= X-MC-Unique: 1iwRfYxGPNGZwOrYNYlQbg-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH v3 32/53] tests: Add unit test for qdev array properties Date: Thu, 12 Nov 2020 16:43:29 -0500 Message-Id: <20201112214350.872250-33-ehabkost@redhat.com> In-Reply-To: <20201112214350.872250-1-ehabkost@redhat.com> References: <20201112214350.872250-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 08:00:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. Berrange" , John Snow , Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Igor Mammedov , Stefan Berger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Add a test case to ensure array properties are behaving as expected. Signed-off-by: Eduardo Habkost --- This is a new patch added in v3 of this series. --- Cc: Paolo Bonzini Cc: "Daniel P. Berrang=C3=A9" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- tests/test-qdev-global-props.c | 61 ++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c index c8862cac5f..9426ce2a72 100644 --- a/tests/test-qdev-global-props.c +++ b/tests/test-qdev-global-props.c @@ -44,11 +44,16 @@ struct MyType { =20 uint32_t prop1; uint32_t prop2; + + char **myarray; + uint32_t myarray_len; }; =20 static Property static_props[] =3D { DEFINE_PROP_UINT32("prop1", MyType, prop1, PROP_DEFAULT), DEFINE_PROP_UINT32("prop2", MyType, prop2, PROP_DEFAULT), + DEFINE_PROP_ARRAY("myarray", MyType, myarray_len, myarray, + prop_info_string, char *), DEFINE_PROP_END_OF_LIST() }; =20 @@ -60,11 +65,19 @@ static void static_prop_class_init(ObjectClass *oc, voi= d *data) device_class_set_props(dc, static_props); } =20 +static void static_props_finalize(Object *obj) +{ + MyType *mt =3D STATIC_TYPE(obj); + + g_free(mt->myarray); +} + static const TypeInfo static_prop_type =3D { .name =3D TYPE_STATIC_PROPS, .parent =3D TYPE_DEVICE, .instance_size =3D sizeof(MyType), .class_init =3D static_prop_class_init, + .instance_finalize =3D static_props_finalize, }; =20 static const TypeInfo subclass_type =3D { @@ -91,6 +104,52 @@ static void test_static_prop(void) g_test_trap_assert_stdout(""); } =20 +static void test_static_prop_array(void) +{ + Error *err =3D NULL; + ObjectClass *oc =3D object_class_by_name(TYPE_STATIC_PROPS); + Object *obj =3D object_new(TYPE_STATIC_PROPS); + char *s =3D NULL; + + g_assert_nonnull(object_class_property_find(oc, "len-myarray")); + g_assert_null(object_class_property_find(oc, "myarray[0]")); + + g_assert_nonnull(object_property_find(obj, "len-myarray")); + g_assert_null(object_property_find(obj, "myarray[0]")); + + g_assert_cmpint(object_property_get_int(obj, "len-myarray", &error_abo= rt), =3D=3D, 0); + object_property_set_int(obj, "len-myarray", 3, &error_abort); + g_assert_cmpint(object_property_get_int(obj, "len-myarray", &error_abo= rt), =3D=3D, 3); + + g_assert_nonnull(object_property_find(obj, "myarray[0]")); + g_assert_nonnull(object_property_find(obj, "myarray[1]")); + g_assert_nonnull(object_property_find(obj, "myarray[2]")); + g_assert_null(object_property_find(obj, "myarray[3]")); + + /* Setting length a second time must fail */ + object_property_set_int(obj, "len-myarray", 42, &err); + error_free_or_abort(&err); + + g_assert_nonnull(object_property_find(obj, "myarray[2]")); + g_assert_null(object_property_find(obj, "myarray[3]")); + + s =3D object_property_get_str(obj, "myarray[2]", &error_abort); + g_assert_cmpstr(s, =3D=3D, ""); + g_free(s); + + object_property_set_str(obj, "myarray[1]", "value", &error_abort); + + s =3D object_property_get_str(obj, "myarray[1]", &error_abort); + g_assert_cmpstr(s, =3D=3D, "value"); + g_free(s); + + s =3D object_property_get_str(obj, "myarray[2]", &error_abort); + g_assert_cmpstr(s, =3D=3D, ""); + g_free(s); + + object_unref(obj); +} + static void register_global_properties(GlobalProperty *props) { int i; @@ -299,6 +358,8 @@ int main(int argc, char **argv) test_static_prop_subprocess); g_test_add_func("/qdev/properties/static/default", test_static_prop); + g_test_add_func("/qdev/properties/static/array", + test_static_prop_array); =20 g_test_add_func("/qdev/properties/static/global/subprocess", test_static_globalprop_subprocess); --=20 2.28.0