From nobody Tue Feb 10 13:17:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605104902; cv=none; d=zohomail.com; s=zohoarc; b=TRpG1Z2p5B//draQwScspDXo6LBFeEuBG4O6x2ocx22y/AOH3FXOfLXo26GyUfZGI80PYnKcCeBr37Vi5yWz612MRUwzvIN9t8tdBePuZ9R67Hmn4uu7HhgIdwVSUv+bA3+AMKXw4NGGzPayVO/iE4l8ZRy4vy8jU9lhi+BS10s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605104902; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C2sr1n0am3Y3kQXKmPGwf0grrVk1ibySMdWngrX3mV4=; b=P2eOfCbMTYZu5yUxhHLGNGbaNgKQlNLCIr67XwcmIs+h8UF0VCqnMWgxvB7SK77heqX5LyJ/g/j0d7QAvB2E5v6xcXdSVKNfdIzkQFb/rpr2xre0MycTwEhKEwqiPHZ539IV7dXIuRdhLe7nl+rwUwbwf8b99LDy9vi3zad/HnE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605104902538497.91813188631966; Wed, 11 Nov 2020 06:28:22 -0800 (PST) Received: from localhost ([::1]:49170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcr6j-0002eX-Az for importer@patchew.org; Wed, 11 Nov 2020 09:28:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1W-0004Kp-Ma; Wed, 11 Nov 2020 09:22:58 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1H-0000c5-9k; Wed, 11 Nov 2020 09:22:58 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CWRl33JYRz15SyH; Wed, 11 Nov 2020 22:22:23 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 22:22:26 +0800 From: Chen Qun To: , Subject: [PATCH v2 2/5] util/qemu-timer: fix uninitialized variable warning in timer_mod_anticipate_ns() Date: Wed, 11 Nov 2020 22:22:00 +0800 Message-ID: <20201111142203.2359370-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> References: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 07:50:46 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Paolo Bonzini , ganqixin@huawei.com, Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify that the statements in the macro must be executed. As a result, some varia= bles assignment statements in the macro may be considered as unexecuted by the = compiler. When the -Wmaybe-uninitialized capability is enabled on GCC9,the compiler s= howed warning: util/qemu-timer.c: In function =E2=80=98timer_mod_anticipate_ns=E2=80=99: util/qemu-timer.c:474:8: warning: =E2=80=98rearm=E2=80=99 may be used unini= tialized in this function [-Wmaybe-uninitialized] 474 | if (rearm) { | ^ Change the default value assignment place to prevented the warning. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Paolo Bonzini --- util/qemu-timer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 81c28af517..8b73882fbb 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -459,7 +459,7 @@ void timer_mod_ns(QEMUTimer *ts, int64_t expire_time) void timer_mod_anticipate_ns(QEMUTimer *ts, int64_t expire_time) { QEMUTimerList *timer_list =3D ts->timer_list; - bool rearm; + bool rearm =3D false; =20 WITH_QEMU_LOCK_GUARD(&timer_list->active_timers_lock) { if (ts->expire_time =3D=3D -1 || ts->expire_time > expire_time) { @@ -467,8 +467,6 @@ void timer_mod_anticipate_ns(QEMUTimer *ts, int64_t exp= ire_time) timer_del_locked(timer_list, ts); } rearm =3D timer_mod_ns_locked(timer_list, ts, expire_time); - } else { - rearm =3D false; } } if (rearm) { --=20 2.27.0