From nobody Fri May 17 06:07:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605104750; cv=none; d=zohomail.com; s=zohoarc; b=Q27o8cR684QfkV0rajXfchH9dbIVSFW3utpSoCf9bfMQRkCXjOSp3H9qHRvTCu52Ny0KZrxClQuOSG13wpCj49S4bBuai//Fc1GG+rQ50xJPhTHhjVfXCbaJyujKxTTdnl9XTXYioE3CZGl7qrk92WQjO19rgOratuwbgBtT7oE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605104750; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VrrTH5hByFiz49x0a+OWH4JBW3vxF0eH7GE+PxMWlHw=; b=cTMbtsPKefIjruWcjzlrbpWW1JF10h3tCBZ0bxfX/SaunXfLgA3go6BKJ2jsXAk1nn17qKfByPpngFQyIDViUAIz+JfJWhaDFZmBwfeW8OI6Y9KpjsRMbtDLPROYs+rAczjz/7pEhsVH6bRdEDNoBCDeb0UY77cQCLQivfZfMiM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605104750792376.4039139985683; Wed, 11 Nov 2020 06:25:50 -0800 (PST) Received: from localhost ([::1]:41638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcr4H-0007wc-Ig for importer@patchew.org; Wed, 11 Nov 2020 09:25:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1W-0004Kf-KS; Wed, 11 Nov 2020 09:22:58 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1I-0000c1-Fz; Wed, 11 Nov 2020 09:22:58 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CWRl33WM9z15TDv; Wed, 11 Nov 2020 22:22:23 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 22:22:24 +0800 From: Chen Qun To: , Subject: [PATCH v2 1/5] hw/rdma/rdma_backend: fix uninitialized variable warning in rdma_poll_cq() Date: Wed, 11 Nov 2020 22:21:59 +0800 Message-ID: <20201111142203.2359370-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> References: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 07:50:46 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ganqixin@huawei.com, zhang.zhanghailiang@huawei.com, Yuval Shaia , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify that the statements in the macro must be executed. As a result, some varia= bles assignment statements in the macro may be considered as unexecuted by the = compiler. When the -Wmaybe-uninitialized capability is enabled on GCC9,the compiler s= howed warning: hw/rdma/rdma_backend.c: In function =E2=80=98rdma_poll_cq=E2=80=99: hw/rdma/rdma_utils.h:25:5: warning: =E2=80=98ne=E2=80=99 may be used uninit= ialized in this function [-Wmaybe-uninitialized] 25 | error_report("%s: " fmt, "rdma", ## __VA_ARGS__) | ^~~~~~~~~~~~ hw/rdma/rdma_backend.c:93:12: note: =E2=80=98ne=E2=80=99 was declared here 93 | int i, ne, total_ne =3D 0; | ^~ Add a default value for 'ne' to prevented the warning. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- Cc: Yuval Shaia Cc: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 5de010b1fa..2fe4a3501c 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -90,7 +90,7 @@ static void clean_recv_mads(RdmaBackendDev *backend_dev) =20 static int rdma_poll_cq(RdmaDeviceResources *rdma_dev_res, struct ibv_cq *= ibcq) { - int i, ne, total_ne =3D 0; + int i, ne =3D 0, total_ne =3D 0; BackendCtx *bctx; struct ibv_wc wc[2]; RdmaProtectedGSList *cqe_ctx_list; --=20 2.27.0 From nobody Fri May 17 06:07:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605104902; cv=none; d=zohomail.com; s=zohoarc; b=TRpG1Z2p5B//draQwScspDXo6LBFeEuBG4O6x2ocx22y/AOH3FXOfLXo26GyUfZGI80PYnKcCeBr37Vi5yWz612MRUwzvIN9t8tdBePuZ9R67Hmn4uu7HhgIdwVSUv+bA3+AMKXw4NGGzPayVO/iE4l8ZRy4vy8jU9lhi+BS10s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605104902; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C2sr1n0am3Y3kQXKmPGwf0grrVk1ibySMdWngrX3mV4=; b=P2eOfCbMTYZu5yUxhHLGNGbaNgKQlNLCIr67XwcmIs+h8UF0VCqnMWgxvB7SK77heqX5LyJ/g/j0d7QAvB2E5v6xcXdSVKNfdIzkQFb/rpr2xre0MycTwEhKEwqiPHZ539IV7dXIuRdhLe7nl+rwUwbwf8b99LDy9vi3zad/HnE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605104902538497.91813188631966; Wed, 11 Nov 2020 06:28:22 -0800 (PST) Received: from localhost ([::1]:49170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcr6j-0002eX-Az for importer@patchew.org; Wed, 11 Nov 2020 09:28:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1W-0004Kp-Ma; Wed, 11 Nov 2020 09:22:58 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1H-0000c5-9k; Wed, 11 Nov 2020 09:22:58 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CWRl33JYRz15SyH; Wed, 11 Nov 2020 22:22:23 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 22:22:26 +0800 From: Chen Qun To: , Subject: [PATCH v2 2/5] util/qemu-timer: fix uninitialized variable warning in timer_mod_anticipate_ns() Date: Wed, 11 Nov 2020 22:22:00 +0800 Message-ID: <20201111142203.2359370-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> References: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 07:50:46 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Paolo Bonzini , ganqixin@huawei.com, Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify that the statements in the macro must be executed. As a result, some varia= bles assignment statements in the macro may be considered as unexecuted by the = compiler. When the -Wmaybe-uninitialized capability is enabled on GCC9,the compiler s= howed warning: util/qemu-timer.c: In function =E2=80=98timer_mod_anticipate_ns=E2=80=99: util/qemu-timer.c:474:8: warning: =E2=80=98rearm=E2=80=99 may be used unini= tialized in this function [-Wmaybe-uninitialized] 474 | if (rearm) { | ^ Change the default value assignment place to prevented the warning. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Paolo Bonzini --- util/qemu-timer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 81c28af517..8b73882fbb 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -459,7 +459,7 @@ void timer_mod_ns(QEMUTimer *ts, int64_t expire_time) void timer_mod_anticipate_ns(QEMUTimer *ts, int64_t expire_time) { QEMUTimerList *timer_list =3D ts->timer_list; - bool rearm; + bool rearm =3D false; =20 WITH_QEMU_LOCK_GUARD(&timer_list->active_timers_lock) { if (ts->expire_time =3D=3D -1 || ts->expire_time > expire_time) { @@ -467,8 +467,6 @@ void timer_mod_anticipate_ns(QEMUTimer *ts, int64_t exp= ire_time) timer_del_locked(timer_list, ts); } rearm =3D timer_mod_ns_locked(timer_list, ts, expire_time); - } else { - rearm =3D false; } } if (rearm) { --=20 2.27.0 From nobody Fri May 17 06:07:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605104663; cv=none; d=zohomail.com; s=zohoarc; b=OZjceKjjFSzRoEy3Qfhekky6/wU0rCxWUkMTLSf3VR7ekuziofO+24OPpy3f+R3y8FKkbo199XOM2MMej3RlCSKM/KoEHHOj1cGi3hBHoQBJCKANJyA42dpfox+KKJD2yPC594ZZcA6MroK1Rq/3TGyj/XXkD1j/W/bmvgLoGMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605104663; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WztA2oSwQkyBfaj0ueYN1wDwvzHZeuKLRdbnUmpu5UI=; b=ROaaVWcfd1mZpOcKnxoQm54mfKx977WDRVwO4GVKmz4AvSqhXjjHrtAPVbVjpyLZ/qvFSBvNK2Ma2s6KFjrQ5g5Or9d7xfkLwcjQ1qnT6lCoeT4qSDwx7wTSJMK3HZ5QK/bGK2In8YQrB2xVe5mPFMh+QdBEtlbb+p4/HvajS7Q= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16051046637951004.9161489325232; Wed, 11 Nov 2020 06:24:23 -0800 (PST) Received: from localhost ([::1]:36480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcr2q-0005nV-QH for importer@patchew.org; Wed, 11 Nov 2020 09:24:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1W-0004Jg-4c; Wed, 11 Nov 2020 09:22:58 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1J-0000cK-CM; Wed, 11 Nov 2020 09:22:57 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CWRl849jDzhjsj; Wed, 11 Nov 2020 22:22:28 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 22:22:27 +0800 From: Chen Qun To: , Subject: [PATCH v2 3/5] util/qemu-timer: fix uninitialized variable warning for expire_time Date: Wed, 11 Nov 2020 22:22:01 +0800 Message-ID: <20201111142203.2359370-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> References: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 07:07:25 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , ganqixin@huawei.com, Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify that the statements in the macro must be executed. As a result, some varia= bles assignment statements in the macro may be considered as unexecuted by the = compiler. When the -Wmaybe-uninitialized capability is enabled on GCC9,the compiler s= howed warning: util/qemu-timer.c: In function =E2=80=98timerlist_expired=E2=80=99: util/qemu-timer.c:199:24: warning: =E2=80=98expire_time=E2=80=99 may be use= d uninitialized in this function [-Wmaybe-uninitialized] 199 | return expire_time <=3D qemu_clock_get_ns(timer_list->clock->typ= e); | ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ util/qemu-timer.c: In function =E2=80=98timerlist_deadline_ns=E2=80=99: util/qemu-timer.c:237:11: warning: =E2=80=98expire_time=E2=80=99 may be use= d uninitialized in this function [-Wmaybe-uninitialized] 237 | delta =3D expire_time - qemu_clock_get_ns(timer_list->clock->typ= e); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Add a default value for 'expire_time' to prevented the warning. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini --- util/qemu-timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 8b73882fbb..3910003e86 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -183,7 +183,7 @@ bool qemu_clock_has_timers(QEMUClockType type) =20 bool timerlist_expired(QEMUTimerList *timer_list) { - int64_t expire_time; + int64_t expire_time =3D -1; =20 if (!qatomic_read(&timer_list->active_timers)) { return false; @@ -213,7 +213,7 @@ bool qemu_clock_expired(QEMUClockType type) int64_t timerlist_deadline_ns(QEMUTimerList *timer_list) { int64_t delta; - int64_t expire_time; + int64_t expire_time =3D -1; =20 if (!qatomic_read(&timer_list->active_timers)) { return -1; --=20 2.27.0 From nobody Fri May 17 06:07:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605104670; cv=none; d=zohomail.com; s=zohoarc; b=AdSNlRZeZ4So0NxI71/fmOHODMAXYKz/E/CcmWOC4teentiK56Bggzvzg9lFtjHL8WZlQ5OFzYiuYYb0Cn2V4UxYvFJeqem9S0dyBLZqMp7+clt1jskAzecTU947ZMYEh6F3OHk5iiLs19HPUZBuZuD4DcsgoSHPlp05lc0mlMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605104670; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OlfjV9TtnQvxScS03OzHWHZ7XEealfTa0qpYVw/eth4=; b=K6V/IjDaHfx6/yUd7tcFLam2jwmuhhL5kBg61QkXR1pE9Ruyf2xnf1d1xv+5eQPNqV+JdQNWvk7XSA//djVP4BOCGqeYgq+WL2wJiCWR4ar+22qjHP7fw+rAvU+dVPjbhDeuhWTmZ+Q4AIhB8kt2yla9m5Tv8OliKUyPmQw8ovs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605104670034517.8047724251772; Wed, 11 Nov 2020 06:24:30 -0800 (PST) Received: from localhost ([::1]:36894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcr2y-0005xb-LX for importer@patchew.org; Wed, 11 Nov 2020 09:24:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1V-0004J0-Nq; Wed, 11 Nov 2020 09:22:57 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1K-0000cI-VY; Wed, 11 Nov 2020 09:22:57 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CWRl84MRGzhk1P; Wed, 11 Nov 2020 22:22:28 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 22:22:28 +0800 From: Chen Qun To: , Subject: [PATCH v2 4/5] plugins/loader: fix uninitialized variable warning in plugin_reset_uninstall() Date: Wed, 11 Nov 2020 22:22:02 +0800 Message-ID: <20201111142203.2359370-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> References: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 07:07:25 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, ganqixin@huawei.com, Euler Robot , Chen Qun , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify that the statements in the macro must be executed. As a result, some varia= bles assignment statements in the macro may be considered as unexecuted by the = compiler. When the -Wmaybe-uninitialized capability is enabled on GCC9,the compiler s= howed warning: plugins/loader.c: In function =E2=80=98plugin_reset_uninstall=E2=80=99: plugins/loader.c:382:15: warning: =E2=80=98ctx=E2=80=99 may be used uniniti= alized in this function [-Wmaybe-uninitialized] 382 | data->ctx =3D ctx; | ~~~~~~~~~~^~~~~ Add a default value for 'expire_time' to prevented the warning. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: "Alex Benn=C3=A9e" --- plugins/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/loader.c b/plugins/loader.c index 8ac5dbc20f..88593fe138 100644 --- a/plugins/loader.c +++ b/plugins/loader.c @@ -367,7 +367,7 @@ void plugin_reset_uninstall(qemu_plugin_id_t id, bool reset) { struct qemu_plugin_reset_data *data; - struct qemu_plugin_ctx *ctx; + struct qemu_plugin_ctx *ctx =3D NULL; =20 WITH_QEMU_LOCK_GUARD(&plugin.lock) { ctx =3D plugin_id_to_ctx_locked(id); --=20 2.27.0 From nobody Fri May 17 06:07:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605104761; cv=none; d=zohomail.com; s=zohoarc; b=M2j61r2rtHdfkHbWdr8FYO7sv7m+d22qN8TVDlx0wMxu69W41OS+0yufM1rndnR/vPgW6d/jTGmHiqwHWHs75/aHTO6Jgzv7/tUR0reFZJidWsmo+rox2Gf8dJ3vPKm3ZmuA96xIEiKJrL7JUrzCITy1ZSjgBs+Mrz64717RLXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605104761; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ymy0qoklHchkUUYxMNU09T5sCDRlCKWAUPGTIf2vhsY=; b=mWm2GeMCUO0boee0AbogAo8WrrK0Lnti/Bq6SdJvEz/bF69gj1bIKhonWE+nbW2uxC8NyobftiCh58cODol68gMI75qh/jqtIUpQa8M0bsxYKSNmefd1b5v0x3Wvb+q0HNNSzbPFBU/aeJhJWTeBOp+jcTCg/xzefvWXCOeesIo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605104761965314.0376713485017; Wed, 11 Nov 2020 06:26:01 -0800 (PST) Received: from localhost ([::1]:42204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcr4S-0008Cp-Sh for importer@patchew.org; Wed, 11 Nov 2020 09:26:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1W-0004Jz-9G; Wed, 11 Nov 2020 09:22:58 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcr1K-0000cJ-Vs; Wed, 11 Nov 2020 09:22:57 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CWRl84XnSzhk1Y; Wed, 11 Nov 2020 22:22:28 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 22:22:30 +0800 From: Chen Qun To: , Subject: [PATCH v2 5/5] migration: fix uninitialized variable warning in migrate_send_rp_req_pages() Date: Wed, 11 Nov 2020 22:22:03 +0800 Message-ID: <20201111142203.2359370-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> References: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 07:07:25 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Juan Quintela , "Dr. David Alan Gilbert" , ganqixin@huawei.com, Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify that the statements in the macro must be executed. As a result, some varia= bles assignment statements in the macro may be considered as unexecuted by the = compiler. When the -Wmaybe-uninitialized capability is enabled on GCC9,the compiler s= howed warning: migration/migration.c: In function =E2=80=98migrate_send_rp_req_pages=E2=80= =99: migration/migration.c:384:8: warning: =E2=80=98received=E2=80=99 may be use= d uninitialized in this function [-Wmaybe-uninitialized] 384 | if (received) { | ^ Add a default value for 'received' to prevented the warning. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 9bb4fee5ac..de90486a61 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -361,7 +361,7 @@ int migrate_send_rp_req_pages(MigrationIncomingState *m= is, RAMBlock *rb, ram_addr_t start, uint64_t had= dr) { void *aligned =3D (void *)(uintptr_t)(haddr & (-qemu_ram_pagesize(rb))= ); - bool received; + bool received =3D false; =20 WITH_QEMU_LOCK_GUARD(&mis->page_request_mutex) { received =3D ramblock_recv_bitmap_test_byte_offset(rb, start); --=20 2.27.0