From nobody Mon Nov 17 17:47:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605096578; cv=none; d=zohomail.com; s=zohoarc; b=A0oG+UDNVp0zAQQph8tYNwtrXx6YFRtQl20nhJ9RCmXLUfrr8b6rhxLxQzTy6Mz84s9PMVC5KogqGgYlUcCogVZ/oKkgUKElzrHrLoynlgHESy4EnTfrxe+7T3REmsbOwLjbSVEMDiIK8baqOALGw1tD/u3H/OAijZ5BcyZXayM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605096578; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=jbCKVEnSHecoxttJIqXX+fojEN4XVd8UbDYUk4BjIvY=; b=YADapzV1WSaz+k6x5G/uXTIaT/B+9ZkCXeHJNxhXsxxwXLwkYYd6ax6tarL4MDA6AbRYliGtsMPvRuExGbMdc0gOxNowZggZrzXvLsyX3pfwcPN+gQZDH3LbSHODqxeuqpaOndtpTFv1OGT9IV6y3tM8DxZXORBtQLH2+Xfysyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1605096578078785.8849835935562; Wed, 11 Nov 2020 04:09:38 -0800 (PST) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-mljmT_UqOM-31vCb0x9Q4A-1; Wed, 11 Nov 2020 07:09:35 -0500 Received: by mail-wm1-f72.google.com with SMTP id u123so693241wmu.5 for ; Wed, 11 Nov 2020 04:09:35 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id l24sm2401649wmi.7.2020.11.11.04.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 04:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605096577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jbCKVEnSHecoxttJIqXX+fojEN4XVd8UbDYUk4BjIvY=; b=V88hZucc1XkTu448CqpM17uugPoIFbGCY9lEq/doHfqBi96xVvKBWDbw6YghZ/9kq6WQ2s HJ7RtO6suIDANwkI4TlOYZmgt0LlhoueE4aXu763E2Jdv3yO/eS/kn5fgSoadasiJd+7S+ a6vvb3eynZa6aMZHimD4RjyAOrV64w4= X-MC-Unique: mljmT_UqOM-31vCb0x9Q4A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jbCKVEnSHecoxttJIqXX+fojEN4XVd8UbDYUk4BjIvY=; b=DIPGzGHZPtEgXTpMSPyl4AQ5Kx+yZTmu7ro5Z/qfVzc2pJA+On9VBpaN71gpbrZ/6e WPGpMHr7MHcF3X9Ivn3dDipeXHshEvvE19SH2MWC73ikAEHx5tqW2V8S6TDs/Mnjp131 W3rdlBkeIiO70NZY00ftV0ABSHpS1vzY12LYjwqBVhA2Lhghrv7CMBc6PW4dibwB3KGK HhFOzFfEBDbx6baGdIl/6rd5tmOwETVbZLOrcA0w28W5cIAv6fpIbfqlnF7sLLjeltM3 c2M5oCJ08fNKKfFmp5g7aopO45znvWzrOIJfhrnQ4pkmbgtEoYKVA+P9sQwa9t/jOaWX evtw== X-Gm-Message-State: AOAM532PVWd2MDi2hkbVqjqGYkqbFDOfYivgxji98UauJb45gqEtlfXa D2ulZ9Mr0AmlUpP1RVtMfwVrNMV9YOnUIzXfYdrmtQ7c3tpoeuZy3pR9msUCDcz0VrcOSbZskLy vcKj3/Ncy1DRe9A== X-Received: by 2002:adf:f888:: with SMTP id u8mr19155910wrp.381.1605096574207; Wed, 11 Nov 2020 04:09:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQy0ISXAUNmYX31jd/nnG8+LXeh6kiFVyAF+Y451htCjF1E3ll157jLvbY6zHmwDZaD6wZtg== X-Received: by 2002:adf:f888:: with SMTP id u8mr19155894wrp.381.1605096574064; Wed, 11 Nov 2020 04:09:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Max Reitz , qemu-block@nongnu.org, Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-5.2 v2 4/4] configure: mark vhost-user Linux-only Date: Wed, 11 Nov 2020 13:09:12 +0100 Message-Id: <20201111120912.3245574-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201111120912.3245574-1-philmd@redhat.com> References: <20201111120912.3245574-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Stefan Hajnoczi The vhost-user protocol uses the Linux eventfd feature and is typically connected to Linux kvm.ko ioeventfd and irqfd file descriptors. The protocol specification in docs/interop/vhost-user.rst does not describe how platforms without eventfd support work. The QEMU vhost-user devices compile on other POSIX host operating systems because eventfd usage is abstracted in QEMU. The libvhost-user programs in contrib/ do not compile but we failed to notice since they are not built by default. Make it clear that vhost-user is only supported on Linux for the time being. If someone wishes to support it on other platforms then the details can be added to vhost-user.rst and CI jobs can test the feature to prevent bitrot. Signed-off-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201110171121.1265142-4-stefanha@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 516f28a0888..3fbc2a0c68c 100755 --- a/configure +++ b/configure @@ -328,7 +328,7 @@ vhost_net=3D"" vhost_crypto=3D"" vhost_scsi=3D"" vhost_vsock=3D"" -vhost_user=3D"" +vhost_user=3D"no" vhost_user_blk_server=3D"auto" vhost_user_fs=3D"" kvm=3D"auto" @@ -718,7 +718,6 @@ fi case $targetos in MINGW32*) mingw32=3D"yes" - vhost_user=3D"no" audio_possible_drivers=3D"dsound sdl" if check_include dsound.h; then audio_drv_list=3D"dsound" @@ -797,6 +796,7 @@ Linux) audio_possible_drivers=3D"oss alsa sdl pa" linux=3D"yes" linux_user=3D"yes" + vhost_user=3D"yes" ;; esac =20 @@ -2341,9 +2341,8 @@ fi # vhost interdependencies and host support =20 # vhost backends -test "$vhost_user" =3D "" && vhost_user=3Dyes -if test "$vhost_user" =3D "yes" && test "$mingw32" =3D "yes"; then - error_exit "vhost-user isn't available on win32" +if test "$vhost_user" =3D "yes" && test "$linux" !=3D "yes"; then + error_exit "vhost-user is only available on Linux" fi test "$vhost_vdpa" =3D "" && vhost_vdpa=3D$linux if test "$vhost_vdpa" =3D "yes" && test "$linux" !=3D "yes"; then --=20 2.26.2