From nobody Mon Nov 17 17:47:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605096574; cv=none; d=zohomail.com; s=zohoarc; b=MzUtW6ngXN3KoiYfgMiqwHZlaryGk1BroZWPhk2/x0AkDhtOCtri7aPQGLwgUizRCKapncjYGBdN6P90gWeEyOEk4L/jSLBUyOw7wbHaAY44DMFP4ASuF5aHWN2XrZgVRDh7EH4iiOcLe94jhUX35XR/urwz6N7oEUxrzkP7sqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605096574; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=K2YRTddG2x/SeHapVACTBBQp4nNKWuAWM30XETx0UHg=; b=bc8tu3t8hUPtMM4t42W4j4ohtdBToNQ4nKAbFOLDqaE5qDZzauAZNxNrsNMXWaTve6aGV1jpVh+XtdthrbGbyTmaHWAanLLdOVMWHfETpSgiJJdiIFW1SL3OMIemgVInjE8XIbg/7es0GGY53ZEdRAC+9fxznbhu9fDaQPuY4so= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605096574452863.210993535978; Wed, 11 Nov 2020 04:09:34 -0800 (PST) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-UjdaUL5VOWahXZjzTdnkWg-1; Wed, 11 Nov 2020 07:09:30 -0500 Received: by mail-wm1-f71.google.com with SMTP id b206so699667wmd.3 for ; Wed, 11 Nov 2020 04:09:30 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id a15sm2300209wrn.75.2020.11.11.04.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 04:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605096573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K2YRTddG2x/SeHapVACTBBQp4nNKWuAWM30XETx0UHg=; b=EhttpDBDD/9EeiQ0A+9qID/W8lQUEF3ddNXfPOid6sUarTGh4UoE3VxXw5C1b8vdezgC2e 7fG2gR2c57ypUk9ciq8iwW1nDR2ow7yiuuvIP6H5NMu0NNLxd0XR1oZyuUUzcDU9dJIGbp 0Y120CtDxqBzsliBSZjQUBtf8rWhRMI= X-MC-Unique: UjdaUL5VOWahXZjzTdnkWg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K2YRTddG2x/SeHapVACTBBQp4nNKWuAWM30XETx0UHg=; b=SDmbNz/aDFxnJpVqlZLzWYyK8GZkRkDT21XLl5or6Tf0ThpsLohdawsN4dsB7AVCr7 a+Fw3W/Ij8u+NvUjZWFh12i1gTyDdvR7cCMRqg0qKucPclJTAxQam4wMlQL8usva6JUJ KXfvOoOv5ijk1EZF6VP9cvGWjVI+VmH/XS13xpqCCBYaSF/bhH/FmAS2SMJ8KnkYo3zi MlIhkawkb4cTrz0NO572BUvsDs7XCp6dlOOrVajSclubAwJ5/WlPCNwQnsqFBmdiowbW OeOrgIE1UVmvSoBA28q1+J1y5za56twMWislFC5VRtTN95seDM+XiY+zA37AbnFLF54t 5+LQ== X-Gm-Message-State: AOAM533WvP+pMs677ca0MNG4qYIy8WAk8ExNdq1JXo9Fjuz1LlAJ/qAI JyO5ZnYnwWvpHE4Sa6KMooiDVlhF+gqmRz19YMqg2k9hQvHGN0slTAF9NzGYePIZSMeHO73Bzrg mCYOMm41Nfb8hqw== X-Received: by 2002:a1c:ab57:: with SMTP id u84mr2588829wme.99.1605096569385; Wed, 11 Nov 2020 04:09:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzq4yHUdkNqA37naOfUfNC9xIoM0eZq8iBhuh9Lb7nB4gdStBP4HlTBCncP57Vlmujf65FKHA== X-Received: by 2002:a1c:ab57:: with SMTP id u84mr2588823wme.99.1605096569254; Wed, 11 Nov 2020 04:09:29 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Max Reitz , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH-for-5.2 v2 3/4] vhost-user-blk-server: depend on CONFIG_VHOST_USER Date: Wed, 11 Nov 2020 13:09:11 +0100 Message-Id: <20201111120912.3245574-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201111120912.3245574-1-philmd@redhat.com> References: <20201111120912.3245574-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Stefan Hajnoczi I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user device frontends. However, virtiofsd and contrib/ vhost-user device backends are also controlled by CONFIG_VHOST_USER. Make the vhost-user-blk server depend on CONFIG_VHOST_USER for consistency. Now the following error is printed when the vhost-user-blk server is enabled without CONFIG_VHOST_USER: $ ./configure --disable-vhost-user --enable-vhost-user-blk ... ../meson.build:761:8: ERROR: Problem encountered: vhost_user_blk_server r= equires vhost-user support Suggested-by: Philippe Mathieu-Daud=C3=A9 Suggested-by: Alex Benn=C3=A9e Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201110171121.1265142-3-stefanha@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 4fc58eb2c3d..b978e89ec70 100644 --- a/meson.build +++ b/meson.build @@ -755,11 +755,14 @@ error('vhost-user does not make sense without system or tools support = enabled') endif =20 -have_vhost_user_blk_server =3D (targetos =3D=3D 'linux') +have_vhost_user_blk_server =3D (targetos =3D=3D 'linux' and + 'CONFIG_VHOST_USER' in config_host) =20 if get_option('vhost_user_blk_server').enabled() if targetos !=3D 'linux' error('vhost_user_blk_server requires linux') + elif 'CONFIG_VHOST_USER' not in config_host + error('vhost_user_blk_server requires vhost-user support') endif elif get_option('vhost_user_blk_server').disabled() or not have_system have_vhost_user_blk_server =3D false --=20 2.26.2