From nobody Mon Feb 9 12:15:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605028595; cv=none; d=zohomail.com; s=zohoarc; b=PxCOBakD68oikB4DUkY2UqEpN9vQjW6YgFb69f5Y3WBx6ZBYEjc9RlxTBW55biFBEsAE9uED42hmTDYFlVlUbmYxdQD7PXWcqNxAUSb8QJ2mV4WK+bscD3cuwInngj1A+g32ID6m4H2cXGknx7pbhqfLca+ASY9TGPEIgLtg96c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605028595; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lijNlQoal5CZP324ogddw/V1oy4mBUppSaqJxytQpOE=; b=OQg7p7F9Ku7pMBxUVpK66NCVwyGGxe2NrXqT4d5hjgj7j09kxrM4fpqNYxcsCAsymrWKwpnOmIbtG5Dz4Byp/iMZnrTFCw8lXTX6dSHL7IcqSDHbywbmUlmDLS5aWtSbDVTNDAIGB8uzZrA+qV67FV/rEO2Wi7/u5irwcd5mv2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605028595751521.1898243360786; Tue, 10 Nov 2020 09:16:35 -0800 (PST) Received: from localhost ([::1]:43168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcXFz-0006k2-1U for importer@patchew.org; Tue, 10 Nov 2020 12:16:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcXBR-0002dd-Pg for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:11:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcXBO-0001e1-27 for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:11:53 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-b4uD9JWLN7OhBdW4TuecsQ-1; Tue, 10 Nov 2020 12:11:47 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D4DF1006C9D; Tue, 10 Nov 2020 17:11:46 +0000 (UTC) Received: from localhost (ovpn-114-36.ams2.redhat.com [10.36.114.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44DBF1002C09; Tue, 10 Nov 2020 17:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605028309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lijNlQoal5CZP324ogddw/V1oy4mBUppSaqJxytQpOE=; b=VBpFxVQ/wneP6oE+X86ZYzVee4hqXWknBBUcqmbMwJGUiYzAMLomkY2m4JlCfpMFoe/8bL LMFwBWDIC+7L+alT9H0kwIi2l1TNSr2nBpJS4T4iEBLHzIA0BHGhbFVh9m8SMcHsMLQszl OjTx2obAH0jaC6rft45EH8WtV30fjYQ= X-MC-Unique: b4uD9JWLN7OhBdW4TuecsQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 2/3] vhost-user-blk-server: depend on CONFIG_VHOST_USER Date: Tue, 10 Nov 2020 17:11:20 +0000 Message-Id: <20201110171121.1265142-3-stefanha@redhat.com> In-Reply-To: <20201110171121.1265142-1-stefanha@redhat.com> References: <20201110171121.1265142-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/10 02:00:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Reitz , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user device frontends. However, virtiofsd and contrib/ vhost-user device backends are also controlled by CONFIG_VHOST_USER. Make the vhost-user-blk server depend on CONFIG_VHOST_USER for consistency. Now the following error is printed when the vhost-user-blk server is enabled without CONFIG_VHOST_USER: $ ./configure --disable-vhost-user --enable-vhost-user-blk ... ../meson.build:761:8: ERROR: Problem encountered: vhost_user_blk_server r= equires vhost-user support Suggested-by: Philippe Mathieu-Daud=C3=A9 Suggested-by: Alex Benn=C3=A9e Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 4f5c916557..ee3719da39 100644 --- a/meson.build +++ b/meson.build @@ -751,11 +751,14 @@ statx_test =3D ''' =20 has_statx =3D cc.links(statx_test) =20 -have_vhost_user_blk_server =3D (targetos =3D=3D 'linux') +have_vhost_user_blk_server =3D (targetos =3D=3D 'linux' and + 'CONFIG_VHOST_USER' in config_host) =20 if get_option('vhost_user_blk_server').enabled() if targetos !=3D 'linux' error('vhost_user_blk_server requires linux') + elif 'CONFIG_VHOST_USER' not in config_host + error('vhost_user_blk_server requires vhost-user support') endif elif get_option('vhost_user_blk_server').disabled() or not have_system have_vhost_user_blk_server =3D false --=20 2.28.0